From: Borislav Petkov <bp@alien8.de>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, x86@kernel.org, hpa@zytor.com,
dyoung@redhat.com, bhe@redhat.com, Thomas.Lendacky@amd.com
Subject: Re: [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion
Date: Fri, 22 Mar 2019 18:51:14 +0100 [thread overview]
Message-ID: <20190322175114.GL12472@zn.tnic> (raw)
In-Reply-To: <20190321103309.27883-2-lijiang@redhat.com>
On Thu, Mar 21, 2019 at 06:33:07PM +0800, Lianbo Jiang wrote:
> Following the commit <0e4c12b45aa8> ("x86/mm, resource: Use
> PAGE_KERNEL protection for ioremap of memory pages"),
The proper commit quotation format is done by adding this to your
.gitconfig:
[core]
abbrev = 12
[alias]
one = show -s --pretty='format:%h (\"%s\")'
and then doing:
$ git one <commit id>
which will give you
0e4c12b45aa8 ("x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages")
> here it is really checking for the 'IORES_DESC_ACPI_*' values.
Well, it is not really checking that.
> Therefore, it is necessary to change the examination condition
> to avoid confusion.
What confusion?
The justification for that change sounds really fishy.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: Thomas.Lendacky@amd.com, x86@kernel.org, bhe@redhat.com,
peterz@infradead.org, dave.hansen@linux.intel.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, luto@kernel.org, hpa@zytor.com,
tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion
Date: Fri, 22 Mar 2019 18:51:14 +0100 [thread overview]
Message-ID: <20190322175114.GL12472@zn.tnic> (raw)
In-Reply-To: <20190321103309.27883-2-lijiang@redhat.com>
On Thu, Mar 21, 2019 at 06:33:07PM +0800, Lianbo Jiang wrote:
> Following the commit <0e4c12b45aa8> ("x86/mm, resource: Use
> PAGE_KERNEL protection for ioremap of memory pages"),
The proper commit quotation format is done by adding this to your
.gitconfig:
[core]
abbrev = 12
[alias]
one = show -s --pretty='format:%h (\"%s\")'
and then doing:
$ git one <commit id>
which will give you
0e4c12b45aa8 ("x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages")
> here it is really checking for the 'IORES_DESC_ACPI_*' values.
Well, it is not really checking that.
> Therefore, it is necessary to change the examination condition
> to avoid confusion.
What confusion?
The justification for that change sounds really fishy.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-03-22 17:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 10:33 [PATCH 0/3 v9] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2019-03-21 10:33 ` Lianbo Jiang
2019-03-21 10:33 ` [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion Lianbo Jiang
2019-03-21 10:33 ` Lianbo Jiang
2019-03-22 17:51 ` Borislav Petkov [this message]
2019-03-22 17:51 ` Borislav Petkov
2019-03-25 3:11 ` lijiang
2019-03-25 3:11 ` lijiang
2019-03-25 6:40 ` Borislav Petkov
2019-03-25 6:40 ` Borislav Petkov
2019-03-25 9:20 ` lijiang
2019-03-25 9:20 ` lijiang
2019-03-25 12:15 ` Borislav Petkov
2019-03-25 12:15 ` Borislav Petkov
2019-03-21 10:33 ` [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' Lianbo Jiang
2019-03-21 10:33 ` Lianbo Jiang
2019-03-22 19:28 ` Borislav Petkov
2019-03-22 19:28 ` Borislav Petkov
2019-03-25 6:53 ` lijiang
2019-03-25 6:53 ` lijiang
2019-03-25 12:24 ` Borislav Petkov
2019-03-25 12:24 ` Borislav Petkov
2019-03-28 14:00 ` lijiang
2019-03-28 14:00 ` lijiang
2019-03-21 10:33 ` [PATCH 3/3 v9] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2019-03-21 10:33 ` Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322175114.GL12472@zn.tnic \
--to=bp@alien8.de \
--cc=Thomas.Lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.