All of lore.kernel.org
 help / color / mirror / Atom feed
From: lijiang <lijiang@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
	tglx@linutronix.de, mingo@redhat.com, akpm@linux-foundation.org,
	dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, x86@kernel.org, hpa@zytor.com,
	dyoung@redhat.com, bhe@redhat.com, Thomas.Lendacky@amd.com
Subject: Re: [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion
Date: Mon, 25 Mar 2019 17:20:43 +0800	[thread overview]
Message-ID: <dd7b5fb6-bd77-61a2-afa5-d52137c24cbd@redhat.com> (raw)
In-Reply-To: <20190325064046.GB12016@zn.tnic>

在 2019年03月25日 14:40, Borislav Petkov 写道:
> On Mon, Mar 25, 2019 at 11:11:45AM +0800, lijiang wrote:
>> I mean it needs to find all the value of the 'IORES_DESC_ACPI_*' type.
> 
> A function called __ioremap_check_desc_other() needs to find
> IORES_DESC_ACPI_* types...
> 
> No, still don't know what you're trying to do.

Let's look at the discussion in patch v8, please refer to this link:
https://lkml.org/lkml/2019/3/16/15

I did a test according to Tom's reply, and the test indicated his suggestion was
correct, we should change this to check for IORES_DESC_ACPI_* values.

> 
>> As above mentioned, it needs to find all the value of the 'IORES_DESC_ACPI_*'
>> type, so we should explicitly use the 'IORES_DESC_ACPI_*' type as the check
>> condition instead of the 'IORES_DESC_NONE'.
> 
> And now the same question I'm asking you each time: WHY does it need to find
> the ACPI types?
> 

When SEV is enabled and the page being mapped is in memory, need to ensure the
memory encryption attribute is also enabled in the resulting mapping.

I believe Tom knows better than me. :-)

Thanks.
Lianbo

WARNING: multiple messages have this Message-ID (diff)
From: lijiang <lijiang@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas.Lendacky@amd.com, x86@kernel.org, bhe@redhat.com,
	peterz@infradead.org, dave.hansen@linux.intel.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, luto@kernel.org, hpa@zytor.com,
	tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion
Date: Mon, 25 Mar 2019 17:20:43 +0800	[thread overview]
Message-ID: <dd7b5fb6-bd77-61a2-afa5-d52137c24cbd@redhat.com> (raw)
In-Reply-To: <20190325064046.GB12016@zn.tnic>

在 2019年03月25日 14:40, Borislav Petkov 写道:
> On Mon, Mar 25, 2019 at 11:11:45AM +0800, lijiang wrote:
>> I mean it needs to find all the value of the 'IORES_DESC_ACPI_*' type.
> 
> A function called __ioremap_check_desc_other() needs to find
> IORES_DESC_ACPI_* types...
> 
> No, still don't know what you're trying to do.

Let's look at the discussion in patch v8, please refer to this link:
https://lkml.org/lkml/2019/3/16/15

I did a test according to Tom's reply, and the test indicated his suggestion was
correct, we should change this to check for IORES_DESC_ACPI_* values.

> 
>> As above mentioned, it needs to find all the value of the 'IORES_DESC_ACPI_*'
>> type, so we should explicitly use the 'IORES_DESC_ACPI_*' type as the check
>> condition instead of the 'IORES_DESC_NONE'.
> 
> And now the same question I'm asking you each time: WHY does it need to find
> the ACPI types?
> 

When SEV is enabled and the page being mapped is in memory, need to ensure the
memory encryption attribute is also enabled in the resulting mapping.

I believe Tom knows better than me. :-)

Thanks.
Lianbo

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2019-03-25  9:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 10:33 [PATCH 0/3 v9] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2019-03-21 10:33 ` Lianbo Jiang
2019-03-21 10:33 ` [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion Lianbo Jiang
2019-03-21 10:33   ` Lianbo Jiang
2019-03-22 17:51   ` Borislav Petkov
2019-03-22 17:51     ` Borislav Petkov
2019-03-25  3:11     ` lijiang
2019-03-25  3:11       ` lijiang
2019-03-25  6:40       ` Borislav Petkov
2019-03-25  6:40         ` Borislav Petkov
2019-03-25  9:20         ` lijiang [this message]
2019-03-25  9:20           ` lijiang
2019-03-25 12:15           ` Borislav Petkov
2019-03-25 12:15             ` Borislav Petkov
2019-03-21 10:33 ` [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' Lianbo Jiang
2019-03-21 10:33   ` Lianbo Jiang
2019-03-22 19:28   ` Borislav Petkov
2019-03-22 19:28     ` Borislav Petkov
2019-03-25  6:53     ` lijiang
2019-03-25  6:53       ` lijiang
2019-03-25 12:24       ` Borislav Petkov
2019-03-25 12:24         ` Borislav Petkov
2019-03-28 14:00         ` lijiang
2019-03-28 14:00           ` lijiang
2019-03-21 10:33 ` [PATCH 3/3 v9] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
2019-03-21 10:33   ` Lianbo Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd7b5fb6-bd77-61a2-afa5-d52137c24cbd@redhat.com \
    --to=lijiang@redhat.com \
    --cc=Thomas.Lendacky@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.