From: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>, Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>, Hubert Denkmair <h.denkmair-4pT7WzY1KUiELgA04lAiVw@public.gmane.org>, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: [PATCH V2 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup Date: Sun, 24 Mar 2019 17:50:00 +0000 [thread overview] Message-ID: <20190324175002.28969-8-kernel@martin.sperl.org> (raw) In-Reply-To: <20190324175002.28969-1-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> Setup gpio-cs to the correct levels during setup and also make the gpio definitely an output GPIO. This is transparently fixing some badly configured DTs in the process where cs-gpio is set but the gpios are still configured with native cs. It also makes 100% sure that the initial CS levels are as expected - especially on systems with devices on a bus with mixed CS_HIGH/CS_LOW settings. Fixes: 1ea29b39f4c812ece2f936065a0a3d6fe44a263e Signed-off-by: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> --- drivers/spi/spi-bcm2835aux.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c index 6af07dec5fdc..dd0446968da6 100644 --- a/drivers/spi/spi-bcm2835aux.c +++ b/drivers/spi/spi-bcm2835aux.c @@ -425,7 +425,17 @@ static int bcm2835aux_spi_setup(struct spi_device *spi) return -EINVAL; } - return 0; + /* with gpio-cs set the GPIO to the correct level + * and as output (in case the dt has the gpio not configured + * as output but native cs) + */ + ret = gpio_direction_output(spi->cs_gpio, + (spi->mode & SPI_CS_HIGH) ? 0 : 1); + if (ret) + dev_err(&spi->dev, "could not set gpio %i as output: %i\n", + spi->cs_gpio, ret); + + return ret; } static int bcm2835aux_spi_probe(struct platform_device *pdev) -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: kernel@martin.sperl.org To: Mark Brown <broonie@kernel.org>, Eric Anholt <eric@anholt.net>, Stefan Wahren <stefan.wahren@i2se.com>, Hubert Denkmair <h.denkmair@intence.de>, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Martin Sperl <kernel@martin.sperl.org> Subject: [PATCH V2 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup Date: Sun, 24 Mar 2019 17:50:00 +0000 [thread overview] Message-ID: <20190324175002.28969-8-kernel@martin.sperl.org> (raw) In-Reply-To: <20190324175002.28969-1-kernel@martin.sperl.org> From: Martin Sperl <kernel@martin.sperl.org> Setup gpio-cs to the correct levels during setup and also make the gpio definitely an output GPIO. This is transparently fixing some badly configured DTs in the process where cs-gpio is set but the gpios are still configured with native cs. It also makes 100% sure that the initial CS levels are as expected - especially on systems with devices on a bus with mixed CS_HIGH/CS_LOW settings. Fixes: 1ea29b39f4c812ece2f936065a0a3d6fe44a263e Signed-off-by: Martin Sperl <kernel@martin.sperl.org> --- drivers/spi/spi-bcm2835aux.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c index 6af07dec5fdc..dd0446968da6 100644 --- a/drivers/spi/spi-bcm2835aux.c +++ b/drivers/spi/spi-bcm2835aux.c @@ -425,7 +425,17 @@ static int bcm2835aux_spi_setup(struct spi_device *spi) return -EINVAL; } - return 0; + /* with gpio-cs set the GPIO to the correct level + * and as output (in case the dt has the gpio not configured + * as output but native cs) + */ + ret = gpio_direction_output(spi->cs_gpio, + (spi->mode & SPI_CS_HIGH) ? 0 : 1); + if (ret) + dev_err(&spi->dev, "could not set gpio %i as output: %i\n", + spi->cs_gpio, ret); + + return ret; } static int bcm2835aux_spi_probe(struct platform_device *pdev) -- 2.11.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-24 17:50 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-24 17:49 [PATCH V2 0/9] spi: bcm2835aux: bug fixes and improvements kernel 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 3/9] spi: bcm2835aux: use BCM2835_AUX_SPI_STAT_RX_LVL kernel 2019-03-24 17:49 ` kernel 2019-03-25 9:52 ` Stefan Wahren 2019-03-25 9:52 ` Stefan Wahren 2019-03-24 17:49 ` [PATCH V2 6/9] spi: bcm2835aux: warn in dmesg that native cs is not really supported kernel 2019-03-24 17:49 ` kernel 2019-03-25 10:28 ` Stefan Wahren 2019-03-25 10:28 ` Stefan Wahren [not found] ` <20190324175002.28969-1-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2019-03-24 17:49 ` [PATCH V2 1/9] spi: bcm2835aux: unifying code between polling and interrupt driven code kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 2/9] spi: bcm2835aux: remove dangerous uncontrolled read of fifo kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 4/9] spi: bcm2835aux: remove dead code kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 5/9] spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpios kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:50 ` kernel-TqfNSX0MhmxHKSADF0wUEw [this message] 2019-03-24 17:50 ` [PATCH V2 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup kernel 2019-03-24 17:50 ` [PATCH V2 8/9] spi: bcm2835aux: add driver stats to debugfs kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:50 ` kernel 2019-03-25 9:28 ` Stefan Wahren 2019-03-25 9:28 ` Stefan Wahren 2019-03-25 9:52 ` kernel 2019-03-25 10:06 ` Stefan Wahren 2019-03-25 10:11 ` kernel 2019-03-25 10:45 ` Stefan Wahren 2019-03-24 17:50 ` [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:50 ` kernel 2019-03-25 9:44 ` Stefan Wahren 2019-03-25 9:44 ` Stefan Wahren 2019-03-25 9:49 ` kernel 2019-03-25 9:49 ` kernel 2019-03-25 9:59 ` Stefan Wahren 2019-03-25 9:59 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190324175002.28969-8-kernel@martin.sperl.org \ --to=kernel-tqfnsx0mhmxhksadf0wuew@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org \ --cc=h.denkmair-4pT7WzY1KUiELgA04lAiVw@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.