From: Stefan Wahren <stefan.wahren@i2se.com> To: kernel@martin.sperl.org Cc: linux-spi@vger.kernel.org, Eric Anholt <eric@anholt.net>, Mark Brown <broonie@kernel.org>, linux-rpi-kernel@lists.infradead.org, Hubert Denkmair <h.denkmair@intence.de>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable Date: Mon, 25 Mar 2019 10:59:02 +0100 [thread overview] Message-ID: <d08ce3d4-ec90-6981-bf39-1320a1643e6f@i2se.com> (raw) In-Reply-To: <63AAA1F6-25FB-4C58-9F9B-9377E94CB3B2@martin.sperl.org> Am 25.03.19 um 10:49 schrieb kernel@martin.sperl.org: >> On 25.03.2019, at 10:44, Stefan Wahren <stefan.wahren@i2se.com> wrote: >> >> Hi Martin, >> >> Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: >>> From: Martin Sperl <kernel@martin.sperl.org> >>> >>> +/* define polling limits */ >>> +unsigned int polling_limit_us = 30; >>> +module_param(polling_limit_us, uint, 0664); >>> +MODULE_PARM_DESC(polling_limit_us, >>> + "time in us to run a transfer in polling mode\n"); >>> + >> could you please document the case polling_limit_us = 0 ? > Means no polling under any circumstances - I can add it as a comment in V3. I meant the parameter description, because users shouldn't be forced to look at the source code. > > martin > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com> To: kernel@martin.sperl.org Cc: linux-spi@vger.kernel.org, Eric Anholt <eric@anholt.net>, Mark Brown <broonie@kernel.org>, linux-rpi-kernel@lists.infradead.org, Hubert Denkmair <h.denkmair@intence.de>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable Date: Mon, 25 Mar 2019 10:59:02 +0100 [thread overview] Message-ID: <d08ce3d4-ec90-6981-bf39-1320a1643e6f@i2se.com> (raw) In-Reply-To: <63AAA1F6-25FB-4C58-9F9B-9377E94CB3B2@martin.sperl.org> Am 25.03.19 um 10:49 schrieb kernel@martin.sperl.org: >> On 25.03.2019, at 10:44, Stefan Wahren <stefan.wahren@i2se.com> wrote: >> >> Hi Martin, >> >> Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: >>> From: Martin Sperl <kernel@martin.sperl.org> >>> >>> +/* define polling limits */ >>> +unsigned int polling_limit_us = 30; >>> +module_param(polling_limit_us, uint, 0664); >>> +MODULE_PARM_DESC(polling_limit_us, >>> + "time in us to run a transfer in polling mode\n"); >>> + >> could you please document the case polling_limit_us = 0 ? > Means no polling under any circumstances - I can add it as a comment in V3. I meant the parameter description, because users shouldn't be forced to look at the source code. > > martin > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-25 9:59 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-24 17:49 [PATCH V2 0/9] spi: bcm2835aux: bug fixes and improvements kernel 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 3/9] spi: bcm2835aux: use BCM2835_AUX_SPI_STAT_RX_LVL kernel 2019-03-24 17:49 ` kernel 2019-03-25 9:52 ` Stefan Wahren 2019-03-25 9:52 ` Stefan Wahren 2019-03-24 17:49 ` [PATCH V2 6/9] spi: bcm2835aux: warn in dmesg that native cs is not really supported kernel 2019-03-24 17:49 ` kernel 2019-03-25 10:28 ` Stefan Wahren 2019-03-25 10:28 ` Stefan Wahren [not found] ` <20190324175002.28969-1-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2019-03-24 17:49 ` [PATCH V2 1/9] spi: bcm2835aux: unifying code between polling and interrupt driven code kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 2/9] spi: bcm2835aux: remove dangerous uncontrolled read of fifo kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 4/9] spi: bcm2835aux: remove dead code kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:49 ` [PATCH V2 5/9] spi: bcm2835aux: fix driver to not allow 65535 (=-1) cs-gpios kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:49 ` kernel 2019-03-24 17:50 ` [PATCH V2 7/9] spi: bcm2835aux: setup gpio-cs to output and correct level during setup kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:50 ` kernel 2019-03-24 17:50 ` [PATCH V2 8/9] spi: bcm2835aux: add driver stats to debugfs kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:50 ` kernel 2019-03-25 9:28 ` Stefan Wahren 2019-03-25 9:28 ` Stefan Wahren 2019-03-25 9:52 ` kernel 2019-03-25 10:06 ` Stefan Wahren 2019-03-25 10:11 ` kernel 2019-03-25 10:45 ` Stefan Wahren 2019-03-24 17:50 ` [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable kernel-TqfNSX0MhmxHKSADF0wUEw 2019-03-24 17:50 ` kernel 2019-03-25 9:44 ` Stefan Wahren 2019-03-25 9:44 ` Stefan Wahren 2019-03-25 9:49 ` kernel 2019-03-25 9:49 ` kernel 2019-03-25 9:59 ` Stefan Wahren [this message] 2019-03-25 9:59 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d08ce3d4-ec90-6981-bf39-1320a1643e6f@i2se.com \ --to=stefan.wahren@i2se.com \ --cc=broonie@kernel.org \ --cc=eric@anholt.net \ --cc=h.denkmair@intence.de \ --cc=kernel@martin.sperl.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.