All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
	Ying Xue <ying.xue@windriver.com>,
	Hoang Le <hoang.h.le@dektech.com.au>,
	Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <netdev@vger.kernel.org>,
	<tipc-discussion@lists.sourceforge.net>,
	<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
Date: Mon, 25 Mar 2019 06:31:09 +0000	[thread overview]
Message-ID: <20190325063109.173692-1-weiyongjun1@huawei.com> (raw)
In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().

Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: add reported-by
---
 net/tipc/bcast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 88edfb358ae7..76e14dc08bb9 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
 
 	/* Allocate dummy message */
 	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
-	if (!skb)
+	if (!_skb)
 		return -ENOMEM;
 
 	/* Preparing for 'synching' header */




WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Jon Maloy <jon.maloy@ericsson.com>,
	Ying Xue <ying.xue@windriver.com>,
	Hoang Le <hoang.h.le@dektech.com.au>,
	Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
	netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send_sync()
Date: Mon, 25 Mar 2019 06:31:09 +0000	[thread overview]
Message-ID: <20190325063109.173692-1-weiyongjun1@huawei.com> (raw)
In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in tipc_mcast_send_sync().

Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: add reported-by
---
 net/tipc/bcast.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 88edfb358ae7..76e14dc08bb9 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c
@@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
 
 	/* Allocate dummy message */
 	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
-	if (!skb)
+	if (!_skb)
 		return -ENOMEM;
 
 	/* Preparing for 'synching' header */

  parent reply	other threads:[~2019-03-25  6:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  8:58 [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync() Wei Yongjun
2019-03-21  8:58 ` Wei Yongjun
2019-03-21  8:58 ` Eric Dumazet
2019-03-21  8:58   ` Eric Dumazet
2019-03-25  6:31 ` Wei Yongjun [this message]
2019-03-25  6:31   ` [PATCH net-next v2] " Wei Yongjun
2019-03-25 16:29   ` Jon Maloy
2019-03-25 16:29     ` Jon Maloy
2019-03-26 18:39   ` David Miller
2019-03-26 18:39     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325063109.173692-1-weiyongjun1@huawei.com \
    --to=weiyongjun1@huawei.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hoang.h.le@dektech.com.au \
    --cc=hulkci@huawei.com \
    --cc=jon.maloy@ericsson.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.