All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brian Norris <briannorris@chromium.org>
Cc: shuah <shuah@kernel.org>, David Valleau <valleau@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Sasha Levin <alexander.levin@microsoft.com>
Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions
Date: Tue, 26 Mar 2019 09:55:09 +0900	[thread overview]
Message-ID: <20190326005509.GA32180@kroah.com> (raw)
In-Reply-To: <CA+ASDXMR_HPSnAWRGYV_fDq6kSR7WdgTq3pgW9VaTwA7fA7=qA@mail.gmail.com>

On Mon, Mar 25, 2019 at 05:49:07PM -0700, Brian Norris wrote:
> > Not to say that this shouldn't be fixed if at all possible, but realize
> > that this is not the "normal" case of "we do not break userspace" here,
> > given the tool involved, and the apis being used.
> 
> I think I sort of understand what you're going for here, but can you
> elaborate so I don't have to assume?

To be specific, tools at the "very low level" that are used to configure
the kernel for userspace, or to interact with the kernel such that other
programs work on top of things properly (like udev), we have broken apis
such that we can fix issues with old mistakes and move on to more secure
or "correct" apis.

So we do change things at this layer at times, and normally no one
notices as they have moved on to newer userspace programs in the past 3
years.  Sometimes we do keep kernel support for really old userspace
systems, until they die out, and then we can finally drop the kernel
code.  Again, udev has done this over the years as we worked to figure
out a sane way to handle stuff.  We have rolled back kernel changes
until people finally killed their old Fedora 3 ppc32 systems for
example :)

To be honest, with the USB3 support added to usbip, no one noticed that
things broke, and the fact that it took 4 years to notice implies that
maybe it wasn't that big of a deal as no one used this.  But, as you
show, that assumption was not correct, so if we can fix things, we
should.

Did that help?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Brian Norris <briannorris@chromium.org>
Cc: shuah <shuah@kernel.org>, David Valleau <valleau@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Sasha Levin <alexander.levin@microsoft.com>
Subject: tools: usb: usbip: adding support for older kernel versions
Date: Tue, 26 Mar 2019 09:55:09 +0900	[thread overview]
Message-ID: <20190326005509.GA32180@kroah.com> (raw)

On Mon, Mar 25, 2019 at 05:49:07PM -0700, Brian Norris wrote:
> > Not to say that this shouldn't be fixed if at all possible, but realize
> > that this is not the "normal" case of "we do not break userspace" here,
> > given the tool involved, and the apis being used.
> 
> I think I sort of understand what you're going for here, but can you
> elaborate so I don't have to assume?

To be specific, tools at the "very low level" that are used to configure
the kernel for userspace, or to interact with the kernel such that other
programs work on top of things properly (like udev), we have broken apis
such that we can fix issues with old mistakes and move on to more secure
or "correct" apis.

So we do change things at this layer at times, and normally no one
notices as they have moved on to newer userspace programs in the past 3
years.  Sometimes we do keep kernel support for really old userspace
systems, until they die out, and then we can finally drop the kernel
code.  Again, udev has done this over the years as we worked to figure
out a sane way to handle stuff.  We have rolled back kernel changes
until people finally killed their old Fedora 3 ppc32 systems for
example :)

To be honest, with the USB3 support added to usbip, no one noticed that
things broke, and the fact that it took 4 years to notice implies that
maybe it wasn't that big of a deal as no one used this.  But, as you
show, that assumption was not correct, so if we can fix things, we
should.

Did that help?

thanks,

greg k-h

  reply	other threads:[~2019-03-26  0:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 21:47 [PATCH] tools: usb: usbip: adding support for older kernel versions David Valleau
2019-03-06 21:47 ` David Valleau
2019-03-16 23:39 ` [PATCH] " shuah
2019-03-16 23:39   ` Shuah Khan
2019-03-18 18:23   ` [PATCH] " Brian Norris
2019-03-18 18:23     ` Brian Norris
2019-03-25 15:51     ` [PATCH] " shuah
2019-03-25 15:51       ` Shuah Khan
2019-03-25 17:56       ` [PATCH] " Brian Norris
2019-03-25 17:56         ` Brian Norris
2019-03-25 22:07         ` [PATCH] " shuah
2019-03-25 22:07           ` Shuah Khan
2019-03-25 23:02           ` [PATCH] " Brian Norris
2019-03-25 23:02             ` Brian Norris
2019-03-26  0:04             ` [PATCH] " shuah
2019-03-26  0:04               ` Shuah Khan
2019-03-26  1:29               ` [PATCH] " Brian Norris
2019-03-26  1:29                 ` Brian Norris
2019-03-26  1:59                 ` [PATCH] " shuah
2019-03-26  1:59                   ` Shuah Khan
2019-03-27  1:16                   ` [PATCH] " Brian Norris
2019-03-27  1:16                     ` Brian Norris
2019-03-26  0:13             ` [PATCH] " Greg Kroah-Hartman
2019-03-26  0:13               ` Greg Kroah-Hartman
2019-03-26  0:49               ` [PATCH] " Brian Norris
2019-03-26  0:49                 ` Brian Norris
2019-03-26  0:55                 ` Greg Kroah-Hartman [this message]
2019-03-26  0:55                   ` Greg Kroah-Hartman
2019-03-26  1:28                   ` [PATCH] " Brian Norris
2019-03-26  1:28                     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190326005509.GA32180@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.levin@microsoft.com \
    --cc=briannorris@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=valleau@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.