All of lore.kernel.org
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: David Valleau <valleau@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <alexander.levin@microsoft.com>,
	shuah <shuah@kernel.org>
Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions
Date: Mon, 25 Mar 2019 19:59:30 -0600	[thread overview]
Message-ID: <01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org> (raw)
In-Reply-To: <CA+ASDXMt97g-r3PniB4Z9+DeETdybtZ2sUneRgmetRKVZC-FBw@mail.gmail.com>

On 3/25/19 7:29 PM, Brian Norris wrote:
> Hi Shuah,
> 
> On Mon, Mar 25, 2019 at 5:04 PM shuah <shuah@kernel.org> wrote:
>> Agreed. Let's move forward with the assumption that this won't happen
>> in the future.
> 

I would amend that to say, unless absolutely necessary. The user
exported information is stable after fixing the kernel address
pointer leaks. If something pops up that requires changes, I will
have to make a call on that.

> Great! Are you going to propose a Documentation/ABI/ patch to help
> with that? e.g., Documentation/ABI/testing/sysfs-platform-vhci-hcd?
> I'm frankly not that familiar with usbip (I'm just trying to help
> David out) and might not be the best person for describing the details
> exposed here.
> 

ABI will need to documented at some point. :) This driver moved from
staging to mainline around 3.18 time frame. So what you are seeing is
adaption and enhancements. Some background on this driver might help
understand some of the growing pains. :) This is one of the reasons,
I strongly recommend not using old tool on new kernels and make sure
you are on the latest stable releases. For more details on the nature
if security fixes:

https://events.linuxfoundation.org/wp-content/uploads/2017/11/One-Small-Step-to-Harden-USB-Over-IP-on-Linux-Shuah-Khan-Samsung-OSG.pdf

> And are you planning to try something else to maintain compatibility
> pre-[1]? I'm not saying you have to, but you mentioned it and I'd like
> to know if we're doing any duplicate work.
> 

1. I plan to fix the tool to make it run on older kernels (pre-USB 3.0).
2. I don't plan to support old tool running on new kernels. It doesn't
make sense considering the security fixes. You can use the latest on
older kernels (pre-USB 3.0).
3. I am going to assume you are *using* the latest stable kernels that
have the security fixes.

thanks,
-- Shuah




WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuah@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: David Valleau <valleau@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <alexander.levin@microsoft.com>,
	shuah <shuah@kernel.org>
Subject: tools: usb: usbip: adding support for older kernel versions
Date: Mon, 25 Mar 2019 19:59:30 -0600	[thread overview]
Message-ID: <01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org> (raw)

On 3/25/19 7:29 PM, Brian Norris wrote:
> Hi Shuah,
> 
> On Mon, Mar 25, 2019 at 5:04 PM shuah <shuah@kernel.org> wrote:
>> Agreed. Let's move forward with the assumption that this won't happen
>> in the future.
> 

I would amend that to say, unless absolutely necessary. The user
exported information is stable after fixing the kernel address
pointer leaks. If something pops up that requires changes, I will
have to make a call on that.

> Great! Are you going to propose a Documentation/ABI/ patch to help
> with that? e.g., Documentation/ABI/testing/sysfs-platform-vhci-hcd?
> I'm frankly not that familiar with usbip (I'm just trying to help
> David out) and might not be the best person for describing the details
> exposed here.
> 

ABI will need to documented at some point. :) This driver moved from
staging to mainline around 3.18 time frame. So what you are seeing is
adaption and enhancements. Some background on this driver might help
understand some of the growing pains. :) This is one of the reasons,
I strongly recommend not using old tool on new kernels and make sure
you are on the latest stable releases. For more details on the nature
if security fixes:

https://events.linuxfoundation.org/wp-content/uploads/2017/11/One-Small-Step-to-Harden-USB-Over-IP-on-Linux-Shuah-Khan-Samsung-OSG.pdf

> And are you planning to try something else to maintain compatibility
> pre-[1]? I'm not saying you have to, but you mentioned it and I'd like
> to know if we're doing any duplicate work.
> 

1. I plan to fix the tool to make it run on older kernels (pre-USB 3.0).
2. I don't plan to support old tool running on new kernels. It doesn't
make sense considering the security fixes. You can use the latest on
older kernels (pre-USB 3.0).
3. I am going to assume you are *using* the latest stable kernels that
have the security fixes.

thanks,
-- Shuah

  reply	other threads:[~2019-03-26  1:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 21:47 [PATCH] tools: usb: usbip: adding support for older kernel versions David Valleau
2019-03-06 21:47 ` David Valleau
2019-03-16 23:39 ` [PATCH] " shuah
2019-03-16 23:39   ` Shuah Khan
2019-03-18 18:23   ` [PATCH] " Brian Norris
2019-03-18 18:23     ` Brian Norris
2019-03-25 15:51     ` [PATCH] " shuah
2019-03-25 15:51       ` Shuah Khan
2019-03-25 17:56       ` [PATCH] " Brian Norris
2019-03-25 17:56         ` Brian Norris
2019-03-25 22:07         ` [PATCH] " shuah
2019-03-25 22:07           ` Shuah Khan
2019-03-25 23:02           ` [PATCH] " Brian Norris
2019-03-25 23:02             ` Brian Norris
2019-03-26  0:04             ` [PATCH] " shuah
2019-03-26  0:04               ` Shuah Khan
2019-03-26  1:29               ` [PATCH] " Brian Norris
2019-03-26  1:29                 ` Brian Norris
2019-03-26  1:59                 ` shuah [this message]
2019-03-26  1:59                   ` Shuah Khan
2019-03-27  1:16                   ` [PATCH] " Brian Norris
2019-03-27  1:16                     ` Brian Norris
2019-03-26  0:13             ` [PATCH] " Greg Kroah-Hartman
2019-03-26  0:13               ` Greg Kroah-Hartman
2019-03-26  0:49               ` [PATCH] " Brian Norris
2019-03-26  0:49                 ` Brian Norris
2019-03-26  0:55                 ` [PATCH] " Greg Kroah-Hartman
2019-03-26  0:55                   ` Greg Kroah-Hartman
2019-03-26  1:28                   ` [PATCH] " Brian Norris
2019-03-26  1:28                     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org \
    --to=shuah@kernel.org \
    --cc=alexander.levin@microsoft.com \
    --cc=briannorris@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=valentina.manea.m@gmail.com \
    --cc=valleau@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.