From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Yu Chen <chenyu56@huawei.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Hans de Goede <hdegoede@redhat.com>, Andy Shevchenko <andy.shevchenko@gmail.com> Subject: Re: [PATCH v5 08/13] usb: roles: Introduce stubs for the exiting functions in role.h. Date: Thu, 4 Apr 2019 16:25:28 +0300 [thread overview] Message-ID: <20190404132528.GD21319@kuha.fi.intel.com> (raw) In-Reply-To: <20190329041409.70138-9-chenyu56@huawei.com> On Fri, Mar 29, 2019 at 12:14:04PM +0800, Yu Chen wrote: > This patch adds stubs for the exiting functions while > CONFIG_USB_ROLE_SWITCH does not enabled. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: John Stultz <john.stultz@linaro.org> > Signed-off-by: Yu Chen <chenyu56@huawei.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > include/linux/usb/role.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > index c05ffa6abda9..da2b9641b877 100644 > --- a/include/linux/usb/role.h > +++ b/include/linux/usb/role.h > @@ -42,6 +42,8 @@ struct usb_role_switch_desc { > bool allow_userspace_control; > }; > > + > +#if IS_ENABLED(CONFIG_USB_ROLE_SWITCH) > int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > struct usb_role_switch *usb_role_switch_get(struct device *dev); > @@ -51,5 +53,33 @@ struct usb_role_switch * > usb_role_switch_register(struct device *parent, > const struct usb_role_switch_desc *desc); > void usb_role_switch_unregister(struct usb_role_switch *sw); > +#else > +static inline int usb_role_switch_set_role(struct usb_role_switch *sw, > + enum usb_role role) > +{ > + return 0; > +} > + > +static inline enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw) > +{ > + return USB_ROLE_NONE; > +} > + > +static inline struct usb_role_switch *usb_role_switch_get(struct device *dev) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline void usb_role_switch_put(struct usb_role_switch *sw) { } > + > +static inline struct usb_role_switch * > +usb_role_switch_register(struct device *parent, > + const struct usb_role_switch_desc *desc) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline void usb_role_switch_unregister(struct usb_role_switch *sw) { } > +#endif > > #endif /* __LINUX_USB_ROLE_H */ > -- > 2.15.0-rc2 thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Yu Chen <chenyu56@huawei.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Hans de Goede <hdegoede@redhat.com>, Andy Shevchenko <andy.shevchenko@gmail.com> Subject: [v5,08/13] usb: roles: Introduce stubs for the exiting functions in role.h. Date: Thu, 4 Apr 2019 16:25:28 +0300 [thread overview] Message-ID: <20190404132528.GD21319@kuha.fi.intel.com> (raw) On Fri, Mar 29, 2019 at 12:14:04PM +0800, Yu Chen wrote: > This patch adds stubs for the exiting functions while > CONFIG_USB_ROLE_SWITCH does not enabled. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: John Stultz <john.stultz@linaro.org> > Signed-off-by: Yu Chen <chenyu56@huawei.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > include/linux/usb/role.h | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h > index c05ffa6abda9..da2b9641b877 100644 > --- a/include/linux/usb/role.h > +++ b/include/linux/usb/role.h > @@ -42,6 +42,8 @@ struct usb_role_switch_desc { > bool allow_userspace_control; > }; > > + > +#if IS_ENABLED(CONFIG_USB_ROLE_SWITCH) > int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); > enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); > struct usb_role_switch *usb_role_switch_get(struct device *dev); > @@ -51,5 +53,33 @@ struct usb_role_switch * > usb_role_switch_register(struct device *parent, > const struct usb_role_switch_desc *desc); > void usb_role_switch_unregister(struct usb_role_switch *sw); > +#else > +static inline int usb_role_switch_set_role(struct usb_role_switch *sw, > + enum usb_role role) > +{ > + return 0; > +} > + > +static inline enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw) > +{ > + return USB_ROLE_NONE; > +} > + > +static inline struct usb_role_switch *usb_role_switch_get(struct device *dev) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline void usb_role_switch_put(struct usb_role_switch *sw) { } > + > +static inline struct usb_role_switch * > +usb_role_switch_register(struct device *parent, > + const struct usb_role_switch_desc *desc) > +{ > + return ERR_PTR(-ENODEV); > +} > + > +static inline void usb_role_switch_unregister(struct usb_role_switch *sw) { } > +#endif > > #endif /* __LINUX_USB_ROLE_H */ > -- > 2.15.0-rc2 thanks,
next prev parent reply other threads:[~2019-04-04 13:25 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-29 4:13 [PATCH v5 00/13] Add support for usb on Hikey960 Yu Chen 2019-03-29 4:13 ` Yu Chen 2019-03-29 4:13 ` [PATCH v5 01/13] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen 2019-03-29 4:13 ` [v5,01/13] " Yu Chen 2019-03-29 4:13 ` [PATCH v5 01/13] " Yu Chen 2019-03-29 4:13 ` [PATCH v5 02/13] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen 2019-03-29 4:13 ` [v5,02/13] " Yu Chen 2019-03-29 4:13 ` [PATCH v5 02/13] " Yu Chen 2019-03-29 4:13 ` [PATCH v5 03/13] usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc Platform Yu Chen 2019-03-29 4:13 ` [v5,03/13] " Yu Chen 2019-03-29 4:13 ` [PATCH v5 03/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 04/13] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc Yu Chen 2019-03-29 4:14 ` [v5,04/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 04/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 05/13] usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe " Yu Chen 2019-03-29 4:14 ` [v5,05/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 05/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 06/13] usb: dwc3: Increase timeout for CmdAct cleared by device controller Yu Chen 2019-03-29 4:14 ` [v5,06/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 06/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 07/13] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen 2019-03-29 4:14 ` [v5,07/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 07/13] " Yu Chen 2019-04-17 6:42 ` Kishon Vijay Abraham I 2019-04-17 6:42 ` [v5,07/13] " Kishon Vijay Abraham I 2019-04-17 6:42 ` [PATCH v5 07/13] " Kishon Vijay Abraham I 2019-04-17 7:19 ` Chen Yu 2019-04-17 7:19 ` [v5,07/13] " Yu Chen 2019-04-17 7:19 ` [PATCH v5 07/13] " Chen Yu 2019-03-29 4:14 ` [PATCH v5 08/13] usb: roles: Introduce stubs for the exiting functions in role.h Yu Chen 2019-03-29 4:14 ` [v5,08/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 08/13] " Yu Chen 2019-04-04 13:25 ` Heikki Krogerus [this message] 2019-04-04 13:25 ` [v5,08/13] " Heikki Krogerus 2019-03-29 4:14 ` [PATCH v5 09/13] usb: roles: Add usb role switch notifier Yu Chen 2019-03-29 4:14 ` [v5,09/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 09/13] " Yu Chen 2019-04-04 13:26 ` Heikki Krogerus 2019-04-04 13:26 ` [v5,09/13] " Heikki Krogerus 2019-04-12 1:12 ` [PATCH v5 09/13] " John Stultz 2019-04-12 1:12 ` [v5,09/13] " John Stultz 2019-04-12 1:12 ` [PATCH v5 09/13] " John Stultz 2019-04-12 3:59 ` John Stultz 2019-04-12 3:59 ` [v5,09/13] " John Stultz 2019-04-12 3:59 ` [PATCH v5 09/13] " John Stultz 2019-03-29 4:14 ` [PATCH v5 10/13] usb: dwc3: Registering a role switch in the DRD code Yu Chen 2019-03-29 4:14 ` [v5,10/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 10/13] " Yu Chen 2019-04-12 0:48 ` John Stultz 2019-04-12 0:48 ` [v5,10/13] " John Stultz 2019-04-12 0:48 ` [PATCH v5 10/13] " John Stultz 2019-04-12 1:23 ` Chen Yu 2019-04-12 1:23 ` [v5,10/13] " Yu Chen 2019-04-12 1:23 ` [PATCH v5 10/13] " Chen Yu 2019-03-29 4:14 ` [PATCH v5 11/13] hikey960: Support usb functionality of Hikey960 Yu Chen 2019-03-29 4:14 ` [v5,11/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 11/13] " Yu Chen 2019-04-12 0:55 ` John Stultz 2019-04-12 0:55 ` [v5,11/13] " John Stultz 2019-04-12 0:55 ` [PATCH v5 11/13] " John Stultz 2019-03-29 4:14 ` [PATCH v5 12/13] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen 2019-03-29 4:14 ` [v5,12/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 12/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 13/13] dts: hi3660: Add support for usb on Hikey960 Yu Chen 2019-03-29 4:14 ` Yu Chen 2019-03-29 4:14 ` [v5,13/13] " Yu Chen 2019-03-29 4:14 ` [PATCH v5 13/13] " Yu Chen 2019-04-01 14:57 ` [PATCH v5 00/13] " Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190404132528.GD21319@kuha.fi.intel.com \ --to=heikki.krogerus@linux.intel.com \ --cc=andy.shevchenko@gmail.com \ --cc=butao@hisilicon.com \ --cc=chenyao11@huawei.com \ --cc=chenyu56@huawei.com \ --cc=devicetree@vger.kernel.org \ --cc=fangshengzhou@hisilicon.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=john.stultz@linaro.org \ --cc=kongfei@hisilicon.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=lipengcheng8@huawei.com \ --cc=liuyu712@hisilicon.com \ --cc=songxiaowei@hisilicon.com \ --cc=suzhuangluan@hisilicon.com \ --cc=wanghu17@hisilicon.com \ --cc=xuyiping@hisilicon.com \ --cc=xuyoujun4@huawei.com \ --cc=yudongbin@hisilicon.com \ --cc=zangleigang@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.