From: Will Deacon <will.deacon@arm.com> To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>, "Paul E. McKenney" <paulmck@linux.ibm.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>, Arnd Bergmann <arnd@arndb.de>, Peter Zijlstra <peterz@infradead.org>, Andrea Parri <andrea.parri@amarulasolutions.com>, Palmer Dabbelt <palmer@sifive.com>, Daniel Lustig <dlustig@nvidia.com>, David Howells <dhowells@redhat.com>, Alan Stern <stern@rowland.harvard.edu>, Linus Torvalds <torvalds@linux-foundation.org>, "Maciej W. Rozycki" <macro@linux-mips.org>, Paul Burton <paul.burton@mips.com>, Ingo Molnar <mingo@kernel.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Tony Luck <tony.luck@intel.com>, Mikulas Patocka <mpatocka@redhat.com>, Akira Yokosawa <akiyks@gmail.com>, Luis Chamberlain <mcgrof@kernel.org>, Nicholas Piggin <npiggin@gmail.com> Subject: [PATCH v2 07/21] x86/io: Remove useless definition of mmiowb() Date: Fri, 5 Apr 2019 14:59:22 +0100 [thread overview] Message-ID: <20190405135936.7266-8-will.deacon@arm.com> (raw) In-Reply-To: <20190405135936.7266-1-will.deacon@arm.com> x86 maps mmiowb() to barrier(), but this is superfluous because a compiler barrier is already implied by spin_unlock(). Since x86 also includes asm-generic/io.h in its asm/io.h file, we can remove the definition entirely and pick up the dummy definition from core code. Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/x86/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h index 686247db3106..a06a9f8294ea 100644 --- a/arch/x86/include/asm/io.h +++ b/arch/x86/include/asm/io.h @@ -90,8 +90,6 @@ build_mmio_write(__writel, "l", unsigned int, "r", ) #define __raw_writew __writew #define __raw_writel __writel -#define mmiowb() barrier() - #ifdef CONFIG_X86_64 build_mmio_read(readq, "q", u64, "=r", :"memory") -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com> To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>, "Paul E. McKenney" <paulmck@linux.ibm.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>, Arnd Bergmann <arnd@arndb.de>, Peter Zijlstra <peterz@infradead.org>, Andrea Parri <andrea.parri@amarulasolutions.com>, Palmer Dabbelt <palmer@sifive.com>, Daniel Lustig <dlustig@nvidia.com>, David Howells <dhowells@redhat.com>, Alan Stern <stern@rowland.harvard.edu>, Linus Torvalds <torvalds@linux-foundation.org>, "Maciej W. Rozycki" <macro@linux-mips.org>, Paul Burton <paul.burton@mips.com>, Ingo Molnar <mingo@kernel.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Tony Luck <tony.luck@intel.com>, Mikulas Patocka <mpatoc> Subject: [PATCH v2 07/21] x86/io: Remove useless definition of mmiowb() Date: Fri, 5 Apr 2019 14:59:22 +0100 [thread overview] Message-ID: <20190405135936.7266-8-will.deacon@arm.com> (raw) In-Reply-To: <20190405135936.7266-1-will.deacon@arm.com> x86 maps mmiowb() to barrier(), but this is superfluous because a compiler barrier is already implied by spin_unlock(). Since x86 also includes asm-generic/io.h in its asm/io.h file, we can remove the definition entirely and pick up the dummy definition from core code. Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/x86/include/asm/io.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h index 686247db3106..a06a9f8294ea 100644 --- a/arch/x86/include/asm/io.h +++ b/arch/x86/include/asm/io.h @@ -90,8 +90,6 @@ build_mmio_write(__writel, "l", unsigned int, "r", ) #define __raw_writew __writew #define __raw_writel __writel -#define mmiowb() barrier() - #ifdef CONFIG_X86_64 build_mmio_read(readq, "q", u64, "=r", :"memory") -- 2.11.0
next prev parent reply other threads:[~2019-04-05 14:00 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-05 13:59 [PATCH v2 00/21] Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb()) Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 01/21] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-10 10:58 ` Ingo Molnar 2019-04-10 10:58 ` Ingo Molnar 2019-04-10 12:28 ` Will Deacon 2019-04-10 12:28 ` Will Deacon 2019-04-10 12:28 ` Will Deacon 2019-04-11 11:00 ` Ingo Molnar 2019-04-11 11:00 ` Ingo Molnar 2019-04-11 22:12 ` Benjamin Herrenschmidt 2019-04-11 22:12 ` Benjamin Herrenschmidt 2019-04-11 22:34 ` Linus Torvalds 2019-04-11 22:34 ` Linus Torvalds 2019-04-12 2:07 ` Benjamin Herrenschmidt 2019-04-12 2:07 ` Benjamin Herrenschmidt 2019-04-12 13:17 ` Will Deacon 2019-04-12 13:17 ` Will Deacon 2019-04-15 4:05 ` Benjamin Herrenschmidt 2019-04-15 4:05 ` Benjamin Herrenschmidt 2019-04-16 9:13 ` Will Deacon 2019-04-16 9:13 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 02/21] asm-generic/mmiowb: Add generic implementation of mmiowb() tracking Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 03/21] arch: Use asm-generic header for asm/mmiowb.h Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 04/21] mmiowb: Hook up mmiowb helpers to spinlocks and generic I/O accessors Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 05/21] ARM/io: Remove useless definition of mmiowb() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 06/21] arm64/io: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` Will Deacon [this message] 2019-04-05 13:59 ` [PATCH v2 07/21] x86/io: " Will Deacon 2019-04-05 14:14 ` Thomas Gleixner 2019-04-05 14:14 ` Thomas Gleixner 2019-04-05 13:59 ` [PATCH v2 08/21] nds32/io: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 09/21] m68k/io: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 10/21] sh/mmiowb: Add unconditional mmiowb() to arch_spin_unlock() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 11/21] mips/mmiowb: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 12/21] ia64/mmiowb: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 13/21] powerpc/mmiowb: Hook up mmwiob() implementation to asm-generic code Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 14/21] riscv/mmiowb: " Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 15/21] Documentation: Kill all references to mmiowb() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 16/21] drivers: Remove useless trailing comments from mmiowb() invocations Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 17/21] drivers: Remove explicit invocations of mmiowb() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 15:50 ` Linus Torvalds 2019-04-05 15:50 ` Linus Torvalds 2019-04-09 9:00 ` Nicholas Piggin 2019-04-09 9:00 ` Nicholas Piggin 2019-04-09 13:46 ` Will Deacon 2019-04-09 13:46 ` Will Deacon 2019-04-10 0:25 ` Nicholas Piggin 2019-04-10 0:25 ` Nicholas Piggin 2019-04-05 13:59 ` [PATCH v2 18/21] scsi/qla1280: Remove stale comment about mmiowb() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 19/21] i40iw: Redefine i40iw_mmiowb() to do nothing Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 20/21] net/ethernet/silan/sc92031: Remove stale comment about mmiowb() Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 13:59 ` [PATCH v2 21/21] arch: Remove dummy mmiowb() definitions from arch code Will Deacon 2019-04-05 13:59 ` Will Deacon 2019-04-05 15:55 ` [PATCH v2 00/21] Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb()) Linus Torvalds 2019-04-05 15:55 ` Linus Torvalds 2019-04-05 16:09 ` Will Deacon 2019-04-05 16:09 ` Will Deacon 2019-04-05 16:15 ` Linus Torvalds 2019-04-05 16:15 ` Linus Torvalds 2019-04-05 16:30 ` Will Deacon 2019-04-05 16:30 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190405135936.7266-8-will.deacon@arm.com \ --to=will.deacon@arm.com \ --cc=akiyks@gmail.com \ --cc=andrea.parri@amarulasolutions.com \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=dalias@libc.org \ --cc=dhowells@redhat.com \ --cc=dlustig@nvidia.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=macro@linux-mips.org \ --cc=mcgrof@kernel.org \ --cc=mingo@kernel.org \ --cc=mpatocka@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ --cc=palmer@sifive.com \ --cc=paul.burton@mips.com \ --cc=paulmck@linux.ibm.com \ --cc=peterz@infradead.org \ --cc=stern@rowland.harvard.edu \ --cc=tony.luck@intel.com \ --cc=torvalds@linux-foundation.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.