From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Noralf Trønnes" <noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
meghana.madhyastha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks
Date: Fri, 12 Apr 2019 10:08:26 +0100 [thread overview]
Message-ID: <20190412090826.GD6909@sirena.org.uk> (raw)
In-Reply-To: <20190411164235.49771-3-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 550 bytes --]
On Thu, Apr 11, 2019 at 06:42:33PM +0200, Noralf Trønnes wrote:
> +++ b/drivers/spi/spi.c
> @@ -1299,6 +1299,11 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread)
>
> trace_spi_message_start(ctlr->cur_msg);
>
> + ret = spi_split_transfers_maxsize(ctlr, ctlr->cur_msg, ctlr->max_dma_len,
> + GFP_KERNEL | GFP_DMA);
> + if (ret)
> + goto out;
> +
We should do any message maipulation in __spi_validate() with all the
other mainpulation, the message pump should just be pushing messages
out.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 206 bytes --]
_______________________________________________
linux-rpi-kernel mailing list
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
next prev parent reply other threads:[~2019-04-12 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:42 [PATCH v4 0/4] Chunk splitting of spi transfers Noralf Trønnes
2019-04-11 16:42 ` [PATCH v4 1/4] spi: Remove warning in spi_split_transfers_maxsize() Noralf Trønnes
[not found] ` <20190411164235.49771-1-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-04-11 16:42 ` [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks Noralf Trønnes
2019-04-11 18:18 ` Lukas Wunner
2019-04-11 21:02 ` Noralf Trønnes
2019-04-12 9:47 ` Mark Brown
[not found] ` <20190412094721.GE6909-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2019-04-12 10:03 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2019-04-12 10:22 ` Mark Brown
2019-04-12 10:54 ` Lukas Wunner
2019-04-12 11:09 ` Mark Brown
2019-04-12 11:16 ` Lukas Wunner
2019-04-12 11:28 ` Mark Brown
[not found] ` <20190412111615.25iogtr6qwc5zbx7-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2019-04-12 11:34 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2019-04-12 10:46 ` Lukas Wunner
2019-04-12 11:46 ` Mark Brown
2019-04-11 20:39 ` Noralf Trønnes
[not found] ` <20190411164235.49771-3-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-04-12 9:08 ` Mark Brown [this message]
2019-04-11 16:42 ` [PATCH v4 3/4] spi/spi-bcm2835: Remove DMA transfer size cap Noralf Trønnes
2019-04-11 16:42 ` [PATCH v4 4/4] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412090826.GD6909@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=meghana.madhyastha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.