From: Lukas Wunner <lukas@wunner.de>
To: Mark Brown <broonie@kernel.org>
Cc: stefan.wahren@i2se.com, dri-devel@lists.freedesktop.org,
linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
meghana.madhyastha@gmail.com, kernel@martin.sperl.org
Subject: Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks
Date: Fri, 12 Apr 2019 13:16:15 +0200 [thread overview]
Message-ID: <20190412111615.25iogtr6qwc5zbx7@wunner.de> (raw)
In-Reply-To: <20190412110934.GH6909@sirena.org.uk>
On Fri, Apr 12, 2019 at 12:09:34PM +0100, Mark Brown wrote:
> On Fri, Apr 12, 2019 at 12:54:48PM +0200, Lukas Wunner wrote:
> > On Fri, Apr 12, 2019 at 10:47:21AM +0100, Mark Brown wrote:
> > > I *think* we managed to fix all the architectures to at least stub out
> > > the DMA interfaces, it's such a pointless thing to have conditional -
> > > it really only makes a difference for build coverage.
>
> > My point was that the call to spi_split_transfers_maxsize() shouldn't
> > be called on non-DMA-capable platforms in the first place (because it's
> > DMA-specific).
>
> It's not a DMA specific problem - there can be SPI controller
> limitations on transfer sizes too.
The call does pass in ctlr->max_dma_len though, so is clearly motivated
by a DMA limitation.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-12 11:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:42 [PATCH v4 0/4] Chunk splitting of spi transfers Noralf Trønnes
2019-04-11 16:42 ` [PATCH v4 1/4] spi: Remove warning in spi_split_transfers_maxsize() Noralf Trønnes
[not found] ` <20190411164235.49771-1-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-04-11 16:42 ` [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks Noralf Trønnes
2019-04-11 18:18 ` Lukas Wunner
2019-04-11 21:02 ` Noralf Trønnes
2019-04-12 9:47 ` Mark Brown
[not found] ` <20190412094721.GE6909-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2019-04-12 10:03 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2019-04-12 10:22 ` Mark Brown
2019-04-12 10:54 ` Lukas Wunner
2019-04-12 11:09 ` Mark Brown
2019-04-12 11:16 ` Lukas Wunner [this message]
2019-04-12 11:28 ` Mark Brown
[not found] ` <20190412111615.25iogtr6qwc5zbx7-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2019-04-12 11:34 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2019-04-12 10:46 ` Lukas Wunner
2019-04-12 11:46 ` Mark Brown
2019-04-11 20:39 ` Noralf Trønnes
[not found] ` <20190411164235.49771-3-noralf-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2019-04-12 9:08 ` Mark Brown
2019-04-11 16:42 ` [PATCH v4 3/4] spi/spi-bcm2835: Remove DMA transfer size cap Noralf Trønnes
2019-04-11 16:42 ` [PATCH v4 4/4] drm/tinydrm: Remove chunk splitting in tinydrm_spi_transfer Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412111615.25iogtr6qwc5zbx7@wunner.de \
--to=lukas@wunner.de \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@martin.sperl.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=meghana.madhyastha@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.