From: Eric Auger <eric.auger@redhat.com> To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Cc: alex.williamson@redhat.com, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, yi.l.liu@intel.com, vincent.stehle@arm.com Subject: [Qemu-devel] [RFC v3 24/27] hw/arm/smmuv3: Implement fault injection Date: Fri, 12 Apr 2019 12:03:51 +0200 [thread overview] Message-ID: <20190412100354.6409-25-eric.auger@redhat.com> (raw) In-Reply-To: <20190412100354.6409-1-eric.auger@redhat.com> We convert iommu_fault structs received from the kernel into the data struct used by the emulation code and record the evnts into the virtual event queue. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- Exhaustive mapping remains to be done --- hw/arm/smmuv3.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index a7e48e7972..ddd6564001 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -1545,6 +1545,70 @@ smmuv3_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n) { } +static inline int +smmuv3_inject_faults(IOMMUMemoryRegion *iommu_mr, int count, + struct iommu_fault *buf) +{ + SMMUDevice *sdev = container_of(iommu_mr, SMMUDevice, iommu); + SMMUv3State *s3 = sdev->smmu; + uint32_t sid = smmu_get_sid(sdev); + int i; + + for (i = 0; i < count; i++) { + SMMUEventInfo info = {}; + struct iommu_fault_unrecoverable *record; + + if (buf[i].type != IOMMU_FAULT_DMA_UNRECOV) { + continue; + } + + info.sid = sid; + record = &buf[i].event; + + switch (record->reason) { + case IOMMU_FAULT_REASON_PASID_INVALID: + info.type = SMMU_EVT_C_BAD_SUBSTREAMID; + /* TODO further fill info.u.c_bad_substream */ + break; + case IOMMU_FAULT_REASON_PASID_FETCH: + info.type = SMMU_EVT_F_CD_FETCH; + break; + case IOMMU_FAULT_REASON_BAD_PASID_ENTRY: + info.type = SMMU_EVT_C_BAD_CD; + /* TODO further fill info.u.c_bad_cd */ + break; + case IOMMU_FAULT_REASON_WALK_EABT: + info.type = SMMU_EVT_F_WALK_EABT; + info.u.f_walk_eabt.addr = record->addr; + info.u.f_walk_eabt.addr2 = record->fetch_addr; + break; + case IOMMU_FAULT_REASON_PTE_FETCH: + info.type = SMMU_EVT_F_TRANSLATION; + info.u.f_translation.addr = record->addr; + break; + case IOMMU_FAULT_REASON_OOR_ADDRESS: + info.type = SMMU_EVT_F_ADDR_SIZE; + info.u.f_addr_size.addr = record->addr; + break; + case IOMMU_FAULT_REASON_ACCESS: + info.type = SMMU_EVT_F_ACCESS; + info.u.f_access.addr = record->addr; + break; + case IOMMU_FAULT_REASON_PERMISSION: + info.type = SMMU_EVT_F_PERMISSION; + info.u.f_permission.addr = record->addr; + break; + default: + warn_report("%s Unexpected fault reason received from host: %d", + __func__, record->reason); + continue; + } + + smmuv3_record_event(s3, &info); + } + return 0; +} + static void smmuv3_iommu_memory_region_class_init(ObjectClass *klass, void *data) { @@ -1554,6 +1618,7 @@ static void smmuv3_iommu_memory_region_class_init(ObjectClass *klass, imrc->notify_flag_changed = smmuv3_notify_flag_changed; imrc->get_attr = smmuv3_get_attr; imrc->replay = smmuv3_replay; + imrc->inject_faults = smmuv3_inject_faults; } static const TypeInfo smmuv3_type_info = { -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@redhat.com> To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Cc: yi.l.liu@intel.com, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, alex.williamson@redhat.com, vincent.stehle@arm.com Subject: [Qemu-devel] [RFC v3 24/27] hw/arm/smmuv3: Implement fault injection Date: Fri, 12 Apr 2019 12:03:51 +0200 [thread overview] Message-ID: <20190412100354.6409-25-eric.auger@redhat.com> (raw) Message-ID: <20190412100351.ibq0diNQ3tNIgbFIXaENketOWI9zxWR6gizgIHbO1h4@z> (raw) In-Reply-To: <20190412100354.6409-1-eric.auger@redhat.com> We convert iommu_fault structs received from the kernel into the data struct used by the emulation code and record the evnts into the virtual event queue. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- Exhaustive mapping remains to be done --- hw/arm/smmuv3.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index a7e48e7972..ddd6564001 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -1545,6 +1545,70 @@ smmuv3_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n) { } +static inline int +smmuv3_inject_faults(IOMMUMemoryRegion *iommu_mr, int count, + struct iommu_fault *buf) +{ + SMMUDevice *sdev = container_of(iommu_mr, SMMUDevice, iommu); + SMMUv3State *s3 = sdev->smmu; + uint32_t sid = smmu_get_sid(sdev); + int i; + + for (i = 0; i < count; i++) { + SMMUEventInfo info = {}; + struct iommu_fault_unrecoverable *record; + + if (buf[i].type != IOMMU_FAULT_DMA_UNRECOV) { + continue; + } + + info.sid = sid; + record = &buf[i].event; + + switch (record->reason) { + case IOMMU_FAULT_REASON_PASID_INVALID: + info.type = SMMU_EVT_C_BAD_SUBSTREAMID; + /* TODO further fill info.u.c_bad_substream */ + break; + case IOMMU_FAULT_REASON_PASID_FETCH: + info.type = SMMU_EVT_F_CD_FETCH; + break; + case IOMMU_FAULT_REASON_BAD_PASID_ENTRY: + info.type = SMMU_EVT_C_BAD_CD; + /* TODO further fill info.u.c_bad_cd */ + break; + case IOMMU_FAULT_REASON_WALK_EABT: + info.type = SMMU_EVT_F_WALK_EABT; + info.u.f_walk_eabt.addr = record->addr; + info.u.f_walk_eabt.addr2 = record->fetch_addr; + break; + case IOMMU_FAULT_REASON_PTE_FETCH: + info.type = SMMU_EVT_F_TRANSLATION; + info.u.f_translation.addr = record->addr; + break; + case IOMMU_FAULT_REASON_OOR_ADDRESS: + info.type = SMMU_EVT_F_ADDR_SIZE; + info.u.f_addr_size.addr = record->addr; + break; + case IOMMU_FAULT_REASON_ACCESS: + info.type = SMMU_EVT_F_ACCESS; + info.u.f_access.addr = record->addr; + break; + case IOMMU_FAULT_REASON_PERMISSION: + info.type = SMMU_EVT_F_PERMISSION; + info.u.f_permission.addr = record->addr; + break; + default: + warn_report("%s Unexpected fault reason received from host: %d", + __func__, record->reason); + continue; + } + + smmuv3_record_event(s3, &info); + } + return 0; +} + static void smmuv3_iommu_memory_region_class_init(ObjectClass *klass, void *data) { @@ -1554,6 +1618,7 @@ static void smmuv3_iommu_memory_region_class_init(ObjectClass *klass, imrc->notify_flag_changed = smmuv3_notify_flag_changed; imrc->get_attr = smmuv3_get_attr; imrc->replay = smmuv3_replay; + imrc->inject_faults = smmuv3_inject_faults; } static const TypeInfo smmuv3_type_info = { -- 2.20.1
next prev parent reply other threads:[~2019-04-12 10:06 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-12 10:03 [Qemu-devel] [RFC v3 00/27] vSMMUv3/pSMMUv3 2 stage VFIO integration Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 01/27] hw/arm/smmuv3: Remove SMMUNotifierNode Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 02/27] vfio/common: Introduce vfio_set_irq_signaling helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 03/27] update-linux-headers: Import iommu.h Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 04/27] header update against 5.1-rc3 and IOMMU/VFIO nested stage APIs Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 05/27] memory: add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 06/27] memory: add IOMMU_ATTR_MSI_TRANSLATE " Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 07/27] hw/arm/smmuv3: Advertise VFIO_NESTED and MSI_TRANSLATE attributes Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 08/27] hw/vfio/common: Force nested if iommu requires it Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 09/27] memory: Prepare for different kinds of IOMMU MR notifiers Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 10/27] memory: Add IOMMUConfigNotifier Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 11/27] memory: Add arch_id and leaf fields in IOTLBEntry Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 12/27] hw/arm/smmuv3: Store the PASID table GPA in the translation config Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 13/27] hw/arm/smmuv3: Implement dummy replay Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 14/27] hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 15/27] hw/arm/smmuv3: Fill the IOTLBEntry leaf field " Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 16/27] hw/arm/smmuv3: Notify on config changes Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 17/27] hw/vfio/common: Introduce vfio_alloc_guest_iommu helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 18/27] hw/vfio/common: Introduce hostwin_from_range helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 19/27] hw/vfio/common: Introduce helpers to DMA map/unap a RAM section Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 20/27] hw/vfio/common: Setup nested stage mappings Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 21/27] hw/vfio/common: Register a MAP notifier for MSI binding Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 22/27] vfio-pci: Expose MSI stage 1 bindings to the host Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 23/27] memory: Introduce IOMMU Memory Region inject_faults API Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` Eric Auger [this message] 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 24/27] hw/arm/smmuv3: Implement fault injection Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 25/27] vfio-pci: register handler for iommu fault Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 26/27] vfio-pci: Set up fault regions Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 27/27] vfio-pci: Implement the DMA fault handler Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:46 ` [Qemu-devel] [RFC v3 00/27] vSMMUv3/pSMMUv3 2 stage VFIO integration no-reply 2019-04-12 10:46 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190412100354.6409-25-eric.auger@redhat.com \ --to=eric.auger@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=jean-philippe.brucker@arm.com \ --cc=mst@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=peterx@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=vincent.stehle@arm.com \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.