From: Eric Auger <eric.auger@redhat.com> To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Cc: alex.williamson@redhat.com, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, yi.l.liu@intel.com, vincent.stehle@arm.com Subject: [Qemu-devel] [RFC v3 27/27] vfio-pci: Implement the DMA fault handler Date: Fri, 12 Apr 2019 12:03:54 +0200 [thread overview] Message-ID: <20190412100354.6409-28-eric.auger@redhat.com> (raw) In-Reply-To: <20190412100354.6409-1-eric.auger@redhat.com> Whenever the eventfd is triggered, we retrieve the DMA faults from the mmapped fault region and inject them in the iommu memory region. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- hw/vfio/pci.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++ hw/vfio/pci.h | 1 + 2 files changed, 54 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 89399a290f..fcbb92cf27 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2820,10 +2820,63 @@ static void vfio_unregister_req_notifier(VFIOPCIDevice *vdev) static void vfio_dma_fault_notifier_handler(void *opaque) { VFIOPCIDevice *vdev = opaque; + PCIDevice *pdev = &vdev->pdev; + AddressSpace *as = pci_device_iommu_address_space(pdev); + IOMMUMemoryRegion *iommu_mr = IOMMU_MEMORY_REGION(as->root); + struct vfio_region_fault_prod header; + struct iommu_fault *queue; + char *queue_buffer = NULL; + ssize_t bytes; if (!event_notifier_test_and_clear(&vdev->dma_fault_notifier)) { return; } + + if (!vdev->fault_prod_region.size || !vdev->fault_cons_region.size) { + return; + } + + bytes = pread(vdev->vbasedev.fd, &header, sizeof(header), + vdev->fault_prod_region.fd_offset); + if (bytes != sizeof(header)) { + error_report("%s unable to read the fault region header (0x%lx)", + __func__, bytes); + return; + } + + /* Normally the fault queue is mmapped */ + queue = (struct iommu_fault *)vdev->fault_prod_region.mmaps[0].mmap; + if (!queue) { + size_t queue_size = header.nb_entries * header.entry_size; + + error_report("%s: fault queue not mmapped: slower fault handling", + vdev->vbasedev.name); + + queue_buffer = g_malloc(queue_size); + bytes = pread(vdev->vbasedev.fd, queue_buffer, queue_size, + vdev->fault_prod_region.fd_offset + header.offset); + if (bytes != queue_size) { + error_report("%s unable to read the fault queue (0x%lx)", + __func__, bytes); + return; + } + + queue = (struct iommu_fault *)queue_buffer; + } + + while (vdev->fault_cons_index != header.prod) { + memory_region_inject_faults(iommu_mr, 1, + &queue[vdev->fault_cons_index]); + vdev->fault_cons_index = + (vdev->fault_cons_index + 1) % header.nb_entries; + } + bytes = pwrite(vdev->vbasedev.fd, &vdev->fault_cons_index, 4, + vdev->fault_cons_region.fd_offset + 4); + if (bytes != 4) { + error_report("%s unable to write the fault region cons index (0x%lx)", + __func__, bytes); + } + g_free(queue_buffer); } static void vfio_register_dma_fault_notifier(VFIOPCIDevice *vdev) diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 24ec43ac81..aef69c4487 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -138,6 +138,7 @@ typedef struct VFIOPCIDevice { EventNotifier dma_fault_notifier; VFIORegion fault_prod_region; VFIORegion fault_cons_region; + uint32_t fault_cons_index; int (*resetfn)(struct VFIOPCIDevice *); uint32_t vendor_id; uint32_t device_id; -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Eric Auger <eric.auger@redhat.com> To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org Cc: yi.l.liu@intel.com, mst@redhat.com, jean-philippe.brucker@arm.com, peterx@redhat.com, alex.williamson@redhat.com, vincent.stehle@arm.com Subject: [Qemu-devel] [RFC v3 27/27] vfio-pci: Implement the DMA fault handler Date: Fri, 12 Apr 2019 12:03:54 +0200 [thread overview] Message-ID: <20190412100354.6409-28-eric.auger@redhat.com> (raw) Message-ID: <20190412100354.2Qy9Tfr-y48bOaQbz86W_SEoUUxkQIkBNKGo2RboDHI@z> (raw) In-Reply-To: <20190412100354.6409-1-eric.auger@redhat.com> Whenever the eventfd is triggered, we retrieve the DMA faults from the mmapped fault region and inject them in the iommu memory region. Signed-off-by: Eric Auger <eric.auger@redhat.com> --- hw/vfio/pci.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++ hw/vfio/pci.h | 1 + 2 files changed, 54 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 89399a290f..fcbb92cf27 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2820,10 +2820,63 @@ static void vfio_unregister_req_notifier(VFIOPCIDevice *vdev) static void vfio_dma_fault_notifier_handler(void *opaque) { VFIOPCIDevice *vdev = opaque; + PCIDevice *pdev = &vdev->pdev; + AddressSpace *as = pci_device_iommu_address_space(pdev); + IOMMUMemoryRegion *iommu_mr = IOMMU_MEMORY_REGION(as->root); + struct vfio_region_fault_prod header; + struct iommu_fault *queue; + char *queue_buffer = NULL; + ssize_t bytes; if (!event_notifier_test_and_clear(&vdev->dma_fault_notifier)) { return; } + + if (!vdev->fault_prod_region.size || !vdev->fault_cons_region.size) { + return; + } + + bytes = pread(vdev->vbasedev.fd, &header, sizeof(header), + vdev->fault_prod_region.fd_offset); + if (bytes != sizeof(header)) { + error_report("%s unable to read the fault region header (0x%lx)", + __func__, bytes); + return; + } + + /* Normally the fault queue is mmapped */ + queue = (struct iommu_fault *)vdev->fault_prod_region.mmaps[0].mmap; + if (!queue) { + size_t queue_size = header.nb_entries * header.entry_size; + + error_report("%s: fault queue not mmapped: slower fault handling", + vdev->vbasedev.name); + + queue_buffer = g_malloc(queue_size); + bytes = pread(vdev->vbasedev.fd, queue_buffer, queue_size, + vdev->fault_prod_region.fd_offset + header.offset); + if (bytes != queue_size) { + error_report("%s unable to read the fault queue (0x%lx)", + __func__, bytes); + return; + } + + queue = (struct iommu_fault *)queue_buffer; + } + + while (vdev->fault_cons_index != header.prod) { + memory_region_inject_faults(iommu_mr, 1, + &queue[vdev->fault_cons_index]); + vdev->fault_cons_index = + (vdev->fault_cons_index + 1) % header.nb_entries; + } + bytes = pwrite(vdev->vbasedev.fd, &vdev->fault_cons_index, 4, + vdev->fault_cons_region.fd_offset + 4); + if (bytes != 4) { + error_report("%s unable to write the fault region cons index (0x%lx)", + __func__, bytes); + } + g_free(queue_buffer); } static void vfio_register_dma_fault_notifier(VFIOPCIDevice *vdev) diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h index 24ec43ac81..aef69c4487 100644 --- a/hw/vfio/pci.h +++ b/hw/vfio/pci.h @@ -138,6 +138,7 @@ typedef struct VFIOPCIDevice { EventNotifier dma_fault_notifier; VFIORegion fault_prod_region; VFIORegion fault_cons_region; + uint32_t fault_cons_index; int (*resetfn)(struct VFIOPCIDevice *); uint32_t vendor_id; uint32_t device_id; -- 2.20.1
next prev parent reply other threads:[~2019-04-12 10:07 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-12 10:03 [Qemu-devel] [RFC v3 00/27] vSMMUv3/pSMMUv3 2 stage VFIO integration Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 01/27] hw/arm/smmuv3: Remove SMMUNotifierNode Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 02/27] vfio/common: Introduce vfio_set_irq_signaling helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 03/27] update-linux-headers: Import iommu.h Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 04/27] header update against 5.1-rc3 and IOMMU/VFIO nested stage APIs Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 05/27] memory: add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 06/27] memory: add IOMMU_ATTR_MSI_TRANSLATE " Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 07/27] hw/arm/smmuv3: Advertise VFIO_NESTED and MSI_TRANSLATE attributes Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 08/27] hw/vfio/common: Force nested if iommu requires it Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 09/27] memory: Prepare for different kinds of IOMMU MR notifiers Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 10/27] memory: Add IOMMUConfigNotifier Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 11/27] memory: Add arch_id and leaf fields in IOTLBEntry Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 12/27] hw/arm/smmuv3: Store the PASID table GPA in the translation config Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 13/27] hw/arm/smmuv3: Implement dummy replay Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 14/27] hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 15/27] hw/arm/smmuv3: Fill the IOTLBEntry leaf field " Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 16/27] hw/arm/smmuv3: Notify on config changes Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 17/27] hw/vfio/common: Introduce vfio_alloc_guest_iommu helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 18/27] hw/vfio/common: Introduce hostwin_from_range helper Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 19/27] hw/vfio/common: Introduce helpers to DMA map/unap a RAM section Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 20/27] hw/vfio/common: Setup nested stage mappings Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 21/27] hw/vfio/common: Register a MAP notifier for MSI binding Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 22/27] vfio-pci: Expose MSI stage 1 bindings to the host Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 23/27] memory: Introduce IOMMU Memory Region inject_faults API Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 24/27] hw/arm/smmuv3: Implement fault injection Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 25/27] vfio-pci: register handler for iommu fault Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 26/27] vfio-pci: Set up fault regions Eric Auger 2019-04-12 10:03 ` Eric Auger 2019-04-12 10:03 ` Eric Auger [this message] 2019-04-12 10:03 ` [Qemu-devel] [RFC v3 27/27] vfio-pci: Implement the DMA fault handler Eric Auger 2019-04-12 10:46 ` [Qemu-devel] [RFC v3 00/27] vSMMUv3/pSMMUv3 2 stage VFIO integration no-reply 2019-04-12 10:46 ` no-reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190412100354.6409-28-eric.auger@redhat.com \ --to=eric.auger@redhat.com \ --cc=alex.williamson@redhat.com \ --cc=eric.auger.pro@gmail.com \ --cc=jean-philippe.brucker@arm.com \ --cc=mst@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=peterx@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=vincent.stehle@arm.com \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.