All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	"Denis V . Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage
Date: Sat, 13 Apr 2019 18:53:43 +0200	[thread overview]
Message-ID: <20190413165343.9018-8-mreitz@redhat.com> (raw)
In-Reply-To: <20190413165343.9018-1-mreitz@redhat.com>

We do not support this combination (yet), so this should yield an error
message.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/082     | 1 +
 tests/qemu-iotests/082.out | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082
index d0afa46e9a..c58b37127f 100755
--- a/tests/qemu-iotests/082
+++ b/tests/qemu-iotests/082
@@ -163,6 +163,7 @@ echo === convert: -C and other options ===
 run_qemu_img convert -C -S 4k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -S 8k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -c -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
+run_qemu_img convert -C --salvage -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 
 echo
 echo === amend: Options specified more than once ===
diff --git a/tests/qemu-iotests/082.out b/tests/qemu-iotests/082.out
index d36938da9b..9d4f7574c9 100644
--- a/tests/qemu-iotests/082.out
+++ b/tests/qemu-iotests/082.out
@@ -555,6 +555,9 @@ qemu-img: Cannot enable copy offloading when -S is used
 Testing: convert -C -c -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
 qemu-img: Cannot enable copy offloading when -c is used
 
+Testing: convert -C --salvage -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
+qemu-img: Cannot use copy offloading in salvaging mode
+
 === amend: Options specified more than once ===
 
 Testing: amend -f foo -f qcow2 -o lazy_refcounts=on TEST_DIR/t.qcow2
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	"Denis V . Lunev" <den@openvz.org>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage
Date: Sat, 13 Apr 2019 18:53:43 +0200	[thread overview]
Message-ID: <20190413165343.9018-8-mreitz@redhat.com> (raw)
Message-ID: <20190413165343.X9yAW972Mq32lms61eQp172E1qOyyqfnnyGxgOh2_pY@z> (raw)
In-Reply-To: <20190413165343.9018-1-mreitz@redhat.com>

We do not support this combination (yet), so this should yield an error
message.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/082     | 1 +
 tests/qemu-iotests/082.out | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/tests/qemu-iotests/082 b/tests/qemu-iotests/082
index d0afa46e9a..c58b37127f 100755
--- a/tests/qemu-iotests/082
+++ b/tests/qemu-iotests/082
@@ -163,6 +163,7 @@ echo === convert: -C and other options ===
 run_qemu_img convert -C -S 4k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -S 8k -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 run_qemu_img convert -C -c -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
+run_qemu_img convert -C --salvage -O $IMGFMT "$TEST_IMG" "$TEST_IMG".target
 
 echo
 echo === amend: Options specified more than once ===
diff --git a/tests/qemu-iotests/082.out b/tests/qemu-iotests/082.out
index d36938da9b..9d4f7574c9 100644
--- a/tests/qemu-iotests/082.out
+++ b/tests/qemu-iotests/082.out
@@ -555,6 +555,9 @@ qemu-img: Cannot enable copy offloading when -S is used
 Testing: convert -C -c -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
 qemu-img: Cannot enable copy offloading when -c is used
 
+Testing: convert -C --salvage -O qcow2 TEST_DIR/t.qcow2 TEST_DIR/t.qcow2.target
+qemu-img: Cannot use copy offloading in salvaging mode
+
 === amend: Options specified more than once ===
 
 Testing: amend -f foo -f qcow2 -o lazy_refcounts=on TEST_DIR/t.qcow2
-- 
2.20.1



  parent reply	other threads:[~2019-04-13 16:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13 16:53 [Qemu-devel] [PATCH v3 0/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-04-13 16:53 ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 1/7] qemu-img: Move quiet into ImgConvertState Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 2/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  6:40   ` Vladimir Sementsov-Ogievskiy
2019-04-16  6:40     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 3/7] blkdebug: Add @iotype error option Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:18   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:18     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:36     ` Max Reitz
2019-04-17 16:36       ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 4/7] blkdebug: Add "none" event Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:21   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:21     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 5/7] blkdebug: Inject errors on .bdrv_co_block_status() Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:23   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:23     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 6/7] iotests: Test qemu-img convert --salvage Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  8:02   ` Vladimir Sementsov-Ogievskiy
2019-04-16  8:02     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:42     ` Max Reitz
2019-04-17 16:42       ` Max Reitz
2019-04-24 15:21   ` Thomas Huth
2019-04-24 15:21     ` Thomas Huth
2019-04-13 16:53 ` Max Reitz [this message]
2019-04-13 16:53   ` [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage Max Reitz
2019-04-16  8:13   ` Vladimir Sementsov-Ogievskiy
2019-04-16  8:13     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:43     ` Max Reitz
2019-04-17 16:43       ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190413165343.9018-8-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.