All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Denis Lunev <den@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage
Date: Wed, 17 Apr 2019 18:43:51 +0200	[thread overview]
Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> (raw)
In-Reply-To: <c923c1c0-e866-9bbc-f351-1c5d861d830d@virtuozzo.com>

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

On 16.04.19 10:13, Vladimir Sementsov-Ogievskiy wrote:
> 13.04.2019 19:53, Max Reitz wrote:
>> We do not support this combination (yet), so this should yield an error
>> message.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> 
> Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>             [only -qcow2, as -nfs -qcow2 is already broken]
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> 
> Hmm, interesting, that this test is defined as
> _supported_fmt qcow2
> _supported_proto file nfs
> 
> And of course, it doesn't work for -qcow2 -nfs combination..

Of course, nobody ever tests nfs. :-)

Thanks for reviewing!

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Denis Lunev <den@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage
Date: Wed, 17 Apr 2019 18:43:51 +0200	[thread overview]
Message-ID: <7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com> (raw)
Message-ID: <20190417164351.qDrxb-S_z8042BCnY3bsQJ6_433I9uVIWRjULwItKuY@z> (raw)
In-Reply-To: <c923c1c0-e866-9bbc-f351-1c5d861d830d@virtuozzo.com>

[-- Attachment #1: Type: text/plain, Size: 695 bytes --]

On 16.04.19 10:13, Vladimir Sementsov-Ogievskiy wrote:
> 13.04.2019 19:53, Max Reitz wrote:
>> We do not support this combination (yet), so this should yield an error
>> message.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
> 
> Tested-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>             [only -qcow2, as -nfs -qcow2 is already broken]
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> 
> Hmm, interesting, that this test is defined as
> _supported_fmt qcow2
> _supported_proto file nfs
> 
> And of course, it doesn't work for -qcow2 -nfs combination..

Of course, nobody ever tests nfs. :-)

Thanks for reviewing!

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-04-17 16:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13 16:53 [Qemu-devel] [PATCH v3 0/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-04-13 16:53 ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 1/7] qemu-img: Move quiet into ImgConvertState Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 2/7] qemu-img: Add salvaging mode to convert Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  6:40   ` Vladimir Sementsov-Ogievskiy
2019-04-16  6:40     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 3/7] blkdebug: Add @iotype error option Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:18   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:18     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:36     ` Max Reitz
2019-04-17 16:36       ` Max Reitz
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 4/7] blkdebug: Add "none" event Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:21   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:21     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 5/7] blkdebug: Inject errors on .bdrv_co_block_status() Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  7:23   ` Vladimir Sementsov-Ogievskiy
2019-04-16  7:23     ` Vladimir Sementsov-Ogievskiy
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 6/7] iotests: Test qemu-img convert --salvage Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  8:02   ` Vladimir Sementsov-Ogievskiy
2019-04-16  8:02     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:42     ` Max Reitz
2019-04-17 16:42       ` Max Reitz
2019-04-24 15:21   ` Thomas Huth
2019-04-24 15:21     ` Thomas Huth
2019-04-13 16:53 ` [Qemu-devel] [PATCH v3 7/7] iotests: Test qemu-img convert -C --salvage Max Reitz
2019-04-13 16:53   ` Max Reitz
2019-04-16  8:13   ` Vladimir Sementsov-Ogievskiy
2019-04-16  8:13     ` Vladimir Sementsov-Ogievskiy
2019-04-17 16:43     ` Max Reitz [this message]
2019-04-17 16:43       ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a624f61-a20c-1839-4493-f1ca62664d71@redhat.com \
    --to=mreitz@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.