* [PATCH net-next] r8169: change irq handler to always trigger NAPI polling
@ 2019-04-14 9:48 Heiner Kallweit
2019-04-14 20:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-04-14 9:48 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev
This check isn't really needed and we can simplify the code and save
some CPU cycles by removing it. Only in case of an error none of these
bits are set, and calling the NAPI callback doesn't hurt in this case.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 68caa26f0..efaea1a0a 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -6380,10 +6380,8 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance)
set_bit(RTL_FLAG_TASK_RESET_PENDING, tp->wk.flags);
}
- if (status & (RTL_EVENT_NAPI | LinkChg)) {
- rtl_irq_disable(tp);
- napi_schedule_irqoff(&tp->napi);
- }
+ rtl_irq_disable(tp);
+ napi_schedule_irqoff(&tp->napi);
out:
rtl_ack_events(tp, status);
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] r8169: change irq handler to always trigger NAPI polling
2019-04-14 9:48 [PATCH net-next] r8169: change irq handler to always trigger NAPI polling Heiner Kallweit
@ 2019-04-14 20:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-04-14 20:58 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 14 Apr 2019 11:48:39 +0200
> This check isn't really needed and we can simplify the code and save
> some CPU cycles by removing it. Only in case of an error none of these
> bits are set, and calling the NAPI callback doesn't hurt in this case.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-14 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 9:48 [PATCH net-next] r8169: change irq handler to always trigger NAPI polling Heiner Kallweit
2019-04-14 20:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.