* [PATCH] generic/294: skip on NFS
@ 2019-03-04 2:50 Murphy Zhou
2019-04-08 2:27 ` Murphy Zhou
2019-04-15 4:03 ` Eryu Guan
0 siblings, 2 replies; 5+ messages in thread
From: Murphy Zhou @ 2019-03-04 2:50 UTC (permalink / raw)
To: fstests; +Cc: bcodding, yieli, bxue, Murphy Zhou
Because NFS handles this differently, returning different values.
Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
tests/generic/294 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/294 b/tests/generic/294
index b74579ac..f7e763a3 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -27,6 +27,7 @@ _cleanup()
. ./common/filter
# real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
# Modify as appropriate.
_supported_fs generic
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] generic/294: skip on NFS
2019-03-04 2:50 [PATCH] generic/294: skip on NFS Murphy Zhou
@ 2019-04-08 2:27 ` Murphy Zhou
2019-04-15 4:03 ` Eryu Guan
1 sibling, 0 replies; 5+ messages in thread
From: Murphy Zhou @ 2019-04-08 2:27 UTC (permalink / raw)
To: fstests, bcodding
On Mon, Mar 04, 2019 at 10:50:08AM +0800, Murphy Zhou wrote:
> Because NFS handles this differently, returning different values.
> Details:
> http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
Any comments are helpful, :)
Thanks
M
>
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>
> ---
> tests/generic/294 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/294 b/tests/generic/294
> index b74579ac..f7e763a3 100755
> --- a/tests/generic/294
> +++ b/tests/generic/294
> @@ -27,6 +27,7 @@ _cleanup()
> . ./common/filter
>
> # real QA test starts here
> +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
>
> # Modify as appropriate.
> _supported_fs generic
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] generic/294: skip on NFS
2019-03-04 2:50 [PATCH] generic/294: skip on NFS Murphy Zhou
2019-04-08 2:27 ` Murphy Zhou
@ 2019-04-15 4:03 ` Eryu Guan
2019-04-16 8:11 ` Murphy Zhou
2019-04-16 8:14 ` [PATCH v2] generic/294: add golden output for nfs Murphy Zhou
1 sibling, 2 replies; 5+ messages in thread
From: Eryu Guan @ 2019-04-15 4:03 UTC (permalink / raw)
To: Murphy Zhou; +Cc: fstests, bcodding, yieli, bxue
On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> Because NFS handles this differently, returning different values.
> Details:
> http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
>
> Signed-off-by: Murphy Zhou <xzhou@redhat.com>
Sorry for the so long delay..
> ---
> tests/generic/294 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/294 b/tests/generic/294
> index b74579ac..f7e763a3 100755
> --- a/tests/generic/294
> +++ b/tests/generic/294
> @@ -27,6 +27,7 @@ _cleanup()
> . ./common/filter
>
> # real QA test starts here
> +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
I think it's better to filter the output of NFS to follow the golden
output, so when NFS changes behavior, filter fails and we could know
that from test failure.
Thanks,
Eryu
>
> # Modify as appropriate.
> _supported_fs generic
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] generic/294: skip on NFS
2019-04-15 4:03 ` Eryu Guan
@ 2019-04-16 8:11 ` Murphy Zhou
2019-04-16 8:14 ` [PATCH v2] generic/294: add golden output for nfs Murphy Zhou
1 sibling, 0 replies; 5+ messages in thread
From: Murphy Zhou @ 2019-04-16 8:11 UTC (permalink / raw)
To: Eryu Guan; +Cc: Murphy Zhou, fstests
On Mon, Apr 15, 2019 at 12:03:09PM +0800, Eryu Guan wrote:
> On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote:
> > Because NFS handles this differently, returning different values.
> > Details:
> > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
> >
> > Signed-off-by: Murphy Zhou <xzhou@redhat.com>
>
> Sorry for the so long delay..
Not at all, :)
Sending v2.
Thanks,
Xiong
> > ---
> > tests/generic/294 | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/generic/294 b/tests/generic/294
> > index b74579ac..f7e763a3 100755
> > --- a/tests/generic/294
> > +++ b/tests/generic/294
> > @@ -27,6 +27,7 @@ _cleanup()
> > . ./common/filter
> >
> > # real QA test starts here
> > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
>
> I think it's better to filter the output of NFS to follow the golden
> output, so when NFS changes behavior, filter fails and we could know
> that from test failure.
>
> Thanks,
> Eryu
>
> >
> > # Modify as appropriate.
> > _supported_fs generic
> > --
> > 2.21.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] generic/294: add golden output for nfs
2019-04-15 4:03 ` Eryu Guan
2019-04-16 8:11 ` Murphy Zhou
@ 2019-04-16 8:14 ` Murphy Zhou
1 sibling, 0 replies; 5+ messages in thread
From: Murphy Zhou @ 2019-04-16 8:14 UTC (permalink / raw)
To: guaneryu, fstests; +Cc: bcodding, Murphy Zhou
Because NFS handles this differently, returning different values.
Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
v2:
add a new golden output for nfs instead of _notrun.
tests/generic/294 | 7 +++++++
tests/generic/294.out.nfs | 5 +++++
2 files changed, 12 insertions(+)
create mode 100644 tests/generic/294.out.nfs
diff --git a/tests/generic/294 b/tests/generic/294
index b74579ac..a355c612 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -7,6 +7,7 @@
# Tests for EEXIST (not EROFS) for inode creations, if
# we ask to create an already-existing entity on an RO filesystem
#
+seqfull=$0
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
@@ -27,6 +28,12 @@ _cleanup()
. ./common/filter
# real QA test starts here
+# link correct .out file
+if [ $FSTYP == "nfs" ]; then
+ rm -f $seqfull.out
+ ln -sf $seq.out.nfs $seqfull.out
+fi
+
# Modify as appropriate.
_supported_fs generic
diff --git a/tests/generic/294.out.nfs b/tests/generic/294.out.nfs
new file mode 100644
index 00000000..71ebeecd
--- /dev/null
+++ b/tests/generic/294.out.nfs
@@ -0,0 +1,5 @@
+QA output created by 294
+mknod: 'SCRATCH_MNT/294.test/testnode': Read-only file system
+mkdir: cannot create directory 'SCRATCH_MNT/294.test/testdir': Read-only file system
+touch: cannot touch 'SCRATCH_MNT/294.test/testtarget': Read-only file system
+ln: creating symbolic link 'SCRATCH_MNT/294.test/testlink': File exists
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-16 8:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 2:50 [PATCH] generic/294: skip on NFS Murphy Zhou
2019-04-08 2:27 ` Murphy Zhou
2019-04-15 4:03 ` Eryu Guan
2019-04-16 8:11 ` Murphy Zhou
2019-04-16 8:14 ` [PATCH v2] generic/294: add golden output for nfs Murphy Zhou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.