* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 7:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
@ 2019-04-25 7:36 ` Daniel Vetter
2019-04-25 10:05 ` Jani Nikula
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2019-04-25 7:36 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> >
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > .gitlab-ci.yml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > - ninja -C build
> > - ninja -C build igt-gpu-tools-doc
> >
> > +build:tests-fedora-clang:
> > + stage: build
> > + script:
> > + - dnf install -y clang
> > + - export CC=clang
> > + - meson $MESON_OPTIONS build
> > + - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
> -Daniel
>
> > +
> > build:tests-debian-meson:
> > image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> > stage: build
> > --
> > 2.21.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 7:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-04-25 7:36 ` Daniel Vetter
@ 2019-04-25 10:05 ` Jani Nikula
2019-04-25 13:49 ` Daniel Vetter
2019-04-25 11:22 ` Ser, Simon
2019-04-25 11:45 ` Petri Latvala
3 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2019-04-25 10:05 UTC (permalink / raw)
To: Daniel Vetter, Simon Ser; +Cc: igt-dev
On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
>> This adds a build step with Clang on Fedora. Hopefully this can help keeping
>> Clang builds healthy.
>>
>> Signed-off-by: Simon Ser <simon.ser@intel.com>
>> ---
>> .gitlab-ci.yml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index ae8cbb67..e7d31376 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
>> - ninja -C build
>> - ninja -C build igt-gpu-tools-doc
>>
>> +build:tests-fedora-clang:
>> + stage: build
>> + script:
>> + - dnf install -y clang
>> + - export CC=clang
>> + - meson $MESON_OPTIONS build
>> + - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
And why shouldn't we care about clang?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 10:05 ` Jani Nikula
@ 2019-04-25 13:49 ` Daniel Vetter
2019-04-25 13:54 ` Ser, Simon
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Daniel Vetter @ 2019-04-25 13:49 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev, Daniel Vetter
On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> >> Clang builds healthy.
> >>
> >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> >> ---
> >> .gitlab-ci.yml | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index ae8cbb67..e7d31376 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >> - ninja -C build
> >> - ninja -C build igt-gpu-tools-doc
> >>
> >> +build:tests-fedora-clang:
> >> + stage: build
> >> + script:
> >> + - dnf install -y clang
> >> + - export CC=clang
> >> + - meson $MESON_OPTIONS build
> >> + - ninja -C build
> >
> > Uh why?
> >
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
>
> And why shouldn't we care about clang?
What I meant is: We already have gitlab ci targets that caught the recent
clang regression (because a lot more broke). No one gave a shit from what
I can tell, so I guess I'm questioning the value of more gitlab CI targets
in general. We could fix that by going to merge requests and blocking
pulls that fail to build I guess.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 13:49 ` Daniel Vetter
@ 2019-04-25 13:54 ` Ser, Simon
2019-04-25 14:08 ` Arkadiusz Hiler
2019-04-25 14:00 ` Arkadiusz Hiler
2019-04-25 14:56 ` Ville Syrjälä
2 siblings, 1 reply; 17+ messages in thread
From: Ser, Simon @ 2019-04-25 13:54 UTC (permalink / raw)
To: daniel, jani.nikula; +Cc: igt-dev
On Thu, 2019-04-25 at 15:49 +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > > Clang builds healthy.
> > > >
> > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > > ---
> > > > .gitlab-ci.yml | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > > index ae8cbb67..e7d31376 100644
> > > > --- a/.gitlab-ci.yml
> > > > +++ b/.gitlab-ci.yml
> > > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > > - ninja -C build
> > > > - ninja -C build igt-gpu-tools-doc
> > > >
> > > > +build:tests-fedora-clang:
> > > > + stage: build
> > > > + script:
> > > > + - dnf install -y clang
> > > > + - export CC=clang
> > > > + - meson $MESON_OPTIONS build
> > > > + - ninja -C build
> > >
> > > Uh why?
> > >
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> >
> > And why shouldn't we care about clang?
>
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general. We could fix that by going to merge requests and blocking
> pulls that fail to build I guess.
> -Daniel
I guess no one gave a shit because it was still a little bit early in
the morning. By the time people noticed the Clang patch was already
submitted. All I want to say is: Petri (and probably other maintainers
too) does monitor CI build status.
I strongly agree with you: pre-merge checks would be a lot better.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 13:54 ` Ser, Simon
@ 2019-04-25 14:08 ` Arkadiusz Hiler
0 siblings, 0 replies; 17+ messages in thread
From: Arkadiusz Hiler @ 2019-04-25 14:08 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev, daniel
On Thu, Apr 25, 2019 at 01:54:45PM +0000, Ser, Simon wrote:
> On Thu, 2019-04-25 at 15:49 +0200, Daniel Vetter wrote:
> > On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > > > Clang builds healthy.
> > > > >
> > > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > > > ---
> > > > > .gitlab-ci.yml | 8 ++++++++
> > > > > 1 file changed, 8 insertions(+)
> > > > >
> > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > > > index ae8cbb67..e7d31376 100644
> > > > > --- a/.gitlab-ci.yml
> > > > > +++ b/.gitlab-ci.yml
> > > > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > > > - ninja -C build
> > > > > - ninja -C build igt-gpu-tools-doc
> > > > >
> > > > > +build:tests-fedora-clang:
> > > > > + stage: build
> > > > > + script:
> > > > > + - dnf install -y clang
> > > > > + - export CC=clang
> > > > > + - meson $MESON_OPTIONS build
> > > > > + - ninja -C build
> > > >
> > > > Uh why?
> > > >
> > > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > > not), and I don't think we should care about clang either.
> > >
> > > And why shouldn't we care about clang?
> >
> > What I meant is: We already have gitlab ci targets that caught the recent
> > clang regression (because a lot more broke). No one gave a shit from what
> > I can tell, so I guess I'm questioning the value of more gitlab CI targets
> > in general. We could fix that by going to merge requests and blocking
> > pulls that fail to build I guess.
> > -Daniel
>
> I guess no one gave a shit because it was still a little bit early in
> the morning. By the time people noticed the Clang patch was already
> submitted. All I want to say is: Petri (and probably other maintainers
> too) does monitor CI build status.
>
> I strongly agree with you: pre-merge checks would be a lot better.
We will get there one day :-)
gitlab-ci was the easiest way to give people some control on build
testing.
There is an idea to create gfx-ci/igt-tags repo, where each pre-merge
tree would be pushed. That would give us results from the
gitlab-ci. With some plumbing we could push those to patchwork.
I have to ask daniels first whether our omnibus gitlab is able to handle
that though.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 13:49 ` Daniel Vetter
2019-04-25 13:54 ` Ser, Simon
@ 2019-04-25 14:00 ` Arkadiusz Hiler
2019-04-25 14:56 ` Ville Syrjälä
2 siblings, 0 replies; 17+ messages in thread
From: Arkadiusz Hiler @ 2019-04-25 14:00 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > >> Clang builds healthy.
> > >>
> > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > >> ---
> > >> .gitlab-ci.yml | 8 ++++++++
> > >> 1 file changed, 8 insertions(+)
> > >>
> > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > >> index ae8cbb67..e7d31376 100644
> > >> --- a/.gitlab-ci.yml
> > >> +++ b/.gitlab-ci.yml
> > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > >> - ninja -C build
> > >> - ninja -C build igt-gpu-tools-doc
> > >>
> > >> +build:tests-fedora-clang:
> > >> + stage: build
> > >> + script:
> > >> + - dnf install -y clang
> > >> + - export CC=clang
> > >> + - meson $MESON_OPTIONS build
> > >> + - ninja -C build
> > >
> > > Uh why?
> > >
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> >
> > And why shouldn't we care about clang?
>
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general. We could fix that by going to merge requests and blocking
> pulls that fail to build I guess.
The value is that we do see breakages. We get emails and we can fix this
up post-factum.
Even today, thanks to gilab-ci we fixed breakage in autotools just
moments after it happened.
Most of the checks in the gitlab-ci are not our main way of operation
(meson + x86 + gcc), but they still allow us to be better citizens of
the community. People use various arch and compilers, and as long as
they care and express that interest by sending patches I am okay with
it.
Even if we catch that something broke few days after it happened we have
just one thing to fix, instead of someone coming months down the line
and having to fix what would be a completelty broken tree on their
setup.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 13:49 ` Daniel Vetter
2019-04-25 13:54 ` Ser, Simon
2019-04-25 14:00 ` Arkadiusz Hiler
@ 2019-04-25 14:56 ` Ville Syrjälä
2019-04-30 11:11 ` Arkadiusz Hiler
2 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjälä @ 2019-04-25 14:56 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > >> Clang builds healthy.
> > >>
> > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > >> ---
> > >> .gitlab-ci.yml | 8 ++++++++
> > >> 1 file changed, 8 insertions(+)
> > >>
> > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > >> index ae8cbb67..e7d31376 100644
> > >> --- a/.gitlab-ci.yml
> > >> +++ b/.gitlab-ci.yml
> > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > >> - ninja -C build
> > >> - ninja -C build igt-gpu-tools-doc
> > >>
> > >> +build:tests-fedora-clang:
> > >> + stage: build
> > >> + script:
> > >> + - dnf install -y clang
> > >> + - export CC=clang
> > >> + - meson $MESON_OPTIONS build
> > >> + - ninja -C build
> > >
> > > Uh why?
> > >
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> >
> > And why shouldn't we care about clang?
>
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general.
Has the gitlab ci stuff been fixed so it doesn't fail 100% of time
anyway? At least I've already been fully conditioned to ignore all
gitlab errors because of that.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 14:56 ` Ville Syrjälä
@ 2019-04-30 11:11 ` Arkadiusz Hiler
0 siblings, 0 replies; 17+ messages in thread
From: Arkadiusz Hiler @ 2019-04-30 11:11 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, Daniel Vetter
On Thu, Apr 25, 2019 at 05:56:30PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> > On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > >> Clang builds healthy.
> > > >>
> > > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > >> ---
> > > >> .gitlab-ci.yml | 8 ++++++++
> > > >> 1 file changed, 8 insertions(+)
> > > >>
> > > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > >> index ae8cbb67..e7d31376 100644
> > > >> --- a/.gitlab-ci.yml
> > > >> +++ b/.gitlab-ci.yml
> > > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > >> - ninja -C build
> > > >> - ninja -C build igt-gpu-tools-doc
> > > >>
> > > >> +build:tests-fedora-clang:
> > > >> + stage: build
> > > >> + script:
> > > >> + - dnf install -y clang
> > > >> + - export CC=clang
> > > >> + - meson $MESON_OPTIONS build
> > > >> + - ninja -C build
> > > >
> > > > Uh why?
> > > >
> > > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > > not), and I don't think we should care about clang either.
> > >
> > > And why shouldn't we care about clang?
> >
> > What I meant is: We already have gitlab ci targets that caught the recent
> > clang regression (because a lot more broke). No one gave a shit from what
> > I can tell, so I guess I'm questioning the value of more gitlab CI targets
> > in general.
>
> Has the gitlab ci stuff been fixed so it doesn't fail 100% of time
> anyway? At least I've already been fully conditioned to ignore all
> gitlab errors because of that.
Sadly the publishing on the FDO (which we use to push IGT docs) seems to
be still failing quite reliably.
I think we can abandon all hopes for it being fixed in the near future,
and change the step to be manual, so at least we stop polluting people's
inboxes.
--
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 7:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2019-04-25 7:36 ` Daniel Vetter
2019-04-25 10:05 ` Jani Nikula
@ 2019-04-25 11:22 ` Ser, Simon
2019-04-25 11:45 ` Petri Latvala
3 siblings, 0 replies; 17+ messages in thread
From: Ser, Simon @ 2019-04-25 11:22 UTC (permalink / raw)
To: daniel; +Cc: igt-dev
On Thu, 2019-04-25 at 09:35 +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> >
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > .gitlab-ci.yml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > - ninja -C build
> > - ninja -C build igt-gpu-tools-doc
> >
> > +build:tests-fedora-clang:
> > + stage: build
> > + script:
> > + - dnf install -y clang
> > + - export CC=clang
> > + - meson $MESON_OPTIONS build
> > + - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
> -Daniel
Well I didn't know it was broken on non-x86 hosts. I submitted the
patch because I use Clang and it broke on my machine.
I do think there is value in supporting Clang, just not to be trapped
forever with GCC. It's not like it's a huge hassle either since Clang
implements the huge pile of GNU extensions GCC has (sadly).
> > +
> > build:tests-debian-meson:
> > image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> > stage: build
> > --
> > 2.21.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 7:35 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
` (2 preceding siblings ...)
2019-04-25 11:22 ` Ser, Simon
@ 2019-04-25 11:45 ` Petri Latvala
2019-04-25 13:46 ` Daniel Vetter
3 siblings, 1 reply; 17+ messages in thread
From: Petri Latvala @ 2019-04-25 11:45 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> >
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > .gitlab-ci.yml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > - ninja -C build
> > - ninja -C build igt-gpu-tools-doc
> >
> > +build:tests-fedora-clang:
> > + stage: build
> > + script:
> > + - dnf install -y clang
> > + - export CC=clang
> > + - meson $MESON_OPTIONS build
> > + - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
Consider this patch as a separate thing instead of getting stuck on
the recent build failure.
The current state is that clang builds IGT fine. The discussion would
be different if it didn't. I use clang myself occasionally, although
indirectly, through clang-analyze. It works, there's non-zero value in
keeping it working, and as just a build-test for clang this doesn't
eat that much gitlab-ci-time.
This is
Acked-by: Petri Latvala <petri.latvala@intel.com>
but I'll leave actual doublechecking of the CI change correctness to
someone else (Arek?)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [igt-dev] [PATCH i-g-t] ci: build with Clang
2019-04-25 11:45 ` Petri Latvala
@ 2019-04-25 13:46 ` Daniel Vetter
0 siblings, 0 replies; 17+ messages in thread
From: Daniel Vetter @ 2019-04-25 13:46 UTC (permalink / raw)
To: Daniel Vetter, Simon Ser, igt-dev
On Thu, Apr 25, 2019 at 02:45:12PM +0300, Petri Latvala wrote:
> On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > Clang builds healthy.
> > >
> > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > ---
> > > .gitlab-ci.yml | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index ae8cbb67..e7d31376 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > - ninja -C build
> > > - ninja -C build igt-gpu-tools-doc
> > >
> > > +build:tests-fedora-clang:
> > > + stage: build
> > > + script:
> > > + - dnf install -y clang
> > > + - export CC=clang
> > > + - meson $MESON_OPTIONS build
> > > + - ninja -C build
> >
> > Uh why?
> >
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
>
>
> Consider this patch as a separate thing instead of getting stuck on
> the recent build failure.
>
> The current state is that clang builds IGT fine. The discussion would
> be different if it didn't. I use clang myself occasionally, although
> indirectly, through clang-analyze. It works, there's non-zero value in
> keeping it working, and as just a build-test for clang this doesn't
> eat that much gitlab-ci-time.
>
>
> This is
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> but I'll leave actual doublechecking of the CI change correctness to
> someone else (Arek?)
I'd say if we want to support clang (personally I really dont care, and
clang isn't going to work with the kernel anytime soon so it's not we can
ditch gcc), then the gitlab CI should also run the tests. That's the same
standard as we have for the non-x86 builds (yes we run them through qemu
machine emulation to get arm/arm64 going on our x86 builders).
With that I can also slap my Acked-by: Daniel Vetter
<daniel.vetter@ffwll.ch> onto the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread