[igt-dev] [PATCH i-g-t] ci: build with Clang

[igt-dev] [PATCH i-g-t] ci: build with Clang

[Simon Ser]

This adds a build step with Clang on Fedora. Hopefully this can help keeping
Clang builds healthy.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 .gitlab-ci.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ae8cbb67..e7d31376 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
     - ninja -C build
     - ninja -C build igt-gpu-tools-doc
 
+build:tests-fedora-clang:
+  stage: build
+  script:
+    - dnf install -y clang
+    - export CC=clang
+    - meson $MESON_OPTIONS build
+    - ninja -C build
+
 build:tests-debian-meson:
   image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
   stage: build
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for ci: build with Clang

[Patchwork]

== Series Details ==

Series: ci: build with Clang
URL   : https://patchwork.freedesktop.org/series/59896/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5990 -> IGTPW_2914
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59896/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2914 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       [PASS][1] -> [DMESG-WARN][2] ([fdo#108965])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html

  * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
    - fi-byt-clapper:     [PASS][3] -> [FAIL][4] ([fdo#103191])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/fi-byt-clapper/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/fi-byt-clapper/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html

  
#### Possible fixes ####

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     [FAIL][5] ([fdo#103167]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/fi-byt-clapper/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/fi-byt-clapper/igt@kms_frontbuffer_tracking@basic.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965


Participating hosts (40 -> 40)
------------------------------

  Additional (6): fi-icl-u2 fi-cfl-8700k fi-pnv-d510 fi-bsw-kefka fi-blb-e6850 fi-byt-n2820 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4963 -> IGTPW_2914

  CI_DRM_5990: 59b3d13393721597be4c56e587e079c3acb57d5a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2914: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/
  IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for ci: build with Clang

[Patchwork]

== Series Details ==

Series: ci: build with Clang
URL   : https://patchwork.freedesktop.org/series/59896/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5990_full -> IGTPW_2914_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59896/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2914_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_suspend@debugfs-reader:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +5 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-apl8/igt@i915_suspend@debugfs-reader.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-apl3/igt@i915_suspend@debugfs-reader.html

  * igt@kms_cursor_legacy@cursor-vs-flip-legacy:
    - shard-hsw:          [PASS][3] -> [FAIL][4] ([fdo#103355])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-hsw2/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          [PASS][5] -> [FAIL][6] ([fdo#105363])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][7] -> [FAIL][8] ([fdo#103167]) +8 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
    - shard-glk:          [PASS][9] -> [SKIP][10] ([fdo#109271] / [fdo#109278])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-glk8/igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][11] -> [SKIP][12] ([fdo#109441]) +3 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb8/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_setmode@basic:
    - shard-iclb:         [PASS][13] -> [FAIL][14] ([fdo#99912])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb5/igt@kms_setmode@basic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb5/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [DMESG-WARN][15] ([fdo#108566]) -> [PASS][16] +4 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-apl1/igt@gem_workarounds@suspend-resume.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-apl5/igt@gem_workarounds@suspend-resume.html

  * igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing:
    - shard-iclb:         [INCOMPLETE][17] ([fdo#107713]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb1/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb5/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [FAIL][19] ([fdo#103167]) -> [PASS][20] +10 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
    - shard-hsw:          [SKIP][21] ([fdo#109271]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-hsw8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [INCOMPLETE][23] ([fdo#103665]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
    - shard-glk:          [SKIP][25] ([fdo#109271]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-glk8/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-glk9/igt@kms_plane@pixel-format-pipe-a-planes-source-clamping.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][27] ([fdo#103166]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
    - shard-glk:          [SKIP][29] ([fdo#109271] / [fdo#109278]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-glk7/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][31] ([fdo#109441]) -> [PASS][32] +4 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          [FAIL][33] ([fdo#109016]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-kbl2/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-kbl4/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [FAIL][35] ([fdo#100047]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5990/shard-iclb2/igt@kms_sysfs_edid_timing.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/shard-iclb6/igt@kms_sysfs_edid_timing.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 6)
------------------------------

  Missing    (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 


Build changes
-------------

  * IGT: IGT_4963 -> IGTPW_2914
  * Piglit: piglit_4509 -> None

  CI_DRM_5990: 59b3d13393721597be4c56e587e079c3acb57d5a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2914: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/
  IGT_4963: 11e10bc575516c56978640fcc697c27f277c660a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2914/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Daniel Vetter]

On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> Clang builds healthy.
> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
>  .gitlab-ci.yml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ae8cbb67..e7d31376 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
>      - ninja -C build
>      - ninja -C build igt-gpu-tools-doc
>  
> +build:tests-fedora-clang:
> +  stage: build
> +  script:
> +    - dnf install -y clang
> +    - export CC=clang
> +    - meson $MESON_OPTIONS build
> +    - ninja -C build

Uh why?

The thing that broken is building on non-x86 hosts, and that's the thing
gitlab CI caught. I have no idea why this is all about clang (imo it's
not), and I don't think we should care about clang either.
-Daniel

> +
>  build:tests-debian-meson:
>    image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
>    stage: build
> -- 
> 2.21.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Daniel Vetter]

On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> > 
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> >  .gitlab-ci.yml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >      - ninja -C build
> >      - ninja -C build igt-gpu-tools-doc
> >  
> > +build:tests-fedora-clang:
> > +  stage: build
> > +  script:
> > +    - dnf install -y clang
> > +    - export CC=clang
> > +    - meson $MESON_OPTIONS build
> > +    - ninja -C build
> 
> Uh why?
> 
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
> -Daniel
> 
> > +
> >  build:tests-debian-meson:
> >    image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> >    stage: build
> > -- 
> > 2.21.0
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Jani Nikula]

On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
>> This adds a build step with Clang on Fedora. Hopefully this can help keeping
>> Clang builds healthy.
>> 
>> Signed-off-by: Simon Ser <simon.ser@intel.com>
>> ---
>>  .gitlab-ci.yml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index ae8cbb67..e7d31376 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
>>      - ninja -C build
>>      - ninja -C build igt-gpu-tools-doc
>>  
>> +build:tests-fedora-clang:
>> +  stage: build
>> +  script:
>> +    - dnf install -y clang
>> +    - export CC=clang
>> +    - meson $MESON_OPTIONS build
>> +    - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.

And why shouldn't we care about clang?


BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Ser, Simon]

On Thu, 2019-04-25 at 09:35 +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> > 
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> >  .gitlab-ci.yml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >      - ninja -C build
> >      - ninja -C build igt-gpu-tools-doc
> >  
> > +build:tests-fedora-clang:
> > +  stage: build
> > +  script:
> > +    - dnf install -y clang
> > +    - export CC=clang
> > +    - meson $MESON_OPTIONS build
> > +    - ninja -C build
> 
> Uh why?
> 
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
> -Daniel

Well I didn't know it was broken on non-x86 hosts. I submitted the
patch because I use Clang and it broke on my machine.

I do think there is value in supporting Clang, just not to be trapped
forever with GCC. It's not like it's a huge hassle either since Clang
implements the huge pile of GNU extensions GCC has (sadly).

> > +
> >  build:tests-debian-meson:
> >    image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> >    stage: build
> > -- 
> > 2.21.0
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Petri Latvala]

On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> > 
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> >  .gitlab-ci.yml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >      - ninja -C build
> >      - ninja -C build igt-gpu-tools-doc
> >  
> > +build:tests-fedora-clang:
> > +  stage: build
> > +  script:
> > +    - dnf install -y clang
> > +    - export CC=clang
> > +    - meson $MESON_OPTIONS build
> > +    - ninja -C build
> 
> Uh why?
> 
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.


Consider this patch as a separate thing instead of getting stuck on
the recent build failure.

The current state is that clang builds IGT fine. The discussion would
be different if it didn't. I use clang myself occasionally, although
indirectly, through clang-analyze. It works, there's non-zero value in
keeping it working, and as just a build-test for clang this doesn't
eat that much gitlab-ci-time.


This is
Acked-by: Petri Latvala <petri.latvala@intel.com>
but I'll leave actual doublechecking of the CI change correctness to
someone else (Arek?)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Daniel Vetter]

On Thu, Apr 25, 2019 at 02:45:12PM +0300, Petri Latvala wrote:
> On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > Clang builds healthy.
> > > 
> > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > ---
> > >  .gitlab-ci.yml | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index ae8cbb67..e7d31376 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > >      - ninja -C build
> > >      - ninja -C build igt-gpu-tools-doc
> > >  
> > > +build:tests-fedora-clang:
> > > +  stage: build
> > > +  script:
> > > +    - dnf install -y clang
> > > +    - export CC=clang
> > > +    - meson $MESON_OPTIONS build
> > > +    - ninja -C build
> > 
> > Uh why?
> > 
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
> 
> 
> Consider this patch as a separate thing instead of getting stuck on
> the recent build failure.
> 
> The current state is that clang builds IGT fine. The discussion would
> be different if it didn't. I use clang myself occasionally, although
> indirectly, through clang-analyze. It works, there's non-zero value in
> keeping it working, and as just a build-test for clang this doesn't
> eat that much gitlab-ci-time.
> 
> 
> This is
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> but I'll leave actual doublechecking of the CI change correctness to
> someone else (Arek?)

I'd say if we want to support clang (personally I really dont care, and
clang isn't going to work with the kernel anytime soon so it's not we can
ditch gcc), then the gitlab CI should also run the tests. That's the same
standard as we have for the non-x86 builds (yes we run them through qemu
machine emulation to get arm/arm64 going on our x86 builders).

With that I can also slap my Acked-by: Daniel Vetter
<daniel.vetter@ffwll.ch> onto the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Daniel Vetter]

On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> >> Clang builds healthy.
> >> 
> >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> >> ---
> >>  .gitlab-ci.yml | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >> 
> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> >> index ae8cbb67..e7d31376 100644
> >> --- a/.gitlab-ci.yml
> >> +++ b/.gitlab-ci.yml
> >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> >>      - ninja -C build
> >>      - ninja -C build igt-gpu-tools-doc
> >>  
> >> +build:tests-fedora-clang:
> >> +  stage: build
> >> +  script:
> >> +    - dnf install -y clang
> >> +    - export CC=clang
> >> +    - meson $MESON_OPTIONS build
> >> +    - ninja -C build
> >
> > Uh why?
> >
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
> 
> And why shouldn't we care about clang?

What I meant is: We already have gitlab ci targets that caught the recent
clang regression (because a lot more broke). No one gave a shit from what
I can tell, so I guess I'm questioning the value of more gitlab CI targets
in general. We could fix that by going to merge requests and blocking
pulls that fail to build I guess.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Arkadiusz Hiler]

On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> Clang builds healthy.
> 
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
>  .gitlab-ci.yml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ae8cbb67..e7d31376 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
>      - ninja -C build
>      - ninja -C build igt-gpu-tools-doc
>  
> +build:tests-fedora-clang:
> +  stage: build
> +  script:
> +    - dnf install -y clang

From experience, this is going to be quite slow - packages indexes will
get updated basically every run, and it may cause random failures of the
build step.

I think it would be better to stick to:

diff --git a/Dockerfile.fedora b/Dockerfile.fedora
index 29520f7b..d48d16fc 100644
--- a/Dockerfile.fedora
+++ b/Dockerfile.fedora
@@ -35,6 +35,9 @@ RUN tar xf peg-0.1.18.tar.gz
 RUN cd peg-0.1.18 && make PREFIX=/usr install
 RUN rm -fr /tmp/peg

+# For clang compilation-testing
+RUN dnf install -y clang
+
 # Meson version switching shenanigans
 WORKDIR /usr/src
 RUN curl -O https://files.pythonhosted.org/packages/17/d0/0fe98a9557a2f07dbe6f99ef57f2bc37450b641e1f6ceae9ce04c3c845dd/meson-0.46.0.tar.gz
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Ser, Simon]

On Thu, 2019-04-25 at 15:49 +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > > Clang builds healthy.
> > > > 
> > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > > ---
> > > >  .gitlab-ci.yml | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > > 
> > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > > index ae8cbb67..e7d31376 100644
> > > > --- a/.gitlab-ci.yml
> > > > +++ b/.gitlab-ci.yml
> > > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > >      - ninja -C build
> > > >      - ninja -C build igt-gpu-tools-doc
> > > >  
> > > > +build:tests-fedora-clang:
> > > > +  stage: build
> > > > +  script:
> > > > +    - dnf install -y clang
> > > > +    - export CC=clang
> > > > +    - meson $MESON_OPTIONS build
> > > > +    - ninja -C build
> > > 
> > > Uh why?
> > > 
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> > 
> > And why shouldn't we care about clang?
> 
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general. We could fix that by going to merge requests and blocking
> pulls that fail to build I guess.
> -Daniel

I guess no one gave a shit because it was still a little bit early in
the morning. By the time people noticed the Clang patch was already
submitted. All I want to say is: Petri (and probably other maintainers
too) does monitor CI build status.

I strongly agree with you: pre-merge checks would be a lot better.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Arkadiusz Hiler]

On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > >> Clang builds healthy.
> > >> 
> > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > >> ---
> > >>  .gitlab-ci.yml | 8 ++++++++
> > >>  1 file changed, 8 insertions(+)
> > >> 
> > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > >> index ae8cbb67..e7d31376 100644
> > >> --- a/.gitlab-ci.yml
> > >> +++ b/.gitlab-ci.yml
> > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > >>      - ninja -C build
> > >>      - ninja -C build igt-gpu-tools-doc
> > >>  
> > >> +build:tests-fedora-clang:
> > >> +  stage: build
> > >> +  script:
> > >> +    - dnf install -y clang
> > >> +    - export CC=clang
> > >> +    - meson $MESON_OPTIONS build
> > >> +    - ninja -C build
> > >
> > > Uh why?
> > >
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> > 
> > And why shouldn't we care about clang?
> 
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general. We could fix that by going to merge requests and blocking
> pulls that fail to build I guess.

The value is that we do see breakages. We get emails and we can fix this
up post-factum.

Even today, thanks to gilab-ci we fixed breakage in autotools just
moments after it happened.

Most of the checks in the gitlab-ci are not our main way of operation
(meson + x86 + gcc), but they still allow us to be better citizens of
the community. People use various arch and compilers, and as long as
they care and express that interest by sending patches I am okay with
it.

Even if we catch that something broke few days after it happened we have
just one thing to fix, instead of someone coming months down the line
and having to fix what would be a completelty broken tree on their
setup.

-- 
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Arkadiusz Hiler]

On Thu, Apr 25, 2019 at 01:54:45PM +0000, Ser, Simon wrote:
> On Thu, 2019-04-25 at 15:49 +0200, Daniel Vetter wrote:
> > On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > > > Clang builds healthy.
> > > > > 
> > > > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > > > ---
> > > > >  .gitlab-ci.yml | 8 ++++++++
> > > > >  1 file changed, 8 insertions(+)
> > > > > 
> > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > > > index ae8cbb67..e7d31376 100644
> > > > > --- a/.gitlab-ci.yml
> > > > > +++ b/.gitlab-ci.yml
> > > > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > > >      - ninja -C build
> > > > >      - ninja -C build igt-gpu-tools-doc
> > > > >  
> > > > > +build:tests-fedora-clang:
> > > > > +  stage: build
> > > > > +  script:
> > > > > +    - dnf install -y clang
> > > > > +    - export CC=clang
> > > > > +    - meson $MESON_OPTIONS build
> > > > > +    - ninja -C build
> > > > 
> > > > Uh why?
> > > > 
> > > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > > not), and I don't think we should care about clang either.
> > > 
> > > And why shouldn't we care about clang?
> > 
> > What I meant is: We already have gitlab ci targets that caught the recent
> > clang regression (because a lot more broke). No one gave a shit from what
> > I can tell, so I guess I'm questioning the value of more gitlab CI targets
> > in general. We could fix that by going to merge requests and blocking
> > pulls that fail to build I guess.
> > -Daniel
> 
> I guess no one gave a shit because it was still a little bit early in
> the morning. By the time people noticed the Clang patch was already
> submitted. All I want to say is: Petri (and probably other maintainers
> too) does monitor CI build status.
> 
> I strongly agree with you: pre-merge checks would be a lot better.

We will get there one day :-)

gitlab-ci was the easiest way to give people some control on build
testing.

There is an idea to create gfx-ci/igt-tags repo, where each pre-merge
tree would be pushed. That would give us results from the
gitlab-ci. With some plumbing we could push those to patchwork.

I have to ask daniels first whether our omnibus gitlab is able to handle
that though.

-- 
Cheers,
Arek

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Ville Syrjälä]

On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > >> Clang builds healthy.
> > >> 
> > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > >> ---
> > >>  .gitlab-ci.yml | 8 ++++++++
> > >>  1 file changed, 8 insertions(+)
> > >> 
> > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > >> index ae8cbb67..e7d31376 100644
> > >> --- a/.gitlab-ci.yml
> > >> +++ b/.gitlab-ci.yml
> > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > >>      - ninja -C build
> > >>      - ninja -C build igt-gpu-tools-doc
> > >>  
> > >> +build:tests-fedora-clang:
> > >> +  stage: build
> > >> +  script:
> > >> +    - dnf install -y clang
> > >> +    - export CC=clang
> > >> +    - meson $MESON_OPTIONS build
> > >> +    - ninja -C build
> > >
> > > Uh why?
> > >
> > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > not), and I don't think we should care about clang either.
> > 
> > And why shouldn't we care about clang?
> 
> What I meant is: We already have gitlab ci targets that caught the recent
> clang regression (because a lot more broke). No one gave a shit from what
> I can tell, so I guess I'm questioning the value of more gitlab CI targets
> in general.

Has the gitlab ci stuff been fixed so it doesn't fail 100% of time
anyway? At least I've already been fully conditioned to ignore all
gitlab errors because of that.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

[Arkadiusz Hiler]

On Thu, Apr 25, 2019 at 05:56:30PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 25, 2019 at 03:49:49PM +0200, Daniel Vetter wrote:
> > On Thu, Apr 25, 2019 at 01:05:28PM +0300, Jani Nikula wrote:
> > > On Thu, 25 Apr 2019, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > >> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > >> Clang builds healthy.
> > > >> 
> > > >> Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > >> ---
> > > >>  .gitlab-ci.yml | 8 ++++++++
> > > >>  1 file changed, 8 insertions(+)
> > > >> 
> > > >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > >> index ae8cbb67..e7d31376 100644
> > > >> --- a/.gitlab-ci.yml
> > > >> +++ b/.gitlab-ci.yml
> > > >> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > >>      - ninja -C build
> > > >>      - ninja -C build igt-gpu-tools-doc
> > > >>  
> > > >> +build:tests-fedora-clang:
> > > >> +  stage: build
> > > >> +  script:
> > > >> +    - dnf install -y clang
> > > >> +    - export CC=clang
> > > >> +    - meson $MESON_OPTIONS build
> > > >> +    - ninja -C build
> > > >
> > > > Uh why?
> > > >
> > > > The thing that broken is building on non-x86 hosts, and that's the thing
> > > > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > > > not), and I don't think we should care about clang either.
> > > 
> > > And why shouldn't we care about clang?
> > 
> > What I meant is: We already have gitlab ci targets that caught the recent
> > clang regression (because a lot more broke). No one gave a shit from what
> > I can tell, so I guess I'm questioning the value of more gitlab CI targets
> > in general.
> 
> Has the gitlab ci stuff been fixed so it doesn't fail 100% of time
> anyway? At least I've already been fully conditioned to ignore all
> gitlab errors because of that.

Sadly the publishing on the FDO (which we use to push IGT docs) seems to
be still failing quite reliably.

I think we can abandon all hopes for it being fixed in the near future,
and change the step to be manual, so at least we stop polluting people's
inboxes.

-- 
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH v2 i-g-t] ci: build with Clang

[Arkadiusz Hiler]

From: Simon Ser <simon.ser@intel.com>

This adds a build and test step with Clang on Fedora. Hopefully this can
help keeping Clang builds healthy.

Signed-off-by: Simon Ser <simon.ser@intel.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---

Completed pipeline:
https://gitlab.freedesktop.org/ivyl/igt/pipelines/33973

 .gitlab-ci.yml    | 19 +++++++++++++++++++
 Dockerfile.fedora |  3 +++
 2 files changed, 22 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index ae8cbb67..f282c684 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -47,6 +47,17 @@ build:tests-fedora-oldest-meson:
     - ninja -C build
     - ninja -C build igt-gpu-tools-doc
 
+build:tests-fedora-clang:
+  stage: build
+  variables:
+    CC: clang
+  script:
+    - meson $MESON_OPTIONS build
+    - ninja -C build
+  artifacts:
+    paths:
+      - build
+
 build:tests-debian-meson:
   image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
   stage: build
@@ -99,6 +110,14 @@ test:ninja-test:
   stage: test
   script: ninja -C build test
 
+test:ninja-test-clang:
+  dependencies:
+    - build:tests-fedora-clang
+  variables:
+    CC: clang
+  stage: test
+  script: ninja -C build test
+
 test:ninja-test-arm64:
   image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-arm64:latest
   dependencies:
diff --git a/Dockerfile.fedora b/Dockerfile.fedora
index 29520f7b..0795de0e 100644
--- a/Dockerfile.fedora
+++ b/Dockerfile.fedora
@@ -35,6 +35,9 @@ RUN tar xf peg-0.1.18.tar.gz
 RUN cd peg-0.1.18 && make PREFIX=/usr install
 RUN rm -fr /tmp/peg
 
+# For compile-testing on clang
+RUN dnf install -y clang
+
 # Meson version switching shenanigans
 WORKDIR /usr/src
 RUN curl -O https://files.pythonhosted.org/packages/17/d0/0fe98a9557a2f07dbe6f99ef57f2bc37450b641e1f6ceae9ce04c3c845dd/meson-0.46.0.tar.gz
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev