From: Christoph Hellwig <hch@infradead.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Christoph Hellwig <hch@infradead.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] tty: Don't force RISCV SBI console as preferred console
Date: Thu, 25 Apr 2019 23:21:33 -0700 [thread overview]
Message-ID: <20190426062133.GA28529@infradead.org> (raw)
In-Reply-To: <9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com>
On Thu, Apr 25, 2019 at 09:41:21PM -0700, Atish Patra wrote:
> Do we even need HVC_SBI console to be enabled by default? Disabling
> CONFIG_HVC_RISCV_SBI seems to be fine while running in QEMU.
>
> If we don't need it, I suggest we should remove the config option from
> defconfig in addition to this patch.
I think the whole concept of the SBI console is a little dangerous.
It means that for one piece of physical hardware (usually the uart)
we have two entiries (the M-mode firmware and the OS) in control,
which tends to rarely end well.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Albert Ou <aou@eecs.berkeley.edu>, Jiri Slaby <jslaby@suse.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] tty: Don't force RISCV SBI console as preferred console
Date: Thu, 25 Apr 2019 23:21:33 -0700 [thread overview]
Message-ID: <20190426062133.GA28529@infradead.org> (raw)
In-Reply-To: <9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com>
On Thu, Apr 25, 2019 at 09:41:21PM -0700, Atish Patra wrote:
> Do we even need HVC_SBI console to be enabled by default? Disabling
> CONFIG_HVC_RISCV_SBI seems to be fine while running in QEMU.
>
> If we don't need it, I suggest we should remove the config option from
> defconfig in addition to this patch.
I think the whole concept of the SBI console is a little dangerous.
It means that for one piece of physical hardware (usually the uart)
we have two entiries (the M-mode firmware and the OS) in control,
which tends to rarely end well.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-04-26 6:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 13:35 [PATCH] tty: Don't force RISCV SBI console as preferred console Anup Patel
2019-04-25 13:35 ` Anup Patel
2019-04-26 4:41 ` Atish Patra
2019-04-26 4:41 ` Atish Patra
2019-04-26 6:21 ` Anup Patel
2019-04-26 6:21 ` Anup Patel
2019-04-29 19:50 ` Atish Patra
2019-04-29 19:50 ` Atish Patra
2019-04-26 6:21 ` Christoph Hellwig [this message]
2019-04-26 6:21 ` Christoph Hellwig
2019-04-26 8:42 ` Anup Patel
2019-04-26 8:42 ` Anup Patel
2019-04-29 20:02 ` Paul Walmsley
2019-04-29 20:02 ` Paul Walmsley
2019-05-01 0:25 ` Palmer Dabbelt
2019-05-01 0:25 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426062133.GA28529@infradead.org \
--to=hch@infradead.org \
--cc=Anup.Patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.