From: Atish Patra <atish.patra@wdc.com> To: Anup Patel <Anup.Patel@wdc.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Palmer Dabbelt <palmer@sifive.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Christoph Hellwig <hch@infradead.org>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org> Subject: Re: [PATCH] tty: Don't force RISCV SBI console as preferred console Date: Thu, 25 Apr 2019 21:41:21 -0700 [thread overview] Message-ID: <9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com> (raw) In-Reply-To: <20190425133435.56065-1-anup.patel@wdc.com> On 4/25/19 6:35 AM, Anup Patel wrote: > The Linux kernel will auto-disables all boot consoles whenever it > gets a preferred real console. > > Currently on RISC-V systems, if we have a real console which is not > RISCV SBI console then boot consoles (such as earlycon=sbi) are not > auto-disabled when a real console (ttyS0 or ttySIF0) is available. > This results in duplicate prints at boot-time after kernel starts > using real console (i.e. ttyS0 or ttySIF0) if "earlycon=" kernel > parameter was passed by bootloader. > > The reason for above issue is that RISCV SBI console always adds > itself as preferred console which is causing other real consoles > to be not used as preferred console. > Do we even need HVC_SBI console to be enabled by default? Disabling CONFIG_HVC_RISCV_SBI seems to be fine while running in QEMU. If we don't need it, I suggest we should remove the config option from defconfig in addition to this patch. Regards, Atish > Ideally "console=" kernel parameter passed by bootloaders should > be the one selecting a preferred real console. > > This patch fixes above issue by not forcing RISCV SBI console as > preferred console. > > Fixes: afa6b1ccfad5 ("tty: New RISC-V SBI console driver") > Cc: stable@vger.kernel.org > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > drivers/tty/hvc/hvc_riscv_sbi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c > index 75155bde2b88..31f53fa77e4a 100644 > --- a/drivers/tty/hvc/hvc_riscv_sbi.c > +++ b/drivers/tty/hvc/hvc_riscv_sbi.c > @@ -53,7 +53,6 @@ device_initcall(hvc_sbi_init); > static int __init hvc_sbi_console_init(void) > { > hvc_instantiate(0, 0, &hvc_sbi_ops); > - add_preferred_console("hvc", 0, NULL); > > return 0; > } >
WARNING: multiple messages have this Message-ID (diff)
From: Atish Patra <atish.patra@wdc.com> To: Anup Patel <Anup.Patel@wdc.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Palmer Dabbelt <palmer@sifive.com>, Albert Ou <aou@eecs.berkeley.edu> Cc: Christoph Hellwig <hch@infradead.org>, "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "stable@vger.kernel.org" <stable@vger.kernel.org> Subject: Re: [PATCH] tty: Don't force RISCV SBI console as preferred console Date: Thu, 25 Apr 2019 21:41:21 -0700 [thread overview] Message-ID: <9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com> (raw) In-Reply-To: <20190425133435.56065-1-anup.patel@wdc.com> On 4/25/19 6:35 AM, Anup Patel wrote: > The Linux kernel will auto-disables all boot consoles whenever it > gets a preferred real console. > > Currently on RISC-V systems, if we have a real console which is not > RISCV SBI console then boot consoles (such as earlycon=sbi) are not > auto-disabled when a real console (ttyS0 or ttySIF0) is available. > This results in duplicate prints at boot-time after kernel starts > using real console (i.e. ttyS0 or ttySIF0) if "earlycon=" kernel > parameter was passed by bootloader. > > The reason for above issue is that RISCV SBI console always adds > itself as preferred console which is causing other real consoles > to be not used as preferred console. > Do we even need HVC_SBI console to be enabled by default? Disabling CONFIG_HVC_RISCV_SBI seems to be fine while running in QEMU. If we don't need it, I suggest we should remove the config option from defconfig in addition to this patch. Regards, Atish > Ideally "console=" kernel parameter passed by bootloaders should > be the one selecting a preferred real console. > > This patch fixes above issue by not forcing RISCV SBI console as > preferred console. > > Fixes: afa6b1ccfad5 ("tty: New RISC-V SBI console driver") > Cc: stable@vger.kernel.org > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > drivers/tty/hvc/hvc_riscv_sbi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/hvc/hvc_riscv_sbi.c b/drivers/tty/hvc/hvc_riscv_sbi.c > index 75155bde2b88..31f53fa77e4a 100644 > --- a/drivers/tty/hvc/hvc_riscv_sbi.c > +++ b/drivers/tty/hvc/hvc_riscv_sbi.c > @@ -53,7 +53,6 @@ device_initcall(hvc_sbi_init); > static int __init hvc_sbi_console_init(void) > { > hvc_instantiate(0, 0, &hvc_sbi_ops); > - add_preferred_console("hvc", 0, NULL); > > return 0; > } > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-04-26 4:41 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-25 13:35 [PATCH] tty: Don't force RISCV SBI console as preferred console Anup Patel 2019-04-25 13:35 ` Anup Patel 2019-04-26 4:41 ` Atish Patra [this message] 2019-04-26 4:41 ` Atish Patra 2019-04-26 6:21 ` Anup Patel 2019-04-26 6:21 ` Anup Patel 2019-04-29 19:50 ` Atish Patra 2019-04-29 19:50 ` Atish Patra 2019-04-26 6:21 ` Christoph Hellwig 2019-04-26 6:21 ` Christoph Hellwig 2019-04-26 8:42 ` Anup Patel 2019-04-26 8:42 ` Anup Patel 2019-04-29 20:02 ` Paul Walmsley 2019-04-29 20:02 ` Paul Walmsley 2019-05-01 0:25 ` Palmer Dabbelt 2019-05-01 0:25 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9a8be7ef-e62e-2a93-9170-e3dc70dfb25f@wdc.com \ --to=atish.patra@wdc.com \ --cc=Anup.Patel@wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=gregkh@linuxfoundation.org \ --cc=hch@infradead.org \ --cc=jslaby@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@sifive.com \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.