* [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2018-12-11 4:56 ` Pradeep Kumar Chitrapu
0 siblings, 0 replies; 16+ messages in thread
From: Pradeep Kumar Chitrapu @ 2018-12-11 4:56 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Pradeep kumar Chitrapu, Zhi Chen
From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
Invalid rate code is sent to firmware when multicast rate value of 0 is
sent to driver indicating disabled case, causing broken mesh path.
so fix that.
Tested on QCA9984 with firmware 10.4-3.6.1-00827
Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 6771d8185af5..4546b73b2e45 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -5486,8 +5486,8 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw,
struct cfg80211_chan_def def;
u32 vdev_param, pdev_param, slottime, preamble;
u16 bitrate, hw_value;
- u8 rate, basic_rate_idx;
- int rateidx, ret = 0, hw_rate_code;
+ u8 rate, basic_rate_idx, rateidx;
+ int ret = 0, hw_rate_code, mcast_rate;
enum nl80211_band band;
const struct ieee80211_supported_band *sband;
@@ -5674,7 +5674,11 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_MCAST_RATE &&
!WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) {
band = def.chan->band;
- rateidx = vif->bss_conf.mcast_rate[band] - 1;
+ mcast_rate = vif->bss_conf.mcast_rate[band];
+ if (mcast_rate > 0)
+ rateidx = mcast_rate - 1;
+ else
+ rateidx = ffs(vif->bss_conf.basic_rates) - 1;
if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY)
rateidx += ATH10K_MAC_FIRST_OFDM_RATE_IDX;
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2018-12-11 4:56 ` Pradeep Kumar Chitrapu
0 siblings, 0 replies; 16+ messages in thread
From: Pradeep Kumar Chitrapu @ 2018-12-11 4:56 UTC (permalink / raw)
To: ath10k; +Cc: Pradeep kumar Chitrapu, Zhi Chen, linux-wireless
From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
Invalid rate code is sent to firmware when multicast rate value of 0 is
sent to driver indicating disabled case, causing broken mesh path.
so fix that.
Tested on QCA9984 with firmware 10.4-3.6.1-00827
Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 6771d8185af5..4546b73b2e45 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -5486,8 +5486,8 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw,
struct cfg80211_chan_def def;
u32 vdev_param, pdev_param, slottime, preamble;
u16 bitrate, hw_value;
- u8 rate, basic_rate_idx;
- int rateidx, ret = 0, hw_rate_code;
+ u8 rate, basic_rate_idx, rateidx;
+ int ret = 0, hw_rate_code, mcast_rate;
enum nl80211_band band;
const struct ieee80211_supported_band *sband;
@@ -5674,7 +5674,11 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_MCAST_RATE &&
!WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) {
band = def.chan->band;
- rateidx = vif->bss_conf.mcast_rate[band] - 1;
+ mcast_rate = vif->bss_conf.mcast_rate[band];
+ if (mcast_rate > 0)
+ rateidx = mcast_rate - 1;
+ else
+ rateidx = ffs(vif->bss_conf.basic_rates) - 1;
if (ar->phy_capability & WHAL_WLAN_11A_CAPABILITY)
rateidx += ATH10K_MAC_FIRST_OFDM_RATE_IDX;
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
@ 2018-12-11 19:22 ` Peter Oh
-1 siblings, 0 replies; 16+ messages in thread
From: Peter Oh @ 2018-12-11 19:22 UTC (permalink / raw)
To: Pradeep Kumar Chitrapu, ath10k; +Cc: linux-wireless, Zhi Chen
On 12/10/2018 08:56 PM, Pradeep Kumar Chitrapu wrote:
> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
Test data is too small. You need to provide at least QCA9880 and QCA4019
data together which share ath10k for mesh.
Thanks,
Peter
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2018-12-11 19:22 ` Peter Oh
0 siblings, 0 replies; 16+ messages in thread
From: Peter Oh @ 2018-12-11 19:22 UTC (permalink / raw)
To: Pradeep Kumar Chitrapu, ath10k; +Cc: Zhi Chen, linux-wireless
On 12/10/2018 08:56 PM, Pradeep Kumar Chitrapu wrote:
> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
Test data is too small. You need to provide at least QCA9880 and QCA4019
data together which share ath10k for mesh.
Thanks,
Peter
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2018-12-11 19:22 ` Peter Oh
@ 2019-02-07 14:42 ` Kalle Valo
-1 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-02-07 14:42 UTC (permalink / raw)
To: Peter Oh; +Cc: Pradeep Kumar Chitrapu, ath10k, Zhi Chen, linux-wireless
Peter Oh <peter.oh@bowerswilkins.com> writes:
> On 12/10/2018 08:56 PM, Pradeep Kumar Chitrapu wrote:
>> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>>
>> Invalid rate code is sent to firmware when multicast rate value of 0 is
>> sent to driver indicating disabled case, causing broken mesh path.
>> so fix that.
>>
>> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>>
> Test data is too small. You need to provide at least QCA9880 and QCA4019
> data together which share ath10k for mesh.
Pradeep, did you test those? Or someone else?
But isn't the firmware almost the same on those hardware anyway?
--
Kalle Valo
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2019-02-07 14:42 ` Kalle Valo
0 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-02-07 14:42 UTC (permalink / raw)
To: Peter Oh; +Cc: Pradeep Kumar Chitrapu, Zhi Chen, linux-wireless, ath10k
Peter Oh <peter.oh@bowerswilkins.com> writes:
> On 12/10/2018 08:56 PM, Pradeep Kumar Chitrapu wrote:
>> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>>
>> Invalid rate code is sent to firmware when multicast rate value of 0 is
>> sent to driver indicating disabled case, causing broken mesh path.
>> so fix that.
>>
>> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>>
> Test data is too small. You need to provide at least QCA9880 and QCA4019
> data together which share ath10k for mesh.
Pradeep, did you test those? Or someone else?
But isn't the firmware almost the same on those hardware anyway?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
@ 2019-02-25 20:00 ` Sven Eckelmann
-1 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-02-25 20:00 UTC (permalink / raw)
To: ath10k; +Cc: Pradeep Kumar Chitrapu, Zhi Chen, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Tuesday, 11 December 2018 05:56:11 CET Pradeep Kumar Chitrapu wrote:
> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Tested-by: Sven Eckelmann <sven@narfation.org>
Was tested on QCA988X with 10.2.4-1.0-00041
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2019-02-25 20:00 ` Sven Eckelmann
0 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-02-25 20:00 UTC (permalink / raw)
To: ath10k; +Cc: Pradeep Kumar Chitrapu, Zhi Chen, linux-wireless
[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]
On Tuesday, 11 December 2018 05:56:11 CET Pradeep Kumar Chitrapu wrote:
> From: Pradeep kumar Chitrapu <pradeepc@codeaurora.org>
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Tested-by: Sven Eckelmann <sven@narfation.org>
Was tested on QCA988X with 10.2.4-1.0-00041
Kind regards,
Sven
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2019-02-25 20:00 ` Sven Eckelmann
@ 2019-02-26 9:23 ` Sven Eckelmann
-1 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-02-26 9:23 UTC (permalink / raw)
To: Sven Eckelmann, Ansuel Smith
Cc: ath10k, Pradeep Kumar Chitrapu, Zhi Chen, linux-wireless,
Sebastian Gottschall, John Crispin, Steve deRosier
[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]
On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
[...]
> Tested-by: Sven Eckelmann <sven@narfation.org>
>
> Was tested on QCA988X with 10.2.4-1.0-00041
I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
(linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
always crashes with and without this patch and 11s.
[ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
[ 221.744056] ieee80211 phy0: Hardware restart was requested
[ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
[ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
[ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
[ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
by upstream but it looks like there is an Openwrt private patch (not yet
accepted upstream [1])
package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
which I have now removed to fix this problem for me.
The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
@Kalle are you expecting that he resents the patch again or can you just
append this information to the commit message? At least it looks at the moment
like there will be no new patch in the near future. But the
commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
real world setups.
Kind regards,
Sven
[1] https://patchwork.kernel.org/patch/10327075/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2019-02-26 9:23 ` Sven Eckelmann
0 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-02-26 9:23 UTC (permalink / raw)
To: Sven Eckelmann, Ansuel Smith
Cc: Steve deRosier, Pradeep Kumar Chitrapu, linux-wireless, ath10k,
Zhi Chen, John Crispin, Sebastian Gottschall
[-- Attachment #1.1: Type: text/plain, Size: 1728 bytes --]
On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
[...]
> Tested-by: Sven Eckelmann <sven@narfation.org>
>
> Was tested on QCA988X with 10.2.4-1.0-00041
I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
(linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
always crashes with and without this patch and 11s.
[ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
[ 221.744056] ieee80211 phy0: Hardware restart was requested
[ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
[ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
[ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
[ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
by upstream but it looks like there is an Openwrt private patch (not yet
accepted upstream [1])
package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
which I have now removed to fix this problem for me.
The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
@Kalle are you expecting that he resents the patch again or can you just
append this information to the commit message? At least it looks at the moment
like there will be no new patch in the near future. But the
commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
real world setups.
Kind regards,
Sven
[1] https://patchwork.kernel.org/patch/10327075/
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2019-02-26 9:23 ` Sven Eckelmann
@ 2019-04-03 12:28 ` Kalle Valo
-1 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-04-03 12:28 UTC (permalink / raw)
To: Sven Eckelmann
Cc: Ansuel Smith, Steve deRosier, Pradeep Kumar Chitrapu,
linux-wireless, ath10k, Zhi Chen, John Crispin,
Sebastian Gottschall
Sven Eckelmann <sven@narfation.org> writes:
> On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
> [...]
>> Tested-by: Sven Eckelmann <sven@narfation.org>
>>
>> Was tested on QCA988X with 10.2.4-1.0-00041
>
> I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
> and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
> (linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
> always crashes with and without this patch and 11s.
>
> [ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
> [ 221.744056] ieee80211 phy0: Hardware restart was requested
> [ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
> [ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
> [ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
> [ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
>
> If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
> by upstream but it looks like there is an Openwrt private patch (not yet
> accepted upstream [1])
>
> package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
>
> which I have now removed to fix this problem for me.
>
> The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
>
> @Kalle are you expecting that he resents the patch again or can you just
> append this information to the commit message? At least it looks at the moment
> like there will be no new patch in the near future. But the
> commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
> real world setups.
I'm planning to apply this. I was not sure what you wanted to add to the
commit log but I changed to now what's below. Please let me know if you
want to change it.
ath10k: fix incorrect multicast/broadcast rate setting
Invalid rate code is sent to firmware when multicast rate value of 0 is
sent to driver indicating disabled case, causing broken mesh path.
so fix that.
Tested on QCA9984 with firmware 10.4-3.6.1-00827
Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
(ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Tested-by: Sven Eckelmann <sven@narfation.org>
Patchwork-Id: 10723033
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
--
Kalle Valo
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2019-04-03 12:28 ` Kalle Valo
0 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-04-03 12:28 UTC (permalink / raw)
To: Sven Eckelmann
Cc: Steve deRosier, Pradeep Kumar Chitrapu, linux-wireless, ath10k,
Zhi Chen, John Crispin, Sebastian Gottschall, Ansuel Smith
Sven Eckelmann <sven@narfation.org> writes:
> On Monday, 25 February 2019 21:00:38 CET Sven Eckelmann wrote:
> [...]
>> Tested-by: Sven Eckelmann <sven@narfation.org>
>>
>> Was tested on QCA988X with 10.2.4-1.0-00041
>
> I just wanted to test it with 802.11s setup on IPQ4019 with 10.4-3.5.3-00057
> and QCA9888 with 10.4-3.5.3-00053 (ath10k-firmware) and 10.4-3.6-00140
> (linux-firmware 2018-12-16-211de167) for both. But it looks like the firmware
> always crashes with and without this patch and 11s.
>
> [ 221.620803] ath10k_pci 0000:01:00.0: wmi command 36967 timeout, restarting hardware
> [ 221.744056] ieee80211 phy0: Hardware restart was requested
> [ 225.130829] ath10k_pci 0000:01:00.0: failed to receive control response completion, polling..
> [ 226.170824] ath10k_pci 0000:01:00.0: Service connect timeout
> [ 226.170871] ath10k_pci 0000:01:00.0: failed to connect htt (-110)
> [ 226.252248] ath10k_pci 0000:01:00.0: Could not init core: -110
>
> If i count correctly, this is WMI_10_4_GPIO_CONFIG_CMDID. Not really supported
> by upstream but it looks like there is an Openwrt private patch (not yet
> accepted upstream [1])
>
> package/kernel/mac80211/patches/ath/974-ath10k_add-LED-and-GPIO-controlling-support-for-various-chipsets.patch
>
> which I have now removed to fix this problem for me.
>
> The tests with 10.4-3.6-00140 and 10.4-3.5.3-* worked fine without this patch.
>
> @Kalle are you expecting that he resents the patch again or can you just
> append this information to the commit message? At least it looks at the moment
> like there will be no new patch in the near future. But the
> commit cd93b83ad92 ("ath10k: support for multicast rate control") is breaking
> real world setups.
I'm planning to apply this. I was not sure what you wanted to add to the
commit log but I changed to now what's below. Please let me know if you
want to change it.
ath10k: fix incorrect multicast/broadcast rate setting
Invalid rate code is sent to firmware when multicast rate value of 0 is
sent to driver indicating disabled case, causing broken mesh path.
so fix that.
Tested on QCA9984 with firmware 10.4-3.6.1-00827
Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
(ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Tested-by: Sven Eckelmann <sven@narfation.org>
Patchwork-Id: 10723033
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2019-04-03 12:28 ` Kalle Valo
@ 2019-04-03 13:04 ` Sven Eckelmann
-1 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-04-03 13:04 UTC (permalink / raw)
To: Kalle Valo
Cc: Ansuel Smith, Steve deRosier, Pradeep Kumar Chitrapu,
linux-wireless, ath10k, Zhi Chen, John Crispin,
Sebastian Gottschall
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
On Wednesday, 3 April 2019 14:28:16 CEST Kalle Valo wrote:
[...]
> I'm planning to apply this. I was not sure what you wanted to add to the
> commit log but I changed to now what's below. Please let me know if you
> want to change it.
>
> ath10k: fix incorrect multicast/broadcast rate setting
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
> (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Tested-by: Sven Eckelmann <sven@narfation.org>
> Patchwork-Id: 10723033
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
I thought you just wanted to have this information added to the "Tested on "
line by him. So I didn't really invest time to propose a new paragraph.
The new paragraph is fine for me.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
@ 2019-04-03 13:04 ` Sven Eckelmann
0 siblings, 0 replies; 16+ messages in thread
From: Sven Eckelmann @ 2019-04-03 13:04 UTC (permalink / raw)
To: Kalle Valo
Cc: Steve deRosier, Pradeep Kumar Chitrapu, linux-wireless, ath10k,
Zhi Chen, John Crispin, Sebastian Gottschall, Ansuel Smith
[-- Attachment #1.1: Type: text/plain, Size: 1315 bytes --]
On Wednesday, 3 April 2019 14:28:16 CEST Kalle Valo wrote:
[...]
> I'm planning to apply this. I was not sure what you wanted to add to the
> commit log but I changed to now what's below. Please let me know if you
> want to change it.
>
> ath10k: fix incorrect multicast/broadcast rate setting
>
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
> (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Tested-by: Sven Eckelmann <sven@narfation.org>
> Patchwork-Id: 10723033
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
I thought you just wanted to have this information added to the "Tested on "
line by him. So I didn't really invest time to propose a new paragraph.
The new paragraph is fine for me.
Kind regards,
Sven
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
` (3 preceding siblings ...)
(?)
@ 2019-04-29 14:43 ` Kalle Valo
-1 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-04-29 14:43 UTC (permalink / raw)
To: Pradeep Kumar Chitrapu
Cc: ath10k, linux-wireless, Pradeep kumar Chitrapu, Zhi Chen
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org> wrote:
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
> (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Tested-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
93ee3d108fc7 ath10k: fix incorrect multicast/broadcast rate setting
--
https://patchwork.kernel.org/patch/10723033/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ath10k: fix incorrect multicast/broadcast rate setting
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
` (2 preceding siblings ...)
(?)
@ 2019-04-29 14:43 ` Kalle Valo
-1 siblings, 0 replies; 16+ messages in thread
From: Kalle Valo @ 2019-04-29 14:43 UTC (permalink / raw)
To: Pradeep Kumar Chitrapu; +Cc: Zhi Chen, linux-wireless, ath10k
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org> wrote:
> Invalid rate code is sent to firmware when multicast rate value of 0 is
> sent to driver indicating disabled case, causing broken mesh path.
> so fix that.
>
> Tested on QCA9984 with firmware 10.4-3.6.1-00827
>
> Sven tested on IPQ4019 with 10.4-3.5.3-00057 and QCA9888 with 10.4-3.5.3-00053
> (ath10k-firmware) and 10.4-3.6-00140 (linux-firmware 2018-12-16-211de167).
>
> Fixes: cd93b83ad92 ("ath10k: support for multicast rate control")
> Co-developed-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Zhi Chen <zhichen@codeaurora.org>
> Signed-off-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Tested-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
93ee3d108fc7 ath10k: fix incorrect multicast/broadcast rate setting
--
https://patchwork.kernel.org/patch/10723033/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-04-29 14:43 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 4:56 [PATCH] ath10k: fix incorrect multicast/broadcast rate setting Pradeep Kumar Chitrapu
2018-12-11 4:56 ` Pradeep Kumar Chitrapu
2018-12-11 19:22 ` Peter Oh
2018-12-11 19:22 ` Peter Oh
2019-02-07 14:42 ` Kalle Valo
2019-02-07 14:42 ` Kalle Valo
2019-02-25 20:00 ` Sven Eckelmann
2019-02-25 20:00 ` Sven Eckelmann
2019-02-26 9:23 ` Sven Eckelmann
2019-02-26 9:23 ` Sven Eckelmann
2019-04-03 12:28 ` Kalle Valo
2019-04-03 12:28 ` Kalle Valo
2019-04-03 13:04 ` Sven Eckelmann
2019-04-03 13:04 ` Sven Eckelmann
2019-04-29 14:43 ` Kalle Valo
2019-04-29 14:43 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.