All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64
Date: Thu, 2 May 2019 09:43:03 +0200	[thread overview]
Message-ID: <20190502074303.g3px63n4v4o7xade@flea> (raw)
In-Reply-To: <20190424062543.61852-1-icenowy@aosc.io>

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

Hi,

On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> banks.
>
> This patch adds supplies for PC and PD banks on Pine H64 board. PG and
> PM banks are used for Wi-Fi and should be added when Wi-Fi is added

Not really. The regulator is still there, whether we use it or not. If
it's not used, then it will be left disabled so it doesn't really
change anything.

> PL bank is where PMIC is attached, and currently if a PMIC regulator
> is added for it a dependency loop will happen.

I guess we should fix that somehow

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64
Date: Thu, 2 May 2019 09:43:03 +0200	[thread overview]
Message-ID: <20190502074303.g3px63n4v4o7xade@flea> (raw)
In-Reply-To: <20190424062543.61852-1-icenowy-h8G6r0blFSE@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Hi,

On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> banks.
>
> This patch adds supplies for PC and PD banks on Pine H64 board. PG and
> PM banks are used for Wi-Fi and should be added when Wi-Fi is added

Not really. The regulator is still there, whether we use it or not. If
it's not used, then it will be left disabled so it doesn't really
change anything.

> PL bank is where PMIC is attached, and currently if a PMIC regulator
> is added for it a dependency loop will happen.

I guess we should fix that somehow

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64
Date: Thu, 2 May 2019 09:43:03 +0200	[thread overview]
Message-ID: <20190502074303.g3px63n4v4o7xade@flea> (raw)
In-Reply-To: <20190424062543.61852-1-icenowy@aosc.io>


[-- Attachment #1.1: Type: text/plain, Size: 699 bytes --]

Hi,

On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> banks.
>
> This patch adds supplies for PC and PD banks on Pine H64 board. PG and
> PM banks are used for Wi-Fi and should be added when Wi-Fi is added

Not really. The regulator is still there, whether we use it or not. If
it's not used, then it will be left disabled so it doesn't really
change anything.

> PL bank is where PMIC is attached, and currently if a PMIC regulator
> is added for it a dependency loop will happen.

I guess we should fix that somehow

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-02  7:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  6:25 [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64 Icenowy Zheng
2019-04-24  6:25 ` Icenowy Zheng
2019-05-02  7:43 ` Maxime Ripard [this message]
2019-05-02  7:43   ` Maxime Ripard
2019-05-02  7:43   ` Maxime Ripard
2019-05-02  7:46   ` Icenowy Zheng
2019-05-02  7:46     ` Icenowy Zheng
2019-05-02  7:46     ` Icenowy Zheng
2019-05-02 18:10     ` Maxime Ripard
2019-05-02 18:10       ` Maxime Ripard
2019-05-02 18:10       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190502074303.g3px63n4v4o7xade@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.