From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 3/4] x86/IRQ: relax locking in irq_guest_eoi_timer_fn()
Date: Thu, 16 May 2019 15:48:14 +0200 [thread overview]
Message-ID: <20190516134814.7z33bfew47xsoq3v@Air-de-Roger> (raw)
In-Reply-To: <5CD2CFE6020000780022CCC9@prv1-mh.provo.novell.com>
On Wed, May 08, 2019 at 06:47:34AM -0600, Jan Beulich wrote:
> This is a timer handler, so it gets entered with IRQs enabled. Therefore
> there's no need to save/restore the IRQ masking flag.
>
> Additionally the final switch()'es ACKTYPE_EOI case re-acquires the lock
> just for it to be dropped again right away. Do away with this.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH 3/4] x86/IRQ: relax locking in irq_guest_eoi_timer_fn()
Date: Thu, 16 May 2019 15:48:14 +0200 [thread overview]
Message-ID: <20190516134814.7z33bfew47xsoq3v@Air-de-Roger> (raw)
Message-ID: <20190516134814.Y2dG1KBu_XlMShObQNeC7KhGu-96E7iXJR53Xm2ImQE@z> (raw)
In-Reply-To: <5CD2CFE6020000780022CCC9@prv1-mh.provo.novell.com>
On Wed, May 08, 2019 at 06:47:34AM -0600, Jan Beulich wrote:
> This is a timer handler, so it gets entered with IRQs enabled. Therefore
> there's no need to save/restore the IRQ masking flag.
>
> Additionally the final switch()'es ACKTYPE_EOI case re-acquires the lock
> just for it to be dropped again right away. Do away with this.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-16 13:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 12:39 [PATCH 0/4] x86: EOI timer corrections / improvements Jan Beulich
2019-05-08 12:39 ` [Xen-devel] " Jan Beulich
2019-05-08 12:46 ` [PATCH 1/4] x86/IRQ: don't keep EOI timer running without need Jan Beulich
2019-05-08 12:46 ` [Xen-devel] " Jan Beulich
2019-05-16 10:32 ` Roger Pau Monné
2019-05-16 10:32 ` [Xen-devel] " Roger Pau Monné
2019-05-16 10:50 ` Jan Beulich
2019-05-16 10:50 ` [Xen-devel] " Jan Beulich
2019-05-16 11:03 ` Roger Pau Monné
2019-05-16 11:03 ` [Xen-devel] " Roger Pau Monné
2019-06-05 17:04 ` Andrew Cooper
2019-06-06 8:08 ` Jan Beulich
2019-06-06 9:30 ` Andrew Cooper
2019-05-08 12:46 ` [PATCH 2/4] x86/IRQ: bail early from irq_guest_eoi_timer_fn() when nothing is in flight Jan Beulich
2019-05-08 12:46 ` [Xen-devel] " Jan Beulich
2019-05-16 11:37 ` Roger Pau Monné
2019-05-16 11:37 ` [Xen-devel] " Roger Pau Monné
2019-05-16 12:02 ` Jan Beulich
2019-05-16 12:02 ` [Xen-devel] " Jan Beulich
2019-05-16 13:44 ` Roger Pau Monné
2019-05-16 13:44 ` [Xen-devel] " Roger Pau Monné
2019-06-05 17:15 ` Andrew Cooper
2019-06-06 8:17 ` Jan Beulich
2019-06-06 11:34 ` Andrew Cooper
2019-06-06 11:43 ` Jan Beulich
2019-06-06 11:45 ` Andrew Cooper
2019-05-08 12:47 ` [PATCH 3/4] x86/IRQ: relax locking in irq_guest_eoi_timer_fn() Jan Beulich
2019-05-08 12:47 ` [Xen-devel] " Jan Beulich
2019-05-16 13:48 ` Roger Pau Monné [this message]
2019-05-16 13:48 ` Roger Pau Monné
2019-06-05 17:16 ` Andrew Cooper
2019-05-08 12:48 ` [PATCH 4/4] x86/IRQ: ACKTYPE_NONE cannot make it into irq_guest_eoi_timer_fn() Jan Beulich
2019-05-08 12:48 ` [Xen-devel] " Jan Beulich
2019-05-16 13:52 ` Roger Pau Monné
2019-05-16 13:52 ` [Xen-devel] " Roger Pau Monné
2019-05-16 14:48 ` Jan Beulich
2019-05-16 14:48 ` [Xen-devel] " Jan Beulich
2019-05-17 7:04 ` Jan Beulich
2019-05-17 7:04 ` [Xen-devel] " Jan Beulich
2019-06-05 17:18 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516134814.7z33bfew47xsoq3v@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.