From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Chunfeng Yun <chunfeng.yun@mediatek.com> Cc: Rob Herring <robh+dt@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com>, Matthias Brugger <matthias.bgg@gmail.com>, Adam Thomson <Adam.Thomson.Opensource@diasemi.com>, Li Jun <jun.li@nxp.com>, Badhri Jagan Sridharan <badhri@google.com>, Hans de Goede <hdegoede@redhat.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Min Guo <min.guo@mediatek.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das <biju.das@bp.renesas.com>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH v5 5/6] usb: roles: add USB Type-B GPIO connector driver Date: Mon, 20 May 2019 11:31:51 +0300 [thread overview] Message-ID: <20190520083151.GD1887@kuha.fi.intel.com> (raw) In-Reply-To: <1557823643-8616-6-git-send-email-chunfeng.yun@mediatek.com> On Tue, May 14, 2019 at 04:47:22PM +0800, Chunfeng Yun wrote: > +static int usb_conn_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > + struct device_node *remote_node; > + struct usb_conn_info *info; > + int ret = 0; > + > + info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); > + if (!info) > + return -ENOMEM; > + > + info->dev = dev; > + info->id_gpiod = devm_gpiod_get_optional(dev, "id", GPIOD_IN); > + if (IS_ERR(info->id_gpiod)) > + return PTR_ERR(info->id_gpiod); > + > + info->vbus_gpiod = devm_gpiod_get_optional(dev, "vbus", GPIOD_IN); > + if (IS_ERR(info->vbus_gpiod)) > + return PTR_ERR(info->vbus_gpiod); > + > + if (!info->id_gpiod && !info->vbus_gpiod) { > + dev_err(dev, "failed to get gpios\n"); > + return -ENODEV; > + } > + > + if (info->id_gpiod) > + ret = gpiod_set_debounce(info->id_gpiod, USB_GPIO_DEB_US); > + if (!ret && info->vbus_gpiod) > + ret = gpiod_set_debounce(info->vbus_gpiod, USB_GPIO_DEB_US); > + if (ret < 0) > + info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEB_MS); > + > + INIT_DELAYED_WORK(&info->dw_det, usb_conn_detect_cable); > + > + info->vbus = devm_regulator_get(dev, "vbus"); > + if (IS_ERR(info->vbus)) { > + dev_err(dev, "failed to get vbus\n"); > + return PTR_ERR(info->vbus); > + } > + > + remote_node = of_graph_get_remote_node(node, -1, 0); This is really not ideal. In practice this code will only work if there is only one endpoint described for this device, or if the first endpoint is always the one we are looking for. There is no way to guarantee that. The code really has to walk through the entire graph, and identify the remote endpoint it's looking for (and for that we have the boolean device property). > + if (!remote_node) { > + dev_err(dev, "failed to get remote node\n"); > + return -ENODEV; > + } > + > + info->role_sw = > + fwnode_usb_role_switch_get(of_fwnode_handle(remote_node)); So fwnode_usb_role_switch_get() needs be the one that walks through the graph, not the drivers. Otherwise every driver will do the same exact steps (boilerplate). Here you need to be able to just pass the node of this device, not the remote endpoint: info->role_sw = fwnode_usb_role_switch_get(dev_fwnode(&client->dev)); But why do you need that function at all? Why wouldn't usb_role_switch_get() work? info->role_sw = usb_role_switch_get(&client->dev); > + of_node_put(remote_node); > + if (IS_ERR(info->role_sw)) { > + dev_err(dev, "failed to get role switch\n"); > + return PTR_ERR(info->role_sw); > + } > + > + if (info->id_gpiod) { > + info->id_irq = gpiod_to_irq(info->id_gpiod); > + if (info->id_irq < 0) { > + dev_err(dev, "failed to get ID IRQ\n"); > + ret = info->id_irq; > + goto put_role_sw; > + } > + > + ret = devm_request_threaded_irq(dev, info->id_irq, NULL, > + usb_conn_isr, USB_CONN_IRQF, > + pdev->name, info); > + if (ret < 0) { > + dev_err(dev, "failed to request ID IRQ\n"); > + goto put_role_sw; > + } > + } > + > + if (info->vbus_gpiod) { > + info->vbus_irq = gpiod_to_irq(info->vbus_gpiod); > + if (info->vbus_irq < 0) { > + dev_err(dev, "failed to get VBUS IRQ\n"); > + ret = info->vbus_irq; > + goto put_role_sw; > + } > + > + ret = devm_request_threaded_irq(dev, info->vbus_irq, NULL, > + usb_conn_isr, USB_CONN_IRQF, > + pdev->name, info); > + if (ret < 0) { > + dev_err(dev, "failed to request VBUS IRQ\n"); > + goto put_role_sw; > + } > + } > + > + platform_set_drvdata(pdev, info); > + > + /* Perform initial detection */ > + usb_conn_queue_dwork(info, 0); > + > + return 0; > + > +put_role_sw: > + usb_role_switch_put(info->role_sw); > + return ret; > +} thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Chunfeng Yun <chunfeng.yun@mediatek.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das <biju.das@bp.renesas.com>, Badhri Jagan Sridharan <badhri@google.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, Rob Herring <robh+dt@kernel.org>, linux-mediatek@lists.infradead.org, Min Guo <min.guo@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Adam Thomson <Adam.Thomson.Opensource@diasemi.com>, linux-arm-kernel@lists.infradead.org, Li Jun <jun.li@nxp.com> Subject: Re: [PATCH v5 5/6] usb: roles: add USB Type-B GPIO connector driver Date: Mon, 20 May 2019 11:31:51 +0300 [thread overview] Message-ID: <20190520083151.GD1887@kuha.fi.intel.com> (raw) In-Reply-To: <1557823643-8616-6-git-send-email-chunfeng.yun@mediatek.com> On Tue, May 14, 2019 at 04:47:22PM +0800, Chunfeng Yun wrote: > +static int usb_conn_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > + struct device_node *remote_node; > + struct usb_conn_info *info; > + int ret = 0; > + > + info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL); > + if (!info) > + return -ENOMEM; > + > + info->dev = dev; > + info->id_gpiod = devm_gpiod_get_optional(dev, "id", GPIOD_IN); > + if (IS_ERR(info->id_gpiod)) > + return PTR_ERR(info->id_gpiod); > + > + info->vbus_gpiod = devm_gpiod_get_optional(dev, "vbus", GPIOD_IN); > + if (IS_ERR(info->vbus_gpiod)) > + return PTR_ERR(info->vbus_gpiod); > + > + if (!info->id_gpiod && !info->vbus_gpiod) { > + dev_err(dev, "failed to get gpios\n"); > + return -ENODEV; > + } > + > + if (info->id_gpiod) > + ret = gpiod_set_debounce(info->id_gpiod, USB_GPIO_DEB_US); > + if (!ret && info->vbus_gpiod) > + ret = gpiod_set_debounce(info->vbus_gpiod, USB_GPIO_DEB_US); > + if (ret < 0) > + info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEB_MS); > + > + INIT_DELAYED_WORK(&info->dw_det, usb_conn_detect_cable); > + > + info->vbus = devm_regulator_get(dev, "vbus"); > + if (IS_ERR(info->vbus)) { > + dev_err(dev, "failed to get vbus\n"); > + return PTR_ERR(info->vbus); > + } > + > + remote_node = of_graph_get_remote_node(node, -1, 0); This is really not ideal. In practice this code will only work if there is only one endpoint described for this device, or if the first endpoint is always the one we are looking for. There is no way to guarantee that. The code really has to walk through the entire graph, and identify the remote endpoint it's looking for (and for that we have the boolean device property). > + if (!remote_node) { > + dev_err(dev, "failed to get remote node\n"); > + return -ENODEV; > + } > + > + info->role_sw = > + fwnode_usb_role_switch_get(of_fwnode_handle(remote_node)); So fwnode_usb_role_switch_get() needs be the one that walks through the graph, not the drivers. Otherwise every driver will do the same exact steps (boilerplate). Here you need to be able to just pass the node of this device, not the remote endpoint: info->role_sw = fwnode_usb_role_switch_get(dev_fwnode(&client->dev)); But why do you need that function at all? Why wouldn't usb_role_switch_get() work? info->role_sw = usb_role_switch_get(&client->dev); > + of_node_put(remote_node); > + if (IS_ERR(info->role_sw)) { > + dev_err(dev, "failed to get role switch\n"); > + return PTR_ERR(info->role_sw); > + } > + > + if (info->id_gpiod) { > + info->id_irq = gpiod_to_irq(info->id_gpiod); > + if (info->id_irq < 0) { > + dev_err(dev, "failed to get ID IRQ\n"); > + ret = info->id_irq; > + goto put_role_sw; > + } > + > + ret = devm_request_threaded_irq(dev, info->id_irq, NULL, > + usb_conn_isr, USB_CONN_IRQF, > + pdev->name, info); > + if (ret < 0) { > + dev_err(dev, "failed to request ID IRQ\n"); > + goto put_role_sw; > + } > + } > + > + if (info->vbus_gpiod) { > + info->vbus_irq = gpiod_to_irq(info->vbus_gpiod); > + if (info->vbus_irq < 0) { > + dev_err(dev, "failed to get VBUS IRQ\n"); > + ret = info->vbus_irq; > + goto put_role_sw; > + } > + > + ret = devm_request_threaded_irq(dev, info->vbus_irq, NULL, > + usb_conn_isr, USB_CONN_IRQF, > + pdev->name, info); > + if (ret < 0) { > + dev_err(dev, "failed to request VBUS IRQ\n"); > + goto put_role_sw; > + } > + } > + > + platform_set_drvdata(pdev, info); > + > + /* Perform initial detection */ > + usb_conn_queue_dwork(info, 0); > + > + return 0; > + > +put_role_sw: > + usb_role_switch_put(info->role_sw); > + return ret; > +} thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-20 8:31 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 8:47 [v5 PATCH 0/6] add USB Type-B GPIO connector driver Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` [PATCH v5 1/6] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` [PATCH v5 2/6] dt-bindings: usb: add binding for Type-B GPIO connector driver Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 18:12 ` Rob Herring 2019-05-14 18:12 ` Rob Herring 2019-05-15 9:36 ` Chunfeng Yun 2019-05-15 9:36 ` Chunfeng Yun 2019-05-15 9:36 ` Chunfeng Yun 2019-05-14 8:47 ` [PATCH v5 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 18:17 ` Rob Herring 2019-05-14 18:17 ` Rob Herring 2019-05-14 18:17 ` Rob Herring 2019-05-14 8:47 ` [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-17 10:37 ` Heikki Krogerus 2019-05-17 10:37 ` Heikki Krogerus 2019-05-17 13:05 ` Heikki Krogerus 2019-05-17 13:05 ` Heikki Krogerus 2019-05-20 2:39 ` Chunfeng Yun 2019-05-20 2:39 ` Chunfeng Yun 2019-05-20 2:39 ` Chunfeng Yun 2019-05-20 8:03 ` Heikki Krogerus 2019-05-20 8:03 ` Heikki Krogerus 2019-05-20 8:06 ` Biju Das 2019-05-20 8:06 ` Biju Das 2019-05-20 8:06 ` Biju Das 2019-05-20 8:36 ` Heikki Krogerus 2019-05-20 8:36 ` Heikki Krogerus 2019-05-20 8:36 ` Heikki Krogerus 2019-05-20 9:45 ` Biju Das 2019-05-20 9:45 ` Biju Das 2019-05-20 9:45 ` Biju Das 2019-05-21 7:35 ` Chunfeng Yun 2019-05-21 7:35 ` Chunfeng Yun 2019-05-21 7:35 ` Chunfeng Yun 2019-05-21 10:33 ` Heikki Krogerus 2019-05-21 10:33 ` Heikki Krogerus 2019-05-21 10:33 ` Heikki Krogerus 2019-05-22 3:37 ` Chunfeng Yun 2019-05-22 3:37 ` Chunfeng Yun 2019-05-22 3:37 ` Chunfeng Yun 2019-05-21 9:58 ` Heikki Krogerus 2019-05-21 9:58 ` Heikki Krogerus 2019-05-21 9:58 ` Heikki Krogerus 2019-05-22 8:05 ` Biju Das 2019-05-22 8:05 ` Biju Das 2019-05-22 8:05 ` Biju Das 2019-05-22 9:30 ` Chunfeng Yun 2019-05-22 9:30 ` Chunfeng Yun 2019-05-22 9:30 ` Chunfeng Yun 2019-05-22 10:55 ` Biju Das 2019-05-22 10:55 ` Biju Das 2019-05-22 10:55 ` Biju Das 2019-05-22 14:26 ` Heikki Krogerus 2019-05-22 14:26 ` Heikki Krogerus 2019-05-22 14:26 ` Heikki Krogerus 2019-05-22 14:57 ` Biju Das 2019-05-22 14:57 ` Biju Das 2019-05-22 14:57 ` Biju Das 2019-05-24 12:44 ` Heikki Krogerus 2019-05-24 12:44 ` Heikki Krogerus 2019-05-24 12:44 ` Heikki Krogerus 2019-05-27 3:08 ` Chunfeng Yun 2019-05-27 3:08 ` Chunfeng Yun 2019-05-27 3:08 ` Chunfeng Yun 2019-05-28 6:52 ` Biju Das 2019-05-28 6:52 ` Biju Das 2019-05-28 6:52 ` Biju Das 2019-05-28 9:23 ` Chunfeng Yun 2019-05-28 9:23 ` Chunfeng Yun 2019-05-28 9:23 ` Chunfeng Yun 2019-05-23 10:16 ` Chunfeng Yun 2019-05-23 10:16 ` Chunfeng Yun 2019-05-23 10:16 ` Chunfeng Yun 2019-05-24 11:40 ` Heikki Krogerus 2019-05-24 11:40 ` Heikki Krogerus 2019-05-24 11:40 ` Heikki Krogerus 2019-05-27 3:07 ` Chunfeng Yun 2019-05-27 3:07 ` Chunfeng Yun 2019-05-27 3:07 ` Chunfeng Yun 2019-05-27 10:45 ` Heikki Krogerus 2019-05-27 10:45 ` Heikki Krogerus 2019-05-27 10:45 ` Heikki Krogerus 2019-05-14 8:47 ` [PATCH v5 5/6] usb: roles: add USB Type-B GPIO connector driver Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-20 8:31 ` Heikki Krogerus [this message] 2019-05-20 8:31 ` Heikki Krogerus 2019-05-21 7:44 ` Chunfeng Yun 2019-05-21 7:44 ` Chunfeng Yun 2019-05-21 7:44 ` Chunfeng Yun 2019-05-14 8:47 ` [PATCH v5 6/6] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun 2019-05-14 8:47 ` Chunfeng Yun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190520083151.GD1887@kuha.fi.intel.com \ --to=heikki.krogerus@linux.intel.com \ --cc=Adam.Thomson.Opensource@diasemi.com \ --cc=andy.shevchenko@gmail.com \ --cc=badhri@google.com \ --cc=biju.das@bp.renesas.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=jun.li@nxp.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=min.guo@mediatek.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.