From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Robin Murphy" <robin.murphy@arm.com>,
"Christoph Hellwig" <hch@lst.de>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com
Subject: Re: [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE
Date: Thu, 23 May 2019 18:43:32 +0200 [thread overview]
Message-ID: <20190523164332.GA22245@lst.de> (raw)
In-Reply-To: <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com>
On Thu, May 23, 2019 at 07:35:07AM +0200, Marek Szyprowski wrote:
> Don't we have DMA_BIDIRECTIONAL for such case?
Not sure if it was intended for that case, but it definitively should
do the right thing for swiotlb, and it should also do the right thing
in terms of cache maintainance.
> Maybe we should update
> documentation a bit to point that DMA_FROM_DEVICE expects the whole
> buffer to be filled by the device?
Probably. Horia, can you try to use DMA_BIDIRECTIONAL?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-imx@nxp.com, "Robin Murphy" <robin.murphy@arm.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE
Date: Thu, 23 May 2019 18:43:32 +0200 [thread overview]
Message-ID: <20190523164332.GA22245@lst.de> (raw)
In-Reply-To: <0c79721a-11cb-c945-5626-3d43cc299fe6@samsung.com>
On Thu, May 23, 2019 at 07:35:07AM +0200, Marek Szyprowski wrote:
> Don't we have DMA_BIDIRECTIONAL for such case?
Not sure if it was intended for that case, but it definitively should
do the right thing for swiotlb, and it should also do the right thing
in terms of cache maintainance.
> Maybe we should update
> documentation a bit to point that DMA_FROM_DEVICE expects the whole
> buffer to be filled by the device?
Probably. Horia, can you try to use DMA_BIDIRECTIONAL?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-05-23 16:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 7:20 [PATCH] swiotlb: sync buffer when mapping FROM_DEVICE Horia Geantă
2019-05-22 7:20 ` Horia Geantă
2019-05-22 12:32 ` Christoph Hellwig
2019-05-22 12:32 ` Christoph Hellwig
2019-05-22 12:50 ` Robin Murphy
2019-05-22 12:50 ` Robin Murphy
2019-05-22 13:09 ` Christoph Hellwig
2019-05-22 13:09 ` Christoph Hellwig
2019-05-22 13:25 ` Robin Murphy
2019-05-22 13:25 ` Robin Murphy
2019-05-22 13:34 ` Christoph Hellwig
2019-05-22 13:34 ` Christoph Hellwig
2019-05-22 13:55 ` Robin Murphy
2019-05-22 13:55 ` Robin Murphy
2019-05-23 5:35 ` Marek Szyprowski
2019-05-23 5:35 ` Marek Szyprowski
2019-05-23 16:25 ` Horia Geanta
2019-05-23 16:25 ` Horia Geanta
2019-05-23 16:43 ` Christoph Hellwig [this message]
2019-05-23 16:43 ` Christoph Hellwig
2019-05-23 17:53 ` Horia Geanta
2019-05-23 17:53 ` Horia Geanta
2019-05-23 18:05 ` Robin Murphy
2019-05-23 18:05 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523164332.GA22245@lst.de \
--to=hch@lst.de \
--cc=horia.geanta@nxp.com \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.