[Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite

[Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite

[Raul Hidalgo Caballero]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190527/3d1e7d25/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-package-libnfc-support-pcsc-lite.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190527/3d1e7d25/attachment.bin>

[Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite

[Thomas Petazzoni]

Hello,

On Mon, 27 May 2019 10:27:03 +0200
Raul Hidalgo Caballero <deinok@deinok.com> wrote:

> 

Here as well: please send with git send-email so that we can do a
proper review.

A few comments though:

 - We need you to use your real name as the patch author and for the
   Signed-off-by line

 - Why are you making pcsc-lite a mandatory dependency of libnfc ?
   Since libnfc builds fine today with pcsc-lite, it means it should be
   an optional dependency. Either add a sub-option to enable the
   different libnfc drivers, or automatically add pcsc-lite to the
   dependencies if BR2_PACKAGE_PCSC_LITE=y.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite

[Thomas Petazzoni]

Hello Raul,

On Mon, 27 May 2019 11:15:50 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Here as well: please send with git send-email so that we can do a
> proper review.
> 
> A few comments though:
> 
>  - We need you to use your real name as the patch author and for the
>    Signed-off-by line
> 
>  - Why are you making pcsc-lite a mandatory dependency of libnfc ?
>    Since libnfc builds fine today with pcsc-lite, it means it should be
>    an optional dependency. Either add a sub-option to enable the
>    different libnfc drivers, or automatically add pcsc-lite to the
>    dependencies if BR2_PACKAGE_PCSC_LITE=y.

I just wanted to make sure that you have seen my comments on this
patch. I'm marking it as "Changes Requested" in our patch tracking
system. Therefore, if you don't send an updated version of the patch,
we will forget about it.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com