Re: [PATCH 1/5] pci: use pci_sbdf_t in pci_dev

From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Brian Woods <brian.woods@amd.com>
Subject: Re: [PATCH 1/5] pci: use pci_sbdf_t in pci_dev
Date: Mon, 27 May 2019 17:51:43 +0200	[thread overview]
Message-ID: <20190527155143.khxljfjmq5lsdxxa@Air-de-Roger> (raw)
In-Reply-To: <5CE6BC680200007800231C8F@prv1-mh.provo.novell.com>

On Thu, May 23, 2019 at 09:29:44AM -0600, Jan Beulich wrote:
> >>> On 10.05.19 at 18:10, <roger.pau@citrix.com> wrote:
> > --- a/xen/include/xen/pci.h
> > +++ b/xen/include/xen/pci.h
> > @@ -80,9 +80,8 @@ struct pci_dev {
> >      struct arch_msix *msix;
> >  
> >      struct domain *domain;
> > -    const u16 seg;
> > -    const u8 bus;
> > -    const u8 devfn;
> > +
> > +    const pci_sbdf_t sbdf;
> 
> To help the transition, did you consider first making this a union of
> the existing fields and the new one, next replacing used in a per
> component manner (so that individual maintainers would have to
> look at smaller patches each only), and finally dropping the union
> and its old fields?

No, that didn't occur to me and it's indeed likely to make this much
less painful. My plan was to switch this in one go ad done in this
series, but using such union would allow for smaller patches.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel