From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 2/5] pci: use function generation macros for pci_config_{write, read}<size>
Date: Fri, 24 May 2019 10:29:26 +0100 [thread overview]
Message-ID: <cdc13026-212f-65a0-0fdf-a6bcb919de0e@citrix.com> (raw)
In-Reply-To: <20190510161056.48648-3-roger.pau@citrix.com>
On 10/05/2019 17:10, Roger Pau Monne wrote:
> This avoids code duplication between the helpers.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
-1. I see this as actively making the code worse, not an improvement.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH 2/5] pci: use function generation macros for pci_config_{write, read}<size>
Date: Fri, 24 May 2019 10:29:26 +0100 [thread overview]
Message-ID: <cdc13026-212f-65a0-0fdf-a6bcb919de0e@citrix.com> (raw)
Message-ID: <20190524092926.DIh1wi4gJxVcfvuEh9NsO8nNznLqFVC2A8NK-W_L7KA@z> (raw)
In-Reply-To: <20190510161056.48648-3-roger.pau@citrix.com>
On 10/05/2019 17:10, Roger Pau Monne wrote:
> This avoids code duplication between the helpers.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
-1. I see this as actively making the code worse, not an improvement.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-24 9:29 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 16:10 [PATCH 0/5] pci: expand usage of pci_sbdf_t Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-10 16:10 ` [PATCH 1/5] pci: use pci_sbdf_t in pci_dev Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-10 16:16 ` Andrew Cooper
2019-05-10 16:16 ` [Xen-devel] " Andrew Cooper
2019-05-13 6:25 ` Jan Beulich
2019-05-13 6:25 ` [Xen-devel] " Jan Beulich
2019-05-13 7:53 ` Roger Pau Monné
2019-05-13 7:53 ` [Xen-devel] " Roger Pau Monné
2019-05-23 15:29 ` Jan Beulich
2019-05-23 15:29 ` [Xen-devel] " Jan Beulich
2019-05-27 15:51 ` Roger Pau Monné
2019-05-27 15:51 ` [Xen-devel] " Roger Pau Monné
2019-05-10 16:10 ` [PATCH 2/5] pci: use function generation macros for pci_config_{write, read}<size> Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-24 9:10 ` Jan Beulich
2019-05-24 9:10 ` [Xen-devel] " Jan Beulich
2019-05-24 9:29 ` Andrew Cooper [this message]
2019-05-24 9:29 ` Andrew Cooper
2019-05-27 16:08 ` Roger Pau Monné
2019-05-27 16:08 ` [Xen-devel] " Roger Pau Monné
2019-05-28 8:54 ` Jan Beulich
2019-05-28 8:54 ` [Xen-devel] " Jan Beulich
2019-05-10 16:10 ` [PATCH 3/5] pci: switch pci_conf_{read/write} to use pci_sbdf_t Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-24 9:40 ` Andrew Cooper
2019-05-24 9:40 ` [Xen-devel] " Andrew Cooper
2019-05-24 10:01 ` Jan Beulich
2019-05-24 10:01 ` [Xen-devel] " Jan Beulich
2019-05-27 16:44 ` Roger Pau Monné
2019-05-27 16:44 ` [Xen-devel] " Roger Pau Monné
2019-05-28 8:51 ` Jan Beulich
2019-05-28 8:51 ` [Xen-devel] " Jan Beulich
2019-05-28 10:05 ` Roger Pau Monné
2019-05-28 10:05 ` [Xen-devel] " Roger Pau Monné
2019-05-28 10:38 ` Jan Beulich
2019-05-28 10:38 ` [Xen-devel] " Jan Beulich
2019-05-10 16:10 ` [PATCH 4/5] print: introduce a format specifier for pci_sbdf_t Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-24 10:36 ` Jan Beulich
2019-05-24 10:36 ` [Xen-devel] " Jan Beulich
2019-05-24 10:59 ` Andrew Cooper
2019-05-24 10:59 ` [Xen-devel] " Andrew Cooper
2019-05-24 11:16 ` Jan Beulich
2019-05-24 11:16 ` [Xen-devel] " Jan Beulich
2019-05-27 15:48 ` Roger Pau Monné
2019-05-27 15:48 ` [Xen-devel] " Roger Pau Monné
2019-05-27 15:58 ` Jan Beulich
2019-05-27 15:58 ` [Xen-devel] " Jan Beulich
2019-05-10 16:10 ` [PATCH 5/5] pci: switch PCI capabilities related functions to use pci_sbdf_t Roger Pau Monne
2019-05-10 16:10 ` [Xen-devel] " Roger Pau Monne
2019-05-24 10:52 ` Jan Beulich
2019-05-24 10:52 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc13026-212f-65a0-0fdf-a6bcb919de0e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.