All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv6 0/4] omapdrm: DSI command mode panel support
@ 2019-05-23 20:07 Sebastian Reichel
  2019-05-23 20:07 ` [PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE Sebastian Reichel
                   ` (4 more replies)
  0 siblings, 5 replies; 34+ messages in thread
From: Sebastian Reichel @ 2019-05-23 20:07 UTC (permalink / raw)
  To: Sebastian Reichel, Tomi Valkeinen, Tony Lindgren, Pavel Machek,
	Laurent Pinchart
  Cc: H. Nikolaus Schaller, dri-devel, linux-omap, linux-kernel,
	kernel, Sebastian Reichel

Hi,

Here is another round of the DSI command mode panel patchset
integrating the feedback from PATCHv5. The patches are based
on v5.2-rc1 tag. It does not contain the patches required for
OMAP3 support (it needs a workaround for a hardware bug) and
for automatic display rotation. They should get their own series,
once after everything has been moved to DRM panel API. I think
DRM panel conversion should happen _after_ this series, since
otherwise there is a high risk of bricking DSI support completely.
I already started a WIP branch for converting DSI to the DRM panel
API on top of this patchset.

Tested on Droid 4:
 * Display blanking
  - automatic backlight blanking is missing (not handled by DSI)
 * Framebuffer Console, updated at 1Hz due to blinking cursor
 * Xorg 1.19 with modesetting driver
 * Weston 5.0 with DRM backend
 * kmstest (static image)
 * No updates send when nothing needs to be sent

Known issues:
 * OMAP3 is untested and most likely broken due to missing
   workaround(s) for hardware bugs.
 * Weston 5.0 with fbdev backend does not work, since it
   uses neither page flip nor dirty ioctl. You need to use
   the drm backend.

Changes since PATCHv5:
 * Rebased to v5.2-rc1
 * Simplified omap_framebuffer_dirty() by using
   drm_for_each_crtc()

Changes since PATCHv4:
 * Apply Acked-/Tested-by received from Tony and Pavel
 * Fix spelling/optimize commit messages
 * Use proper multi-line comments
 * Restructure patch 4: move the whole HDMI block into a
   static subfunction, that is only called when output
   type is HDMI. Also drop the incorrect check for DVI.

Changes since PATCHv3:
 * Drop all Tested/Acked-by tags
 * Drop the rotation patches for now
 * Rebase to 4.20-rc1 + fixes from Laurent and Tony
 * Add fixes for DSI regressions introduced in 4.20-rc1
 * Store info update manual update mode in omap_crtc_state
 * Lock modesetting in omap_framebuffer_dirty
 * Directly loop through CRTCs instead of connectors in dirty function
 * Properly refresh display during page flips and get Weston working
 * Add more comments about implementation details

Changes since PATCHv2:
 * Drop omap3 quirk patch (OMAP3 should get its own mini-series)
 * Rebase to current linux-next
 * Use existing 'rotation' DT property to set DRM orientation hint
 * Add Tested-by from Tony

Changes since PATCHv1:
 * Drop patches, that were queued by Tomi
 * Rebase to current master
 * Rework the omap3 workaround patch to only affect omap3
 * Add orientation DRM property support

-- Sebastian

Sebastian Reichel (4):
  drm/omap: use DRM_DEBUG_DRIVER instead of CORE
  drm/omap: don't check dispc timings for DSI
  drm/omap: add framedone interrupt support
  drm/omap: add support for manually updated displays

 drivers/gpu/drm/omapdrm/omap_crtc.c | 182 ++++++++++++++++++++++++++--
 drivers/gpu/drm/omapdrm/omap_crtc.h |   2 +
 drivers/gpu/drm/omapdrm/omap_drv.h  |   4 +-
 drivers/gpu/drm/omapdrm/omap_fb.c   |  19 +++
 drivers/gpu/drm/omapdrm/omap_irq.c  |  25 ++++
 drivers/gpu/drm/omapdrm/omap_irq.h  |   1 +
 6 files changed, 222 insertions(+), 11 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 34+ messages in thread
* Re: [PATCHv5 0/6] omapdrm: DSI command mode panel support
@ 2019-04-03 19:54 Sebastian Reichel
  2019-04-03 20:13 ` [PATCHv6 0/4] " Sebastian Reichel
  0 siblings, 1 reply; 34+ messages in thread
From: Sebastian Reichel @ 2019-04-03 19:54 UTC (permalink / raw)
  To: Laurent Pinchart, Tomi Valkeinen
  Cc: kernel, Tony Lindgren, H. Nikolaus Schaller, dri-devel,
	Pavel Machek, linux-omap, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]

Hi Tomi & Laurent,

On Tue, Apr 02, 2019 at 06:55:08PM +0300, Laurent Pinchart wrote:
> On Tue, Apr 02, 2019 at 06:36:21PM +0300, Tomi Valkeinen wrote:
> > On 21/11/2018 18:09, Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > Here is another round of the DSI command mode panel patchset
> > > integrating the feedback from PATCHv4. The patches are based
> > > on 4.20-rc1 + fixes from Laurent and Tony. I dropped the patches
> > > for OMAP3 support (it needs a workaround for a hardware bug) and
> > > for automatic display rotation. They should get their own series,
> > > once this patchset has landed.
> > 
> > The big omapdrm bridge/panel series from Laurent has been merged to
> > drm-next. I think this series can now be rebased and merged.
> > 
> > However, all this needs to be changed to DRM bridge/panel model sooner
> > or later (sooner, please!), but perhaps it's best to first go with the
> > legacy way.
> 
> I would be OK with that, but I'd like to understand what we still need
> to do to convert DSI support to DRM bridge and panel. Sebastian, if
> you've looked into it, could you provide some insight ?

I have a rebased & tested version of the patches getting the Droid 4
panel working in this branch (together with 2 patches adding
backlight support for testing purposes). I will send it as a patch
series in a few minutes.

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-n900.git/log/?h=omapdrm-5.2-with-dsi

I also had a look at converting to DRM bridge/panel model and
started working on it in the following branch. It's completley
untested and probably not working at all. Also the most recent
patches are not yet properly splitted / formated. But they show
my idea of how this can be achieved:

1. Add DSI transfer() function
2. Convert custom functions to use transfer() instead
3. Convert to use mipi_dsi_host
4. Get rid of custom DSI related omapdss functions
5. at this point panel conversion can hopefully happen the
   same way as for the other modules

https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-n900.git/log/?h=omapdrm-5.2-with-dsi-untested-work-branch

P.S.: I will continue to work on this, but probably not in
the next 4 weeks. I'm currently very busy with non-kernel
tasks and still have to review > 200 power-supply patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 34+ messages in thread

end of thread, other threads:[~2019-06-03  8:29 UTC | newest]

Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 20:07 [PATCHv6 0/4] omapdrm: DSI command mode panel support Sebastian Reichel
2019-05-23 20:07 ` [PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE Sebastian Reichel
2019-05-23 20:19   ` Joe Perches
2019-05-23 20:07 ` [PATCHv6 2/4] drm/omap: don't check dispc timings for DSI Sebastian Reichel
2019-05-23 20:07 ` [PATCHv6 3/4] drm/omap: add framedone interrupt support Sebastian Reichel
2019-05-28 10:19   ` Tomi Valkeinen
2019-05-28 10:19     ` Tomi Valkeinen
2019-05-29 21:55     ` Sebastian Reichel
2019-05-31 12:23       ` Tomi Valkeinen
2019-05-31 12:23         ` Tomi Valkeinen
2019-05-23 20:07 ` [PATCHv6 4/4] drm/omap: add support for manually updated displays Sebastian Reichel
2019-05-27 10:51 ` [PATCHv6 0/4] omapdrm: DSI command mode panel support Tomi Valkeinen
2019-05-27 10:51   ` Tomi Valkeinen
2019-05-27 11:21   ` Tony Lindgren
2019-05-28  9:19     ` Tomi Valkeinen
2019-05-28  9:19       ` Tomi Valkeinen
2019-05-28  9:39       ` Tony Lindgren
2019-05-28  9:51         ` Keerthy
2019-05-28  9:51           ` Keerthy
2019-05-28 10:05         ` Tomi Valkeinen
2019-05-28 10:05           ` Tomi Valkeinen
2019-05-28 10:18           ` Tony Lindgren
2019-05-28 10:32             ` Tomi Valkeinen
2019-05-28 10:32               ` Tomi Valkeinen
2019-05-29  9:33               ` Peter Ujfalusi
2019-05-29  9:33                 ` Peter Ujfalusi
2019-05-29  7:06             ` Tomi Valkeinen
2019-05-29  7:06               ` Tomi Valkeinen
2019-05-29  8:10               ` Tony Lindgren
2019-05-30  5:46                 ` Tony Lindgren
2019-05-30  7:02                   ` Tony Lindgren
2019-06-03  8:29     ` Pavel Machek
2019-06-03  8:29       ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2019-04-03 19:54 [PATCHv5 0/6] " Sebastian Reichel
2019-04-03 20:13 ` [PATCHv6 0/4] " Sebastian Reichel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.