Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions

From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: wsa@the-dreams.de, jarkko.nikula@linux.intel.com,
	andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	benjamin.tissoires@redhat.com, jbroadus@gmail.com,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions
Date: Tue, 28 May 2019 13:30:28 +0300	[thread overview]
Message-ID: <20190528103028.GA2781@lahna.fi.intel.com> (raw)
In-Reply-To: <20190527151932.14310-2-ckeepax@opensource.cirrus.com>

On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote:
>  static int i2c_acpi_get_info(struct acpi_device *adev,
>  			     struct i2c_board_info *info,
>  			     struct i2c_adapter *adapter,
>  			     acpi_handle *adapter_handle)
>  {
>  	struct list_head resource_list;
> -	struct resource_entry *entry;
>  	struct i2c_acpi_lookup lookup;
> +	int irq = -ENOENT;
>  	int ret;
>  
>  	memset(&lookup, 0, sizeof(lookup));
> @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
>  
>  	/* Then fill IRQ number if any */
>  	INIT_LIST_HEAD(&resource_list);
> -	ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL);
> +	ret = acpi_dev_get_resources(adev, &resource_list,
> +				     i2c_acpi_add_resource, &irq);
>  	if (ret < 0)
>  		return -EINVAL;
>  
> -	resource_list_for_each_entry(entry, &resource_list) {
> -		if (resource_type(entry->res) == IORESOURCE_IRQ) {
> -			info->irq = entry->res->start;
> -			break;
> -		}
> -	}
> +	if (irq >= 0)

Since 0 is not valid IRQ, I think this should be written like:

	if (irg > 0)

> +		info->irq = irq;
>  
>  	acpi_dev_free_resource_list(&resource_list);
>  
> -- 
> 2.11.0