From: Charles Keepax <ckeepax@opensource.cirrus.com> To: <wsa@the-dreams.de>, <mika.westerberg@linux.intel.com> Cc: <jarkko.nikula@linux.intel.com>, <andriy.shevchenko@linux.intel.com>, <linux-i2c@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <benjamin.tissoires@redhat.com>, <jbroadus@gmail.com>, <patches@opensource.cirrus.com> Subject: [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Date: Mon, 27 May 2019 16:19:32 +0100 [thread overview] Message-ID: <20190527151932.14310-6-ckeepax@opensource.cirrus.com> (raw) In-Reply-To: <20190527151932.14310-1-ckeepax@opensource.cirrus.com> Only set init_irq during i2c_device_new and only handle client->irq on the probe/remove paths. Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- No changes since v1. Thanks, Charles drivers/i2c/i2c-core-base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 684ea2665d994..6d4904cdf58ac 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -322,6 +322,8 @@ static int i2c_device_probe(struct device *dev) driver = to_i2c_driver(dev->driver); + client->irq = client->init_irq; + if (!client->irq && !driver->disable_i2c_core_irq_mapping) { int irq = -ENOENT; @@ -432,7 +434,7 @@ static int i2c_device_remove(struct device *dev) dev_pm_clear_wake_irq(&client->dev); device_init_wakeup(&client->dev, false); - client->irq = client->init_irq; + client->irq = 0; if (client->flags & I2C_CLIENT_HOST_NOTIFY) pm_runtime_put(&client->adapter->dev); @@ -749,7 +751,6 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf if (!client->init_irq) client->init_irq = i2c_dev_irq_from_resources(info->resources, info->num_resources); - client->irq = client->init_irq; strlcpy(client->name, info->type, sizeof(client->name)); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com> To: wsa@the-dreams.de, mika.westerberg@linux.intel.com Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Date: Mon, 27 May 2019 16:19:32 +0100 [thread overview] Message-ID: <20190527151932.14310-6-ckeepax@opensource.cirrus.com> (raw) In-Reply-To: <20190527151932.14310-1-ckeepax@opensource.cirrus.com> Only set init_irq during i2c_device_new and only handle client->irq on the probe/remove paths. Suggested-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- No changes since v1. Thanks, Charles drivers/i2c/i2c-core-base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 684ea2665d994..6d4904cdf58ac 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -322,6 +322,8 @@ static int i2c_device_probe(struct device *dev) driver = to_i2c_driver(dev->driver); + client->irq = client->init_irq; + if (!client->irq && !driver->disable_i2c_core_irq_mapping) { int irq = -ENOENT; @@ -432,7 +434,7 @@ static int i2c_device_remove(struct device *dev) dev_pm_clear_wake_irq(&client->dev); device_init_wakeup(&client->dev, false); - client->irq = client->init_irq; + client->irq = 0; if (client->flags & I2C_CLIENT_HOST_NOTIFY) pm_runtime_put(&client->adapter->dev); @@ -749,7 +751,6 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf if (!client->init_irq) client->init_irq = i2c_dev_irq_from_resources(info->resources, info->num_resources); - client->irq = client->init_irq; strlcpy(client->name, info->type, sizeof(client->name)); -- 2.11.0
next prev parent reply other threads:[~2019-05-27 15:20 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-28 10:30 ` Mika Westerberg 2019-05-28 11:13 ` Charles Keepax 2019-05-28 11:13 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-28 8:37 ` Charles Keepax 2019-05-28 8:37 ` Charles Keepax 2019-05-28 10:35 ` Mika Westerberg 2019-05-27 15:19 ` [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` Charles Keepax [this message] 2019-05-27 15:19 ` [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190527151932.14310-6-ckeepax@opensource.cirrus.com \ --to=ckeepax@opensource.cirrus.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=benjamin.tissoires@redhat.com \ --cc=jarkko.nikula@linux.intel.com \ --cc=jbroadus@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=patches@opensource.cirrus.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.