From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: <wsa@the-dreams.de>, <jarkko.nikula@linux.intel.com>, <andriy.shevchenko@linux.intel.com>, <linux-i2c@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <benjamin.tissoires@redhat.com>, <jbroadus@gmail.com>, <patches@opensource.cirrus.com> Subject: Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Date: Tue, 28 May 2019 12:13:08 +0100 [thread overview] Message-ID: <20190528111308.GF28362@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <20190528103028.GA2781@lahna.fi.intel.com> On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote: > On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote: > > static int i2c_acpi_get_info(struct acpi_device *adev, > > struct i2c_board_info *info, > > struct i2c_adapter *adapter, > > acpi_handle *adapter_handle) > > { > > struct list_head resource_list; > > - struct resource_entry *entry; > > struct i2c_acpi_lookup lookup; > > + int irq = -ENOENT; > > int ret; > > > > memset(&lookup, 0, sizeof(lookup)); > > @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev, > > > > /* Then fill IRQ number if any */ > > INIT_LIST_HEAD(&resource_list); > > - ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > > + ret = acpi_dev_get_resources(adev, &resource_list, > > + i2c_acpi_add_resource, &irq); > > if (ret < 0) > > return -EINVAL; > > > > - resource_list_for_each_entry(entry, &resource_list) { > > - if (resource_type(entry->res) == IORESOURCE_IRQ) { > > - info->irq = entry->res->start; > > - break; > > - } > > - } > > + if (irq >= 0) > > Since 0 is not valid IRQ, I think this should be written like: > > if (irg > 0) > Yeah sorry thought IRQs were like GPIOs where 0 is a valid number, will update the patches. Thanks, Charles > > + info->irq = irq; > > > > acpi_dev_free_resource_list(&resource_list); > > > > -- > > 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: wsa@the-dreams.de, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Date: Tue, 28 May 2019 12:13:08 +0100 [thread overview] Message-ID: <20190528111308.GF28362@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <20190528103028.GA2781@lahna.fi.intel.com> On Tue, May 28, 2019 at 01:30:28PM +0300, Mika Westerberg wrote: > On Mon, May 27, 2019 at 04:19:28PM +0100, Charles Keepax wrote: > > static int i2c_acpi_get_info(struct acpi_device *adev, > > struct i2c_board_info *info, > > struct i2c_adapter *adapter, > > acpi_handle *adapter_handle) > > { > > struct list_head resource_list; > > - struct resource_entry *entry; > > struct i2c_acpi_lookup lookup; > > + int irq = -ENOENT; > > int ret; > > > > memset(&lookup, 0, sizeof(lookup)); > > @@ -176,16 +187,13 @@ static int i2c_acpi_get_info(struct acpi_device *adev, > > > > /* Then fill IRQ number if any */ > > INIT_LIST_HEAD(&resource_list); > > - ret = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > > + ret = acpi_dev_get_resources(adev, &resource_list, > > + i2c_acpi_add_resource, &irq); > > if (ret < 0) > > return -EINVAL; > > > > - resource_list_for_each_entry(entry, &resource_list) { > > - if (resource_type(entry->res) == IORESOURCE_IRQ) { > > - info->irq = entry->res->start; > > - break; > > - } > > - } > > + if (irq >= 0) > > Since 0 is not valid IRQ, I think this should be written like: > > if (irg > 0) > Yeah sorry thought IRQs were like GPIOs where 0 is a valid number, will update the patches. Thanks, Charles > > + info->irq = irq; > > > > acpi_dev_free_resource_list(&resource_list); > > > > -- > > 2.11.0
next prev parent reply other threads:[~2019-05-28 11:14 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-27 15:19 [PATCH v2 1/6] i2c: core: Allow whole core to use i2c_dev_irq_from_resources Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 2/6] i2c: acpi: Use available IRQ helper functions Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-28 10:30 ` Mika Westerberg 2019-05-28 11:13 ` Charles Keepax [this message] 2019-05-28 11:13 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 3/6] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-28 8:37 ` Charles Keepax 2019-05-28 8:37 ` Charles Keepax 2019-05-28 10:35 ` Mika Westerberg 2019-05-27 15:19 ` [PATCH v2 4/6] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 5/6] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax 2019-05-27 15:19 ` Charles Keepax 2019-05-27 15:19 ` [PATCH v2 6/6] i2c: core: Tidy up handling of init_irq Charles Keepax 2019-05-27 15:19 ` Charles Keepax
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190528111308.GF28362@ediswmail.ad.cirrus.com \ --to=ckeepax@opensource.cirrus.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=benjamin.tissoires@redhat.com \ --cc=jarkko.nikula@linux.intel.com \ --cc=jbroadus@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mika.westerberg@linux.intel.com \ --cc=patches@opensource.cirrus.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.