All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: CK Hu <ck.hu@mediatek.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] drm: mediatek: fix unbind functions
Date: Wed, 29 May 2019 18:25:52 +0800	[thread overview]
Message-ID: <20190529102555.251579-2-hsinyi@chromium.org> (raw)
In-Reply-To: <20190529102555.251579-1-hsinyi@chromium.org>

detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
attach it again.

Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* mipi_dsi_host_unregister() should be fixed in another patch on the list.
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index b00eb2d2e086..1ae3be99e0ff 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
 	/* Skip connector cleanup if creation was delegated to the bridge */
 	if (dsi->conn.dev)
 		drm_connector_cleanup(&dsi->conn);
+	if (dsi->panel)
+		drm_panel_detach(dsi->panel);
 }
 
 static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>, CK Hu <ck.hu@mediatek.com>
Subject: [PATCH v2 1/4] drm: mediatek: fix unbind functions
Date: Wed, 29 May 2019 18:25:52 +0800	[thread overview]
Message-ID: <20190529102555.251579-2-hsinyi@chromium.org> (raw)
In-Reply-To: <20190529102555.251579-1-hsinyi@chromium.org>

detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to
attach it again.

Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
change log v1->v2:
* mipi_dsi_host_unregister() should be fixed in another patch on the list.
---
 drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index b00eb2d2e086..1ae3be99e0ff 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi)
 	/* Skip connector cleanup if creation was delegated to the bridge */
 	if (dsi->conn.dev)
 		drm_connector_cleanup(&dsi->conn);
+	if (dsi->panel)
+		drm_panel_detach(dsi->panel);
 }
 
 static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-29 10:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 10:25 [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind Hsin-Yi Wang
2019-05-29 10:25 ` Hsin-Yi Wang
2019-05-29 10:25 ` Hsin-Yi Wang [this message]
2019-05-29 10:25   ` [PATCH v2 1/4] drm: mediatek: fix unbind functions Hsin-Yi Wang
2019-05-30  2:13   ` CK Hu
2019-05-30  2:13     ` CK Hu
2019-05-30  2:13     ` CK Hu
2019-05-29 10:25 ` [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind() Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:17   ` CK Hu
2019-05-30  2:17     ` CK Hu
2019-05-30  2:17     ` CK Hu
2019-05-29 10:25 ` [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:22   ` CK Hu
2019-05-30  2:22     ` CK Hu
2019-05-30  2:22     ` CK Hu
2019-05-29 10:25 ` [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:28   ` CK Hu
2019-05-30  2:28     ` CK Hu
2019-05-30  2:28     ` CK Hu
2019-06-04  1:33 ` [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind CK Hu
2019-06-04  1:33   ` CK Hu
2019-06-04  1:33   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529102555.251579-2-hsinyi@chromium.org \
    --to=hsinyi@chromium.org \
    --cc=airlied@linux.ie \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.