All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: CK Hu <ck.hu@mediatek.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
Date: Wed, 29 May 2019 18:25:55 +0800	[thread overview]
Message-ID: <20190529102555.251579-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20190529102555.251579-1-hsinyi@chromium.org>

num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
don't clear num_pipes count, when rebinding driver, the count will
be accumulated. From mtk_disp_mutex_get(), there can only be at most
10 mutex id. Clear this number so it starts from 0 in every rebind.

Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 8718d123ccaa..bbfe3a464aea 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
 	drm_dev_unregister(private->drm);
 	mtk_drm_kms_deinit(private->drm);
 	drm_dev_put(private->drm);
+	private->num_pipes = 0;
 	private->drm = NULL;
 }
 
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Hsin-Yi Wang <hsinyi@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>, CK Hu <ck.hu@mediatek.com>
Subject: [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver
Date: Wed, 29 May 2019 18:25:55 +0800	[thread overview]
Message-ID: <20190529102555.251579-5-hsinyi@chromium.org> (raw)
In-Reply-To: <20190529102555.251579-1-hsinyi@chromium.org>

num_pipes is used for mutex created in mtk_drm_crtc_create(). If we
don't clear num_pipes count, when rebinding driver, the count will
be accumulated. From mtk_disp_mutex_get(), there can only be at most
10 mutex id. Clear this number so it starts from 0 in every rebind.

Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 8718d123ccaa..bbfe3a464aea 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -400,6 +400,7 @@ static void mtk_drm_unbind(struct device *dev)
 	drm_dev_unregister(private->drm);
 	mtk_drm_kms_deinit(private->drm);
 	drm_dev_put(private->drm);
+	private->num_pipes = 0;
 	private->drm = NULL;
 }
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-05-29 10:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 10:25 [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind Hsin-Yi Wang
2019-05-29 10:25 ` Hsin-Yi Wang
2019-05-29 10:25 ` [PATCH v2 1/4] drm: mediatek: fix unbind functions Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:13   ` CK Hu
2019-05-30  2:13     ` CK Hu
2019-05-30  2:13     ` CK Hu
2019-05-29 10:25 ` [PATCH v2 2/4] drm: mediatek: unbind components in mtk_drm_unbind() Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:17   ` CK Hu
2019-05-30  2:17     ` CK Hu
2019-05-30  2:17     ` CK Hu
2019-05-29 10:25 ` [PATCH v2 3/4] drm: mediatek: call drm_atomic_helper_shutdown() when unbinding driver Hsin-Yi Wang
2019-05-29 10:25   ` Hsin-Yi Wang
2019-05-30  2:22   ` CK Hu
2019-05-30  2:22     ` CK Hu
2019-05-30  2:22     ` CK Hu
2019-05-29 10:25 ` Hsin-Yi Wang [this message]
2019-05-29 10:25   ` [PATCH v2 4/4] drm: mediatek: clear num_pipes when unbind driver Hsin-Yi Wang
2019-05-30  2:28   ` CK Hu
2019-05-30  2:28     ` CK Hu
2019-05-30  2:28     ` CK Hu
2019-06-04  1:33 ` [PATCH v2 0/4] fix mediatek drm, dis, and disp-* unbind/bind CK Hu
2019-06-04  1:33   ` CK Hu
2019-06-04  1:33   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529102555.251579-5-hsinyi@chromium.org \
    --to=hsinyi@chromium.org \
    --cc=airlied@linux.ie \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.