From: David Sterba <dsterba@suse.cz>
To: David Gstir <david@sigma-star.at>
Cc: Johannes Thumshirn <jthumshirn@suse.de>, Chris Mason <clm@fb.com>,
Richard Weinberger <richard@nod.at>,
Nikolay Borisov <nborisov@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 11/13] btrfs: directly call into crypto framework for checsumming
Date: Thu, 30 May 2019 12:14:01 +0200 [thread overview]
Message-ID: <20190530101401.GB15290@suse.cz> (raw)
In-Reply-To: <13AD00D3-9804-4C6A-BF98-CCED1C974EF5@sigma-star.at>
On Wed, May 29, 2019 at 09:32:59PM +0200, David Gstir wrote:
> If you aim for using as many of the hardware drivers as possible,
> it might be better to use the ahash API, since some drivers
> (eg. CAAM on NXP's i.MX) only implement that API and not shash.
> Looking at crypto_ahash_init_tfm(...) in crypto/ahash.c using
> drivers that implement shash through the ahash API should work
> fine though.
>
> I just found that out myself today [1]. ;)
>
> - David
>
> [1] https://lore.kernel.org/linux-crypto/729A4150-93A0-456B-B7AB-6D3A446E600E@sigma-star.at/T/#u
The thread says otherwise. Using SHASH interface for AHASH does not
work. Besides checksumming in btrfs is called from atomic contexts so
the sleeping part of the async API can't work at all (crypto_wait_req
indirectly calls schedule).
next prev parent reply other threads:[~2019-05-30 10:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:18 [PATCH v3 00/13] Add support for other checksums Johannes Thumshirn
2019-05-22 8:18 ` [PATCH v3 01/13] btrfs: use btrfs_csum_data() instead of directly calling crc32c Johannes Thumshirn
2019-05-22 8:18 ` [PATCH v3 02/13] btrfs: resurrect btrfs_crc32c() Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 03/13] btrfs: use btrfs_crc32c{,_final}() in for free space cache Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 04/13] btrfs: don't assume ordered sums to be 4 bytes Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 05/13] btrfs: dont assume compressed_bio " Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 06/13] btrfs: format checksums according to type for printing Johannes Thumshirn
2019-05-27 16:57 ` David Sterba
2019-06-03 9:33 ` Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 07/13] btrfs: add common checksum type validation Johannes Thumshirn
2019-05-30 15:47 ` David Sterba
2019-05-22 8:19 ` [PATCH v3 08/13] btrfs: check for supported superblock checksum type before checksum validation Johannes Thumshirn
2019-05-30 15:49 ` David Sterba
2019-05-22 8:19 ` [PATCH v3 09/13] btrfs: Simplify btrfs_check_super_csum() and get rid of size assumptions Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 10/13] btrfs: add boilerplate code for directly including the crypto framework Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 11/13] btrfs: directly call into crypto framework for checsumming Johannes Thumshirn
2019-05-22 8:33 ` Nikolay Borisov
2019-05-22 8:35 ` Johannes Thumshirn
2019-05-22 9:04 ` Johannes Thumshirn
2019-05-29 19:32 ` David Gstir
2019-05-30 10:14 ` David Sterba [this message]
2019-05-30 10:27 ` David Gstir
2019-05-22 8:19 ` [PATCH v3 12/13] btrfs: remove assumption about csum type form btrfs_print_data_csum_error() Johannes Thumshirn
2019-05-22 8:19 ` [RFC PATCH v3 13/13] btrfs: add sha256 as another checksum algorithm Johannes Thumshirn
2019-05-27 17:10 ` David Sterba
2019-05-27 17:19 ` [PATCH v3 00/13] Add support for other checksums David Sterba
2019-06-03 9:38 ` Johannes Thumshirn
2019-06-03 12:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530101401.GB15290@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=david@sigma-star.at \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.