From: Johannes Thumshirn <jthumshirn@suse.de>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>,
Chris Mason <clm@fb.com>, Richard Weinberger <richard@nod.at>,
David Gstir <david@sigma-star.at>,
Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH v3 00/13] Add support for other checksums
Date: Mon, 3 Jun 2019 11:38:40 +0200 [thread overview]
Message-ID: <20190603093840.GC4044@x250> (raw)
In-Reply-To: <20190527171954.GP15290@twin.jikos.cz>
On Mon, May 27, 2019 at 07:19:54PM +0200, David Sterba wrote:
> 1-5 are reviewed and ok, 6 and 13 should be reworked, 7-12 is ok. I
> can't put the branch to next yet due to the csum formatting "issues" but
> will do once you resend. Should be ok just 6 and 13 as they're
> independent.
I'd still like to hold back 13/13. SHA-256 doesn't seem to be well received by
the community as the "slow" hash and using a plain SHA-256 is not sufficient
for the dm-verity/fs-verity like approach I intend to implement in subsequent
patches.
For the record, the current idea is to use a HMAC(SHA-256) as checksum
algorithm with a key provided at mkfs and mount time.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-06-03 9:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:18 [PATCH v3 00/13] Add support for other checksums Johannes Thumshirn
2019-05-22 8:18 ` [PATCH v3 01/13] btrfs: use btrfs_csum_data() instead of directly calling crc32c Johannes Thumshirn
2019-05-22 8:18 ` [PATCH v3 02/13] btrfs: resurrect btrfs_crc32c() Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 03/13] btrfs: use btrfs_crc32c{,_final}() in for free space cache Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 04/13] btrfs: don't assume ordered sums to be 4 bytes Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 05/13] btrfs: dont assume compressed_bio " Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 06/13] btrfs: format checksums according to type for printing Johannes Thumshirn
2019-05-27 16:57 ` David Sterba
2019-06-03 9:33 ` Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 07/13] btrfs: add common checksum type validation Johannes Thumshirn
2019-05-30 15:47 ` David Sterba
2019-05-22 8:19 ` [PATCH v3 08/13] btrfs: check for supported superblock checksum type before checksum validation Johannes Thumshirn
2019-05-30 15:49 ` David Sterba
2019-05-22 8:19 ` [PATCH v3 09/13] btrfs: Simplify btrfs_check_super_csum() and get rid of size assumptions Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 10/13] btrfs: add boilerplate code for directly including the crypto framework Johannes Thumshirn
2019-05-22 8:19 ` [PATCH v3 11/13] btrfs: directly call into crypto framework for checsumming Johannes Thumshirn
2019-05-22 8:33 ` Nikolay Borisov
2019-05-22 8:35 ` Johannes Thumshirn
2019-05-22 9:04 ` Johannes Thumshirn
2019-05-29 19:32 ` David Gstir
2019-05-30 10:14 ` David Sterba
2019-05-30 10:27 ` David Gstir
2019-05-22 8:19 ` [PATCH v3 12/13] btrfs: remove assumption about csum type form btrfs_print_data_csum_error() Johannes Thumshirn
2019-05-22 8:19 ` [RFC PATCH v3 13/13] btrfs: add sha256 as another checksum algorithm Johannes Thumshirn
2019-05-27 17:10 ` David Sterba
2019-05-27 17:19 ` [PATCH v3 00/13] Add support for other checksums David Sterba
2019-06-03 9:38 ` Johannes Thumshirn [this message]
2019-06-03 12:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603093840.GC4044@x250 \
--to=jthumshirn@suse.de \
--cc=clm@fb.com \
--cc=david@sigma-star.at \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.