* [PATCH] usb: chipidea: Use dev_err() instead of pr_err()
@ 2019-06-04 2:09 Fabio Estevam
2019-06-04 6:03 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2019-06-04 2:09 UTC (permalink / raw)
To: Peter.Chen; +Cc: gregkh, linux-usb, Fabio Estevam
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/usb/chipidea/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 27749ace2d93..1b6495829265 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -523,8 +523,9 @@ int hw_device_reset(struct ci_hdrc *ci)
hw_write(ci, OP_USBMODE, USBMODE_SLOM, USBMODE_SLOM);
if (hw_read(ci, OP_USBMODE, USBMODE_CM) != USBMODE_CM_DC) {
- pr_err("cannot enter in %s device mode", ci_role(ci)->name);
- pr_err("lpm = %i", ci->hw_bank.lpm);
+ dev_err(ci->dev, "cannot enter in %s device mode",
+ ci_role(ci)->name);
+ dev_err(ci->dev, "lpm = %i", ci->hw_bank.lpm);
return -ENODEV;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: chipidea: Use dev_err() instead of pr_err()
2019-06-04 2:09 [PATCH] usb: chipidea: Use dev_err() instead of pr_err() Fabio Estevam
@ 2019-06-04 6:03 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2019-06-04 6:03 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Peter.Chen, gregkh, linux-usb
On Mon, Jun 03, 2019 at 11:09:01PM -0300, Fabio Estevam wrote:
> dev_err() is more appropriate for printing error messages inside
> drivers, so switch to dev_err().
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/usb/chipidea/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 27749ace2d93..1b6495829265 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -523,8 +523,9 @@ int hw_device_reset(struct ci_hdrc *ci)
> hw_write(ci, OP_USBMODE, USBMODE_SLOM, USBMODE_SLOM);
>
> if (hw_read(ci, OP_USBMODE, USBMODE_CM) != USBMODE_CM_DC) {
> - pr_err("cannot enter in %s device mode", ci_role(ci)->name);
> - pr_err("lpm = %i", ci->hw_bank.lpm);
> + dev_err(ci->dev, "cannot enter in %s device mode",
> + ci_role(ci)->name);
> + dev_err(ci->dev, "lpm = %i", ci->hw_bank.lpm);
Please also add the missing newlines '\n' (and check if there are more
instances of that mistake in this driver).
> return -ENODEV;
> }
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 2:09 [PATCH] usb: chipidea: Use dev_err() instead of pr_err() Fabio Estevam
2019-06-04 6:03 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.