* [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err()
@ 2019-06-04 3:04 Fabio Estevam
2019-06-04 3:04 ` [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() " Fabio Estevam
2019-06-04 3:55 ` [EXT] [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() " Andy Duan
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2019-06-04 3:04 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, netdev, Fabio Estevam
netdev_err() is more appropriate for printing error messages inside
network drivers, so switch to netdev_err().
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Split the changes from fec_main and fec_ptp in two different patches
drivers/net/ethernet/freescale/fec_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 848defa33d3a..4ec9733a88d5 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2452,24 +2452,24 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
return -EOPNOTSUPP;
if (ec->rx_max_coalesced_frames > 255) {
- pr_err("Rx coalesced frames exceed hardware limitation\n");
+ netdev_err(ndev, "Rx coalesced frames exceed hardware limitation\n");
return -EINVAL;
}
if (ec->tx_max_coalesced_frames > 255) {
- pr_err("Tx coalesced frame exceed hardware limitation\n");
+ netdev_err(ndev, "Tx coalesced frame exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesced usec exceed hardware limitation\n");
+ netdev_err(ndev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesced usec exceed hardware limitation\n");
+ netdev_err(ndev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() instead of pr_err()
2019-06-04 3:04 [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err() Fabio Estevam
@ 2019-06-04 3:04 ` Fabio Estevam
2019-06-04 3:51 ` [EXT] " Andy Duan
2019-06-04 3:55 ` [EXT] [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() " Andy Duan
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2019-06-04 3:04 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, netdev, Fabio Estevam
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use dev_err() instead of netdev_err() - Andy
drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c
index 7e892b1cbd3d..19e2365be7d8 100644
--- a/drivers/net/ethernet/freescale/fec_ptp.c
+++ b/drivers/net/ethernet/freescale/fec_ptp.c
@@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
if (IS_ERR(fep->ptp_clock)) {
fep->ptp_clock = NULL;
- pr_err("ptp_clock_register failed\n");
+ dev_err(&pdev->dev, "ptp_clock_register failed\n");
}
schedule_delayed_work(&fep->time_keep, HZ);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [EXT] [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() instead of pr_err()
2019-06-04 3:04 ` [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() " Fabio Estevam
@ 2019-06-04 3:51 ` Andy Duan
0 siblings, 0 replies; 4+ messages in thread
From: Andy Duan @ 2019-06-04 3:51 UTC (permalink / raw)
To: Fabio Estevam, davem; +Cc: netdev
From: Fabio Estevam <festevam@gmail.com> Sent: Tuesday, June 4, 2019 11:05 AM
> dev_err() is more appropriate for printing error messages inside drivers, so
> switch to dev_err().
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> Changes since v1:
> - Use dev_err() instead of netdev_err() - Andy
>
> drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 7e892b1cbd3d..19e2365be7d8 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx)
> fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
> if (IS_ERR(fep->ptp_clock)) {
> fep->ptp_clock = NULL;
> - pr_err("ptp_clock_register failed\n");
> + dev_err(&pdev->dev, "ptp_clock_register failed\n");
> }
>
> schedule_delayed_work(&fep->time_keep, HZ);
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err()
2019-06-04 3:04 [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err() Fabio Estevam
2019-06-04 3:04 ` [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() " Fabio Estevam
@ 2019-06-04 3:55 ` Andy Duan
1 sibling, 0 replies; 4+ messages in thread
From: Andy Duan @ 2019-06-04 3:55 UTC (permalink / raw)
To: Fabio Estevam, davem; +Cc: netdev
From: Fabio Estevam <festevam@gmail.com> Sent: Tuesday, June 4, 2019 11:05 AM
> netdev_err() is more appropriate for printing error messages inside network
> drivers, so switch to netdev_err().
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Split the changes from fec_main and fec_ptp in two different patches
>
> drivers/net/ethernet/freescale/fec_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 848defa33d3a..4ec9733a88d5 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2452,24 +2452,24 @@ fec_enet_set_coalesce(struct net_device *ndev,
> struct ethtool_coalesce *ec)
> return -EOPNOTSUPP;
>
> if (ec->rx_max_coalesced_frames > 255) {
> - pr_err("Rx coalesced frames exceed hardware
> limitation\n");
> + netdev_err(ndev, "Rx coalesced frames exceed hardware
> + limitation\n");
The API still can be called before .register_netdev(), which means ndev is uninitialized.
> return -EINVAL;
> }
>
> if (ec->tx_max_coalesced_frames > 255) {
> - pr_err("Tx coalesced frame exceed hardware
> limitation\n");
> + netdev_err(ndev, "Tx coalesced frame exceed hardware
> + limitation\n");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesced usec exceed hardware
> limitation\n");
> + netdev_err(ndev, "Rx coalesced usec exceed hardware
> + limitation\n");
> return -EINVAL;
> }
>
> cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
> if (cycle > 0xFFFF) {
> - pr_err("Rx coalesced usec exceed hardware
> limitation\n");
> + netdev_err(ndev, "Rx coalesced usec exceed hardware
> + limitation\n");
> return -EINVAL;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-04 3:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 3:04 [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() instead of pr_err() Fabio Estevam
2019-06-04 3:04 ` [PATCH net-next v2 2/2] net: fec_ptp: Use dev_err() " Fabio Estevam
2019-06-04 3:51 ` [EXT] " Andy Duan
2019-06-04 3:55 ` [EXT] [PATCH net-next v2 1/2] net: fec_main: Use netdev_err() " Andy Duan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.