From: Jason Gunthorpe <jgg@ziepe.ca>
To: janani <janani@linux.ibm.com>
Cc: Bharata B Rao <bharata@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linuxram@us.ibm.com,
cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com,
Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>
Subject: Re: [PATCH v5 1/7] kvmppc: HMM backend driver to manage pages of secure guest
Date: Wed, 10 Jul 2019 10:47:34 -0300 [thread overview]
Message-ID: <20190710134734.GB2873@ziepe.ca> (raw)
In-Reply-To: <29e536f225036d2a93e653c56a961fcb@linux.vnet.ibm.com>
On Tue, Jul 09, 2019 at 01:55:28PM -0500, janani wrote:
> > +int kvmppc_hmm_init(void)
> > +{
> > + int ret = 0;
> > + unsigned long size;
> > +
> > + size = kvmppc_get_secmem_size();
> > + if (!size) {
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.device = hmm_device_new(NULL);
> > + if (IS_ERR(kvmppc_hmm.device)) {
> > + ret = PTR_ERR(kvmppc_hmm.device);
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.devmem = hmm_devmem_add(&kvmppc_hmm_devmem_ops,
> > + &kvmppc_hmm.device->device, size);
> > + if (IS_ERR(kvmppc_hmm.devmem)) {
> > + ret = PTR_ERR(kvmppc_hmm.devmem);
> > + goto out_device;
> > + }
This 'hmm_device' API family was recently deleted from hmm:
commit 07ec38917e68f0114b9c8aeeb1c584b5e73e4dd6
Author: Christoph Hellwig <hch@lst.de>
Date: Wed Jun 26 14:27:01 2019 +0200
mm: remove the struct hmm_device infrastructure
This code is a trivial wrapper around device model helpers, which
should have been integrated into the driver device model usage from
the start. Assuming it actually had users, which it never had since
the code was added more than 1 1/2 years ago.
This patch should use the driver core directly instead.
Regards,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: janani <janani@linux.ibm.com>
Cc: Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>,
linuxram@us.ibm.com, cclaudio@linux.ibm.com,
kvm-ppc@vger.kernel.org, Bharata B Rao <bharata@linux.ibm.com>,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 1/7] kvmppc: HMM backend driver to manage pages of secure guest
Date: Wed, 10 Jul 2019 10:47:34 -0300 [thread overview]
Message-ID: <20190710134734.GB2873@ziepe.ca> (raw)
In-Reply-To: <29e536f225036d2a93e653c56a961fcb@linux.vnet.ibm.com>
On Tue, Jul 09, 2019 at 01:55:28PM -0500, janani wrote:
> > +int kvmppc_hmm_init(void)
> > +{
> > + int ret = 0;
> > + unsigned long size;
> > +
> > + size = kvmppc_get_secmem_size();
> > + if (!size) {
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.device = hmm_device_new(NULL);
> > + if (IS_ERR(kvmppc_hmm.device)) {
> > + ret = PTR_ERR(kvmppc_hmm.device);
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.devmem = hmm_devmem_add(&kvmppc_hmm_devmem_ops,
> > + &kvmppc_hmm.device->device, size);
> > + if (IS_ERR(kvmppc_hmm.devmem)) {
> > + ret = PTR_ERR(kvmppc_hmm.devmem);
> > + goto out_device;
> > + }
This 'hmm_device' API family was recently deleted from hmm:
commit 07ec38917e68f0114b9c8aeeb1c584b5e73e4dd6
Author: Christoph Hellwig <hch@lst.de>
Date: Wed Jun 26 14:27:01 2019 +0200
mm: remove the struct hmm_device infrastructure
This code is a trivial wrapper around device model helpers, which
should have been integrated into the driver device model usage from
the start. Assuming it actually had users, which it never had since
the code was added more than 1 1/2 years ago.
This patch should use the driver core directly instead.
Regards,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: janani <janani@linux.ibm.com>
Cc: Bharata B Rao <bharata@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linuxram@us.ibm.com,
cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com,
Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>
Subject: Re: [PATCH v5 1/7] kvmppc: HMM backend driver to manage pages of secure guest
Date: Wed, 10 Jul 2019 13:47:34 +0000 [thread overview]
Message-ID: <20190710134734.GB2873@ziepe.ca> (raw)
In-Reply-To: <29e536f225036d2a93e653c56a961fcb@linux.vnet.ibm.com>
On Tue, Jul 09, 2019 at 01:55:28PM -0500, janani wrote:
> > +int kvmppc_hmm_init(void)
> > +{
> > + int ret = 0;
> > + unsigned long size;
> > +
> > + size = kvmppc_get_secmem_size();
> > + if (!size) {
> > + ret = -ENODEV;
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.device = hmm_device_new(NULL);
> > + if (IS_ERR(kvmppc_hmm.device)) {
> > + ret = PTR_ERR(kvmppc_hmm.device);
> > + goto out;
> > + }
> > +
> > + kvmppc_hmm.devmem = hmm_devmem_add(&kvmppc_hmm_devmem_ops,
> > + &kvmppc_hmm.device->device, size);
> > + if (IS_ERR(kvmppc_hmm.devmem)) {
> > + ret = PTR_ERR(kvmppc_hmm.devmem);
> > + goto out_device;
> > + }
This 'hmm_device' API family was recently deleted from hmm:
commit 07ec38917e68f0114b9c8aeeb1c584b5e73e4dd6
Author: Christoph Hellwig <hch@lst.de>
Date: Wed Jun 26 14:27:01 2019 +0200
mm: remove the struct hmm_device infrastructure
This code is a trivial wrapper around device model helpers, which
should have been integrated into the driver device model usage from
the start. Assuming it actually had users, which it never had since
the code was added more than 1 1/2 years ago.
This patch should use the driver core directly instead.
Regards,
Jason
next prev parent reply other threads:[~2019-07-10 13:47 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 10:25 [PATCH v5 0/7] kvmppc: HMM driver to manage pages of secure guest Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 10:25 ` [PATCH v5 1/7] kvmppc: HMM backend " Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 18:55 ` janani
2019-07-09 18:55 ` janani
2019-07-09 18:55 ` janani
2019-07-10 13:47 ` Jason Gunthorpe [this message]
2019-07-10 13:47 ` Jason Gunthorpe
2019-07-10 13:47 ` Jason Gunthorpe
2019-07-11 5:08 ` Bharata B Rao
2019-07-11 5:20 ` Bharata B Rao
2019-07-11 5:08 ` Bharata B Rao
2019-07-19 6:46 ` Christoph Hellwig
2019-07-19 6:46 ` Christoph Hellwig
2019-07-19 8:14 ` Bharata B Rao
2019-07-19 8:26 ` Bharata B Rao
2019-07-09 10:25 ` [PATCH v5 2/7] kvmppc: Shared pages support for secure guests Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:35 ` janani
2019-07-09 19:35 ` janani
2019-07-09 19:35 ` janani
2019-07-09 10:25 ` [PATCH v5 3/7] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:42 ` janani
2019-07-09 19:42 ` janani
2019-07-09 19:42 ` janani
2019-07-09 10:25 ` [PATCH v5 4/7] kvmppc: Handle memory plug/unplug to secure VM Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:43 ` janani
2019-07-09 19:43 ` janani
2019-07-09 19:43 ` janani
2019-07-09 10:25 ` [RFC PATCH v5 5/7] kvmppc: Radix changes for secure guest Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:53 ` janani
2019-07-09 19:53 ` janani
2019-07-09 19:53 ` janani
2019-07-09 10:25 ` [RFC PATCH v5 6/7] kvmppc: Support reset of " Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-10 13:30 ` janani
2019-07-10 13:30 ` janani
2019-07-10 13:30 ` janani
2019-07-09 10:25 ` [PATCH v5 7/7] KVM: PPC: Ultravisor: Add PPC_UV config option Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-10 13:24 ` janani
2019-07-10 13:24 ` janani
2019-07-10 13:24 ` janani
2019-07-10 14:15 ` Jason Gunthorpe
2019-07-10 14:15 ` Jason Gunthorpe
2019-07-10 14:15 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710134734.GB2873@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=cclaudio@linux.ibm.com \
--cc=janani@linux.ibm.com \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@au1.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.