From: janani <janani@linux.ibm.com>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linuxram@us.ibm.com,
cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com,
Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>
Subject: Re: [PATCH v5 4/7] kvmppc: Handle memory plug/unplug to secure VM
Date: Tue, 09 Jul 2019 14:43:47 -0500 [thread overview]
Message-ID: <730f4bbd1be9abae7640ddc7366b0beb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190709102545.9187-5-bharata@linux.ibm.com>
On 2019-07-09 05:25, Bharata B Rao wrote:
> Register the new memslot with UV during plug and unregister
> the memslot during unplug.
>
> Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
Reviewed-by: Janani Janakiraman <janani@linux.ibm.com>
> ---
> arch/powerpc/include/asm/ultravisor-api.h | 1 +
> arch/powerpc/include/asm/ultravisor.h | 7 +++++++
> arch/powerpc/kvm/book3s_hv.c | 19 +++++++++++++++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/ultravisor-api.h
> b/arch/powerpc/include/asm/ultravisor-api.h
> index 07b7d638e7af..d6d6eb2e6e6b 100644
> --- a/arch/powerpc/include/asm/ultravisor-api.h
> +++ b/arch/powerpc/include/asm/ultravisor-api.h
> @@ -21,6 +21,7 @@
> #define UV_WRITE_PATE 0xF104
> #define UV_RETURN 0xF11C
> #define UV_REGISTER_MEM_SLOT 0xF120
> +#define UV_UNREGISTER_MEM_SLOT 0xF124
> #define UV_PAGE_IN 0xF128
> #define UV_PAGE_OUT 0xF12C
>
> diff --git a/arch/powerpc/include/asm/ultravisor.h
> b/arch/powerpc/include/asm/ultravisor.h
> index b46042f1aa8f..fe45be9ee63b 100644
> --- a/arch/powerpc/include/asm/ultravisor.h
> +++ b/arch/powerpc/include/asm/ultravisor.h
> @@ -70,6 +70,13 @@ static inline int uv_register_mem_slot(u64 lpid,
> u64 start_gpa, u64 size,
> return ucall(UV_REGISTER_MEM_SLOT, retbuf, lpid, start_gpa,
> size, flags, slotid);
> }
> +
> +static inline int uv_unregister_mem_slot(u64 lpid, u64 slotid)
> +{
> + unsigned long retbuf[UCALL_BUFSIZE];
> +
> + return ucall(UV_UNREGISTER_MEM_SLOT, retbuf, lpid, slotid);
> +}
> #endif /* !__ASSEMBLY__ */
>
> #endif /* _ASM_POWERPC_ULTRAVISOR_H */
> diff --git a/arch/powerpc/kvm/book3s_hv.c
> b/arch/powerpc/kvm/book3s_hv.c
> index b8f801d00ad4..7cbb5edaed01 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -77,6 +77,7 @@
> #include <asm/hw_breakpoint.h>
> #include <asm/kvm_host.h>
> #include <asm/kvm_book3s_hmm.h>
> +#include <asm/ultravisor.h>
>
> #include "book3s.h"
>
> @@ -4504,6 +4505,24 @@ static void
> kvmppc_core_commit_memory_region_hv(struct kvm *kvm,
> if (change == KVM_MR_FLAGS_ONLY && kvm_is_radix(kvm) &&
> ((new->flags ^ old->flags) & KVM_MEM_LOG_DIRTY_PAGES))
> kvmppc_radix_flush_memslot(kvm, old);
> + /*
> + * If UV hasn't yet called H_SVM_INIT_START, don't register memslots.
> + */
> + if (!kvm->arch.secure_guest)
> + return;
> +
> + /*
> + * TODO: Handle KVM_MR_MOVE
> + */
> + if (change == KVM_MR_CREATE) {
> + uv_register_mem_slot(kvm->arch.lpid,
> + new->base_gfn << PAGE_SHIFT,
> + new->npages * PAGE_SIZE,
> + 0,
> + new->id);
> + } else if (change == KVM_MR_DELETE) {
> + uv_unregister_mem_slot(kvm->arch.lpid, old->id);
> + }
> }
>
> /*
WARNING: multiple messages have this Message-ID (diff)
From: janani <janani@linux.ibm.com>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxram@us.ibm.com, cclaudio@linux.ibm.com,
kvm-ppc@vger.kernel.org,
Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 4/7] kvmppc: Handle memory plug/unplug to secure VM
Date: Tue, 09 Jul 2019 14:43:47 -0500 [thread overview]
Message-ID: <730f4bbd1be9abae7640ddc7366b0beb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190709102545.9187-5-bharata@linux.ibm.com>
On 2019-07-09 05:25, Bharata B Rao wrote:
> Register the new memslot with UV during plug and unregister
> the memslot during unplug.
>
> Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
Reviewed-by: Janani Janakiraman <janani@linux.ibm.com>
> ---
> arch/powerpc/include/asm/ultravisor-api.h | 1 +
> arch/powerpc/include/asm/ultravisor.h | 7 +++++++
> arch/powerpc/kvm/book3s_hv.c | 19 +++++++++++++++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/ultravisor-api.h
> b/arch/powerpc/include/asm/ultravisor-api.h
> index 07b7d638e7af..d6d6eb2e6e6b 100644
> --- a/arch/powerpc/include/asm/ultravisor-api.h
> +++ b/arch/powerpc/include/asm/ultravisor-api.h
> @@ -21,6 +21,7 @@
> #define UV_WRITE_PATE 0xF104
> #define UV_RETURN 0xF11C
> #define UV_REGISTER_MEM_SLOT 0xF120
> +#define UV_UNREGISTER_MEM_SLOT 0xF124
> #define UV_PAGE_IN 0xF128
> #define UV_PAGE_OUT 0xF12C
>
> diff --git a/arch/powerpc/include/asm/ultravisor.h
> b/arch/powerpc/include/asm/ultravisor.h
> index b46042f1aa8f..fe45be9ee63b 100644
> --- a/arch/powerpc/include/asm/ultravisor.h
> +++ b/arch/powerpc/include/asm/ultravisor.h
> @@ -70,6 +70,13 @@ static inline int uv_register_mem_slot(u64 lpid,
> u64 start_gpa, u64 size,
> return ucall(UV_REGISTER_MEM_SLOT, retbuf, lpid, start_gpa,
> size, flags, slotid);
> }
> +
> +static inline int uv_unregister_mem_slot(u64 lpid, u64 slotid)
> +{
> + unsigned long retbuf[UCALL_BUFSIZE];
> +
> + return ucall(UV_UNREGISTER_MEM_SLOT, retbuf, lpid, slotid);
> +}
> #endif /* !__ASSEMBLY__ */
>
> #endif /* _ASM_POWERPC_ULTRAVISOR_H */
> diff --git a/arch/powerpc/kvm/book3s_hv.c
> b/arch/powerpc/kvm/book3s_hv.c
> index b8f801d00ad4..7cbb5edaed01 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -77,6 +77,7 @@
> #include <asm/hw_breakpoint.h>
> #include <asm/kvm_host.h>
> #include <asm/kvm_book3s_hmm.h>
> +#include <asm/ultravisor.h>
>
> #include "book3s.h"
>
> @@ -4504,6 +4505,24 @@ static void
> kvmppc_core_commit_memory_region_hv(struct kvm *kvm,
> if (change == KVM_MR_FLAGS_ONLY && kvm_is_radix(kvm) &&
> ((new->flags ^ old->flags) & KVM_MEM_LOG_DIRTY_PAGES))
> kvmppc_radix_flush_memslot(kvm, old);
> + /*
> + * If UV hasn't yet called H_SVM_INIT_START, don't register memslots.
> + */
> + if (!kvm->arch.secure_guest)
> + return;
> +
> + /*
> + * TODO: Handle KVM_MR_MOVE
> + */
> + if (change == KVM_MR_CREATE) {
> + uv_register_mem_slot(kvm->arch.lpid,
> + new->base_gfn << PAGE_SHIFT,
> + new->npages * PAGE_SIZE,
> + 0,
> + new->id);
> + } else if (change == KVM_MR_DELETE) {
> + uv_unregister_mem_slot(kvm->arch.lpid, old->id);
> + }
> }
>
> /*
WARNING: multiple messages have this Message-ID (diff)
From: janani <janani@linux.ibm.com>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linuxram@us.ibm.com,
cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com,
Linuxppc-dev
<linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org>
Subject: Re: [PATCH v5 4/7] kvmppc: Handle memory plug/unplug to secure VM
Date: Tue, 09 Jul 2019 19:43:47 +0000 [thread overview]
Message-ID: <730f4bbd1be9abae7640ddc7366b0beb@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190709102545.9187-5-bharata@linux.ibm.com>
On 2019-07-09 05:25, Bharata B Rao wrote:
> Register the new memslot with UV during plug and unregister
> the memslot during unplug.
>
> Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
> Acked-by: Paul Mackerras <paulus@ozlabs.org>
Reviewed-by: Janani Janakiraman <janani@linux.ibm.com>
> ---
> arch/powerpc/include/asm/ultravisor-api.h | 1 +
> arch/powerpc/include/asm/ultravisor.h | 7 +++++++
> arch/powerpc/kvm/book3s_hv.c | 19 +++++++++++++++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/ultravisor-api.h
> b/arch/powerpc/include/asm/ultravisor-api.h
> index 07b7d638e7af..d6d6eb2e6e6b 100644
> --- a/arch/powerpc/include/asm/ultravisor-api.h
> +++ b/arch/powerpc/include/asm/ultravisor-api.h
> @@ -21,6 +21,7 @@
> #define UV_WRITE_PATE 0xF104
> #define UV_RETURN 0xF11C
> #define UV_REGISTER_MEM_SLOT 0xF120
> +#define UV_UNREGISTER_MEM_SLOT 0xF124
> #define UV_PAGE_IN 0xF128
> #define UV_PAGE_OUT 0xF12C
>
> diff --git a/arch/powerpc/include/asm/ultravisor.h
> b/arch/powerpc/include/asm/ultravisor.h
> index b46042f1aa8f..fe45be9ee63b 100644
> --- a/arch/powerpc/include/asm/ultravisor.h
> +++ b/arch/powerpc/include/asm/ultravisor.h
> @@ -70,6 +70,13 @@ static inline int uv_register_mem_slot(u64 lpid,
> u64 start_gpa, u64 size,
> return ucall(UV_REGISTER_MEM_SLOT, retbuf, lpid, start_gpa,
> size, flags, slotid);
> }
> +
> +static inline int uv_unregister_mem_slot(u64 lpid, u64 slotid)
> +{
> + unsigned long retbuf[UCALL_BUFSIZE];
> +
> + return ucall(UV_UNREGISTER_MEM_SLOT, retbuf, lpid, slotid);
> +}
> #endif /* !__ASSEMBLY__ */
>
> #endif /* _ASM_POWERPC_ULTRAVISOR_H */
> diff --git a/arch/powerpc/kvm/book3s_hv.c
> b/arch/powerpc/kvm/book3s_hv.c
> index b8f801d00ad4..7cbb5edaed01 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -77,6 +77,7 @@
> #include <asm/hw_breakpoint.h>
> #include <asm/kvm_host.h>
> #include <asm/kvm_book3s_hmm.h>
> +#include <asm/ultravisor.h>
>
> #include "book3s.h"
>
> @@ -4504,6 +4505,24 @@ static void
> kvmppc_core_commit_memory_region_hv(struct kvm *kvm,
> if (change = KVM_MR_FLAGS_ONLY && kvm_is_radix(kvm) &&
> ((new->flags ^ old->flags) & KVM_MEM_LOG_DIRTY_PAGES))
> kvmppc_radix_flush_memslot(kvm, old);
> + /*
> + * If UV hasn't yet called H_SVM_INIT_START, don't register memslots.
> + */
> + if (!kvm->arch.secure_guest)
> + return;
> +
> + /*
> + * TODO: Handle KVM_MR_MOVE
> + */
> + if (change = KVM_MR_CREATE) {
> + uv_register_mem_slot(kvm->arch.lpid,
> + new->base_gfn << PAGE_SHIFT,
> + new->npages * PAGE_SIZE,
> + 0,
> + new->id);
> + } else if (change = KVM_MR_DELETE) {
> + uv_unregister_mem_slot(kvm->arch.lpid, old->id);
> + }
> }
>
> /*
next prev parent reply other threads:[~2019-07-09 19:41 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 10:25 [PATCH v5 0/7] kvmppc: HMM driver to manage pages of secure guest Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 10:25 ` [PATCH v5 1/7] kvmppc: HMM backend " Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 18:55 ` janani
2019-07-09 18:55 ` janani
2019-07-09 18:55 ` janani
2019-07-10 13:47 ` Jason Gunthorpe
2019-07-10 13:47 ` Jason Gunthorpe
2019-07-10 13:47 ` Jason Gunthorpe
2019-07-11 5:08 ` Bharata B Rao
2019-07-11 5:20 ` Bharata B Rao
2019-07-11 5:08 ` Bharata B Rao
2019-07-19 6:46 ` Christoph Hellwig
2019-07-19 6:46 ` Christoph Hellwig
2019-07-19 8:14 ` Bharata B Rao
2019-07-19 8:26 ` Bharata B Rao
2019-07-09 10:25 ` [PATCH v5 2/7] kvmppc: Shared pages support for secure guests Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:35 ` janani
2019-07-09 19:35 ` janani
2019-07-09 19:35 ` janani
2019-07-09 10:25 ` [PATCH v5 3/7] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:42 ` janani
2019-07-09 19:42 ` janani
2019-07-09 19:42 ` janani
2019-07-09 10:25 ` [PATCH v5 4/7] kvmppc: Handle memory plug/unplug to secure VM Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:43 ` janani [this message]
2019-07-09 19:43 ` janani
2019-07-09 19:43 ` janani
2019-07-09 10:25 ` [RFC PATCH v5 5/7] kvmppc: Radix changes for secure guest Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-09 19:53 ` janani
2019-07-09 19:53 ` janani
2019-07-09 19:53 ` janani
2019-07-09 10:25 ` [RFC PATCH v5 6/7] kvmppc: Support reset of " Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-10 13:30 ` janani
2019-07-10 13:30 ` janani
2019-07-10 13:30 ` janani
2019-07-09 10:25 ` [PATCH v5 7/7] KVM: PPC: Ultravisor: Add PPC_UV config option Bharata B Rao
2019-07-09 10:37 ` Bharata B Rao
2019-07-09 10:25 ` Bharata B Rao
2019-07-10 13:24 ` janani
2019-07-10 13:24 ` janani
2019-07-10 13:24 ` janani
2019-07-10 14:15 ` Jason Gunthorpe
2019-07-10 14:15 ` Jason Gunthorpe
2019-07-10 14:15 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=730f4bbd1be9abae7640ddc7366b0beb@linux.vnet.ibm.com \
--to=janani@linux.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=cclaudio@linux.ibm.com \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev-bounces+janani=linux.ibm.com@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@au1.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.