* [PATCH] USB: serial: option: add D-Link DWM-222 device ID @ 2019-07-11 9:40 Rogan Dawes 2019-07-11 10:34 ` [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] Rogan Dawes 0 siblings, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-11 9:40 UTC (permalink / raw) To: linux-usb Add device id for D-Link DWM-222. Cc: stable@vger.kernel.org --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a0aaf0635359..018a9772b869 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) }, { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ .driver_info = RSVD(4) }, + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e36, 0xff), /* D-Link DWM-222 A2 */ + .driver_info = RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-11 9:40 [PATCH] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes @ 2019-07-11 10:34 ` Rogan Dawes 2019-07-16 9:11 ` Johan Hovold 0 siblings, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-11 10:34 UTC (permalink / raw) To: linux-usb Add device id for D-Link DWM-222. Cc: stable@vger.kernel.org Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> --- Apologies, a typo crept in when submitting this previously. drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a0aaf0635359..267111b1f431 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) }, { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ .driver_info = RSVD(4) }, + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ + .driver_info = RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-11 10:34 ` [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] Rogan Dawes @ 2019-07-16 9:11 ` Johan Hovold 2019-07-16 10:55 ` Rogan Dawes 0 siblings, 1 reply; 21+ messages in thread From: Johan Hovold @ 2019-07-16 9:11 UTC (permalink / raw) To: Rogan Dawes; +Cc: linux-usb On Thu, Jul 11, 2019 at 12:34:57PM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: stable@vger.kernel.org > Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> > --- > Apologies, a typo crept in when submitting this previously. Thanks for the patch, all looks good, but next time add the version information inside the "[PATCH v2]" prefix so that it doesn't end up the commit logs. Would you mind posting also the output of usb-devices (or lsusb -v) for this device for completeness? The former is compact enough to be included in the commit message. No need to resend unless you prefer to. I'll apply this one after the merge window closes. Thanks, Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 9:11 ` Johan Hovold @ 2019-07-16 10:55 ` Rogan Dawes 2019-07-16 11:17 ` Johan Hovold 0 siblings, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-16 10:55 UTC (permalink / raw) To: Johan Hovold; +Cc: linux-usb I have a gist with all of the relevant information here: https://gist.github.com/RoganDawes/afcc0aa1d12b53b540afc94ffc8e4494 lsusb -v is at: https://gist.githubusercontent.com/RoganDawes/afcc0aa1d12b53b540afc94ffc8e4494/raw/de31775e4a8048a0f06362fe59bb4f98a54b3c16/lsusb%2520-v%2520-d%25202001:7e3d%2520after Or: After binding the Option driver, lsusb -v -d 2001:7e3d Bus 001 Device 062: ID 2001:7e3d D-Link Corp. Mobile Connect Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.01 bDeviceClass 0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x2001 D-Link Corp. idProduct 0x7e3d bcdDevice 2.28 iManufacturer 1 Mobile Connect iProduct 2 Mobile Connect iSerial 3 0123456789ABCDEF bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 0x00e8 bNumInterfaces 6 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x01 EP 1 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 1 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 05 24 00 10 01 ** UNRECOGNIZED: 05 24 01 00 00 ** UNRECOGNIZED: 04 24 02 02 ** UNRECOGNIZED: 05 24 06 00 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x000a 1x 10 bytes bInterval 9 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x82 EP 2 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 2 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 05 24 00 10 01 ** UNRECOGNIZED: 05 24 01 00 00 ** UNRECOGNIZED: 04 24 02 02 ** UNRECOGNIZED: 05 24 06 00 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x85 EP 5 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x000a 1x 10 bytes bInterval 9 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x84 EP 4 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x03 EP 3 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 3 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0 bInterfaceProtocol 0 iInterface 0 ** UNRECOGNIZED: 05 24 00 10 01 ** UNRECOGNIZED: 05 24 01 00 00 ** UNRECOGNIZED: 04 24 02 02 ** UNRECOGNIZED: 05 24 06 00 00 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x87 EP 7 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x000a 1x 10 bytes bInterval 9 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x86 EP 6 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x04 EP 4 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 4 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x89 EP 9 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x0008 1x 8 bytes bInterval 9 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x88 EP 8 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x05 EP 5 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 5 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 8 Mass Storage bInterfaceSubClass 6 SCSI bInterfaceProtocol 80 Bulk-Only iInterface 4 Mass Storage Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x8a EP 10 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x06 EP 6 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0200 1x 512 bytes bInterval 1 Binary Object Store Descriptor: bLength 5 bDescriptorType 15 wTotalLength 0x000c bNumDeviceCaps 1 USB 2.0 Extension Device Capability: bLength 7 bDescriptorType 16 bDevCapabilityType 2 bmAttributes 0x00000002 HIRD Link Power Management (LPM) Supported can't get debug descriptor: Resource temporarily unavailable Device Status: 0x0000 (Bus Powered) On Tue, Jul 16, 2019 at 11:11 AM Johan Hovold <johan@kernel.org> wrote: > > On Thu, Jul 11, 2019 at 12:34:57PM +0200, Rogan Dawes wrote: > > Add device id for D-Link DWM-222. > > > > Cc: stable@vger.kernel.org > > Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> > > --- > > Apologies, a typo crept in when submitting this previously. > > Thanks for the patch, all looks good, but next time add the version > information inside the "[PATCH v2]" prefix so that it doesn't end up the > commit logs. > > Would you mind posting also the output of usb-devices (or lsusb -v) for > this device for completeness? The former is compact enough to be > included in the commit message. > > No need to resend unless you prefer to. I'll apply this one after the > merge window closes. > > Thanks, > Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 10:55 ` Rogan Dawes @ 2019-07-16 11:17 ` Johan Hovold 2019-07-16 14:34 ` Lars Melin 0 siblings, 1 reply; 21+ messages in thread From: Johan Hovold @ 2019-07-16 11:17 UTC (permalink / raw) To: Rogan Dawes; +Cc: Johan Hovold, linux-usb, Lars Melin, Dan Williams On Tue, Jul 16, 2019 at 12:55:17PM +0200, Rogan Dawes wrote: > After binding the Option driver, lsusb -v -d 2001:7e3d > > Bus 001 Device 062: ID 2001:7e3d D-Link Corp. Mobile Connect > Device Descriptor: > bLength 18 > bDescriptorType 1 > bcdUSB 2.01 > bDeviceClass 0 > bDeviceSubClass 0 > bDeviceProtocol 0 > bMaxPacketSize0 64 > idVendor 0x2001 D-Link Corp. > idProduct 0x7e3d > bcdDevice 2.28 > iManufacturer 1 Mobile Connect > iProduct 2 Mobile Connect > iSerial 3 0123456789ABCDEF > bNumConfigurations 1 > Configuration Descriptor: > bLength 9 > bDescriptorType 2 > wTotalLength 0x00e8 > bNumInterfaces 6 > bConfigurationValue 1 > iConfiguration 0 > bmAttributes 0x80 > (Bus Powered) > MaxPower 500mA > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 0 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 255 Vendor Specific Class > bInterfaceSubClass 255 Vendor Specific Subclass > bInterfaceProtocol 255 Vendor Specific Protocol > iInterface 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x81 EP 1 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x01 EP 1 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 1 > bAlternateSetting 0 > bNumEndpoints 3 > bInterfaceClass 255 Vendor Specific Class > bInterfaceSubClass 0 > bInterfaceProtocol 0 > iInterface 0 > ** UNRECOGNIZED: 05 24 00 10 01 > ** UNRECOGNIZED: 05 24 01 00 00 > ** UNRECOGNIZED: 04 24 02 02 > ** UNRECOGNIZED: 05 24 06 00 00 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x83 EP 3 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x000a 1x 10 bytes > bInterval 9 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x82 EP 2 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x02 EP 2 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 2 > bAlternateSetting 0 > bNumEndpoints 3 > bInterfaceClass 255 Vendor Specific Class > bInterfaceSubClass 0 > bInterfaceProtocol 0 > iInterface 0 > ** UNRECOGNIZED: 05 24 00 10 01 > ** UNRECOGNIZED: 05 24 01 00 00 > ** UNRECOGNIZED: 04 24 02 02 > ** UNRECOGNIZED: 05 24 06 00 00 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x85 EP 5 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x000a 1x 10 bytes > bInterval 9 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x84 EP 4 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x03 EP 3 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 3 > bAlternateSetting 0 > bNumEndpoints 3 > bInterfaceClass 255 Vendor Specific Class > bInterfaceSubClass 0 > bInterfaceProtocol 0 > iInterface 0 > ** UNRECOGNIZED: 05 24 00 10 01 > ** UNRECOGNIZED: 05 24 01 00 00 > ** UNRECOGNIZED: 04 24 02 02 > ** UNRECOGNIZED: 05 24 06 00 00 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x87 EP 7 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x000a 1x 10 bytes > bInterval 9 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x86 EP 6 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x04 EP 4 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 4 > bAlternateSetting 0 > bNumEndpoints 3 > bInterfaceClass 255 Vendor Specific Class > bInterfaceSubClass 255 Vendor Specific Subclass > bInterfaceProtocol 255 Vendor Specific Protocol > iInterface 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x89 EP 9 IN > bmAttributes 3 > Transfer Type Interrupt > Synch Type None > Usage Type Data > wMaxPacketSize 0x0008 1x 8 bytes > bInterval 9 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x88 EP 8 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x05 EP 5 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Interface Descriptor: > bLength 9 > bDescriptorType 4 > bInterfaceNumber 5 > bAlternateSetting 0 > bNumEndpoints 2 > bInterfaceClass 8 Mass Storage > bInterfaceSubClass 6 SCSI > bInterfaceProtocol 80 Bulk-Only > iInterface 4 Mass Storage > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x8a EP 10 IN > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 0 > Endpoint Descriptor: > bLength 7 > bDescriptorType 5 > bEndpointAddress 0x06 EP 6 OUT > bmAttributes 2 > Transfer Type Bulk > Synch Type None > Usage Type Data > wMaxPacketSize 0x0200 1x 512 bytes > bInterval 1 > Binary Object Store Descriptor: > bLength 5 > bDescriptorType 15 > wTotalLength 0x000c > bNumDeviceCaps 1 > USB 2.0 Extension Device Capability: > bLength 7 > bDescriptorType 16 > bDevCapabilityType 2 > bmAttributes 0x00000002 > HIRD Link Power Management (LPM) Supported > can't get debug descriptor: Resource temporarily unavailable > Device Status: 0x0000 > (Bus Powered) Ok, thanks. Do you have any idea what all those vendor interface are for? Some of the other D-Link entries blacklist a speech and debug port for example. We can always do that later if we need to, but perhaps you or someone already know (also adding Lars and Dan on CC). Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 11:17 ` Johan Hovold @ 2019-07-16 14:34 ` Lars Melin 2019-07-16 18:05 ` Johan Hovold 0 siblings, 1 reply; 21+ messages in thread From: Lars Melin @ 2019-07-16 14:34 UTC (permalink / raw) To: Johan Hovold, Rogan Dawes; +Cc: linux-usb, Dan Williams On 7/16/2019 18:17, Johan Hovold wrote: snip > Ok, thanks. Do you have any idea what all those vendor interface are > for? Some of the other D-Link entries blacklist a speech and debug port > for example. > > We can always do that later if we need to, but perhaps you or someone > already know (also adding Lars and Dan on CC). > > Johan > This is the interface composition: MI_00 D-Link HS-USB Diagnostics MI_01 D-Link HS-USB Modem MI_02 D-Link HS-USB AT Port MI_03 D-Link HS-USB NMEA MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) MI_05 USB Mass Storage Device rgds /Lars ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 14:34 ` Lars Melin @ 2019-07-16 18:05 ` Johan Hovold 2019-07-16 18:40 ` Rogan Dawes 0 siblings, 1 reply; 21+ messages in thread From: Johan Hovold @ 2019-07-16 18:05 UTC (permalink / raw) To: Lars Melin; +Cc: Johan Hovold, Rogan Dawes, linux-usb, Dan Williams On Tue, Jul 16, 2019 at 09:34:56PM +0700, Lars Melin wrote: > On 7/16/2019 18:17, Johan Hovold wrote: > > snip > > > Ok, thanks. Do you have any idea what all those vendor interface are > > for? Some of the other D-Link entries blacklist a speech and debug port > > for example. > > > > We can always do that later if we need to, but perhaps you or someone > > already know (also adding Lars and Dan on CC). > > > > Johan > > > > This is the interface composition: > > MI_00 D-Link HS-USB Diagnostics > MI_01 D-Link HS-USB Modem > MI_02 D-Link HS-USB AT Port > MI_03 D-Link HS-USB NMEA > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > MI_05 USB Mass Storage Device Thanks, Lars. Then interface 0 and 4 should be blacklisted, right? Rogan, would you mind doing that in a v3? You can include above composition details in the commit message as well. Thanks, Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 18:05 ` Johan Hovold @ 2019-07-16 18:40 ` Rogan Dawes 2019-07-16 18:49 ` Rogan Dawes 0 siblings, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-16 18:40 UTC (permalink / raw) To: Johan Hovold; +Cc: Lars Melin, linux-usb, Dan Williams I have no idea how to do that, I'm afraid. I'm mostly a cargo cult C-programmer :-) I can copy and paste, but that's about it! On Tue, Jul 16, 2019 at 8:05 PM Johan Hovold <johan@kernel.org> wrote: > > On Tue, Jul 16, 2019 at 09:34:56PM +0700, Lars Melin wrote: > > On 7/16/2019 18:17, Johan Hovold wrote: > > > > snip > > > > > Ok, thanks. Do you have any idea what all those vendor interface are > > > for? Some of the other D-Link entries blacklist a speech and debug port > > > for example. > > > > > > We can always do that later if we need to, but perhaps you or someone > > > already know (also adding Lars and Dan on CC). > > > > > > Johan > > > > > > > This is the interface composition: > > > > MI_00 D-Link HS-USB Diagnostics > > MI_01 D-Link HS-USB Modem > > MI_02 D-Link HS-USB AT Port > > MI_03 D-Link HS-USB NMEA > > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > > MI_05 USB Mass Storage Device > > Thanks, Lars. > > Then interface 0 and 4 should be blacklisted, right? > > Rogan, would you mind doing that in a v3? You can include above > composition details in the commit message as well. > > Thanks, > Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] 2019-07-16 18:40 ` Rogan Dawes @ 2019-07-16 18:49 ` Rogan Dawes 2019-07-16 19:02 ` [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes 0 siblings, 2 replies; 21+ messages in thread From: Rogan Dawes @ 2019-07-16 18:49 UTC (permalink / raw) To: Johan Hovold; +Cc: Lars Melin, linux-usb, Dan Williams On Tue, Jul 16, 2019 at 8:40 PM Rogan Dawes <rogan@dawes.za.net> wrote: > > I have no idea how to do that, I'm afraid. > > I'm mostly a cargo cult C-programmer :-) I can copy and paste, but > that's about it! That said, I think that I have already blacklisted interface 4, as it was also blacklisted in the DWM-222 A1 hardware. Rogan ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID 2019-07-16 18:49 ` Rogan Dawes @ 2019-07-16 19:02 ` Rogan Dawes 2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes 1 sibling, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-16 19:02 UTC (permalink / raw) To: linux-usb; +Cc: Johan Hovold, Lars Melin, Dan Williams Add device id for D-Link DWM-222. Cc: stable@vger.kernel.org --- Added the reserved interface 0, as suggested by Johan and Lars. drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a0aaf0635359..db6f76bbb471 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) }, { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ .driver_info = RSVD(4) }, + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ + .driver_info = RSVD(0) | RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID 2019-07-16 19:02 ` [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes @ 2019-07-16 19:12 ` Rogan Dawes 2019-07-16 19:37 ` Greg KH ` (2 more replies) 0 siblings, 3 replies; 21+ messages in thread From: Rogan Dawes @ 2019-07-16 19:12 UTC (permalink / raw) To: linux-usb; +Cc: Johan Hovold, Lars Melin, Dan Williams Add device id for D-Link DWM-222. Cc: stable@vger.kernel.org --- Also add the qmi_wwan entry, since it was blacklisted already in option Apologies for the spam! drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 8b4ad10cf940..69e0a2acfcb0 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1292,6 +1292,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x2001, 0x7e16, 3)}, /* D-Link DWM-221 */ {QMI_FIXED_INTF(0x2001, 0x7e19, 4)}, /* D-Link DWM-221 B1 */ {QMI_FIXED_INTF(0x2001, 0x7e35, 4)}, /* D-Link DWM-222 */ + {QMI_FIXED_INTF(0x2001, 0x7e3d, 4)}, /* D-Link DWM-222 A2 */ {QMI_FIXED_INTF(0x2020, 0x2031, 4)}, /* Olicard 600 */ {QMI_FIXED_INTF(0x2020, 0x2033, 4)}, /* BroadMobi BM806U */ {QMI_FIXED_INTF(0x0f3d, 0x68a2, 8)}, /* Sierra Wireless MC7700 */ diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a0aaf0635359..db6f76bbb471 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) }, { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ .driver_info = RSVD(4) }, + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ + .driver_info = RSVD(0) | RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID 2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes @ 2019-07-16 19:37 ` Greg KH 2019-07-16 19:44 ` Johan Hovold 2019-07-17 1:43 ` Dan Williams 2 siblings, 0 replies; 21+ messages in thread From: Greg KH @ 2019-07-16 19:37 UTC (permalink / raw) To: Rogan Dawes; +Cc: linux-usb, Johan Hovold, Lars Melin, Dan Williams On Tue, Jul 16, 2019 at 09:12:05PM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: stable@vger.kernel.org > --- > Also add the qmi_wwan entry, since it was blacklisted already in option > > Apologies for the spam! You need a signed-off-by line :( ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID 2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes 2019-07-16 19:37 ` Greg KH @ 2019-07-16 19:44 ` Johan Hovold 2019-07-17 1:43 ` Dan Williams 2 siblings, 0 replies; 21+ messages in thread From: Johan Hovold @ 2019-07-16 19:44 UTC (permalink / raw) To: Rogan Dawes; +Cc: linux-usb, Johan Hovold, Lars Melin, Dan Williams On Tue, Jul 16, 2019 at 09:12:05PM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: stable@vger.kernel.org > --- > Also add the qmi_wwan entry, since it was blacklisted already in option > > Apologies for the spam! No worries, you're getting there. :) > drivers/net/usb/qmi_wwan.c | 1 + > drivers/usb/serial/option.c | 2 ++ > 2 files changed, 3 insertions(+) But please split this up in two patches and run get_maintainer.pl on each. The qmi_wwan one will go through the network tree. Also include the interface layout that Lars provided in the USB serial commit message. And don't forget the SoB line as Greg pointed out. Thanks, Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID 2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes 2019-07-16 19:37 ` Greg KH 2019-07-16 19:44 ` Johan Hovold @ 2019-07-17 1:43 ` Dan Williams 2019-07-17 6:19 ` Johan Hovold 2 siblings, 1 reply; 21+ messages in thread From: Dan Williams @ 2019-07-17 1:43 UTC (permalink / raw) To: Rogan Dawes, linux-usb; +Cc: Johan Hovold, Lars Melin On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222. > > Cc: stable@vger.kernel.org > --- > Also add the qmi_wwan entry, since it was blacklisted already in option > > Apologies for the spam! > > drivers/net/usb/qmi_wwan.c | 1 + > drivers/usb/serial/option.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 8b4ad10cf940..69e0a2acfcb0 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -1292,6 +1292,7 @@ static const struct usb_device_id products[] = { > {QMI_FIXED_INTF(0x2001, 0x7e16, 3)}, /* D-Link DWM-221 */ > {QMI_FIXED_INTF(0x2001, 0x7e19, 4)}, /* D-Link DWM-221 B1 */ > {QMI_FIXED_INTF(0x2001, 0x7e35, 4)}, /* D-Link DWM-222 */ > + {QMI_FIXED_INTF(0x2001, 0x7e3d, 4)}, /* D-Link DWM-222 A2 */ > {QMI_FIXED_INTF(0x2020, 0x2031, 4)}, /* Olicard 600 */ > {QMI_FIXED_INTF(0x2020, 0x2033, 4)}, /* BroadMobi BM806U */ > {QMI_FIXED_INTF(0x0f3d, 0x68a2, 8)}, /* Sierra Wireless MC7700 */ > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index a0aaf0635359..db6f76bbb471 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { > .driver_info = RSVD(4) }, > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ > .driver_info = RSVD(4) }, > + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ > + .driver_info = RSVD(0) | RSVD(4) }, I don't think we actually do need to blacklist interface 0, since that's likely a QCDM/DIAG interface and that does need a serial driver like option or qcserial. Johan, any reason why you thought we should blacklist 0? Dan > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5] USB: serial/qmi_wwan: add D-Link DWM-222 device ID 2019-07-17 1:43 ` Dan Williams @ 2019-07-17 6:19 ` Johan Hovold 0 siblings, 0 replies; 21+ messages in thread From: Johan Hovold @ 2019-07-17 6:19 UTC (permalink / raw) To: Dan Williams; +Cc: Rogan Dawes, linux-usb, Johan Hovold, Lars Melin On Tue, Jul 16, 2019 at 08:43:52PM -0500, Dan Williams wrote: > On Tue, 2019-07-16 at 21:12 +0200, Rogan Dawes wrote: > > Add device id for D-Link DWM-222. > > @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { > > .driver_info = RSVD(4) }, > > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ > > .driver_info = RSVD(4) }, > > + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ > > + .driver_info = RSVD(0) | RSVD(4) }, > > I don't think we actually do need to blacklist interface 0, since > that's likely a QCDM/DIAG interface and that does need a serial driver > like option or qcserial. > > Johan, any reason why you thought we should blacklist 0? It was just me being confused about the Qualcomm protocols and how the diag port was accessed from user space. Thanks, Dan. Rogan, let's keep interface 0 and only blacklist interface 4 as you did originally. Sorry about the confusion. Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID 2019-07-16 18:49 ` Rogan Dawes 2019-07-16 19:02 ` [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes @ 2019-07-17 9:11 ` Rogan Dawes 2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes ` (2 more replies) 1 sibling, 3 replies; 21+ messages in thread From: Rogan Dawes @ 2019-07-17 9:11 UTC (permalink / raw) To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb Add device id for D-Link DWM-222 A2. MI_00 D-Link HS-USB Diagnostics MI_01 D-Link HS-USB Modem MI_02 D-Link HS-USB AT Port MI_03 D-Link HS-USB NMEA MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) MI_05 USB Mass Storage Device Cc: stable@vger.kernel.org Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index a0aaf0635359..267111b1f431 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -1951,6 +1951,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) }, { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e35, 0xff), /* D-Link DWM-222 */ .driver_info = RSVD(4) }, + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e3d, 0xff), /* D-Link DWM-222 A2 */ + .driver_info = RSVD(4) }, { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 device ID 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes @ 2019-07-17 9:14 ` Rogan Dawes 2019-07-18 23:34 ` David Miller 2019-07-17 9:20 ` [PATCH v6] USB: serial: option: add D-Link DWM-222 " Johan Hovold 2019-08-05 11:36 ` Johan Hovold 2 siblings, 1 reply; 21+ messages in thread From: Rogan Dawes @ 2019-07-17 9:14 UTC (permalink / raw) To: Bjørn Mork; +Cc: David S. Miller, netdev, linux-usb Signed-off-by: Rogan Dawes <rogan@dawes.za.net> --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 8b4ad10cf940..69e0a2acfcb0 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -1292,6 +1292,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x2001, 0x7e16, 3)}, /* D-Link DWM-221 */ {QMI_FIXED_INTF(0x2001, 0x7e19, 4)}, /* D-Link DWM-221 B1 */ {QMI_FIXED_INTF(0x2001, 0x7e35, 4)}, /* D-Link DWM-222 */ + {QMI_FIXED_INTF(0x2001, 0x7e3d, 4)}, /* D-Link DWM-222 A2 */ {QMI_FIXED_INTF(0x2020, 0x2031, 4)}, /* Olicard 600 */ {QMI_FIXED_INTF(0x2020, 0x2033, 4)}, /* BroadMobi BM806U */ {QMI_FIXED_INTF(0x0f3d, 0x68a2, 8)}, /* Sierra Wireless MC7700 */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 device ID 2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes @ 2019-07-18 23:34 ` David Miller 0 siblings, 0 replies; 21+ messages in thread From: David Miller @ 2019-07-18 23:34 UTC (permalink / raw) To: rogan; +Cc: bjorn, netdev, linux-usb From: Rogan Dawes <rogan@dawes.za.net> Date: Wed, 17 Jul 2019 11:14:33 +0200 > Signed-off-by: Rogan Dawes <rogan@dawes.za.net> Applied. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes 2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes @ 2019-07-17 9:20 ` Johan Hovold 2019-07-17 9:37 ` Rogan Dawes 2019-08-05 11:36 ` Johan Hovold 2 siblings, 1 reply; 21+ messages in thread From: Johan Hovold @ 2019-07-17 9:20 UTC (permalink / raw) To: Rogan Dawes; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb On Wed, Jul 17, 2019 at 11:11:34AM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222 A2. > > MI_00 D-Link HS-USB Diagnostics > MI_01 D-Link HS-USB Modem > MI_02 D-Link HS-USB AT Port > MI_03 D-Link HS-USB NMEA > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > MI_05 USB Mass Storage Device > > Cc: stable@vger.kernel.org > Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> Perfect, thanks for sticking with it. I'll queue this is up after the merge window closes. Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID 2019-07-17 9:20 ` [PATCH v6] USB: serial: option: add D-Link DWM-222 " Johan Hovold @ 2019-07-17 9:37 ` Rogan Dawes 0 siblings, 0 replies; 21+ messages in thread From: Rogan Dawes @ 2019-07-17 9:37 UTC (permalink / raw) To: Johan Hovold; +Cc: Greg Kroah-Hartman, linux-usb Thank you for all the hand holding ... On Wed, Jul 17, 2019 at 11:20 AM Johan Hovold <johan@kernel.org> wrote: > > On Wed, Jul 17, 2019 at 11:11:34AM +0200, Rogan Dawes wrote: > > Add device id for D-Link DWM-222 A2. > > > > MI_00 D-Link HS-USB Diagnostics > > MI_01 D-Link HS-USB Modem > > MI_02 D-Link HS-USB AT Port > > MI_03 D-Link HS-USB NMEA > > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > > MI_05 USB Mass Storage Device > > > > Cc: stable@vger.kernel.org > > Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> > > Perfect, thanks for sticking with it. > > I'll queue this is up after the merge window closes. > > Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v6] USB: serial: option: add D-Link DWM-222 device ID 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes 2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes 2019-07-17 9:20 ` [PATCH v6] USB: serial: option: add D-Link DWM-222 " Johan Hovold @ 2019-08-05 11:36 ` Johan Hovold 2 siblings, 0 replies; 21+ messages in thread From: Johan Hovold @ 2019-08-05 11:36 UTC (permalink / raw) To: Rogan Dawes; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb On Wed, Jul 17, 2019 at 11:11:34AM +0200, Rogan Dawes wrote: > Add device id for D-Link DWM-222 A2. > > MI_00 D-Link HS-USB Diagnostics > MI_01 D-Link HS-USB Modem > MI_02 D-Link HS-USB AT Port > MI_03 D-Link HS-USB NMEA > MI_04 D-Link HS-USB WWAN Adapter (qmi_wwan) > MI_05 USB Mass Storage Device > > Cc: stable@vger.kernel.org > Signed-Off-By: Rogan Dawes <rogan@dawes.za.net> Now applied, thanks. Johan ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2019-08-05 11:36 UTC | newest] Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-11 9:40 [PATCH] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes 2019-07-11 10:34 ` [PATCH] USB: serial: option: add D-Link DWM-222 device ID [version 2] Rogan Dawes 2019-07-16 9:11 ` Johan Hovold 2019-07-16 10:55 ` Rogan Dawes 2019-07-16 11:17 ` Johan Hovold 2019-07-16 14:34 ` Lars Melin 2019-07-16 18:05 ` Johan Hovold 2019-07-16 18:40 ` Rogan Dawes 2019-07-16 18:49 ` Rogan Dawes 2019-07-16 19:02 ` [PATCH v4] USB: serial: option: add D-Link DWM-222 device ID Rogan Dawes 2019-07-16 19:12 ` [PATCH v5] USB: serial/qmi_wwan: " Rogan Dawes 2019-07-16 19:37 ` Greg KH 2019-07-16 19:44 ` Johan Hovold 2019-07-17 1:43 ` Dan Williams 2019-07-17 6:19 ` Johan Hovold 2019-07-17 9:11 ` [PATCH v6] USB: serial: option: " Rogan Dawes 2019-07-17 9:14 ` [PATCH] usb: qmi_wwan: add D-Link DWM-222 A2 " Rogan Dawes 2019-07-18 23:34 ` David Miller 2019-07-17 9:20 ` [PATCH v6] USB: serial: option: add D-Link DWM-222 " Johan Hovold 2019-07-17 9:37 ` Rogan Dawes 2019-08-05 11:36 ` Johan Hovold
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.