From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Ira Weiny" <ira.weiny@intel.com>,
john.hubbard@gmail.com,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Boaz Harrosh" <boaz@plexistor.com>,
"Christoph Hellwig" <hch@lst.de>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"David Airlie" <airlied@linux.ie>,
"David S . Miller" <davem@davemloft.net>,
"Ilya Dryomov" <idryomov@gmail.com>, "Jan Kara" <jack@suse.cz>,
"Jens Axboe" <axboe@kernel.dk>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Johannes Thumshirn" <jthumshirn@suse.de>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Ming Lei" <ming.lei@redhat.com>, "Sage Weil" <sage@redhat.com>,
"Santosh Shilimkar" <santosh.shilimkar@oracle.com>,
"Yan Zheng" <zyan@redhat.com>,
netdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mm@kvack.org, linux-rdma@vger.kernel.org,
bpf@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()
Date: Tue, 23 Jul 2019 09:47:07 -0300 [thread overview]
Message-ID: <20190723124707.GB15357@ziepe.ca> (raw)
In-Reply-To: <a4e9b293-11f8-6b3c-cf4d-308e3b32df34@nvidia.com>
On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote:
> * The leading underscores are often used for the more elaborate form of the
> call (as oppposed to decorating the core function name with "_flags", for
> example).
IMHO usually the __ version of a public symbol means something like
'why are you using this? you probably should not'
Often because the __ version has no locking or some other dangerous
configuration like that.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Ira Weiny" <ira.weiny@intel.com>,
john.hubbard@gmail.com,
"Andrew Morton" <akpm@linux-foundation.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Boaz Harrosh" <boaz@plexistor.com>,
"Christoph Hellwig" <hch@lst.de>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"David Airlie" <airlied@linux.ie>,
"David S . Miller" <davem@davemloft.net>,
"Ilya Dryomov" <idryomov@gmail.com>, "Jan Kara" <jack@suse.cz>,
"Jens Axboe" <axboe@kernel.dk>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Johannes Thumshirn" <jthumshirn@suse.de>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Miklos Szeredi" <miklos@szeredi.hu>
Subject: Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()
Date: Tue, 23 Jul 2019 09:47:07 -0300 [thread overview]
Message-ID: <20190723124707.GB15357@ziepe.ca> (raw)
In-Reply-To: <a4e9b293-11f8-6b3c-cf4d-308e3b32df34@nvidia.com>
On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote:
> * The leading underscores are often used for the more elaborate form of the
> call (as oppposed to decorating the core function name with "_flags", for
> example).
IMHO usually the __ version of a public symbol means something like
'why are you using this? you probably should not'
Often because the __ version has no locking or some other dangerous
configuration like that.
Jason
next prev parent reply other threads:[~2019-07-23 12:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 22:34 [PATCH 0/3] introduce __put_user_pages(), convert a few call sites john.hubbard
2019-07-22 22:34 ` john.hubbard
2019-07-22 22:34 ` [PATCH 1/3] mm/gup: introduce __put_user_pages() john.hubbard
2019-07-22 22:34 ` john.hubbard
2019-07-23 5:53 ` Christoph Hellwig
2019-07-23 6:33 ` John Hubbard
2019-07-23 6:33 ` John Hubbard
2019-07-23 15:36 ` Christoph Hellwig
2019-07-23 15:36 ` Christoph Hellwig
2019-07-22 22:34 ` [PATCH 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*() john.hubbard
2019-07-22 22:34 ` john.hubbard
2019-07-22 22:34 ` [PATCH 3/3] net/xdp: " john.hubbard
2019-07-22 22:34 ` john.hubbard
2019-07-23 0:25 ` Ira Weiny
2019-07-23 0:25 ` Ira Weiny
2019-07-23 4:41 ` John Hubbard
2019-07-23 4:41 ` John Hubbard
2019-07-23 12:47 ` Jason Gunthorpe [this message]
2019-07-23 12:47 ` Jason Gunthorpe
2019-07-23 18:06 ` Ira Weiny
2019-07-23 18:06 ` Ira Weiny
2019-07-23 23:24 ` John Hubbard
2019-07-23 23:24 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723124707.GB15357@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bjorn.topel@intel.com \
--cc=boaz@plexistor.com \
--cc=bpf@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=david@fromorbit.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=miklos@szeredi.hu \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sage@redhat.com \
--cc=santosh.shilimkar@oracle.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.