From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: broonie@kernel.org, festevam@gmail.com, perex@perex.cz,
tiwai@suse.com, Xiubo.Lee@gmail.com, timur@kernel.org,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
shengjiu.wang@nxp.com, angus@akkea.ca, kernel@pengutronix.de,
l.stach@pengutronix.de, viorel.suman@nxp.com
Subject: Re: [PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property
Date: Wed, 24 Jul 2019 16:22:09 -0700 [thread overview]
Message-ID: <20190724232209.GC6859@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190722124833.28757-9-daniel.baluta@nxp.com>
On Mon, Jul 22, 2019 at 03:48:31PM +0300, Daniel Baluta wrote:
> This allows combining multiple-data-line FIFOs into a
> single-data-line FIFO.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl-sai.txt | 4 ++++
This should be sent to devicetree mail-list also.
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> index 59f4d965a5fb..ca27afd840ba 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> @@ -54,6 +54,10 @@ Optional properties:
> represents first data line, bit 1 represents second
> data line and so on. Data line is enabled if
> corresponding bit is set to 1.
> + - fsl,fcomb_mode : list of two integers (first for RX, second for TX)
> + representing FIFO combine mode. Possible values for
> + combined mode are: 0 - disabled, 1 - Rx/Tx from shift
> + registers, 2 - Rx/Tx by software, 3 - both.
Looks like a software configuration to me, instead of a device
property. Is this configurable by user case, or hard-coded by
SoC/hardware design?
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: alsa-devel@alsa-project.org, viorel.suman@nxp.com,
timur@kernel.org, Xiubo.Lee@gmail.com,
linuxppc-dev@lists.ozlabs.org, shengjiu.wang@nxp.com,
angus@akkea.ca, tiwai@suse.com, perex@perex.cz,
broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
festevam@gmail.com, linux-kernel@vger.kernel.org,
l.stach@pengutronix.de
Subject: Re: [PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property
Date: Wed, 24 Jul 2019 16:22:09 -0700 [thread overview]
Message-ID: <20190724232209.GC6859@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190722124833.28757-9-daniel.baluta@nxp.com>
On Mon, Jul 22, 2019 at 03:48:31PM +0300, Daniel Baluta wrote:
> This allows combining multiple-data-line FIFOs into a
> single-data-line FIFO.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl-sai.txt | 4 ++++
This should be sent to devicetree mail-list also.
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> index 59f4d965a5fb..ca27afd840ba 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> @@ -54,6 +54,10 @@ Optional properties:
> represents first data line, bit 1 represents second
> data line and so on. Data line is enabled if
> corresponding bit is set to 1.
> + - fsl,fcomb_mode : list of two integers (first for RX, second for TX)
> + representing FIFO combine mode. Possible values for
> + combined mode are: 0 - disabled, 1 - Rx/Tx from shift
> + registers, 2 - Rx/Tx by software, 3 - both.
Looks like a software configuration to me, instead of a device
property. Is this configurable by user case, or hard-coded by
SoC/hardware design?
next prev parent reply other threads:[~2019-07-24 23:21 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:48 [PATCH 00/10] Add support for new SAI IP version Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 01/10] ASoC: fsl_sai: add of_match data Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-23 17:00 ` Mark Brown
2019-07-23 17:00 ` Mark Brown
2019-07-24 6:42 ` [alsa-devel] " Daniel Baluta
2019-07-24 6:42 ` Daniel Baluta
2019-07-24 22:34 ` Nicolin Chen
2019-07-24 22:34 ` Nicolin Chen
2019-07-25 6:00 ` [alsa-devel] " Daniel Baluta
2019-07-25 6:00 ` Daniel Baluta
2019-07-25 6:00 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 02/10] ASoC: fsl_sai: derive TX FIFO watermark from FIFO depth Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 03/10] ASoC: fsl_sai: Add registers definition for multiple datalines Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 04/10] ASoC: fsl_sai: Update Tx/Rx channel enable mask Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 05/10] ASoC: fsl_sai: Add support to enable multiple data lines Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:55 ` Lucas Stach
2019-07-22 12:55 ` Lucas Stach
2019-07-24 8:58 ` [alsa-devel] " Daniel Baluta
2019-07-24 8:58 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 06/10] ASoC: dt-bindings: Document dl_mask property Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 12:56 ` Lucas Stach
2019-07-22 12:56 ` Lucas Stach
2019-07-24 23:13 ` Nicolin Chen
2019-07-24 23:13 ` Nicolin Chen
2019-07-24 23:13 ` Nicolin Chen
2019-07-25 6:08 ` [alsa-devel] " Daniel Baluta
2019-07-25 6:08 ` Daniel Baluta
2019-07-25 6:08 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 07/10] ASoC: fsl_sai: Add support for FIFO combine mode Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 13:01 ` Lucas Stach
2019-07-22 13:01 ` Lucas Stach
2019-07-22 12:48 ` [PATCH 08/10] ASoC: dt-bindings: Document fcomb_mode property Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-24 23:22 ` Nicolin Chen [this message]
2019-07-24 23:22 ` Nicolin Chen
2019-07-25 6:02 ` [alsa-devel] " Daniel Baluta
2019-07-25 6:02 ` Daniel Baluta
2019-07-25 17:39 ` Nicolin Chen
2019-07-25 17:39 ` Nicolin Chen
2019-07-25 17:39 ` Nicolin Chen
2019-07-22 12:48 ` [PATCH 09/10] ASoC: fsl_sai: Add support for SAI new version Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-24 23:32 ` Nicolin Chen
2019-07-24 23:32 ` Nicolin Chen
2019-07-25 6:06 ` [alsa-devel] " Daniel Baluta
2019-07-25 6:06 ` Daniel Baluta
2019-07-22 12:48 ` [PATCH 10/10] ASoC: fsl_sai: Add support for imx7ulp/imx8mq Daniel Baluta
2019-07-22 12:48 ` Daniel Baluta
2019-07-22 13:04 ` Lucas Stach
2019-07-22 13:04 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724232209.GC6859@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=angus@akkea.ca \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.