All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] drm/tinydrm: Rename to drm/tiny
@ 2019-07-25 10:51 Noralf Trønnes
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
                   ` (4 more replies)
  0 siblings, 5 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-25 10:51 UTC (permalink / raw)
  To: dri-devel; +Cc: daniel.vetter, sam, hdegoede

This is the final polish on tinydrm turning it into _the_ place for tiny
DRM drivers.

Noralf.

Noralf Trønnes (3):
  drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  drm/tinydrm: Rename folder to tiny
  drm/gm12u320: Move driver to drm/tiny

 MAINTAINERS                                   | 14 +++----
 drivers/gpu/drm/Kconfig                       |  4 +-
 drivers/gpu/drm/Makefile                      |  3 +-
 drivers/gpu/drm/gm12u320/Kconfig              |  9 ----
 drivers/gpu/drm/gm12u320/Makefile             |  2 -
 drivers/gpu/drm/{tinydrm => tiny}/Kconfig     | 41 +++++++++++++------
 drivers/gpu/drm/{tinydrm => tiny}/Makefile    |  1 +
 drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c |  0
 drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c   |  0
 drivers/gpu/drm/{tinydrm => tiny}/ili9225.c   |  0
 drivers/gpu/drm/{tinydrm => tiny}/ili9341.c   |  0
 drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c  |  0
 drivers/gpu/drm/{tinydrm => tiny}/repaper.c   |  0
 drivers/gpu/drm/{tinydrm => tiny}/st7586.c    |  0
 drivers/gpu/drm/{tinydrm => tiny}/st7735r.c   |  0
 15 files changed, 38 insertions(+), 36 deletions(-)
 delete mode 100644 drivers/gpu/drm/gm12u320/Kconfig
 delete mode 100644 drivers/gpu/drm/gm12u320/Makefile
 rename drivers/gpu/drm/{tinydrm => tiny}/Kconfig (73%)
 rename drivers/gpu/drm/{tinydrm => tiny}/Makefile (89%)
 rename drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/ili9225.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/ili9341.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/repaper.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/st7586.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/st7735r.c (100%)

-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
@ 2019-07-25 10:51 ` Noralf Trønnes
  2019-07-30 13:19   ` Hans de Goede
                     ` (2 more replies)
  2019-07-25 10:51 ` [PATCH 2/3] drm/tinydrm: Rename folder to tiny Noralf Trønnes
                   ` (3 subsequent siblings)
  4 siblings, 3 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-25 10:51 UTC (permalink / raw)
  To: dri-devel; +Cc: daniel.vetter, sam, hdegoede

This makes the tiny drivers visible by default without having to enable a
knob.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/Makefile        |  2 +-
 drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
 2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 98c732f925c7..0b30afa7524d 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
 obj-y			+= hisilicon/
 obj-$(CONFIG_DRM_ZTE)	+= zte/
 obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
-obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
+obj-y			+= tinydrm/
 obj-$(CONFIG_DRM_PL111) += pl111/
 obj-$(CONFIG_DRM_TVE200) += tve200/
 obj-$(CONFIG_DRM_XEN) += xen/
diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
index 42b06f4f8989..f8c9a0e71dde 100644
--- a/drivers/gpu/drm/tinydrm/Kconfig
+++ b/drivers/gpu/drm/tinydrm/Kconfig
@@ -1,16 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0-only
-menuconfig DRM_TINYDRM
-	tristate "Support for simple displays"
-	depends on DRM
-	select DRM_KMS_HELPER
-	select DRM_KMS_CMA_HELPER
-	help
-	  Choose this option if you have a tinydrm supported display.
-	  If M is selected the module will be called tinydrm.
-
 config TINYDRM_HX8357D
 	tristate "DRM support for HX8357D display panels"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	select BACKLIGHT_CLASS_DEVICE
 	help
@@ -21,7 +14,9 @@ config TINYDRM_HX8357D
 
 config TINYDRM_ILI9225
 	tristate "DRM support for ILI9225 display panels"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	help
 	  DRM driver for the following Ilitek ILI9225 panels:
@@ -31,7 +26,9 @@ config TINYDRM_ILI9225
 
 config TINYDRM_ILI9341
 	tristate "DRM support for ILI9341 display panels"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	select BACKLIGHT_CLASS_DEVICE
 	help
@@ -42,7 +39,9 @@ config TINYDRM_ILI9341
 
 config TINYDRM_MI0283QT
 	tristate "DRM support for MI0283QT"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	select BACKLIGHT_CLASS_DEVICE
 	help
@@ -51,7 +50,9 @@ config TINYDRM_MI0283QT
 
 config TINYDRM_REPAPER
 	tristate "DRM support for Pervasive Displays RePaper panels (V231)"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	depends on THERMAL || !THERMAL
 	help
 	  DRM driver for the following Pervasive Displays panels:
@@ -64,7 +65,9 @@ config TINYDRM_REPAPER
 
 config TINYDRM_ST7586
 	tristate "DRM support for Sitronix ST7586 display panels"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	help
 	  DRM driver for the following Sitronix ST7586 panels:
@@ -74,7 +77,9 @@ config TINYDRM_ST7586
 
 config TINYDRM_ST7735R
 	tristate "DRM support for Sitronix ST7735R display panels"
-	depends on DRM_TINYDRM && SPI
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
 	select DRM_MIPI_DBI
 	select BACKLIGHT_CLASS_DEVICE
 	help
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [PATCH 2/3] drm/tinydrm: Rename folder to tiny
  2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
@ 2019-07-25 10:51 ` Noralf Trønnes
  2019-07-25 10:51 ` [PATCH 3/3] drm/gm12u320: Move driver to drm/tiny Noralf Trønnes
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-25 10:51 UTC (permalink / raw)
  To: dri-devel; +Cc: daniel.vetter, sam, hdegoede

The drm in tinydrm is superfluous so rename to tiny.

Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 MAINTAINERS                                  | 12 ++++++------
 drivers/gpu/drm/Kconfig                      |  2 +-
 drivers/gpu/drm/Makefile                     |  2 +-
 drivers/gpu/drm/{tinydrm => tiny}/Kconfig    |  0
 drivers/gpu/drm/{tinydrm => tiny}/Makefile   |  0
 drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c  |  0
 drivers/gpu/drm/{tinydrm => tiny}/ili9225.c  |  0
 drivers/gpu/drm/{tinydrm => tiny}/ili9341.c  |  0
 drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c |  0
 drivers/gpu/drm/{tinydrm => tiny}/repaper.c  |  0
 drivers/gpu/drm/{tinydrm => tiny}/st7586.c   |  0
 drivers/gpu/drm/{tinydrm => tiny}/st7735r.c  |  0
 12 files changed, 8 insertions(+), 8 deletions(-)
 rename drivers/gpu/drm/{tinydrm => tiny}/Kconfig (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/Makefile (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/ili9225.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/ili9341.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/repaper.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/st7586.c (100%)
 rename drivers/gpu/drm/{tinydrm => tiny}/st7735r.c (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 060ffe635832..00c7cbc92711 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5105,14 +5105,14 @@ DRM DRIVER FOR ILITEK ILI9225 PANELS
 M:	David Lechner <david@lechnology.com>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/ili9225.c
+F:	drivers/gpu/drm/tiny/ili9225.c
 F:	Documentation/devicetree/bindings/display/ilitek,ili9225.txt
 
 DRM DRIVER FOR HX8357D PANELS
 M:	Eric Anholt <eric@anholt.net>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/hx8357d.c
+F:	drivers/gpu/drm/tiny/hx8357d.c
 F:	Documentation/devicetree/bindings/display/himax,hx8357d.txt
 
 DRM DRIVER FOR INTEL I810 VIDEO CARDS
@@ -5134,7 +5134,7 @@ DRM DRIVER FOR MI0283QT
 M:	Noralf Trønnes <noralf@tronnes.org>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/mi0283qt.c
+F:	drivers/gpu/drm/tiny/mi0283qt.c
 F:	Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
 
 DRM DRIVER FOR MSM ADRENO GPU
@@ -5168,7 +5168,7 @@ DRM DRIVER FOR PERVASIVE DISPLAYS REPAPER PANELS
 M:	Noralf Trønnes <noralf@tronnes.org>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/repaper.c
+F:	drivers/gpu/drm/tiny/repaper.c
 F:	Documentation/devicetree/bindings/display/repaper.txt
 
 DRM DRIVER FOR QEMU'S CIRRUS DEVICE
@@ -5228,14 +5228,14 @@ DRM DRIVER FOR SITRONIX ST7586 PANELS
 M:	David Lechner <david@lechnology.com>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/st7586.c
+F:	drivers/gpu/drm/tiny/st7586.c
 F:	Documentation/devicetree/bindings/display/sitronix,st7586.txt
 
 DRM DRIVER FOR SITRONIX ST7735R PANELS
 M:	David Lechner <david@lechnology.com>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/tinydrm/st7735r.c
+F:	drivers/gpu/drm/tiny/st7735r.c
 F:	Documentation/devicetree/bindings/display/sitronix,st7735r.txt
 
 DRM DRIVER FOR ST-ERICSSON MCDE
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index a88581b0f002..a5ae0d369e88 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -340,7 +340,7 @@ source "drivers/gpu/drm/mxsfb/Kconfig"
 
 source "drivers/gpu/drm/meson/Kconfig"
 
-source "drivers/gpu/drm/tinydrm/Kconfig"
+source "drivers/gpu/drm/tiny/Kconfig"
 
 source "drivers/gpu/drm/pl111/Kconfig"
 
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 0b30afa7524d..1d366c4bbd1f 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
 obj-y			+= hisilicon/
 obj-$(CONFIG_DRM_ZTE)	+= zte/
 obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
-obj-y			+= tinydrm/
+obj-y			+= tiny/
 obj-$(CONFIG_DRM_PL111) += pl111/
 obj-$(CONFIG_DRM_TVE200) += tve200/
 obj-$(CONFIG_DRM_XEN) += xen/
diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tiny/Kconfig
similarity index 100%
rename from drivers/gpu/drm/tinydrm/Kconfig
rename to drivers/gpu/drm/tiny/Kconfig
diff --git a/drivers/gpu/drm/tinydrm/Makefile b/drivers/gpu/drm/tiny/Makefile
similarity index 100%
rename from drivers/gpu/drm/tinydrm/Makefile
rename to drivers/gpu/drm/tiny/Makefile
diff --git a/drivers/gpu/drm/tinydrm/hx8357d.c b/drivers/gpu/drm/tiny/hx8357d.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/hx8357d.c
rename to drivers/gpu/drm/tiny/hx8357d.c
diff --git a/drivers/gpu/drm/tinydrm/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/ili9225.c
rename to drivers/gpu/drm/tiny/ili9225.c
diff --git a/drivers/gpu/drm/tinydrm/ili9341.c b/drivers/gpu/drm/tiny/ili9341.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/ili9341.c
rename to drivers/gpu/drm/tiny/ili9341.c
diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/mi0283qt.c
rename to drivers/gpu/drm/tiny/mi0283qt.c
diff --git a/drivers/gpu/drm/tinydrm/repaper.c b/drivers/gpu/drm/tiny/repaper.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/repaper.c
rename to drivers/gpu/drm/tiny/repaper.c
diff --git a/drivers/gpu/drm/tinydrm/st7586.c b/drivers/gpu/drm/tiny/st7586.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/st7586.c
rename to drivers/gpu/drm/tiny/st7586.c
diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tiny/st7735r.c
similarity index 100%
rename from drivers/gpu/drm/tinydrm/st7735r.c
rename to drivers/gpu/drm/tiny/st7735r.c
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* [PATCH 3/3] drm/gm12u320: Move driver to drm/tiny
  2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
  2019-07-25 10:51 ` [PATCH 2/3] drm/tinydrm: Rename folder to tiny Noralf Trønnes
@ 2019-07-25 10:51 ` Noralf Trønnes
  2019-07-25 12:06 ` [PATCH 0/3] drm/tinydrm: Rename " Daniel Vetter
  2019-07-31 13:32 ` Noralf Trønnes
  4 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-25 10:51 UTC (permalink / raw)
  To: dri-devel; +Cc: daniel.vetter, sam, hdegoede

Move the driver to the new haven for tiny DRM drivers.

Cc: Hans de Goede <hdegoede@redhat.com>
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 MAINTAINERS                                   |  2 +-
 drivers/gpu/drm/Kconfig                       |  2 --
 drivers/gpu/drm/Makefile                      |  1 -
 drivers/gpu/drm/gm12u320/Kconfig              |  9 ---------
 drivers/gpu/drm/gm12u320/Makefile             |  2 --
 drivers/gpu/drm/tiny/Kconfig                  | 10 ++++++++++
 drivers/gpu/drm/tiny/Makefile                 |  1 +
 drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c |  0
 8 files changed, 12 insertions(+), 15 deletions(-)
 delete mode 100644 drivers/gpu/drm/gm12u320/Kconfig
 delete mode 100644 drivers/gpu/drm/gm12u320/Makefile
 rename drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 00c7cbc92711..6fe3462a1f7a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5099,7 +5099,7 @@ DRM DRIVER FOR GRAIN MEDIA GM12U320 PROJECTORS
 M:	Hans de Goede <hdegoede@redhat.com>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
-F:	drivers/gpu/drm/gm12u320/
+F:	drivers/gpu/drm/tiny/gm12u320.c
 
 DRM DRIVER FOR ILITEK ILI9225 PANELS
 M:	David Lechner <david@lechnology.com>
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index a5ae0d369e88..e6f40fb54c9a 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -358,8 +358,6 @@ source "drivers/gpu/drm/aspeed/Kconfig"
 
 source "drivers/gpu/drm/mcde/Kconfig"
 
-source "drivers/gpu/drm/gm12u320/Kconfig"
-
 # Keep legacy drivers last
 
 menuconfig DRM_LEGACY
diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
index 1d366c4bbd1f..10f8329a8b71 100644
--- a/drivers/gpu/drm/Makefile
+++ b/drivers/gpu/drm/Makefile
@@ -121,4 +121,3 @@ obj-$(CONFIG_DRM_LIMA)  += lima/
 obj-$(CONFIG_DRM_PANFROST) += panfrost/
 obj-$(CONFIG_DRM_ASPEED_GFX) += aspeed/
 obj-$(CONFIG_DRM_MCDE) += mcde/
-obj-$(CONFIG_DRM_GM12U320) += gm12u320/
diff --git a/drivers/gpu/drm/gm12u320/Kconfig b/drivers/gpu/drm/gm12u320/Kconfig
deleted file mode 100644
index 0882a61c04d5..000000000000
--- a/drivers/gpu/drm/gm12u320/Kconfig
+++ /dev/null
@@ -1,9 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-config DRM_GM12U320
-	tristate "GM12U320 driver for USB projectors"
-	depends on DRM && USB
-	select DRM_KMS_HELPER
-	select DRM_GEM_SHMEM_HELPER
-	help
-	 This is a KMS driver for projectors which use the GM12U320 chipset
-	 for video transfer over USB2/3, such as the Acer C120 mini projector.
diff --git a/drivers/gpu/drm/gm12u320/Makefile b/drivers/gpu/drm/gm12u320/Makefile
deleted file mode 100644
index ea514382f00d..000000000000
--- a/drivers/gpu/drm/gm12u320/Makefile
+++ /dev/null
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-obj-$(CONFIG_DRM_GM12U320) += gm12u320.o
diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index f8c9a0e71dde..504763423d46 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -1,4 +1,14 @@
 # SPDX-License-Identifier: GPL-2.0-only
+
+config DRM_GM12U320
+	tristate "GM12U320 driver for USB projectors"
+	depends on DRM && USB
+	select DRM_KMS_HELPER
+	select DRM_GEM_SHMEM_HELPER
+	help
+	 This is a KMS driver for projectors which use the GM12U320 chipset
+	 for video transfer over USB2/3, such as the Acer C120 mini projector.
+
 config TINYDRM_HX8357D
 	tristate "DRM support for HX8357D display panels"
 	depends on DRM && SPI
diff --git a/drivers/gpu/drm/tiny/Makefile b/drivers/gpu/drm/tiny/Makefile
index 6490167a9ad1..896cf31132d3 100644
--- a/drivers/gpu/drm/tiny/Makefile
+++ b/drivers/gpu/drm/tiny/Makefile
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
+obj-$(CONFIG_DRM_GM12U320)		+= gm12u320.o
 obj-$(CONFIG_TINYDRM_HX8357D)		+= hx8357d.o
 obj-$(CONFIG_TINYDRM_ILI9225)		+= ili9225.o
 obj-$(CONFIG_TINYDRM_ILI9341)		+= ili9341.o
diff --git a/drivers/gpu/drm/gm12u320/gm12u320.c b/drivers/gpu/drm/tiny/gm12u320.c
similarity index 100%
rename from drivers/gpu/drm/gm12u320/gm12u320.c
rename to drivers/gpu/drm/tiny/gm12u320.c
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny
  2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
                   ` (2 preceding siblings ...)
  2019-07-25 10:51 ` [PATCH 3/3] drm/gm12u320: Move driver to drm/tiny Noralf Trønnes
@ 2019-07-25 12:06 ` Daniel Vetter
  2019-07-25 12:46   ` Noralf Trønnes
  2019-07-31 13:32 ` Noralf Trønnes
  4 siblings, 1 reply; 25+ messages in thread
From: Daniel Vetter @ 2019-07-25 12:06 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: daniel.vetter, sam, dri-devel, hdegoede

On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote:
> This is the final polish on tinydrm turning it into _the_ place for tiny
> DRM drivers.
> 
> Noralf.
> 
> Noralf Trønnes (3):
>   drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
>   drm/tinydrm: Rename folder to tiny
>   drm/gm12u320: Move driver to drm/tiny

I wonder whether we could place a documentation hint somewhere to put
tiny drm drivers (i.e. one file only, and that one pretty small) into
drm/tiny. But I couldn't come up with a good place. Maybe re-add tiny.rst
with a short overview paragraph that points at the most useful helpers for
tiny drivers, plus how to integrate them? Kinda as a FAQ to the "I want to
port an fbdev driver, halp pls?" question.

Anyway that's just an idea aside, on the series:

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
>  MAINTAINERS                                   | 14 +++----
>  drivers/gpu/drm/Kconfig                       |  4 +-
>  drivers/gpu/drm/Makefile                      |  3 +-
>  drivers/gpu/drm/gm12u320/Kconfig              |  9 ----
>  drivers/gpu/drm/gm12u320/Makefile             |  2 -
>  drivers/gpu/drm/{tinydrm => tiny}/Kconfig     | 41 +++++++++++++------
>  drivers/gpu/drm/{tinydrm => tiny}/Makefile    |  1 +
>  drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c |  0
>  drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c   |  0
>  drivers/gpu/drm/{tinydrm => tiny}/ili9225.c   |  0
>  drivers/gpu/drm/{tinydrm => tiny}/ili9341.c   |  0
>  drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c  |  0
>  drivers/gpu/drm/{tinydrm => tiny}/repaper.c   |  0
>  drivers/gpu/drm/{tinydrm => tiny}/st7586.c    |  0
>  drivers/gpu/drm/{tinydrm => tiny}/st7735r.c   |  0
>  15 files changed, 38 insertions(+), 36 deletions(-)
>  delete mode 100644 drivers/gpu/drm/gm12u320/Kconfig
>  delete mode 100644 drivers/gpu/drm/gm12u320/Makefile
>  rename drivers/gpu/drm/{tinydrm => tiny}/Kconfig (73%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/Makefile (89%)
>  rename drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/ili9225.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/ili9341.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/repaper.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/st7586.c (100%)
>  rename drivers/gpu/drm/{tinydrm => tiny}/st7735r.c (100%)
> 
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny
  2019-07-25 12:06 ` [PATCH 0/3] drm/tinydrm: Rename " Daniel Vetter
@ 2019-07-25 12:46   ` Noralf Trønnes
  2019-07-25 15:10     ` Sam Ravnborg
  0 siblings, 1 reply; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-25 12:46 UTC (permalink / raw)
  To: Daniel Vetter, sam; +Cc: daniel.vetter, dri-devel, hdegoede



Den 25.07.2019 14.06, skrev Daniel Vetter:
> On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote:
>> This is the final polish on tinydrm turning it into _the_ place for tiny
>> DRM drivers.
>>
>> Noralf.
>>
>> Noralf Trønnes (3):
>>   drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
>>   drm/tinydrm: Rename folder to tiny
>>   drm/gm12u320: Move driver to drm/tiny
> 
> I wonder whether we could place a documentation hint somewhere to put
> tiny drm drivers (i.e. one file only, and that one pretty small) into
> drm/tiny. But I couldn't come up with a good place. Maybe re-add tiny.rst
> with a short overview paragraph that points at the most useful helpers for
> tiny drivers, plus how to integrate them? Kinda as a FAQ to the "I want to
> port an fbdev driver, halp pls?" question.
> 

Sam, is this something you could do, you giving a talk about this and
everything :-)

A link to the driver example in drivers/gpu/drm/drm_drv.c: "DOC: driver
instance overview" would make sense in such a doc.

Noralf.

> Anyway that's just an idea aside, on the series:
> 
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
>>
>>  MAINTAINERS                                   | 14 +++----
>>  drivers/gpu/drm/Kconfig                       |  4 +-
>>  drivers/gpu/drm/Makefile                      |  3 +-
>>  drivers/gpu/drm/gm12u320/Kconfig              |  9 ----
>>  drivers/gpu/drm/gm12u320/Makefile             |  2 -
>>  drivers/gpu/drm/{tinydrm => tiny}/Kconfig     | 41 +++++++++++++------
>>  drivers/gpu/drm/{tinydrm => tiny}/Makefile    |  1 +
>>  drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c   |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/ili9225.c   |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/ili9341.c   |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c  |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/repaper.c   |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/st7586.c    |  0
>>  drivers/gpu/drm/{tinydrm => tiny}/st7735r.c   |  0
>>  15 files changed, 38 insertions(+), 36 deletions(-)
>>  delete mode 100644 drivers/gpu/drm/gm12u320/Kconfig
>>  delete mode 100644 drivers/gpu/drm/gm12u320/Makefile
>>  rename drivers/gpu/drm/{tinydrm => tiny}/Kconfig (73%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/Makefile (89%)
>>  rename drivers/gpu/drm/{gm12u320 => tiny}/gm12u320.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/hx8357d.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/ili9225.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/ili9341.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/mi0283qt.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/repaper.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/st7586.c (100%)
>>  rename drivers/gpu/drm/{tinydrm => tiny}/st7735r.c (100%)
>>
>> -- 
>> 2.20.1
>>
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny
  2019-07-25 12:46   ` Noralf Trønnes
@ 2019-07-25 15:10     ` Sam Ravnborg
  0 siblings, 0 replies; 25+ messages in thread
From: Sam Ravnborg @ 2019-07-25 15:10 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: daniel.vetter, dri-devel, hdegoede

Hi Noralf.

On Thu, Jul 25, 2019 at 02:46:08PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 25.07.2019 14.06, skrev Daniel Vetter:
> > On Thu, Jul 25, 2019 at 12:51:29PM +0200, Noralf Trønnes wrote:
> >> This is the final polish on tinydrm turning it into _the_ place for tiny
> >> DRM drivers.
> >>
> >> Noralf.
> >>
> >> Noralf Trønnes (3):
> >>   drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
> >>   drm/tinydrm: Rename folder to tiny
> >>   drm/gm12u320: Move driver to drm/tiny
I have thrown the patch-set after my usual build testing.
Looks good - so you can consider the full series:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> > 
> > I wonder whether we could place a documentation hint somewhere to put
> > tiny drm drivers (i.e. one file only, and that one pretty small) into
> > drm/tiny. But I couldn't come up with a good place. Maybe re-add tiny.rst
> > with a short overview paragraph that points at the most useful helpers for
> > tiny drivers, plus how to integrate them? Kinda as a FAQ to the "I want to
> > port an fbdev driver, halp pls?" question.
> > 
> 
> Sam, is this something you could do, you giving a talk about this and
> everything :-)

Talk proposal is accepted, but I need to get a few details in order
here. (work, family stuff).

And then I also hope to actaully create a first tiny driver - awaiting
display to arrive by mail.

But if that all succeeds then I will be happy to try to come up with
something that would have helped me.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
@ 2019-07-30 13:19   ` Hans de Goede
  2019-07-30 13:34     ` Noralf Trønnes
  2019-07-30 13:53   ` Emil Velikov
  2019-10-01 12:36   ` [1/3] " Jason Gunthorpe
  2 siblings, 1 reply; 25+ messages in thread
From: Hans de Goede @ 2019-07-30 13:19 UTC (permalink / raw)
  To: Noralf Trønnes, dri-devel; +Cc: daniel.vetter, sam

Hi,

On 25-07-19 12:51, Noralf Trønnes wrote:
> This makes the tiny drivers visible by default without having to enable a
> knob.
> 
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>   drivers/gpu/drm/Makefile        |  2 +-
>   drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>   2 files changed, 22 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 42b06f4f8989..f8c9a0e71dde 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -1,16 +1,9 @@
>   # SPDX-License-Identifier: GPL-2.0-only
> -menuconfig DRM_TINYDRM
> -	tristate "Support for simple displays"
> -	depends on DRM
> -	select DRM_KMS_HELPER
> -	select DRM_KMS_CMA_HELPER
> -	help
> -	  Choose this option if you have a tinydrm supported display.
> -	  If M is selected the module will be called tinydrm.
> -
>   config TINYDRM_HX8357D
>   	tristate "DRM support for HX8357D display panels"
> -	depends on DRM_TINYDRM && SPI
> +	depends on DRM && SPI
> +	select DRM_KMS_HELPER
> +	select DRM_KMS_CMA_HELPER
>   	select DRM_MIPI_DBI
>   	select BACKLIGHT_CLASS_DEVICE
>   	help

<snip>

drivers/gpu/drm/tinydrm/Makefile has:

obj-$(CONFIG_DRM_TINYDRM)               += core/

And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
actually need the tinydrm-core.

So instead you should make the config option a hidden one
and select it in all the drivers which need it, otherwise
things will no longer work after a clean build AFAICT.

Note that even though the config option now remains, this change:

 > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
 > index 98c732f925c7..0b30afa7524d 100644
 > --- a/drivers/gpu/drm/Makefile
 > +++ b/drivers/gpu/drm/Makefile
 > @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
 >   obj-y			+= hisilicon/
 >   obj-$(CONFIG_DRM_ZTE)	+= zte/
 >   obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
 > -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
 > +obj-y			+= tinydrm/
 >   obj-$(CONFIG_DRM_PL111) += pl111/
 >   obj-$(CONFIG_DRM_TVE200) += tve200/
 >   obj-$(CONFIG_DRM_XEN) += xen/

Is still necessary so that when other drivers which do not
depend on the tinydrm core and thus will not do:
	select DRM_TINYDRM
will still get build.

Otherwise this series looks good to me and you can add my:

Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
this is fixed.

Note that drivers/gpu/drm/cirrus is a single .c file tiny
driver now a days too, so it too could be moved to the new
tiny dir. I was actually planning on doing something similar
to this series once I got one more tiny driver upstream :)

Regards,

Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-30 13:19   ` Hans de Goede
@ 2019-07-30 13:34     ` Noralf Trønnes
  2019-07-30 13:35       ` Hans de Goede
  0 siblings, 1 reply; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-30 13:34 UTC (permalink / raw)
  To: Hans de Goede, dri-devel; +Cc: daniel.vetter, sam



Den 30.07.2019 15.19, skrev Hans de Goede:
> Hi,
> 
> On 25-07-19 12:51, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> ---
>>   drivers/gpu/drm/Makefile        |  2 +-
>>   drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>   2 files changed, 22 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tinydrm/Kconfig
>> b/drivers/gpu/drm/tinydrm/Kconfig
>> index 42b06f4f8989..f8c9a0e71dde 100644
>> --- a/drivers/gpu/drm/tinydrm/Kconfig
>> +++ b/drivers/gpu/drm/tinydrm/Kconfig
>> @@ -1,16 +1,9 @@
>>   # SPDX-License-Identifier: GPL-2.0-only
>> -menuconfig DRM_TINYDRM
>> -    tristate "Support for simple displays"
>> -    depends on DRM
>> -    select DRM_KMS_HELPER
>> -    select DRM_KMS_CMA_HELPER
>> -    help
>> -      Choose this option if you have a tinydrm supported display.
>> -      If M is selected the module will be called tinydrm.
>> -
>>   config TINYDRM_HX8357D
>>       tristate "DRM support for HX8357D display panels"
>> -    depends on DRM_TINYDRM && SPI
>> +    depends on DRM && SPI
>> +    select DRM_KMS_HELPER
>> +    select DRM_KMS_CMA_HELPER
>>       select DRM_MIPI_DBI
>>       select BACKLIGHT_CLASS_DEVICE
>>       help
> 
> <snip>
> 
> drivers/gpu/drm/tinydrm/Makefile has:
> 
> obj-$(CONFIG_DRM_TINYDRM)               += core/
> 
> And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
> actually need the tinydrm-core.
> 

This is gone in current drm-misc-next.
It went away with:
drm/tinydrm: Remove tinydrm.ko
https://patchwork.freedesktop.org/series/63811/

Noralf.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-30 13:34     ` Noralf Trønnes
@ 2019-07-30 13:35       ` Hans de Goede
  0 siblings, 0 replies; 25+ messages in thread
From: Hans de Goede @ 2019-07-30 13:35 UTC (permalink / raw)
  To: Noralf Trønnes, dri-devel; +Cc: daniel.vetter, sam

Hi,

On 30-07-19 15:34, Noralf Trønnes wrote:
> 
> 
> Den 30.07.2019 15.19, skrev Hans de Goede:
>> Hi,
>>
>> On 25-07-19 12:51, Noralf Trønnes wrote:
>>> This makes the tiny drivers visible by default without having to enable a
>>> knob.
>>>
>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>>> ---
>>>    drivers/gpu/drm/Makefile        |  2 +-
>>>    drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>>    2 files changed, 22 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/tinydrm/Kconfig
>>> b/drivers/gpu/drm/tinydrm/Kconfig
>>> index 42b06f4f8989..f8c9a0e71dde 100644
>>> --- a/drivers/gpu/drm/tinydrm/Kconfig
>>> +++ b/drivers/gpu/drm/tinydrm/Kconfig
>>> @@ -1,16 +1,9 @@
>>>    # SPDX-License-Identifier: GPL-2.0-only
>>> -menuconfig DRM_TINYDRM
>>> -    tristate "Support for simple displays"
>>> -    depends on DRM
>>> -    select DRM_KMS_HELPER
>>> -    select DRM_KMS_CMA_HELPER
>>> -    help
>>> -      Choose this option if you have a tinydrm supported display.
>>> -      If M is selected the module will be called tinydrm.
>>> -
>>>    config TINYDRM_HX8357D
>>>        tristate "DRM support for HX8357D display panels"
>>> -    depends on DRM_TINYDRM && SPI
>>> +    depends on DRM && SPI
>>> +    select DRM_KMS_HELPER
>>> +    select DRM_KMS_CMA_HELPER
>>>        select DRM_MIPI_DBI
>>>        select BACKLIGHT_CLASS_DEVICE
>>>        help
>>
>> <snip>
>>
>> drivers/gpu/drm/tinydrm/Makefile has:
>>
>> obj-$(CONFIG_DRM_TINYDRM)               += core/
>>
>> And AFAIK at least most of the drivers under drivers/gpu/drm/tinydrm
>> actually need the tinydrm-core.
>>
> 
> This is gone in current drm-misc-next.
> It went away with:
> drm/tinydrm: Remove tinydrm.ko
> https://patchwork.freedesktop.org/series/63811/

Ah I see.

Regards,

Hans

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
  2019-07-30 13:19   ` Hans de Goede
@ 2019-07-30 13:53   ` Emil Velikov
  2019-07-30 14:03     ` Noralf Trønnes
  2019-10-01 12:36   ` [1/3] " Jason Gunthorpe
  2 siblings, 1 reply; 25+ messages in thread
From: Emil Velikov @ 2019-07-30 13:53 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: daniel.vetter, sam, dri-devel, hdegoede

On 2019/07/25, Noralf Trønnes wrote:
> This makes the tiny drivers visible by default without having to enable a
> knob.
> 
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>  drivers/gpu/drm/Makefile        |  2 +-
>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>  2 files changed, 22 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 98c732f925c7..0b30afa7524d 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
>  obj-y			+= hisilicon/
>  obj-$(CONFIG_DRM_ZTE)	+= zte/
>  obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> +obj-y			+= tinydrm/
>  obj-$(CONFIG_DRM_PL111) += pl111/
>  obj-$(CONFIG_DRM_TVE200) += tve200/
>  obj-$(CONFIG_DRM_XEN) += xen/
> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> index 42b06f4f8989..f8c9a0e71dde 100644
> --- a/drivers/gpu/drm/tinydrm/Kconfig
> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> @@ -1,16 +1,9 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> -menuconfig DRM_TINYDRM
> -	tristate "Support for simple displays"
> -	depends on DRM
> -	select DRM_KMS_HELPER
> -	select DRM_KMS_CMA_HELPER
> -	help
> -	  Choose this option if you have a tinydrm supported display.
> -	  If M is selected the module will be called tinydrm.
> -
Fwiw I would have gone with Han's idea of making this hidden. That has a
number of advantages, even if we don't have a separate tinydrm.ko:
 - the tinydrm code is not build when there are no users
 - the tinydrm dependencies are contained within itself, instead of
updating 5-10 individual drivers

That said, I won't get in the way if people like this approach ;-)

HTH
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-30 13:53   ` Emil Velikov
@ 2019-07-30 14:03     ` Noralf Trønnes
  2019-07-30 14:16       ` Emil Velikov
  0 siblings, 1 reply; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-30 14:03 UTC (permalink / raw)
  To: Emil Velikov; +Cc: daniel.vetter, sam, dri-devel, hdegoede



Den 30.07.2019 15.53, skrev Emil Velikov:
> On 2019/07/25, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> ---
>>  drivers/gpu/drm/Makefile        |  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>  2 files changed, 22 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
>> index 98c732f925c7..0b30afa7524d 100644
>> --- a/drivers/gpu/drm/Makefile
>> +++ b/drivers/gpu/drm/Makefile
>> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
>>  obj-y			+= hisilicon/
>>  obj-$(CONFIG_DRM_ZTE)	+= zte/
>>  obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
>> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
>> +obj-y			+= tinydrm/
>>  obj-$(CONFIG_DRM_PL111) += pl111/
>>  obj-$(CONFIG_DRM_TVE200) += tve200/
>>  obj-$(CONFIG_DRM_XEN) += xen/
>> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
>> index 42b06f4f8989..f8c9a0e71dde 100644
>> --- a/drivers/gpu/drm/tinydrm/Kconfig
>> +++ b/drivers/gpu/drm/tinydrm/Kconfig
>> @@ -1,16 +1,9 @@
>>  # SPDX-License-Identifier: GPL-2.0-only
>> -menuconfig DRM_TINYDRM
>> -	tristate "Support for simple displays"
>> -	depends on DRM
>> -	select DRM_KMS_HELPER
>> -	select DRM_KMS_CMA_HELPER
>> -	help
>> -	  Choose this option if you have a tinydrm supported display.
>> -	  If M is selected the module will be called tinydrm.
>> -
> Fwiw I would have gone with Han's idea of making this hidden. That has a
> number of advantages, even if we don't have a separate tinydrm.ko:
>  - the tinydrm code is not build when there are no users

The thing is, there is no tinydrm code anymore, it's all been put into
various core helpers. The folder does only contain regular DRM drivers.
The only thing special about them is that they fit into one source file.

Noralf.

>  - the tinydrm dependencies are contained within itself, instead of
> updating 5-10 individual drivers
> 
> That said, I won't get in the way if people like this approach ;-)
> 
> HTH
> -Emil
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-30 14:03     ` Noralf Trønnes
@ 2019-07-30 14:16       ` Emil Velikov
  0 siblings, 0 replies; 25+ messages in thread
From: Emil Velikov @ 2019-07-30 14:16 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: daniel.vetter, sam, dri-devel, hdegoede

On 2019/07/30, Noralf Trønnes wrote:
> 
> 
> Den 30.07.2019 15.53, skrev Emil Velikov:
> > On 2019/07/25, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >> ---
> >>  drivers/gpu/drm/Makefile        |  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> >> index 98c732f925c7..0b30afa7524d 100644
> >> --- a/drivers/gpu/drm/Makefile
> >> +++ b/drivers/gpu/drm/Makefile
> >> @@ -112,7 +112,7 @@ obj-$(CONFIG_DRM_ARCPGU)+= arc/
> >>  obj-y			+= hisilicon/
> >>  obj-$(CONFIG_DRM_ZTE)	+= zte/
> >>  obj-$(CONFIG_DRM_MXSFB)	+= mxsfb/
> >> -obj-$(CONFIG_DRM_TINYDRM) += tinydrm/
> >> +obj-y			+= tinydrm/
> >>  obj-$(CONFIG_DRM_PL111) += pl111/
> >>  obj-$(CONFIG_DRM_TVE200) += tve200/
> >>  obj-$(CONFIG_DRM_XEN) += xen/
> >> diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
> >> index 42b06f4f8989..f8c9a0e71dde 100644
> >> --- a/drivers/gpu/drm/tinydrm/Kconfig
> >> +++ b/drivers/gpu/drm/tinydrm/Kconfig
> >> @@ -1,16 +1,9 @@
> >>  # SPDX-License-Identifier: GPL-2.0-only
> >> -menuconfig DRM_TINYDRM
> >> -	tristate "Support for simple displays"
> >> -	depends on DRM
> >> -	select DRM_KMS_HELPER
> >> -	select DRM_KMS_CMA_HELPER
> >> -	help
> >> -	  Choose this option if you have a tinydrm supported display.
> >> -	  If M is selected the module will be called tinydrm.
> >> -
> > Fwiw I would have gone with Han's idea of making this hidden. That has a
> > number of advantages, even if we don't have a separate tinydrm.ko:
> >  - the tinydrm code is not build when there are no users
> 
> The thing is, there is no tinydrm code anymore, it's all been put into
> various core helpers. The folder does only contain regular DRM drivers.
> The only thing special about them is that they fit into one source file.

Right, I saw your series killing tinydrm.ko [1] and missed see the
mipi-dbi.c move with commit 174102f4de230a1bf85e6ef2f8c83e50b3ba22c9

Thanks for the awesome work.
Emil

[1] https://patchwork.freedesktop.org/series/63811/
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [PATCH 0/3] drm/tinydrm: Rename to drm/tiny
  2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
                   ` (3 preceding siblings ...)
  2019-07-25 12:06 ` [PATCH 0/3] drm/tinydrm: Rename " Daniel Vetter
@ 2019-07-31 13:32 ` Noralf Trønnes
  4 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-07-31 13:32 UTC (permalink / raw)
  To: dri-devel; +Cc: daniel.vetter, sam, hdegoede



Den 25.07.2019 12.51, skrev Noralf Trønnes:
> This is the final polish on tinydrm turning it into _the_ place for tiny
> DRM drivers.
> 
> Noralf.
> 
> Noralf Trønnes (3):
>   drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
>   drm/tinydrm: Rename folder to tiny
>   drm/gm12u320: Move driver to drm/tiny
> 

Series applied to drm-misc-next, thanks for reviewing.

Noralf.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
  2019-07-30 13:19   ` Hans de Goede
  2019-07-30 13:53   ` Emil Velikov
@ 2019-10-01 12:36   ` Jason Gunthorpe
  2019-10-01 13:28       ` Noralf Trønnes
  2 siblings, 1 reply; 25+ messages in thread
From: Jason Gunthorpe @ 2019-10-01 12:36 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: dri-devel, daniel.vetter, sam, hdegoede, linux-kernel

On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> This makes the tiny drivers visible by default without having to enable a
> knob.
> 
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
> ---
>  drivers/gpu/drm/Makefile        |  2 +-
>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>  2 files changed, 22 insertions(+), 17 deletions(-)

Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
breaks kconfig stuff in v5.4-rc by creating circular
dependencies. Could someone send a -rc patch to fix this please?

THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)

Full output:

kconfiglib.KconfigError: 
Dependency loop
===============

THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...

config THINKPAD_ACPI
	tristate "ThinkPad ACPI Laptop Extras"
	select HWMON
	select NVRAM
	select NEW_LEDS
	select LEDS_CLASS
	select LEDS_TRIGGERS
	select LEDS_TRIGGER_AUDIO
	depends on ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86
	help
	  This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
	  support for Fn-Fx key combinations, Bluetooth control, video
	  output switching, ThinkLight control, UltraBay eject and more.
	  For more information about this driver see
	  <file:Documentation/admin-guide/laptops/thinkpad-acpi.rst> and
	  <http://ibm-acpi.sf.net/> .
	  
	  This driver was formerly known as ibm-acpi.
	  
	  Extra functionality will be available if the rfkill (CONFIG_RFKILL)
	  and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
	  Note that if you want ThinkPad-ACPI to be built-in instead of
	  modular, ALSA and rfkill will also have to be built-in.
	  
	  If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.

...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...

config ACPI_VIDEO
	tristate "Video"
	select THERMAL
	depends on X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI
	help
	  This driver implements the ACPI Extensions For Display Adapters
	  for integrated graphics devices on motherboard, as specified in
	  ACPI 2.0 Specification, Appendix B.  This supports basic operations
	  such as defining the video POST device, retrieving EDID information,
	  and setting up a video output.
	  
	  To compile this driver as a module, choose M here:
	  the module will be called video.

(select-related dependencies: (DRM_NOUVEAU && ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && ACPI && DRM && X86 && PCI && HAS_IOMEM) || (DRM_GMA500 && ACPI && DRM && PCI && X86 && MMU && HAS_IOMEM) || (ACER_WMI && ACPI && ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86))

...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...

config ACER_WMI
	tristate "Acer WMI Laptop Extras"
	select LEDS_CLASS
	select NEW_LEDS
	select INPUT_SPARSEKMAP
	select ACPI_VIDEO if ACPI
	depends on ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86
	help
	  This is a driver for newer Acer (and Wistron) laptops. It adds
	  wireless radio and bluetooth control, and on some laptops,
	  exposes the mail LED and LCD backlight.
	  
	  If you have an ACPI-WMI compatible Acer/ Wistron laptop, say Y or M
	  here.

...depends on SERIO_I8042 (defined at drivers/input/serio/Kconfig:29), with definition...

config SERIO_I8042
	tristate "i8042 PC Keyboard controller"
	default y
	depends on ARCH_MIGHT_HAVE_PC_SERIO && SERIO && !UML
	help
	  i8042 is the chip over which the standard AT keyboard and PS/2
	  mouse are connected to the computer. If you use these devices,
	  you'll need to say Y here.
	  
	  If unsure, say Y.
	  
	  To compile this driver as a module, choose M here: the
	  module will be called i8042.

(select-related dependencies: (KEYBOARD_ATKBD && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_MOUSE && INPUT && !UML))

...depends on SERIO (defined at drivers/input/serio/Kconfig:5), with definition...

config SERIO
	tristate "Serial I/O support"
	default y
	depends on !UML
	help
	  Say Yes here if you have any input device that uses serial I/O to
	  communicate with the system. This includes the
	                * standard AT keyboard and PS/2 mouse *
	  as well as serial mice, Sun keyboards, some joysticks and 6dof
	  devices and more.
	  
	  If unsure, say Y.
	  
	  To compile this driver as a module, choose M here: the
	  module will be called serio.

(select-related dependencies: (KEYBOARD_ATKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_LKKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_HIL && (GSC || HP300) && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_NEWTON && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_STOWAWAY && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_SUNKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_XTKBD && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && INPUT_MOUSE && INPUT && !UML) || (MOUSE_SERIAL && INPUT_MOUSE && INPUT && !UML) || (MOUSE_VSXXXAA && INPUT_MOUSE && INPUT && !UML) || (JOYSTICK_WARRIOR && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_MAGELLAN && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEORB && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEBALL && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_STINGER && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_TWIDJOY && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_ZHENHUA && INPUT_JOYSTICK && INPUT && !UML) || (TABLET_SERIAL_WACOM4 && INPUT_TABLET && INPUT && !UML) || (TOUCHSCREEN_DYNAPRO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_HAMPSHIRE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_EGALAX_SERIAL && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_FUJITSU && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_GUNZE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_ELO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_WACOM_W8001 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_MTOUCH && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_INEXIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_PENMOUNT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHRIGHT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHWIN && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHIT213 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TSC_SERIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (RMI4_F03_SERIO && RMI4_CORE && RMI4_F03 && RMI4_CORE && INPUT && !UML) || (I2C_TAOS_EVM && TTY && HAS_IOMEM && I2C) || (USB_PULSE8_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT) || (USB_RAINSHADOW_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT))

...depends on RMI4_F03 (defined at drivers/input/rmi4/Kconfig:46), with definition...

config RMI4_F03
	bool "RMI4 Function 03 (PS2 Guest)"
	depends on RMI4_CORE && RMI4_CORE && INPUT && !UML
	help
	  Say Y here if you want to add support for RMI4 function 03.
	  
	  Function 03 provides PS2 guest support for RMI4 devices. This
	  includes support for TrackPoints on TouchPads.

(select-related dependencies: HID_RMI && HID && HID && HID && INPUT)

...depends on HID_RMI (defined at drivers/hid/Kconfig:919), with definition...

config HID_RMI
	tristate "Synaptics RMI4 device support"
	select RMI4_CORE
	select RMI4_F03
	select RMI4_F11
	select RMI4_F12
	select RMI4_F30
	depends on HID && HID && HID && INPUT
	help
	  Support for Synaptics RMI4 touchpads.
	  Say Y here if you have a Synaptics RMI4 touchpads over i2c-hid or usbhid
	  and want support for its special functionalities.

...depends on HID (defined at drivers/hid/Kconfig:8), with definition...

config HID
	tristate "HID bus support"
	default y
	depends on INPUT && INPUT
	help
	  A human interface device (HID) is a type of computer device that
	  interacts directly with and takes input from humans. The term "HID"
	  most commonly used to refer to the USB-HID specification, but other
	  devices (such as, but not strictly limited to, Bluetooth) are
	  designed using HID specification (this involves certain keyboards,
	  mice, tablets, etc). This option adds the HID bus to the kernel,
	  together with generic HID layer code. The HID devices are added and
	  removed from the HID bus by the transport-layer drivers, such as
	  usbhid (USB_HID) and hidp (BT_HIDP).
	  
	  For docs and specs, see http://www.usb.org/developers/hidpage/
	  
	  If unsure, say Y.

(select-related dependencies: (BT_HIDP && BT_BREDR && INPUT && NET) || (USB_HID && USB && INPUT && USB && INPUT) || (I2C_HID && I2C && INPUT && I2C && INPUT) || (INTEL_ISH_HID && (X86_64 || COMPILE_TEST) && PCI && INPUT))

...depends on I2C_HID (defined at drivers/hid/i2c-hid/Kconfig:5), with definition...

config I2C_HID
	tristate "HID over I2C transport layer"
	default n
	select HID
	depends on I2C && INPUT && I2C && INPUT
	help
	  Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
	  other HID based devices which is connected to your computer via I2C.
	  
	  If unsure, say N.
	  
	  This support is also available as a module.  If so, the module
	  will be called i2c-hid.

...depends on I2C (defined at drivers/i2c/Kconfig:8), with definition...

config I2C
	tristate "I2C support"
	select RT_MUTEXES
	select IRQ_DOMAIN
	help
	  I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
	  many micro controller applications and developed by Philips.  SMBus,
	  or System Management Bus is a subset of the I2C protocol.  More
	  information is contained in the directory <file:Documentation/i2c/>,
	  especially in the file called "summary" there.
	  
	  Both I2C and SMBus are supported here. You will need this for
	  hardware sensors support, and also for Video For Linux support.
	  
	  If you want I2C support, you should say Y here and also to the
	  specific driver for your bus adapter(s) below.
	  
	  This I2C support can also be built as a module.  If so, the module
	  will be called i2c-core.

(select-related dependencies: (X86_INTEL_MID && X86_EXTENDED_PLATFORM && X86_PLATFORM_DEVICES && PCI && (X86_64 || (PCI_GOANY && X86_32)) && X86_IO_APIC) || (CAN_PEAK_PCIEC && CAN_PEAK_PCI && CAN_SJA1000 && CAN_DEV && CAN && NET) || (IGB && PCI && NET_VENDOR_INTEL && ETHERNET && NETDEVICES) || (SFC && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (SFC_FALCON && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (IPMI_SSIF && IPMI_HANDLER) || I3C || (MEDIA_SUBDRV_AUTOSELECT && (MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT || MEDIA_SDR_SUPPORT) && HAS_IOMEM && MEDIA_SUPPORT) || (DRM && (AGP || AGP = n) && !EMULATED_CMPXCHG && HAS_DMA && HAS_IOMEM) || (FB_DDC && FB && HAS_IOMEM) || (SND_AOA_ONYX && SND_AOA && SND && !UML && SOUND) || (SND_AOA_TAS && SND_AOA && SND && !UML && SOUND) || (ARCH_R8A7790 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7791 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7793 && ARM && ARCH_RENESAS && SOC_RENESAS) || (PHY_EXYNOS5250_SATA && SOC_EXYNOS5250 && HAS_IOMEM && OF))

...depends on FB_DDC (defined at drivers/video/fbdev/Kconfig:63), with definition...

config FB_DDC
	tristate
	select I2C_ALGOBIT
	select I2C
	depends on FB && HAS_IOMEM

(select-related dependencies: (FB_CYBER2000_DDC && FB_CYBER2000 && HAS_IOMEM) || (FB_NVIDIA_I2C && FB_NVIDIA && HAS_IOMEM) || (FB_RIVA_I2C && FB_RIVA && HAS_IOMEM) || (FB_I740 && FB && PCI && HAS_IOMEM) || (FB_I810_I2C && FB_I810 && FB_I810_GTF && HAS_IOMEM) || (FB_INTEL_I2C && FB_INTEL && HAS_IOMEM) || (FB_MATROX_I2C && FB_MATROX && HAS_IOMEM) || (FB_RADEON_I2C && FB_RADEON && HAS_IOMEM) || (FB_S3_DDC && FB_S3 && HAS_IOMEM) || (FB_SAVAGE_I2C && FB_SAVAGE && HAS_IOMEM) || (FB_3DFX_I2C && FB_3DFX && HAS_IOMEM) || (FB_TRIDENT && FB && PCI && HAS_IOMEM))

...depends on FB_S3 (defined at drivers/video/fbdev/Kconfig:1314), with definition...

config FB_S3
	tristate "S3 Trio/Virge support"
	select FB_CFB_FILLRECT
	select FB_CFB_COPYAREA
	select FB_CFB_IMAGEBLIT
	select FB_TILEBLITTING
	select FB_SVGALIB
	select VGASTATE
	select FONT_8x16 if FRAMEBUFFER_CONSOLE
	depends on FB && PCI && HAS_IOMEM
	help
	  Driver for graphics boards with S3 Trio / S3 Virge chip.

...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...

menuconfig FB
	tristate "Support for frame buffer devices"
	select FB_CMDLINE
	select FB_NOTIFY
	depends on HAS_IOMEM
	help
	  The frame buffer device provides an abstraction for the graphics
	  hardware. It represents the frame buffer of some video hardware and
	  allows application software to access the graphics hardware through
	  a well-defined interface, so the software doesn't need to know
	  anything about the low-level (hardware register) stuff.
	  
	  Frame buffer devices work identically across the different
	  architectures supported by Linux and make the implementation of
	  application programs easier and more portable; at this point, an X
	  server exists which uses the frame buffer device exclusively.
	  On several non-X86 architectures, the frame buffer device is the
	  only way to use the graphics hardware.
	  
	  The device is accessed through special device nodes, usually located
	  in the /dev directory, i.e. /dev/fb*.
	  
	  You need an utility program called fbset to make full use of frame
	  buffer devices. Please read <file:Documentation/fb/framebuffer.rst>
	  and the Framebuffer-HOWTO at
	  <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more
	  information.
	  
	  Say Y here and to the driver for your graphics board below if you
	  are compiling a kernel for a non-x86 architecture.
	  
	  If you are compiling for the x86 architecture, you can say Y if you
	  want to play with it, but it is not essential. Please note that
	  running graphical applications that directly touch the hardware
	  (e.g. an accelerated X server) and that are not frame buffer
	  device-aware may cause unexpected results. If unsure, say N.

(select-related dependencies: (DRM_KMS_FB_HELPER && DRM_KMS_HELPER && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM))

...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...

config DRM_KMS_HELPER
	tristate
	depends on DRM && HAS_IOMEM
	help
	  CRTC helpers for KMS drivers.

(select-related dependencies: (DRM_DEBUG_SELFTEST && DRM && DEBUG_KERNEL && HAS_IOMEM) || (DRM_FBDEV_EMULATION && DRM && HAS_IOMEM) || (DRM_HDLCD && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_MALI_DISPLAY && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_KOMEDA && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && DRM && X86 && PCI && HAS_IOMEM) || (DRM_VKMS && DRM && HAS_IOMEM) || (DRM_EXYNOS && OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST) && HAS_IOMEM) || (DRM_ROCKCHIP && DRM && ROCKCHIP_IOMMU && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_GMA500 && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_UDL && DRM && USB_SUPPORT && USB_ARCH_HAS_HCD && HAS_IOMEM) || (DRM_AST && DRM && PCI && MMU && HAS_IOMEM) || (DRM_MGAG200 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_CIRRUS_QEMU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ARMADA && DRM && HAVE_CLK && ARM && MMU && HAS_IOMEM) || (DRM_ATMEL_HLCDC && DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM && HAS_IOMEM) || (DRM_RCAR_DU && DRM && OF && (ARM || ARM64) && (ARCH_RENESAS || COMPILE_TEST) && HAS_IOMEM) || (DRM_SHMOBILE && DRM && ARM && (ARCH_SHMOBILE || COMPILE_TEST) && HAS_IOMEM) || (DRM_SUN4I && DRM && (ARM || ARM64) && COMMON_CLK && (ARCH_SUNXI || COMPILE_TEST) && HAS_IOMEM) || (DRM_OMAP && DRM && (ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_TILCDC && DRM && OF && ARM && HAS_IOMEM) || (DRM_QXL && DRM && PCI && MMU && HAS_IOMEM) || (DRM_BOCHS && DRM && PCI && MMU && HAS_IOMEM) || (DRM_VIRTIO_GPU && DRM && VIRTIO && MMU && HAS_IOMEM) || (DRM_MSM && DRM && (ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)) && OF && COMMON_CLK && MMU && (INTERCONNECT || !INTERCONNECT) && HAS_IOMEM) || (DRM_FSL_DCU && DRM && OF && ARM && COMMON_CLK && HAS_IOMEM) || (DRM_TEGRA && (ARCH_TEGRA || (ARM && COMPILE_TEST)) && COMMON_CLK && DRM && OF && HAS_IOMEM) || (DRM_STM && DRM && (ARCH_STM32 || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_ANALOGIX_ANX78XX && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_CDNS_DSI && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DUMB_VGA_DAC && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_NXP_PTN3460 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_PARADE_PS8622 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SIL_SII8620 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SII902X && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TOSHIBA_TC358767 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_TFP410 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_SN65DSI86 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_I2C_ADV7511 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_HDMI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_MIPI_DSI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_STI && OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_IMX && DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST) && IMX_IPUV3_CORE && HAS_IOMEM) || (DRM_INGENIC && (MIPS || COMPILE_TEST) && DRM && CMA && OF && HAS_IOMEM) || (DRM_VC4 && (ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST) && DRM && SND && SND_SOC && COMMON_CLK && HAS_IOMEM) || (DRM_ARCPGU && DRM && OF && HAS_IOMEM) || (DRM_HISI_HIBMC && DRM && PCI && MMU && HAS_IOMEM) || (DRM_HISI_KIRIN && DRM && OF && ARM64 && HAS_IOMEM) || (DRM_MEDIATEK && DRM && (ARCH_MEDIATEK || (ARM && COMPILE_TEST)) && COMMON_CLK && HAVE_ARM_SMCCC && OF && HAS_IOMEM) || (DRM_ZTE && DRM && ARCH_ZX && HAS_IOMEM) || (DRM_MXSFB && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_MESON && DRM && OF && (ARM || ARM64) && (ARCH_MESON || COMPILE_TEST) && HAS_IOMEM) || (TINYDRM_HX8357D && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9225 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9341 && DRM && SPI && HAS_IOMEM) || (TINYDRM_MI0283QT && DRM && SPI && HAS_IOMEM) || (TINYDRM_REPAPER && DRM && SPI && (THERMAL || !THERMAL) && HAS_IOMEM) || (TINYDRM_ST7586 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ST7735R && DRM && SPI && HAS_IOMEM) || (DRM_PL111 && DRM && (ARM || ARM64 || COMPILE_TEST) && COMMON_CLK && HAS_IOMEM) || (DRM_TVE200 && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_XEN_FRONTEND && DRM_XEN && DRM && HAS_IOMEM) || (DRM_VBOXVIDEO && DRM && X86 && PCI && HAS_IOMEM) || (DRM_ASPEED_GFX && DRM && OF && (COMPILE_TEST || ARCH_ASPEED) && HAS_IOMEM) || (DRM_MCDE && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_GM12U320 && DRM && USB && HAS_IOMEM))

...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...

menuconfig THERMAL
	bool "Generic Thermal sysfs driver"
	help
	  Generic Thermal Sysfs driver offers a generic mechanism for
	  thermal management. Usually it's made up of one or more thermal
	  zone and cooling device.
	  Each thermal zone contains its own temperature, trip points,
	  cooling devices.
	  All platforms with ACPI thermal support can use this driver.
	  If you want this support, you should say Y here.

(select-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))

(imply-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))

...depends on SENSORS_MLXREG_FAN (defined at drivers/hwmon/Kconfig:952), with definition...

config SENSORS_MLXREG_FAN
	tristate "Mellanox Mellanox FAN driver"
	select REGMAP
	imply THERMAL
	depends on MELLANOX_PLATFORM && HWMON
	help
	  This option enables support for the FAN control on the Mellanox
	  Ethernet and InfiniBand switches. The driver can be activated by the
	  platform device add call. Say Y to enable these. To compile this
	  driver as a module, choose 'M' here: the module will be called
	  mlxreg-fan.

...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...

menuconfig HWMON
	tristate "Hardware Monitoring support"
	default y
	depends on HAS_IOMEM
	help
	  Hardware monitoring devices let you monitor the hardware health
	  of a system. Most modern motherboards include such a device. It
	  can include temperature sensors, voltage sensors, fan speed
	  sensors and various additional features such as the ability to
	  control the speed of the fans. If you want this support you
	  should say Y here and also to the specific driver(s) for your
	  sensors chip(s) below.
	  
	  To find out which specific driver(s) you need, use the
	  sensors-detect script from the lm_sensors package.  Read
	  <file:Documentation/hwmon/userspace-tools.rst> for details.
	  
	  This support can also be built as a module. If so, the module
	  will be called hwmon.

(select-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))

(imply-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))

...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-01 12:36   ` [1/3] " Jason Gunthorpe
@ 2019-10-01 13:28       ` Noralf Trønnes
  0 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-01 13:28 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: dri-devel, daniel.vetter, sam, hdegoede, linux-kernel



Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
>> ---
>>  drivers/gpu/drm/Makefile        |  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>  2 files changed, 22 insertions(+), 17 deletions(-)
> 
> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> breaks kconfig stuff in v5.4-rc by creating circular
> dependencies. Could someone send a -rc patch to fix this please?
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> 

Would this commit fix this by any chance:

drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Noralf.

> Full output:
> 
> kconfiglib.KconfigError: 
> Dependency loop
> ===============
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> 
> config THINKPAD_ACPI
> 	tristate "ThinkPad ACPI Laptop Extras"
> 	select HWMON
> 	select NVRAM
> 	select NEW_LEDS
> 	select LEDS_CLASS
> 	select LEDS_TRIGGERS
> 	select LEDS_TRIGGER_AUDIO
> 	depends on ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86
> 	help
> 	  This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
> 	  support for Fn-Fx key combinations, Bluetooth control, video
> 	  output switching, ThinkLight control, UltraBay eject and more.
> 	  For more information about this driver see
> 	  <file:Documentation/admin-guide/laptops/thinkpad-acpi.rst> and
> 	  <http://ibm-acpi.sf.net/> .
> 	  
> 	  This driver was formerly known as ibm-acpi.
> 	  
> 	  Extra functionality will be available if the rfkill (CONFIG_RFKILL)
> 	  and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
> 	  Note that if you want ThinkPad-ACPI to be built-in instead of
> 	  modular, ALSA and rfkill will also have to be built-in.
> 	  
> 	  If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.
> 
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> 
> config ACPI_VIDEO
> 	tristate "Video"
> 	select THERMAL
> 	depends on X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI
> 	help
> 	  This driver implements the ACPI Extensions For Display Adapters
> 	  for integrated graphics devices on motherboard, as specified in
> 	  ACPI 2.0 Specification, Appendix B.  This supports basic operations
> 	  such as defining the video POST device, retrieving EDID information,
> 	  and setting up a video output.
> 	  
> 	  To compile this driver as a module, choose M here:
> 	  the module will be called video.
> 
> (select-related dependencies: (DRM_NOUVEAU && ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && ACPI && DRM && X86 && PCI && HAS_IOMEM) || (DRM_GMA500 && ACPI && DRM && PCI && X86 && MMU && HAS_IOMEM) || (ACER_WMI && ACPI && ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86))
> 
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> 
> config ACER_WMI
> 	tristate "Acer WMI Laptop Extras"
> 	select LEDS_CLASS
> 	select NEW_LEDS
> 	select INPUT_SPARSEKMAP
> 	select ACPI_VIDEO if ACPI
> 	depends on ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86
> 	help
> 	  This is a driver for newer Acer (and Wistron) laptops. It adds
> 	  wireless radio and bluetooth control, and on some laptops,
> 	  exposes the mail LED and LCD backlight.
> 	  
> 	  If you have an ACPI-WMI compatible Acer/ Wistron laptop, say Y or M
> 	  here.
> 
> ...depends on SERIO_I8042 (defined at drivers/input/serio/Kconfig:29), with definition...
> 
> config SERIO_I8042
> 	tristate "i8042 PC Keyboard controller"
> 	default y
> 	depends on ARCH_MIGHT_HAVE_PC_SERIO && SERIO && !UML
> 	help
> 	  i8042 is the chip over which the standard AT keyboard and PS/2
> 	  mouse are connected to the computer. If you use these devices,
> 	  you'll need to say Y here.
> 	  
> 	  If unsure, say Y.
> 	  
> 	  To compile this driver as a module, choose M here: the
> 	  module will be called i8042.
> 
> (select-related dependencies: (KEYBOARD_ATKBD && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_MOUSE && INPUT && !UML))
> 
> ...depends on SERIO (defined at drivers/input/serio/Kconfig:5), with definition...
> 
> config SERIO
> 	tristate "Serial I/O support"
> 	default y
> 	depends on !UML
> 	help
> 	  Say Yes here if you have any input device that uses serial I/O to
> 	  communicate with the system. This includes the
> 	                * standard AT keyboard and PS/2 mouse *
> 	  as well as serial mice, Sun keyboards, some joysticks and 6dof
> 	  devices and more.
> 	  
> 	  If unsure, say Y.
> 	  
> 	  To compile this driver as a module, choose M here: the
> 	  module will be called serio.
> 
> (select-related dependencies: (KEYBOARD_ATKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_LKKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_HIL && (GSC || HP300) && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_NEWTON && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_STOWAWAY && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_SUNKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_XTKBD && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && INPUT_MOUSE && INPUT && !UML) || (MOUSE_SERIAL && INPUT_MOUSE && INPUT && !UML) || (MOUSE_VSXXXAA && INPUT_MOUSE && INPUT && !UML) || (JOYSTICK_WARRIOR && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_MAGELLAN && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEORB && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEBALL && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_STINGER && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_TWIDJOY && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_ZHENHUA && INPUT_JOYSTICK && INPUT && !UML) || (TABLET_SERIAL_WACOM4 && INPUT_TABLET && INPUT && !UML) || (TOUCHSCREEN_DYNAPRO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_HAMPSHIRE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_EGALAX_SERIAL && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_FUJITSU && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_GUNZE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_ELO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_WACOM_W8001 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_MTOUCH && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_INEXIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_PENMOUNT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHRIGHT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHWIN && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHIT213 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TSC_SERIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (RMI4_F03_SERIO && RMI4_CORE && RMI4_F03 && RMI4_CORE && INPUT && !UML) || (I2C_TAOS_EVM && TTY && HAS_IOMEM && I2C) || (USB_PULSE8_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT) || (USB_RAINSHADOW_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT))
> 
> ...depends on RMI4_F03 (defined at drivers/input/rmi4/Kconfig:46), with definition...
> 
> config RMI4_F03
> 	bool "RMI4 Function 03 (PS2 Guest)"
> 	depends on RMI4_CORE && RMI4_CORE && INPUT && !UML
> 	help
> 	  Say Y here if you want to add support for RMI4 function 03.
> 	  
> 	  Function 03 provides PS2 guest support for RMI4 devices. This
> 	  includes support for TrackPoints on TouchPads.
> 
> (select-related dependencies: HID_RMI && HID && HID && HID && INPUT)
> 
> ...depends on HID_RMI (defined at drivers/hid/Kconfig:919), with definition...
> 
> config HID_RMI
> 	tristate "Synaptics RMI4 device support"
> 	select RMI4_CORE
> 	select RMI4_F03
> 	select RMI4_F11
> 	select RMI4_F12
> 	select RMI4_F30
> 	depends on HID && HID && HID && INPUT
> 	help
> 	  Support for Synaptics RMI4 touchpads.
> 	  Say Y here if you have a Synaptics RMI4 touchpads over i2c-hid or usbhid
> 	  and want support for its special functionalities.
> 
> ...depends on HID (defined at drivers/hid/Kconfig:8), with definition...
> 
> config HID
> 	tristate "HID bus support"
> 	default y
> 	depends on INPUT && INPUT
> 	help
> 	  A human interface device (HID) is a type of computer device that
> 	  interacts directly with and takes input from humans. The term "HID"
> 	  most commonly used to refer to the USB-HID specification, but other
> 	  devices (such as, but not strictly limited to, Bluetooth) are
> 	  designed using HID specification (this involves certain keyboards,
> 	  mice, tablets, etc). This option adds the HID bus to the kernel,
> 	  together with generic HID layer code. The HID devices are added and
> 	  removed from the HID bus by the transport-layer drivers, such as
> 	  usbhid (USB_HID) and hidp (BT_HIDP).
> 	  
> 	  For docs and specs, see http://www.usb.org/developers/hidpage/
> 	  
> 	  If unsure, say Y.
> 
> (select-related dependencies: (BT_HIDP && BT_BREDR && INPUT && NET) || (USB_HID && USB && INPUT && USB && INPUT) || (I2C_HID && I2C && INPUT && I2C && INPUT) || (INTEL_ISH_HID && (X86_64 || COMPILE_TEST) && PCI && INPUT))
> 
> ...depends on I2C_HID (defined at drivers/hid/i2c-hid/Kconfig:5), with definition...
> 
> config I2C_HID
> 	tristate "HID over I2C transport layer"
> 	default n
> 	select HID
> 	depends on I2C && INPUT && I2C && INPUT
> 	help
> 	  Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
> 	  other HID based devices which is connected to your computer via I2C.
> 	  
> 	  If unsure, say N.
> 	  
> 	  This support is also available as a module.  If so, the module
> 	  will be called i2c-hid.
> 
> ...depends on I2C (defined at drivers/i2c/Kconfig:8), with definition...
> 
> config I2C
> 	tristate "I2C support"
> 	select RT_MUTEXES
> 	select IRQ_DOMAIN
> 	help
> 	  I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
> 	  many micro controller applications and developed by Philips.  SMBus,
> 	  or System Management Bus is a subset of the I2C protocol.  More
> 	  information is contained in the directory <file:Documentation/i2c/>,
> 	  especially in the file called "summary" there.
> 	  
> 	  Both I2C and SMBus are supported here. You will need this for
> 	  hardware sensors support, and also for Video For Linux support.
> 	  
> 	  If you want I2C support, you should say Y here and also to the
> 	  specific driver for your bus adapter(s) below.
> 	  
> 	  This I2C support can also be built as a module.  If so, the module
> 	  will be called i2c-core.
> 
> (select-related dependencies: (X86_INTEL_MID && X86_EXTENDED_PLATFORM && X86_PLATFORM_DEVICES && PCI && (X86_64 || (PCI_GOANY && X86_32)) && X86_IO_APIC) || (CAN_PEAK_PCIEC && CAN_PEAK_PCI && CAN_SJA1000 && CAN_DEV && CAN && NET) || (IGB && PCI && NET_VENDOR_INTEL && ETHERNET && NETDEVICES) || (SFC && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (SFC_FALCON && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (IPMI_SSIF && IPMI_HANDLER) || I3C || (MEDIA_SUBDRV_AUTOSELECT && (MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT || MEDIA_SDR_SUPPORT) && HAS_IOMEM && MEDIA_SUPPORT) || (DRM && (AGP || AGP = n) && !EMULATED_CMPXCHG && HAS_DMA && HAS_IOMEM) || (FB_DDC && FB && HAS_IOMEM) || (SND_AOA_ONYX && SND_AOA && SND && !UML && SOUND) || (SND_AOA_TAS && SND_AOA && SND && !UML && SOUND) || (ARCH_R8A7790 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7791 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7793 && ARM && ARCH_RENESAS && SOC_RENESAS) || (PHY_EXYNOS5250_SATA && SOC_EXYNOS5250 && HAS_IOMEM && OF))
> 
> ...depends on FB_DDC (defined at drivers/video/fbdev/Kconfig:63), with definition...
> 
> config FB_DDC
> 	tristate
> 	select I2C_ALGOBIT
> 	select I2C
> 	depends on FB && HAS_IOMEM
> 
> (select-related dependencies: (FB_CYBER2000_DDC && FB_CYBER2000 && HAS_IOMEM) || (FB_NVIDIA_I2C && FB_NVIDIA && HAS_IOMEM) || (FB_RIVA_I2C && FB_RIVA && HAS_IOMEM) || (FB_I740 && FB && PCI && HAS_IOMEM) || (FB_I810_I2C && FB_I810 && FB_I810_GTF && HAS_IOMEM) || (FB_INTEL_I2C && FB_INTEL && HAS_IOMEM) || (FB_MATROX_I2C && FB_MATROX && HAS_IOMEM) || (FB_RADEON_I2C && FB_RADEON && HAS_IOMEM) || (FB_S3_DDC && FB_S3 && HAS_IOMEM) || (FB_SAVAGE_I2C && FB_SAVAGE && HAS_IOMEM) || (FB_3DFX_I2C && FB_3DFX && HAS_IOMEM) || (FB_TRIDENT && FB && PCI && HAS_IOMEM))
> 
> ...depends on FB_S3 (defined at drivers/video/fbdev/Kconfig:1314), with definition...
> 
> config FB_S3
> 	tristate "S3 Trio/Virge support"
> 	select FB_CFB_FILLRECT
> 	select FB_CFB_COPYAREA
> 	select FB_CFB_IMAGEBLIT
> 	select FB_TILEBLITTING
> 	select FB_SVGALIB
> 	select VGASTATE
> 	select FONT_8x16 if FRAMEBUFFER_CONSOLE
> 	depends on FB && PCI && HAS_IOMEM
> 	help
> 	  Driver for graphics boards with S3 Trio / S3 Virge chip.
> 
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> 
> menuconfig FB
> 	tristate "Support for frame buffer devices"
> 	select FB_CMDLINE
> 	select FB_NOTIFY
> 	depends on HAS_IOMEM
> 	help
> 	  The frame buffer device provides an abstraction for the graphics
> 	  hardware. It represents the frame buffer of some video hardware and
> 	  allows application software to access the graphics hardware through
> 	  a well-defined interface, so the software doesn't need to know
> 	  anything about the low-level (hardware register) stuff.
> 	  
> 	  Frame buffer devices work identically across the different
> 	  architectures supported by Linux and make the implementation of
> 	  application programs easier and more portable; at this point, an X
> 	  server exists which uses the frame buffer device exclusively.
> 	  On several non-X86 architectures, the frame buffer device is the
> 	  only way to use the graphics hardware.
> 	  
> 	  The device is accessed through special device nodes, usually located
> 	  in the /dev directory, i.e. /dev/fb*.
> 	  
> 	  You need an utility program called fbset to make full use of frame
> 	  buffer devices. Please read <file:Documentation/fb/framebuffer.rst>
> 	  and the Framebuffer-HOWTO at
> 	  <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more
> 	  information.
> 	  
> 	  Say Y here and to the driver for your graphics board below if you
> 	  are compiling a kernel for a non-x86 architecture.
> 	  
> 	  If you are compiling for the x86 architecture, you can say Y if you
> 	  want to play with it, but it is not essential. Please note that
> 	  running graphical applications that directly touch the hardware
> 	  (e.g. an accelerated X server) and that are not frame buffer
> 	  device-aware may cause unexpected results. If unsure, say N.
> 
> (select-related dependencies: (DRM_KMS_FB_HELPER && DRM_KMS_HELPER && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM))
> 
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> 
> config DRM_KMS_HELPER
> 	tristate
> 	depends on DRM && HAS_IOMEM
> 	help
> 	  CRTC helpers for KMS drivers.
> 
> (select-related dependencies: (DRM_DEBUG_SELFTEST && DRM && DEBUG_KERNEL && HAS_IOMEM) || (DRM_FBDEV_EMULATION && DRM && HAS_IOMEM) || (DRM_HDLCD && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_MALI_DISPLAY && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_KOMEDA && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && DRM && X86 && PCI && HAS_IOMEM) || (DRM_VKMS && DRM && HAS_IOMEM) || (DRM_EXYNOS && OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST) && HAS_IOMEM) || (DRM_ROCKCHIP && DRM && ROCKCHIP_IOMMU && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_GMA500 && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_UDL && DRM && USB_SUPPORT && USB_ARCH_HAS_HCD && HAS_IOMEM) || (DRM_AST && DRM && PCI && MMU && HAS_IOMEM) || (DRM_MGAG200 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_CIRRUS_QEMU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ARMADA && DRM && HAVE_CLK && ARM && MMU && HAS_IOMEM) || (DRM_ATMEL_HLCDC && DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM && HAS_IOMEM) || (DRM_RCAR_DU && DRM && OF && (ARM || ARM64) && (ARCH_RENESAS || COMPILE_TEST) && HAS_IOMEM) || (DRM_SHMOBILE && DRM && ARM && (ARCH_SHMOBILE || COMPILE_TEST) && HAS_IOMEM) || (DRM_SUN4I && DRM && (ARM || ARM64) && COMMON_CLK && (ARCH_SUNXI || COMPILE_TEST) && HAS_IOMEM) || (DRM_OMAP && DRM && (ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_TILCDC && DRM && OF && ARM && HAS_IOMEM) || (DRM_QXL && DRM && PCI && MMU && HAS_IOMEM) || (DRM_BOCHS && DRM && PCI && MMU && HAS_IOMEM) || (DRM_VIRTIO_GPU && DRM && VIRTIO && MMU && HAS_IOMEM) || (DRM_MSM && DRM && (ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)) && OF && COMMON_CLK && MMU && (INTERCONNECT || !INTERCONNECT) && HAS_IOMEM) || (DRM_FSL_DCU && DRM && OF && ARM && COMMON_CLK && HAS_IOMEM) || (DRM_TEGRA && (ARCH_TEGRA || (ARM && COMPILE_TEST)) && COMMON_CLK && DRM && OF && HAS_IOMEM) || (DRM_STM && DRM && (ARCH_STM32 || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_ANALOGIX_ANX78XX && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_CDNS_DSI && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DUMB_VGA_DAC && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_NXP_PTN3460 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_PARADE_PS8622 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SIL_SII8620 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SII902X && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TOSHIBA_TC358767 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_TFP410 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_SN65DSI86 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_I2C_ADV7511 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_HDMI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_MIPI_DSI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_STI && OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_IMX && DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST) && IMX_IPUV3_CORE && HAS_IOMEM) || (DRM_INGENIC && (MIPS || COMPILE_TEST) && DRM && CMA && OF && HAS_IOMEM) || (DRM_VC4 && (ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST) && DRM && SND && SND_SOC && COMMON_CLK && HAS_IOMEM) || (DRM_ARCPGU && DRM && OF && HAS_IOMEM) || (DRM_HISI_HIBMC && DRM && PCI && MMU && HAS_IOMEM) || (DRM_HISI_KIRIN && DRM && OF && ARM64 && HAS_IOMEM) || (DRM_MEDIATEK && DRM && (ARCH_MEDIATEK || (ARM && COMPILE_TEST)) && COMMON_CLK && HAVE_ARM_SMCCC && OF && HAS_IOMEM) || (DRM_ZTE && DRM && ARCH_ZX && HAS_IOMEM) || (DRM_MXSFB && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_MESON && DRM && OF && (ARM || ARM64) && (ARCH_MESON || COMPILE_TEST) && HAS_IOMEM) || (TINYDRM_HX8357D && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9225 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9341 && DRM && SPI && HAS_IOMEM) || (TINYDRM_MI0283QT && DRM && SPI && HAS_IOMEM) || (TINYDRM_REPAPER && DRM && SPI && (THERMAL || !THERMAL) && HAS_IOMEM) || (TINYDRM_ST7586 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ST7735R && DRM && SPI && HAS_IOMEM) || (DRM_PL111 && DRM && (ARM || ARM64 || COMPILE_TEST) && COMMON_CLK && HAS_IOMEM) || (DRM_TVE200 && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_XEN_FRONTEND && DRM_XEN && DRM && HAS_IOMEM) || (DRM_VBOXVIDEO && DRM && X86 && PCI && HAS_IOMEM) || (DRM_ASPEED_GFX && DRM && OF && (COMPILE_TEST || ARCH_ASPEED) && HAS_IOMEM) || (DRM_MCDE && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_GM12U320 && DRM && USB && HAS_IOMEM))
> 
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> 
> menuconfig THERMAL
> 	bool "Generic Thermal sysfs driver"
> 	help
> 	  Generic Thermal Sysfs driver offers a generic mechanism for
> 	  thermal management. Usually it's made up of one or more thermal
> 	  zone and cooling device.
> 	  Each thermal zone contains its own temperature, trip points,
> 	  cooling devices.
> 	  All platforms with ACPI thermal support can use this driver.
> 	  If you want this support, you should say Y here.
> 
> (select-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))
> 
> (imply-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))
> 
> ...depends on SENSORS_MLXREG_FAN (defined at drivers/hwmon/Kconfig:952), with definition...
> 
> config SENSORS_MLXREG_FAN
> 	tristate "Mellanox Mellanox FAN driver"
> 	select REGMAP
> 	imply THERMAL
> 	depends on MELLANOX_PLATFORM && HWMON
> 	help
> 	  This option enables support for the FAN control on the Mellanox
> 	  Ethernet and InfiniBand switches. The driver can be activated by the
> 	  platform device add call. Say Y to enable these. To compile this
> 	  driver as a module, choose 'M' here: the module will be called
> 	  mlxreg-fan.
> 
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> 
> menuconfig HWMON
> 	tristate "Hardware Monitoring support"
> 	default y
> 	depends on HAS_IOMEM
> 	help
> 	  Hardware monitoring devices let you monitor the hardware health
> 	  of a system. Most modern motherboards include such a device. It
> 	  can include temperature sensors, voltage sensors, fan speed
> 	  sensors and various additional features such as the ability to
> 	  control the speed of the fans. If you want this support you
> 	  should say Y here and also to the specific driver(s) for your
> 	  sensors chip(s) below.
> 	  
> 	  To find out which specific driver(s) you need, use the
> 	  sensors-detect script from the lm_sensors package.  Read
> 	  <file:Documentation/hwmon/userspace-tools.rst> for details.
> 	  
> 	  This support can also be built as a module. If so, the module
> 	  will be called hwmon.
> 
> (select-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))
> 
> (imply-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))
> 
> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
@ 2019-10-01 13:28       ` Noralf Trønnes
  0 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-01 13:28 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: daniel.vetter, sam, linux-kernel, dri-devel, hdegoede



Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>> This makes the tiny drivers visible by default without having to enable a
>> knob.
>>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
>> ---
>>  drivers/gpu/drm/Makefile        |  2 +-
>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>  2 files changed, 22 insertions(+), 17 deletions(-)
> 
> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> breaks kconfig stuff in v5.4-rc by creating circular
> dependencies. Could someone send a -rc patch to fix this please?
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> 

Would this commit fix this by any chance:

drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Noralf.

> Full output:
> 
> kconfiglib.KconfigError: 
> Dependency loop
> ===============
> 
> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> 
> config THINKPAD_ACPI
> 	tristate "ThinkPad ACPI Laptop Extras"
> 	select HWMON
> 	select NVRAM
> 	select NEW_LEDS
> 	select LEDS_CLASS
> 	select LEDS_TRIGGERS
> 	select LEDS_TRIGGER_AUDIO
> 	depends on ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86
> 	help
> 	  This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
> 	  support for Fn-Fx key combinations, Bluetooth control, video
> 	  output switching, ThinkLight control, UltraBay eject and more.
> 	  For more information about this driver see
> 	  <file:Documentation/admin-guide/laptops/thinkpad-acpi.rst> and
> 	  <http://ibm-acpi.sf.net/> .
> 	  
> 	  This driver was formerly known as ibm-acpi.
> 	  
> 	  Extra functionality will be available if the rfkill (CONFIG_RFKILL)
> 	  and/or ALSA (CONFIG_SND) subsystems are available in the kernel.
> 	  Note that if you want ThinkPad-ACPI to be built-in instead of
> 	  modular, ALSA and rfkill will also have to be built-in.
> 	  
> 	  If you have an IBM or Lenovo ThinkPad laptop, say Y or M here.
> 
> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> 
> config ACPI_VIDEO
> 	tristate "Video"
> 	select THERMAL
> 	depends on X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI
> 	help
> 	  This driver implements the ACPI Extensions For Display Adapters
> 	  for integrated graphics devices on motherboard, as specified in
> 	  ACPI 2.0 Specification, Appendix B.  This supports basic operations
> 	  such as defining the video POST device, retrieving EDID information,
> 	  and setting up a video output.
> 	  
> 	  To compile this driver as a module, choose M here:
> 	  the module will be called video.
> 
> (select-related dependencies: (DRM_NOUVEAU && ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && ACPI && DRM && X86 && PCI && HAS_IOMEM) || (DRM_GMA500 && ACPI && DRM && PCI && X86 && MMU && HAS_IOMEM) || (ACER_WMI && ACPI && ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86))
> 
> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> 
> config ACER_WMI
> 	tristate "Acer WMI Laptop Extras"
> 	select LEDS_CLASS
> 	select NEW_LEDS
> 	select INPUT_SPARSEKMAP
> 	select ACPI_VIDEO if ACPI
> 	depends on ACPI && BACKLIGHT_CLASS_DEVICE && SERIO_I8042 && INPUT && (RFKILL || RFKILL = n) && ACPI_WMI && X86_PLATFORM_DEVICES && X86
> 	help
> 	  This is a driver for newer Acer (and Wistron) laptops. It adds
> 	  wireless radio and bluetooth control, and on some laptops,
> 	  exposes the mail LED and LCD backlight.
> 	  
> 	  If you have an ACPI-WMI compatible Acer/ Wistron laptop, say Y or M
> 	  here.
> 
> ...depends on SERIO_I8042 (defined at drivers/input/serio/Kconfig:29), with definition...
> 
> config SERIO_I8042
> 	tristate "i8042 PC Keyboard controller"
> 	default y
> 	depends on ARCH_MIGHT_HAVE_PC_SERIO && SERIO && !UML
> 	help
> 	  i8042 is the chip over which the standard AT keyboard and PS/2
> 	  mouse are connected to the computer. If you use these devices,
> 	  you'll need to say Y here.
> 	  
> 	  If unsure, say Y.
> 	  
> 	  To compile this driver as a module, choose M here: the
> 	  module will be called i8042.
> 
> (select-related dependencies: (KEYBOARD_ATKBD && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && ARCH_MIGHT_HAVE_PC_SERIO && INPUT_MOUSE && INPUT && !UML))
> 
> ...depends on SERIO (defined at drivers/input/serio/Kconfig:5), with definition...
> 
> config SERIO
> 	tristate "Serial I/O support"
> 	default y
> 	depends on !UML
> 	help
> 	  Say Yes here if you have any input device that uses serial I/O to
> 	  communicate with the system. This includes the
> 	                * standard AT keyboard and PS/2 mouse *
> 	  as well as serial mice, Sun keyboards, some joysticks and 6dof
> 	  devices and more.
> 	  
> 	  If unsure, say Y.
> 	  
> 	  To compile this driver as a module, choose M here: the
> 	  module will be called serio.
> 
> (select-related dependencies: (KEYBOARD_ATKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_LKKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_HIL && (GSC || HP300) && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_NEWTON && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_STOWAWAY && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_SUNKBD && INPUT_KEYBOARD && INPUT && !UML) || (KEYBOARD_XTKBD && INPUT_KEYBOARD && INPUT && !UML) || (MOUSE_PS2 && INPUT_MOUSE && INPUT && !UML) || (MOUSE_SERIAL && INPUT_MOUSE && INPUT && !UML) || (MOUSE_VSXXXAA && INPUT_MOUSE && INPUT && !UML) || (JOYSTICK_WARRIOR && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_MAGELLAN && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEORB && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_SPACEBALL && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_STINGER && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_TWIDJOY && INPUT_JOYSTICK && INPUT && !UML) || (JOYSTICK_ZHENHUA && INPUT_JOYSTICK && INPUT && !UML) || (TABLET_SERIAL_WACOM4 && INPUT_TABLET && INPUT && !UML) || (TOUCHSCREEN_DYNAPRO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_HAMPSHIRE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_EGALAX_SERIAL && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_FUJITSU && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_GUNZE && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_ELO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_WACOM_W8001 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_MTOUCH && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_INEXIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_PENMOUNT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHRIGHT && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHWIN && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TOUCHIT213 && INPUT_TOUCHSCREEN && INPUT && !UML) || (TOUCHSCREEN_TSC_SERIO && INPUT_TOUCHSCREEN && INPUT && !UML) || (RMI4_F03_SERIO && RMI4_CORE && RMI4_F03 && RMI4_CORE && INPUT && !UML) || (I2C_TAOS_EVM && TTY && HAS_IOMEM && I2C) || (USB_PULSE8_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT) || (USB_RAINSHADOW_CEC && USB_ACM && MEDIA_CEC_SUPPORT && MEDIA_USB_SUPPORT && USB && MEDIA_SUPPORT && MEDIA_SUPPORT))
> 
> ...depends on RMI4_F03 (defined at drivers/input/rmi4/Kconfig:46), with definition...
> 
> config RMI4_F03
> 	bool "RMI4 Function 03 (PS2 Guest)"
> 	depends on RMI4_CORE && RMI4_CORE && INPUT && !UML
> 	help
> 	  Say Y here if you want to add support for RMI4 function 03.
> 	  
> 	  Function 03 provides PS2 guest support for RMI4 devices. This
> 	  includes support for TrackPoints on TouchPads.
> 
> (select-related dependencies: HID_RMI && HID && HID && HID && INPUT)
> 
> ...depends on HID_RMI (defined at drivers/hid/Kconfig:919), with definition...
> 
> config HID_RMI
> 	tristate "Synaptics RMI4 device support"
> 	select RMI4_CORE
> 	select RMI4_F03
> 	select RMI4_F11
> 	select RMI4_F12
> 	select RMI4_F30
> 	depends on HID && HID && HID && INPUT
> 	help
> 	  Support for Synaptics RMI4 touchpads.
> 	  Say Y here if you have a Synaptics RMI4 touchpads over i2c-hid or usbhid
> 	  and want support for its special functionalities.
> 
> ...depends on HID (defined at drivers/hid/Kconfig:8), with definition...
> 
> config HID
> 	tristate "HID bus support"
> 	default y
> 	depends on INPUT && INPUT
> 	help
> 	  A human interface device (HID) is a type of computer device that
> 	  interacts directly with and takes input from humans. The term "HID"
> 	  most commonly used to refer to the USB-HID specification, but other
> 	  devices (such as, but not strictly limited to, Bluetooth) are
> 	  designed using HID specification (this involves certain keyboards,
> 	  mice, tablets, etc). This option adds the HID bus to the kernel,
> 	  together with generic HID layer code. The HID devices are added and
> 	  removed from the HID bus by the transport-layer drivers, such as
> 	  usbhid (USB_HID) and hidp (BT_HIDP).
> 	  
> 	  For docs and specs, see http://www.usb.org/developers/hidpage/
> 	  
> 	  If unsure, say Y.
> 
> (select-related dependencies: (BT_HIDP && BT_BREDR && INPUT && NET) || (USB_HID && USB && INPUT && USB && INPUT) || (I2C_HID && I2C && INPUT && I2C && INPUT) || (INTEL_ISH_HID && (X86_64 || COMPILE_TEST) && PCI && INPUT))
> 
> ...depends on I2C_HID (defined at drivers/hid/i2c-hid/Kconfig:5), with definition...
> 
> config I2C_HID
> 	tristate "HID over I2C transport layer"
> 	default n
> 	select HID
> 	depends on I2C && INPUT && I2C && INPUT
> 	help
> 	  Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
> 	  other HID based devices which is connected to your computer via I2C.
> 	  
> 	  If unsure, say N.
> 	  
> 	  This support is also available as a module.  If so, the module
> 	  will be called i2c-hid.
> 
> ...depends on I2C (defined at drivers/i2c/Kconfig:8), with definition...
> 
> config I2C
> 	tristate "I2C support"
> 	select RT_MUTEXES
> 	select IRQ_DOMAIN
> 	help
> 	  I2C (pronounce: I-squared-C) is a slow serial bus protocol used in
> 	  many micro controller applications and developed by Philips.  SMBus,
> 	  or System Management Bus is a subset of the I2C protocol.  More
> 	  information is contained in the directory <file:Documentation/i2c/>,
> 	  especially in the file called "summary" there.
> 	  
> 	  Both I2C and SMBus are supported here. You will need this for
> 	  hardware sensors support, and also for Video For Linux support.
> 	  
> 	  If you want I2C support, you should say Y here and also to the
> 	  specific driver for your bus adapter(s) below.
> 	  
> 	  This I2C support can also be built as a module.  If so, the module
> 	  will be called i2c-core.
> 
> (select-related dependencies: (X86_INTEL_MID && X86_EXTENDED_PLATFORM && X86_PLATFORM_DEVICES && PCI && (X86_64 || (PCI_GOANY && X86_32)) && X86_IO_APIC) || (CAN_PEAK_PCIEC && CAN_PEAK_PCI && CAN_SJA1000 && CAN_DEV && CAN && NET) || (IGB && PCI && NET_VENDOR_INTEL && ETHERNET && NETDEVICES) || (SFC && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (SFC_FALCON && PCI && NET_VENDOR_SOLARFLARE && ETHERNET && NETDEVICES) || (IPMI_SSIF && IPMI_HANDLER) || I3C || (MEDIA_SUBDRV_AUTOSELECT && (MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT || MEDIA_SDR_SUPPORT) && HAS_IOMEM && MEDIA_SUPPORT) || (DRM && (AGP || AGP = n) && !EMULATED_CMPXCHG && HAS_DMA && HAS_IOMEM) || (FB_DDC && FB && HAS_IOMEM) || (SND_AOA_ONYX && SND_AOA && SND && !UML && SOUND) || (SND_AOA_TAS && SND_AOA && SND && !UML && SOUND) || (ARCH_R8A7790 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7791 && ARM && ARCH_RENESAS && SOC_RENESAS) || (ARCH_R8A7793 && ARM && ARCH_RENESAS && SOC_RENESAS) || (PHY_EXYNOS5250_SATA && SOC_EXYNOS5250 && HAS_IOMEM && OF))
> 
> ...depends on FB_DDC (defined at drivers/video/fbdev/Kconfig:63), with definition...
> 
> config FB_DDC
> 	tristate
> 	select I2C_ALGOBIT
> 	select I2C
> 	depends on FB && HAS_IOMEM
> 
> (select-related dependencies: (FB_CYBER2000_DDC && FB_CYBER2000 && HAS_IOMEM) || (FB_NVIDIA_I2C && FB_NVIDIA && HAS_IOMEM) || (FB_RIVA_I2C && FB_RIVA && HAS_IOMEM) || (FB_I740 && FB && PCI && HAS_IOMEM) || (FB_I810_I2C && FB_I810 && FB_I810_GTF && HAS_IOMEM) || (FB_INTEL_I2C && FB_INTEL && HAS_IOMEM) || (FB_MATROX_I2C && FB_MATROX && HAS_IOMEM) || (FB_RADEON_I2C && FB_RADEON && HAS_IOMEM) || (FB_S3_DDC && FB_S3 && HAS_IOMEM) || (FB_SAVAGE_I2C && FB_SAVAGE && HAS_IOMEM) || (FB_3DFX_I2C && FB_3DFX && HAS_IOMEM) || (FB_TRIDENT && FB && PCI && HAS_IOMEM))
> 
> ...depends on FB_S3 (defined at drivers/video/fbdev/Kconfig:1314), with definition...
> 
> config FB_S3
> 	tristate "S3 Trio/Virge support"
> 	select FB_CFB_FILLRECT
> 	select FB_CFB_COPYAREA
> 	select FB_CFB_IMAGEBLIT
> 	select FB_TILEBLITTING
> 	select FB_SVGALIB
> 	select VGASTATE
> 	select FONT_8x16 if FRAMEBUFFER_CONSOLE
> 	depends on FB && PCI && HAS_IOMEM
> 	help
> 	  Driver for graphics boards with S3 Trio / S3 Virge chip.
> 
> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> 
> menuconfig FB
> 	tristate "Support for frame buffer devices"
> 	select FB_CMDLINE
> 	select FB_NOTIFY
> 	depends on HAS_IOMEM
> 	help
> 	  The frame buffer device provides an abstraction for the graphics
> 	  hardware. It represents the frame buffer of some video hardware and
> 	  allows application software to access the graphics hardware through
> 	  a well-defined interface, so the software doesn't need to know
> 	  anything about the low-level (hardware register) stuff.
> 	  
> 	  Frame buffer devices work identically across the different
> 	  architectures supported by Linux and make the implementation of
> 	  application programs easier and more portable; at this point, an X
> 	  server exists which uses the frame buffer device exclusively.
> 	  On several non-X86 architectures, the frame buffer device is the
> 	  only way to use the graphics hardware.
> 	  
> 	  The device is accessed through special device nodes, usually located
> 	  in the /dev directory, i.e. /dev/fb*.
> 	  
> 	  You need an utility program called fbset to make full use of frame
> 	  buffer devices. Please read <file:Documentation/fb/framebuffer.rst>
> 	  and the Framebuffer-HOWTO at
> 	  <http://www.munted.org.uk/programming/Framebuffer-HOWTO-1.3.html> for more
> 	  information.
> 	  
> 	  Say Y here and to the driver for your graphics board below if you
> 	  are compiling a kernel for a non-x86 architecture.
> 	  
> 	  If you are compiling for the x86 architecture, you can say Y if you
> 	  want to play with it, but it is not essential. Please note that
> 	  running graphical applications that directly touch the hardware
> 	  (e.g. an accelerated X server) and that are not frame buffer
> 	  device-aware may cause unexpected results. If unsure, say N.
> 
> (select-related dependencies: (DRM_KMS_FB_HELPER && DRM_KMS_HELPER && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM))
> 
> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> 
> config DRM_KMS_HELPER
> 	tristate
> 	depends on DRM && HAS_IOMEM
> 	help
> 	  CRTC helpers for KMS drivers.
> 
> (select-related dependencies: (DRM_DEBUG_SELFTEST && DRM && DEBUG_KERNEL && HAS_IOMEM) || (DRM_FBDEV_EMULATION && DRM && HAS_IOMEM) || (DRM_HDLCD && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_MALI_DISPLAY && DRM && OF && (ARM || ARM64) && COMMON_CLK && HAS_IOMEM) || (DRM_KOMEDA && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_NOUVEAU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_I915 && DRM && X86 && PCI && HAS_IOMEM) || (DRM_VKMS && DRM && HAS_IOMEM) || (DRM_EXYNOS && OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST) && HAS_IOMEM) || (DRM_ROCKCHIP && DRM && ROCKCHIP_IOMMU && HAS_IOMEM) || (DRM_VMWGFX && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_GMA500 && DRM && PCI && X86 && MMU && HAS_IOMEM) || (DRM_UDL && DRM && USB_SUPPORT && USB_ARCH_HAS_HCD && HAS_IOMEM) || (DRM_AST && DRM && PCI && MMU && HAS_IOMEM) || (DRM_MGAG200 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_CIRRUS_QEMU && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ARMADA && DRM && HAVE_CLK && ARM && MMU && HAS_IOMEM) || (DRM_ATMEL_HLCDC && DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM && HAS_IOMEM) || (DRM_RCAR_DU && DRM && OF && (ARM || ARM64) && (ARCH_RENESAS || COMPILE_TEST) && HAS_IOMEM) || (DRM_SHMOBILE && DRM && ARM && (ARCH_SHMOBILE || COMPILE_TEST) && HAS_IOMEM) || (DRM_SUN4I && DRM && (ARM || ARM64) && COMMON_CLK && (ARCH_SUNXI || COMPILE_TEST) && HAS_IOMEM) || (DRM_OMAP && DRM && (ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_TILCDC && DRM && OF && ARM && HAS_IOMEM) || (DRM_QXL && DRM && PCI && MMU && HAS_IOMEM) || (DRM_BOCHS && DRM && PCI && MMU && HAS_IOMEM) || (DRM_VIRTIO_GPU && DRM && VIRTIO && MMU && HAS_IOMEM) || (DRM_MSM && DRM && (ARCH_QCOM || SOC_IMX5 || (ARM && COMPILE_TEST)) && OF && COMMON_CLK && MMU && (INTERCONNECT || !INTERCONNECT) && HAS_IOMEM) || (DRM_FSL_DCU && DRM && OF && ARM && COMMON_CLK && HAS_IOMEM) || (DRM_TEGRA && (ARCH_TEGRA || (ARM && COMPILE_TEST)) && COMMON_CLK && DRM && OF && HAS_IOMEM) || (DRM_STM && DRM && (ARCH_STM32 || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_ANALOGIX_ANX78XX && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_CDNS_DSI && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DUMB_VGA_DAC && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_NXP_PTN3460 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_PARADE_PS8622 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SIL_SII8620 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_SII902X && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TOSHIBA_TC358767 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_TFP410 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_TI_SN65DSI86 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_I2C_ADV7511 && OF && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_HDMI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_DW_MIPI_DSI && DRM && DRM_BRIDGE && HAS_IOMEM) || (DRM_STI && OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM) && HAS_IOMEM) || (DRM_IMX && DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST) && IMX_IPUV3_CORE && HAS_IOMEM) || (DRM_INGENIC && (MIPS || COMPILE_TEST) && DRM && CMA && OF && HAS_IOMEM) || (DRM_VC4 && (ARCH_BCM || ARCH_BCM2835 || COMPILE_TEST) && DRM && SND && SND_SOC && COMMON_CLK && HAS_IOMEM) || (DRM_ARCPGU && DRM && OF && HAS_IOMEM) || (DRM_HISI_HIBMC && DRM && PCI && MMU && HAS_IOMEM) || (DRM_HISI_KIRIN && DRM && OF && ARM64 && HAS_IOMEM) || (DRM_MEDIATEK && DRM && (ARCH_MEDIATEK || (ARM && COMPILE_TEST)) && COMMON_CLK && HAVE_ARM_SMCCC && OF && HAS_IOMEM) || (DRM_ZTE && DRM && ARCH_ZX && HAS_IOMEM) || (DRM_MXSFB && DRM && OF && COMMON_CLK && HAS_IOMEM) || (DRM_MESON && DRM && OF && (ARM || ARM64) && (ARCH_MESON || COMPILE_TEST) && HAS_IOMEM) || (TINYDRM_HX8357D && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9225 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ILI9341 && DRM && SPI && HAS_IOMEM) || (TINYDRM_MI0283QT && DRM && SPI && HAS_IOMEM) || (TINYDRM_REPAPER && DRM && SPI && (THERMAL || !THERMAL) && HAS_IOMEM) || (TINYDRM_ST7586 && DRM && SPI && HAS_IOMEM) || (TINYDRM_ST7735R && DRM && SPI && HAS_IOMEM) || (DRM_PL111 && DRM && (ARM || ARM64 || COMPILE_TEST) && COMMON_CLK && HAS_IOMEM) || (DRM_TVE200 && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_XEN_FRONTEND && DRM_XEN && DRM && HAS_IOMEM) || (DRM_VBOXVIDEO && DRM && X86 && PCI && HAS_IOMEM) || (DRM_ASPEED_GFX && DRM && OF && (COMPILE_TEST || ARCH_ASPEED) && HAS_IOMEM) || (DRM_MCDE && DRM && CMA && (ARM || COMPILE_TEST) && OF && HAS_IOMEM) || (DRM_GM12U320 && DRM && USB && HAS_IOMEM))
> 
> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> 
> menuconfig THERMAL
> 	bool "Generic Thermal sysfs driver"
> 	help
> 	  Generic Thermal Sysfs driver offers a generic mechanism for
> 	  thermal management. Usually it's made up of one or more thermal
> 	  zone and cooling device.
> 	  Each thermal zone contains its own temperature, trip points,
> 	  cooling devices.
> 	  All platforms with ACPI thermal support can use this driver.
> 	  If you want this support, you should say Y here.
> 
> (select-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))
> 
> (imply-related dependencies: (ACPI_VIDEO && X86 && BACKLIGHT_CLASS_DEVICE && INPUT && ACPI) || (ACPI_CPU_FREQ_PSS && ACPI) || (ACPI_THERMAL && ACPI_PROCESSOR && ACPI) || (DRM_NOUVEAU && ACPI && X86 && DRM && PCI && MMU && HAS_IOMEM) || (DRM_ETNAVIV && DRM_ETNAVIV_THERMAL && DRM && MMU && HAS_IOMEM) || (MMC_SDHCI_OMAP && MMC_SDHCI_PLTFM && OF && MMC) || (INTEL_MENLOW && ACPI_THERMAL && X86_PLATFORM_DEVICES && X86))
> 
> ...depends on SENSORS_MLXREG_FAN (defined at drivers/hwmon/Kconfig:952), with definition...
> 
> config SENSORS_MLXREG_FAN
> 	tristate "Mellanox Mellanox FAN driver"
> 	select REGMAP
> 	imply THERMAL
> 	depends on MELLANOX_PLATFORM && HWMON
> 	help
> 	  This option enables support for the FAN control on the Mellanox
> 	  Ethernet and InfiniBand switches. The driver can be activated by the
> 	  platform device add call. Say Y to enable these. To compile this
> 	  driver as a module, choose 'M' here: the module will be called
> 	  mlxreg-fan.
> 
> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> 
> menuconfig HWMON
> 	tristate "Hardware Monitoring support"
> 	default y
> 	depends on HAS_IOMEM
> 	help
> 	  Hardware monitoring devices let you monitor the hardware health
> 	  of a system. Most modern motherboards include such a device. It
> 	  can include temperature sensors, voltage sensors, fan speed
> 	  sensors and various additional features such as the ability to
> 	  control the speed of the fans. If you want this support you
> 	  should say Y here and also to the specific driver(s) for your
> 	  sensors chip(s) below.
> 	  
> 	  To find out which specific driver(s) you need, use the
> 	  sensors-detect script from the lm_sensors package.  Read
> 	  <file:Documentation/hwmon/userspace-tools.rst> for details.
> 	  
> 	  This support can also be built as a module. If so, the module
> 	  will be called hwmon.
> 
> (select-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))
> 
> (imply-related dependencies: I8K || (HABANA_AI && PCI && HAS_IOMEM) || (DRM_RADEON && DRM && PCI && MMU && HAS_IOMEM) || (DRM_AMDGPU && DRM && PCI && MMU && HAS_IOMEM) || (THINKPAD_ACPI && ACPI && ACPI_BATTERY && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (EEEPC_LAPTOP && ACPI && INPUT && (RFKILL || RFKILL = n) && (ACPI_VIDEO || ACPI_VIDEO = n) && HOTPLUG_PCI && BACKLIGHT_CLASS_DEVICE && X86_PLATFORM_DEVICES && X86) || (CPU_HWMON && LOONGSON_MACH3X && MIPS_PLATFORM_DEVICES && MIPS) || (NTB_IDT && PCI && NTB))
> 
> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-01 13:28       ` Noralf Trønnes
  (?)
@ 2019-10-01 13:45       ` Jason Gunthorpe
  2019-10-01 14:07         ` Noralf Trønnes
  -1 siblings, 1 reply; 25+ messages in thread
From: Jason Gunthorpe @ 2019-10-01 13:45 UTC (permalink / raw)
  To: Noralf Trønnes; +Cc: dri-devel, daniel.vetter, sam, hdegoede, linux-kernel

On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> > On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> >> This makes the tiny drivers visible by default without having to enable a
> >> knob.
> >>
> >> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
> >>  drivers/gpu/drm/Makefile        |  2 +-
> >>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>  2 files changed, 22 insertions(+), 17 deletions(-)
> > 
> > Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> > breaks kconfig stuff in v5.4-rc by creating circular
> > dependencies. Could someone send a -rc patch to fix this please?
> > 
> > THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> > ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> > ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> > ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> > ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> > ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> > ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> > ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> > ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> > ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> > ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> > ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> > ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> > ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> > 
> 
> Would this commit fix this by any chance:
> 
> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a

Yes, thank you, can someone send this to -rc to unbreak 5.4?

Jason

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-01 13:45       ` Jason Gunthorpe
@ 2019-10-01 14:07         ` Noralf Trønnes
  2019-10-09 10:45             ` Daniel Vetter
  0 siblings, 1 reply; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-01 14:07 UTC (permalink / raw)
  To: Jason Gunthorpe, Maarten Lankhorst, Maxime Ripard, Sean Paul
  Cc: dri-devel, daniel.vetter, sam, hdegoede, linux-kernel

Hi drm-misc maintainers,

I have just applied a patch to drm-misc-next that as it turns out should
have been applied to -fixes for this -rc cycle.

Should I cherry pick it to drm-misc-next-fixes?
(I know there's a flowchart in the docs but I've never really understood
it.)

Noralf.

Den 01.10.2019 15.45, skrev Jason Gunthorpe:
> On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
>>
>>
>> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
>>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>>>> This makes the tiny drivers visible by default without having to enable a
>>>> knob.
>>>>
>>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
>>>>  drivers/gpu/drm/Makefile        |  2 +-
>>>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>>>  2 files changed, 22 insertions(+), 17 deletions(-)
>>>
>>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
>>> breaks kconfig stuff in v5.4-rc by creating circular
>>> dependencies. Could someone send a -rc patch to fix this please?
>>>
>>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
>>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
>>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
>>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
>>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
>>> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
>>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
>>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
>>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
>>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
>>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
>>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
>>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
>>> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
>>>
>>
>> Would this commit fix this by any chance:
>>
>> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
> 
> Yes, thank you, can someone send this to -rc to unbreak 5.4?
> 
> Jason
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-01 14:07         ` Noralf Trønnes
@ 2019-10-09 10:45             ` Daniel Vetter
  0 siblings, 0 replies; 25+ messages in thread
From: Daniel Vetter @ 2019-10-09 10:45 UTC (permalink / raw)
  To: Noralf Trønnes
  Cc: Jason Gunthorpe, Maarten Lankhorst, Maxime Ripard, Sean Paul,
	dri-devel, daniel.vetter, sam, hdegoede, linux-kernel

On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
> Hi drm-misc maintainers,
> 
> I have just applied a patch to drm-misc-next that as it turns out should
> have been applied to -fixes for this -rc cycle.
> 
> Should I cherry pick it to drm-misc-next-fixes?

Yup, cherry pick and reference the commit that's already in -next (in case
it creates conflicts down the road that reference makes the mess easier to
understand).

> (I know there's a flowchart in the docs but I've never really understood
> it.)

Usually bugfixes for kernel releases should land in drm-misc-next-fixes or
drm-misc-fixes. But cherry-picking over in case of mistakes is ok too.
-Daniel

> 
> Noralf.
> 
> Den 01.10.2019 15.45, skrev Jason Gunthorpe:
> > On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> >>
> >>
> >> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> >>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> >>>> This makes the tiny drivers visible by default without having to enable a
> >>>> knob.
> >>>>
> >>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
> >>>>  drivers/gpu/drm/Makefile        |  2 +-
> >>>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>>>  2 files changed, 22 insertions(+), 17 deletions(-)
> >>>
> >>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> >>> breaks kconfig stuff in v5.4-rc by creating circular
> >>> dependencies. Could someone send a -rc patch to fix this please?
> >>>
> >>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> >>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> >>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> >>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> >>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> >>> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> >>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> >>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> >>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> >>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> >>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> >>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> >>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> >>> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> >>>
> >>
> >> Would this commit fix this by any chance:
> >>
> >> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> >> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
> > 
> > Yes, thank you, can someone send this to -rc to unbreak 5.4?
> > 
> > Jason
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
@ 2019-10-09 10:45             ` Daniel Vetter
  0 siblings, 0 replies; 25+ messages in thread
From: Daniel Vetter @ 2019-10-09 10:45 UTC (permalink / raw)
  To: Noralf Trønnes
  Cc: sam, hdegoede, daniel.vetter, linux-kernel, dri-devel,
	Jason Gunthorpe, Maxime Ripard, Sean Paul

On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
> Hi drm-misc maintainers,
> 
> I have just applied a patch to drm-misc-next that as it turns out should
> have been applied to -fixes for this -rc cycle.
> 
> Should I cherry pick it to drm-misc-next-fixes?

Yup, cherry pick and reference the commit that's already in -next (in case
it creates conflicts down the road that reference makes the mess easier to
understand).

> (I know there's a flowchart in the docs but I've never really understood
> it.)

Usually bugfixes for kernel releases should land in drm-misc-next-fixes or
drm-misc-fixes. But cherry-picking over in case of mistakes is ok too.
-Daniel

> 
> Noralf.
> 
> Den 01.10.2019 15.45, skrev Jason Gunthorpe:
> > On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
> >>
> >>
> >> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
> >>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
> >>>> This makes the tiny drivers visible by default without having to enable a
> >>>> knob.
> >>>>
> >>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> >>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
> >>>>  drivers/gpu/drm/Makefile        |  2 +-
> >>>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
> >>>>  2 files changed, 22 insertions(+), 17 deletions(-)
> >>>
> >>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
> >>> breaks kconfig stuff in v5.4-rc by creating circular
> >>> dependencies. Could someone send a -rc patch to fix this please?
> >>>
> >>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> >>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
> >>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
> >>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
> >>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
> >>> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
> >>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
> >>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
> >>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
> >>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
> >>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
> >>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
> >>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
> >>> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
> >>>
> >>
> >> Would this commit fix this by any chance:
> >>
> >> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
> >> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
> > 
> > Yes, thank you, can someone send this to -rc to unbreak 5.4?
> > 
> > Jason
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-09 10:45             ` Daniel Vetter
  (?)
@ 2019-10-09 12:48             ` Noralf Trønnes
  2019-10-09 13:31               ` Maxime Ripard
  -1 siblings, 1 reply; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-09 12:48 UTC (permalink / raw)
  To: Daniel Vetter
  Cc: Jason Gunthorpe, Maarten Lankhorst, Maxime Ripard, Sean Paul,
	dri-devel, sam, hdegoede, linux-kernel



Den 09.10.2019 12.45, skrev Daniel Vetter:
> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
>> Hi drm-misc maintainers,
>>
>> I have just applied a patch to drm-misc-next that as it turns out should
>> have been applied to -fixes for this -rc cycle.
>>
>> Should I cherry pick it to drm-misc-next-fixes?
> 
> Yup, cherry pick and reference the commit that's already in -next (in case
> it creates conflicts down the road that reference makes the mess easier to
> understand).
> 

I remembered that Maxime just sent out a fixes pull and the subject says
drm-misc-fixes. The prevous one he sent out was -next-fixes.
So it looks like I should cherry pick to drm-misc-fixes for it to show
up in 5.4?

Noralf.

>> (I know there's a flowchart in the docs but I've never really understood
>> it.)
> 
> Usually bugfixes for kernel releases should land in drm-misc-next-fixes or
> drm-misc-fixes. But cherry-picking over in case of mistakes is ok too.
> -Daniel
> 
>>
>> Noralf.
>>
>> Den 01.10.2019 15.45, skrev Jason Gunthorpe:
>>> On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote:
>>>>
>>>>
>>>> Den 01.10.2019 14.36, skrev Jason Gunthorpe:
>>>>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote:
>>>>>> This makes the tiny drivers visible by default without having to enable a
>>>>>> knob.
>>>>>>
>>>>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>>>>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> to it once
>>>>>>  drivers/gpu/drm/Makefile        |  2 +-
>>>>>>  drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++--------------
>>>>>>  2 files changed, 22 insertions(+), 17 deletions(-)
>>>>>
>>>>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c)
>>>>> breaks kconfig stuff in v5.4-rc by creating circular
>>>>> dependencies. Could someone send a -rc patch to fix this please?
>>>>>
>>>>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
>>>>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition...
>>>>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition...
>>>>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition...
>>>>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition...
>>>>> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition...
>>>>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition...
>>>>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition...
>>>>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition...
>>>>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition...
>>>>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition...
>>>>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition...
>>>>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition...
>>>>> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484)
>>>>>
>>>>
>>>> Would this commit fix this by any chance:
>>>>
>>>> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER
>>>> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a
>>>
>>> Yes, thank you, can someone send this to -rc to unbreak 5.4?
>>>
>>> Jason
>>>
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-09 12:48             ` Noralf Trønnes
@ 2019-10-09 13:31               ` Maxime Ripard
  2019-10-10 13:30                   ` Noralf Trønnes
  0 siblings, 1 reply; 25+ messages in thread
From: Maxime Ripard @ 2019-10-09 13:31 UTC (permalink / raw)
  To: Noralf Trønnes
  Cc: Daniel Vetter, Jason Gunthorpe, Maarten Lankhorst, Sean Paul,
	dri-devel, sam, hdegoede, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote:
> Den 09.10.2019 12.45, skrev Daniel Vetter:
> > On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
> >> Hi drm-misc maintainers,
> >>
> >> I have just applied a patch to drm-misc-next that as it turns out should
> >> have been applied to -fixes for this -rc cycle.
> >>
> >> Should I cherry pick it to drm-misc-next-fixes?
> >
> > Yup, cherry pick and reference the commit that's already in -next (in case
> > it creates conflicts down the road that reference makes the mess easier to
> > understand).
> >
>
> I remembered that Maxime just sent out a fixes pull and the subject says
> drm-misc-fixes. The prevous one he sent out was -next-fixes.
> So it looks like I should cherry pick to drm-misc-fixes for it to show
> up in 5.4?

drm-misc-next-fixes is the branch where we gather fixes supposed to be
applied on top of drm-misc-next during the merge window. If you have
something targeting the current release, it should be drm-misc-fixes
indeed.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
  2019-10-09 13:31               ` Maxime Ripard
@ 2019-10-10 13:30                   ` Noralf Trønnes
  0 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-10 13:30 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Daniel Vetter, Jason Gunthorpe, Maarten Lankhorst, Sean Paul,
	dri-devel, sam, hdegoede, linux-kernel



Den 09.10.2019 15.31, skrev Maxime Ripard:
> On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote:
>> Den 09.10.2019 12.45, skrev Daniel Vetter:
>>> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
>>>> Hi drm-misc maintainers,
>>>>
>>>> I have just applied a patch to drm-misc-next that as it turns out should
>>>> have been applied to -fixes for this -rc cycle.
>>>>
>>>> Should I cherry pick it to drm-misc-next-fixes?
>>>
>>> Yup, cherry pick and reference the commit that's already in -next (in case
>>> it creates conflicts down the road that reference makes the mess easier to
>>> understand).
>>>
>>
>> I remembered that Maxime just sent out a fixes pull and the subject says
>> drm-misc-fixes. The prevous one he sent out was -next-fixes.
>> So it looks like I should cherry pick to drm-misc-fixes for it to show
>> up in 5.4?
> 
> drm-misc-next-fixes is the branch where we gather fixes supposed to be
> applied on top of drm-misc-next during the merge window. If you have
> something targeting the current release, it should be drm-misc-fixes
> indeed.

Thanks, it's applied now.

Noralf.

> 
> Maxime
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread
* Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM
@ 2019-10-10 13:30                   ` Noralf Trønnes
  0 siblings, 0 replies; 25+ messages in thread
From: Noralf Trønnes @ 2019-10-10 13:30 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: hdegoede, sam, linux-kernel, dri-devel, Jason Gunthorpe, Sean Paul



Den 09.10.2019 15.31, skrev Maxime Ripard:
> On Wed, Oct 09, 2019 at 02:48:20PM +0200, Noralf Trønnes wrote:
>> Den 09.10.2019 12.45, skrev Daniel Vetter:
>>> On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote:
>>>> Hi drm-misc maintainers,
>>>>
>>>> I have just applied a patch to drm-misc-next that as it turns out should
>>>> have been applied to -fixes for this -rc cycle.
>>>>
>>>> Should I cherry pick it to drm-misc-next-fixes?
>>>
>>> Yup, cherry pick and reference the commit that's already in -next (in case
>>> it creates conflicts down the road that reference makes the mess easier to
>>> understand).
>>>
>>
>> I remembered that Maxime just sent out a fixes pull and the subject says
>> drm-misc-fixes. The prevous one he sent out was -next-fixes.
>> So it looks like I should cherry pick to drm-misc-fixes for it to show
>> up in 5.4?
> 
> drm-misc-next-fixes is the branch where we gather fixes supposed to be
> applied on top of drm-misc-next during the merge window. If you have
> something targeting the current release, it should be drm-misc-fixes
> indeed.

Thanks, it's applied now.

Noralf.

> 
> Maxime
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 25+ messages in thread
end of thread, other threads:[~2019-10-10 13:31 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 10:51 [PATCH 0/3] drm/tinydrm: Rename to drm/tiny Noralf Trønnes
2019-07-25 10:51 ` [PATCH 1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Noralf Trønnes
2019-07-30 13:19   ` Hans de Goede
2019-07-30 13:34     ` Noralf Trønnes
2019-07-30 13:35       ` Hans de Goede
2019-07-30 13:53   ` Emil Velikov
2019-07-30 14:03     ` Noralf Trønnes
2019-07-30 14:16       ` Emil Velikov
2019-10-01 12:36   ` [1/3] " Jason Gunthorpe
2019-10-01 13:28     ` Noralf Trønnes
2019-10-01 13:28       ` Noralf Trønnes
2019-10-01 13:45       ` Jason Gunthorpe
2019-10-01 14:07         ` Noralf Trønnes
2019-10-09 10:45           ` Daniel Vetter
2019-10-09 10:45             ` Daniel Vetter
2019-10-09 12:48             ` Noralf Trønnes
2019-10-09 13:31               ` Maxime Ripard
2019-10-10 13:30                 ` Noralf Trønnes
2019-10-10 13:30                   ` Noralf Trønnes
2019-07-25 10:51 ` [PATCH 2/3] drm/tinydrm: Rename folder to tiny Noralf Trønnes
2019-07-25 10:51 ` [PATCH 3/3] drm/gm12u320: Move driver to drm/tiny Noralf Trønnes
2019-07-25 12:06 ` [PATCH 0/3] drm/tinydrm: Rename " Daniel Vetter
2019-07-25 12:46   ` Noralf Trønnes
2019-07-25 15:10     ` Sam Ravnborg
2019-07-31 13:32 ` Noralf Trønnes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.