* [PATCH net] ocelot: Cancel delayed work before wq destruction
@ 2019-07-25 13:33 Claudiu Manoil
2019-07-25 14:03 ` Alexandre Belloni
2019-07-26 21:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Claudiu Manoil @ 2019-07-25 13:33 UTC (permalink / raw)
To: David S . Miller; +Cc: Alexandre Belloni, netdev, UNGLinuxDriver
Make sure the delayed work for stats update is not pending before
wq destruction.
This fixes the module unload path.
The issue is there since day 1.
Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
---
drivers/net/ethernet/mscc/ocelot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index b71e4ecbe469..6932e615d4b0 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -1818,6 +1818,7 @@ EXPORT_SYMBOL(ocelot_init);
void ocelot_deinit(struct ocelot *ocelot)
{
+ cancel_delayed_work(&ocelot->stats_work);
destroy_workqueue(ocelot->stats_queue);
mutex_destroy(&ocelot->stats_lock);
ocelot_ace_deinit();
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ocelot: Cancel delayed work before wq destruction
2019-07-25 13:33 [PATCH net] ocelot: Cancel delayed work before wq destruction Claudiu Manoil
@ 2019-07-25 14:03 ` Alexandre Belloni
2019-07-26 21:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2019-07-25 14:03 UTC (permalink / raw)
To: Claudiu Manoil; +Cc: David S . Miller, netdev, UNGLinuxDriver
On 25/07/2019 16:33:18+0300, Claudiu Manoil wrote:
> Make sure the delayed work for stats update is not pending before
> wq destruction.
> This fixes the module unload path.
> The issue is there since day 1.
>
> Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/net/ethernet/mscc/ocelot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
> index b71e4ecbe469..6932e615d4b0 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -1818,6 +1818,7 @@ EXPORT_SYMBOL(ocelot_init);
>
> void ocelot_deinit(struct ocelot *ocelot)
> {
> + cancel_delayed_work(&ocelot->stats_work);
> destroy_workqueue(ocelot->stats_queue);
> mutex_destroy(&ocelot->stats_lock);
> ocelot_ace_deinit();
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ocelot: Cancel delayed work before wq destruction
2019-07-25 13:33 [PATCH net] ocelot: Cancel delayed work before wq destruction Claudiu Manoil
2019-07-25 14:03 ` Alexandre Belloni
@ 2019-07-26 21:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-07-26 21:11 UTC (permalink / raw)
To: claudiu.manoil; +Cc: alexandre.belloni, netdev, UNGLinuxDriver
From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Thu, 25 Jul 2019 16:33:18 +0300
> Make sure the delayed work for stats update is not pending before
> wq destruction.
> This fixes the module unload path.
> The issue is there since day 1.
>
> Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-26 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 13:33 [PATCH net] ocelot: Cancel delayed work before wq destruction Claudiu Manoil
2019-07-25 14:03 ` Alexandre Belloni
2019-07-26 21:11 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.