From: Lee Jones <lee.jones@linaro.org> To: Sam Ravnborg <sam@ravnborg.org> Cc: "Daniel Thompson" <daniel.thompson@linaro.org>, "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Gerd Hoffmann" <kraxel@redhat.com>, "Jingoo Han" <jingoohan1@gmail.com>, "Peter Rosin" <peda@axentia.se> Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Date: Mon, 05 Aug 2019 10:35:04 +0000 [thread overview] Message-ID: <20190805103504.GE4739@dell> (raw) In-Reply-To: <20190726160953.GA25708@ravnborg.org> On Fri, 26 Jul 2019, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > > This patch removes the support in backlight, > > > > and drop the notifier in fbmem. > > > > > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > > > > > lcd_ops.early_set_power() > > > > lcd_ops.r_early_set_power() > > > > > > > > Noticed while browsing backlight code for other reasons. > > > > > > Ah I didn't grep hard enough, I didn't realize that no one sets the > > > lcd_ops->(r_)early_set_power hooks. Nice find! > > > > > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > > > Cc: Lee Jones <lee.jones@linaro.org> > > > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > > > > Cc: Jingoo Han <jingoohan1@gmail.com> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > Cc: Sam Ravnborg <sam@ravnborg.org> > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> > > > > Cc: Peter Rosin <peda@axentia.se> > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > Cc: dri-devel@lists.freedesktop.org > > > > Cc: linux-fbdev@vger.kernel.org > > > > --- > > > > > > > > Build tested with various architectures, configs. > > > > > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > > > maintained today? > > > > > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > > > think at least. > > > > That's correct. We'll sort that once we have all the Acks. > > We have acks all around now. I am still missing Daniel T's Ack. > OK that I commit this to drm-misc-next? > > This is where we maintain fbdev these days. Or you could apply it to > your backlight tree. > > Both solutins would be fine as the risk of introducing merge conflicts > in these code paths are minimal. If that's the case, then I'd be happy to apply it to the Backlight tree. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Sam Ravnborg <sam@ravnborg.org> Cc: "Daniel Thompson" <daniel.thompson@linaro.org>, "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>, "Daniel Vetter" <daniel.vetter@ffwll.ch>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Gerd Hoffmann" <kraxel@redhat.com>, "Jingoo Han" <jingoohan1@gmail.com>, "Peter Rosin" <peda@axentia.se> Subject: Re: [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Date: Mon, 5 Aug 2019 11:35:04 +0100 [thread overview] Message-ID: <20190805103504.GE4739@dell> (raw) In-Reply-To: <20190726160953.GA25708@ravnborg.org> On Fri, 26 Jul 2019, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Jul 25, 2019 at 04:06:29PM +0100, Lee Jones wrote: > > On Thu, 25 Jul 2019, Daniel Vetter wrote: > > > > > On Thu, Jul 25, 2019 at 04:32:24PM +0200, Sam Ravnborg wrote: > > > > There was no users left - so drop the code to support EARLY_FB_BLANK. > > > > This patch removes the support in backlight, > > > > and drop the notifier in fbmem. > > > > > > > > That EARLY_FB_BLANK is not used can be verified that no driver set any of: > > > > > > > > lcd_ops.early_set_power() > > > > lcd_ops.r_early_set_power() > > > > > > > > Noticed while browsing backlight code for other reasons. > > > > > > Ah I didn't grep hard enough, I didn't realize that no one sets the > > > lcd_ops->(r_)early_set_power hooks. Nice find! > > > > > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > > > Cc: Lee Jones <lee.jones@linaro.org> > > > > Cc: Daniel Thompson <daniel.thompson@linaro.org> > > > > Cc: Jingoo Han <jingoohan1@gmail.com> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > Cc: Sam Ravnborg <sam@ravnborg.org> > > > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > > > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> > > > > Cc: Peter Rosin <peda@axentia.se> > > > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > > > Cc: dri-devel@lists.freedesktop.org > > > > Cc: linux-fbdev@vger.kernel.org > > > > --- > > > > > > > > Build tested with various architectures, configs. > > > > > > > > Lee, Daniel - OK to commit to drm-misc-next where fbdev stuff is > > > > maintained today? > > > > > > backlight is separate from fbdev in Lee's own tree, not in drm-misc. I > > > think at least. > > > > That's correct. We'll sort that once we have all the Acks. > > We have acks all around now. I am still missing Daniel T's Ack. > OK that I commit this to drm-misc-next? > > This is where we maintain fbdev these days. Or you could apply it to > your backlight tree. > > Both solutins would be fine as the risk of introducing merge conflicts > in these code paths are minimal. If that's the case, then I'd be happy to apply it to the Backlight tree. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-05 10:35 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20190725143232epcas2p3e9c37b4d946bc025375a5154ac60b5e8@epcas2p3.samsung.com> 2019-07-25 14:32 ` [PATCH v1 1/1] backlight: drop EARLY_EVENT_BLANK support Sam Ravnborg 2019-07-25 14:32 ` Sam Ravnborg 2019-07-25 14:39 ` Daniel Vetter 2019-07-25 14:39 ` Daniel Vetter 2019-07-25 15:06 ` Lee Jones 2019-07-25 15:06 ` Lee Jones 2019-07-26 16:09 ` Sam Ravnborg 2019-07-26 16:09 ` Sam Ravnborg 2019-08-05 10:35 ` Lee Jones [this message] 2019-08-05 10:35 ` Lee Jones 2019-07-26 9:50 ` Daniel Thompson 2019-07-26 9:50 ` Daniel Thompson 2019-07-26 11:27 ` Sam Ravnborg 2019-07-26 11:27 ` Sam Ravnborg 2019-07-26 13:05 ` Daniel Thompson 2019-07-26 13:05 ` Daniel Thompson 2019-08-05 10:36 ` Lee Jones 2019-08-05 10:36 ` Lee Jones 2019-08-05 20:29 ` Sam Ravnborg 2019-08-05 20:29 ` Sam Ravnborg 2019-07-26 16:05 ` Bartlomiej Zolnierkiewicz 2019-07-26 16:05 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190805103504.GE4739@dell \ --to=lee.jones@linaro.org \ --cc=b.zolnierkie@samsung.com \ --cc=daniel.thompson@linaro.org \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jingoohan1@gmail.com \ --cc=kraxel@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=mirq-linux@rere.qmqm.pl \ --cc=peda@axentia.se \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.