All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for mmu notifier debug annotations/checks
Date: Tue, 20 Aug 2019 11:15:48 -0000	[thread overview]
Message-ID: <20190820111548.30808.35037@emeril.freedesktop.org> (raw)
In-Reply-To: <20190820081902.24815-1-daniel.vetter@ffwll.ch>

== Series Details ==

Series: mmu notifier debug annotations/checks
URL   : https://patchwork.freedesktop.org/series/65465/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e625d02db27d mm, notifier: Add a lockdep map for invalidate_range_start/end
-:129: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 60 lines checked
535e4c5ab1a2 mm, notifier: Prime lockdep
-:50: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 13 lines checked
8ae83bb713da kernel.h: Add non_block_start/end()
-:93: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#93: FILE: include/linux/kernel.h:248:
+# define non_block_start() \
+	do { current->non_block_count++; } while (0)

-:100: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#100: FILE: include/linux/kernel.h:255:
+# define non_block_end() \
+	do { WARN_ON(current->non_block_count-- == 0); } while (0)

-:147: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
#147: FILE: kernel/sched/core.c:3712:
+		printk(KERN_ERR "BUG: scheduling in a non-blocking section: %s/%d/%i\n",

-:148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#148: FILE: kernel/sched/core.c:3713:
+		printk(KERN_ERR "BUG: scheduling in a non-blocking section: %s/%d/%i\n",
+			prev->comm, prev->pid, prev->non_block_count);

-:185: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 4 warnings, 1 checks, 102 lines checked
2b614044a13f mm, notifier: Catch sleeping/blocking for !blockable
-:57: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 14 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-08-20 11:15 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  8:18 [PATCH 0/4] mmu notifier debug annotations/checks Daniel Vetter
2019-08-20  8:18 ` [PATCH 1/4] mm, notifier: Add a lockdep map for invalidate_range_start/end Daniel Vetter
2019-08-20 13:31   ` Jason Gunthorpe
2019-08-20  8:19 ` [PATCH 2/4] mm, notifier: Prime lockdep Daniel Vetter
2019-08-20 13:31   ` Jason Gunthorpe
2019-08-20  8:19 ` [PATCH 3/4] kernel.h: Add non_block_start/end() Daniel Vetter
2019-08-20  8:19   ` Daniel Vetter
2019-08-20 20:24   ` Daniel Vetter
2019-08-20 20:24     ` Daniel Vetter
2019-08-22 23:14     ` Andrew Morton
2019-08-22 23:14       ` Andrew Morton
2019-08-23  8:34       ` Daniel Vetter
2019-08-23  8:34         ` Daniel Vetter
2019-08-23 12:12         ` Jason Gunthorpe
2019-08-23 12:12           ` Jason Gunthorpe
2019-08-23 12:22           ` Peter Zijlstra
2019-08-23 12:22             ` Peter Zijlstra
2019-08-23 13:42           ` Daniel Vetter
2019-08-23 13:42             ` Daniel Vetter
2019-08-23 14:06             ` Peter Zijlstra
2019-08-23 14:06               ` Peter Zijlstra
2019-08-23 15:15               ` Daniel Vetter
2019-08-23 15:15                 ` Daniel Vetter
2019-08-23  8:48     ` Peter Zijlstra
2019-08-23  8:48       ` Peter Zijlstra
2019-08-20  8:19 ` [PATCH 4/4] mm, notifier: Catch sleeping/blocking for !blockable Daniel Vetter
2019-08-20 13:34   ` Jason Gunthorpe
2019-08-20 15:18     ` Daniel Vetter
2019-08-20 15:27       ` Jason Gunthorpe
2019-08-21  9:34         ` Daniel Vetter
2019-08-21  9:34           ` Daniel Vetter
2019-08-21 15:41       ` Daniel Vetter
2019-08-21 15:41         ` Daniel Vetter
2019-08-21 16:16         ` Jason Gunthorpe
2019-08-22  8:42           ` Daniel Vetter
2019-08-22  8:42             ` Daniel Vetter
2019-08-22 14:24             ` Jason Gunthorpe
2019-08-22 14:27               ` Daniel Vetter
2019-08-22 14:27                 ` Daniel Vetter
2019-08-20 11:15 ` Patchwork [this message]
2019-08-20 12:33 ` ✓ Fi.CI.BAT: success for mmu notifier debug annotations/checks Patchwork
2019-08-20 18:14 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820111548.30808.35037@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.