* [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code
@ 2019-08-21 13:41 YueHaibing
2019-08-21 16:59 ` Florian Fainelli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2019-08-21 13:41 UTC (permalink / raw)
To: davem, opendmb, f.fainelli, bcm-kernel-feedback-list
Cc: linux-kernel, netdev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index d3a0b61..2108e59 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3437,7 +3437,6 @@ static int bcmgenet_probe(struct platform_device *pdev)
struct bcmgenet_priv *priv;
struct net_device *dev;
const void *macaddr;
- struct resource *r;
unsigned int i;
int err = -EIO;
const char *phy_mode_str;
@@ -3477,8 +3476,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
macaddr = pd->mac_address;
}
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, r);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
err = PTR_ERR(priv->base);
goto err;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code
2019-08-21 13:41 [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:52 ` David Miller
2019-08-21 22:27 ` Doug Berger
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-08-21 16:59 UTC (permalink / raw)
To: YueHaibing, davem, opendmb, bcm-kernel-feedback-list; +Cc: linux-kernel, netdev
On 8/21/19 6:41 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code
2019-08-21 13:41 [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
@ 2019-08-21 20:52 ` David Miller
2019-08-21 22:27 ` Doug Berger
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-08-21 20:52 UTC (permalink / raw)
To: yuehaibing
Cc: opendmb, f.fainelli, bcm-kernel-feedback-list, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 21 Aug 2019 21:41:31 +0800
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code
2019-08-21 13:41 [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:52 ` David Miller
@ 2019-08-21 22:27 ` Doug Berger
2 siblings, 0 replies; 4+ messages in thread
From: Doug Berger @ 2019-08-21 22:27 UTC (permalink / raw)
To: YueHaibing, davem, f.fainelli, bcm-kernel-feedback-list
Cc: linux-kernel, netdev
On 8/21/19 6:41 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index d3a0b61..2108e59 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -3437,7 +3437,6 @@ static int bcmgenet_probe(struct platform_device *pdev)
> struct bcmgenet_priv *priv;
> struct net_device *dev;
> const void *macaddr;
> - struct resource *r;
> unsigned int i;
> int err = -EIO;
> const char *phy_mode_str;
> @@ -3477,8 +3476,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
> macaddr = pd->mac_address;
> }
>
> - r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, r);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base)) {
> err = PTR_ERR(priv->base);
> goto err;
>
Acked-by: Doug Berger <opendmb@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-21 22:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 13:41 [PATCH net-next] net: bcmgenet: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:52 ` David Miller
2019-08-21 22:27 ` Doug Berger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.