* [PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure
@ 2019-08-23 21:29 Jae Hyun Yoo
2019-08-26 1:32 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Jae Hyun Yoo @ 2019-08-23 21:29 UTC (permalink / raw)
To: Eddie James, Mauro Carvalho Chehab, Joel Stanley, Andrew Jeffery,
Benjamin Herrenschmidt
Cc: linux-aspeed, linux-media, openbmc, Jae Hyun Yoo
It returns '0' even when a failure happens on jpeg buffer allocation
so this commit fixes the issue.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
---
drivers/media/platform/aspeed-video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index f899ac3b4a61..94f97d96dabc 100644
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -1624,6 +1624,7 @@ static int aspeed_video_init(struct aspeed_video *video)
if (!aspeed_video_alloc_buf(video, &video->jpeg,
VE_JPEG_HEADER_SIZE)) {
dev_err(dev, "Failed to allocate DMA for JPEG header\n");
+ rc = -ENOMEM;
goto err_release_reserved_mem;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure
2019-08-23 21:29 [PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure Jae Hyun Yoo
@ 2019-08-26 1:32 ` Andrew Jeffery
2019-08-26 2:50 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2019-08-26 1:32 UTC (permalink / raw)
To: Jae Hyun Yoo, Eddie James, Mauro Carvalho Chehab, Joel Stanley,
Benjamin Herrenschmidt
Cc: linux-aspeed, linux-media, openbmc
On Sat, 24 Aug 2019, at 07:00, Jae Hyun Yoo wrote:
> It returns '0' even when a failure happens on jpeg buffer allocation
> so this commit fixes the issue.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> drivers/media/platform/aspeed-video.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/aspeed-video.c
> b/drivers/media/platform/aspeed-video.c
> index f899ac3b4a61..94f97d96dabc 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -1624,6 +1624,7 @@ static int aspeed_video_init(struct aspeed_video
> *video)
> if (!aspeed_video_alloc_buf(video, &video->jpeg,
> VE_JPEG_HEADER_SIZE)) {
> dev_err(dev, "Failed to allocate DMA for JPEG header\n");
> + rc = -ENOMEM;
> goto err_release_reserved_mem;
> }
>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure
2019-08-26 1:32 ` Andrew Jeffery
@ 2019-08-26 2:50 ` Andrew Jeffery
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2019-08-26 2:50 UTC (permalink / raw)
To: Jae Hyun Yoo, Eddie James, Mauro Carvalho Chehab, Joel Stanley,
Benjamin Herrenschmidt
Cc: linux-aspeed, linux-media, openbmc
On Mon, 26 Aug 2019, at 11:02, Andrew Jeffery wrote:
>
>
> On Sat, 24 Aug 2019, at 07:00, Jae Hyun Yoo wrote:
> > It returns '0' even when a failure happens on jpeg buffer allocation
> > so this commit fixes the issue.
> >
> > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Keep my Reviewed-by, but can you please do a v2 that adds a Fixes: tag
and also Cc stable with the patch?
Cheers,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-26 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 21:29 [PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure Jae Hyun Yoo
2019-08-26 1:32 ` Andrew Jeffery
2019-08-26 2:50 ` Andrew Jeffery
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.